Hi Kai @soarcn

This pull request is a sample of unit test cases that we plan to contribute in order to raise the overall coverage to 80%. Code coverage is measured using Android Studio. This pull request increases code coverage of library from 0% to 18%.

| Metric | Before | After | | --- | --- | --- | | Coverage % | 0% | 18% | | Lines Covered | 0 | 80 | | Total Lines | 440 | 440 |

Please let me know if you have any questions.

Mohd Farid DevFactory - Code Quality Team

When using [getSharedPreferences(java.lang.String, int)](https://developer.android.com/reference/android/content/Context.html#getSharedPreferences%28java.lang.String, int%29) instead of getDefaultSharedPreferences(android.content.Context), you have to specify the preferences file name. It would be nice to have a way to specify that file name to Favor so that getSharedPreferences(java.lang.String, int) would be called using it. The idea is to keep the old preferences when migrating to Favor in an application that was already using getSharedPreferences(java.lang.String, int) without losing the current preferences or having to do a migration.

I wanted to use Serializable with rxPreferences as such:

@AllFavor
public interface MapPreference {
    Preference<BaseTileType> baseTile();
}

With BaseTileType implementing Serializable interface. However, I saw that Favor doesn't handle rxPreference serializable data.

I tested the following changes, which seem to work:

MethodInfo.java

    // Adding serializable adapter to be used with rxPreferences
    class SerializableAdapter<T extends Serializable> implements Preference.Adapter<T> {

        @Override
        public T get(@NonNull String key, @NonNull SharedPreferences preferences) {
            String gets = preferences.getString(key, null);
            if (TextUtils.isEmpty(gets))
                return null;
            byte[] bytes = Base64.decode(gets, Base64.DEFAULT);
            return (T)Taste.SerializableTaste.deserialize(bytes);
        }

        @Override
        public void set(@NonNull String key, @NonNull T value, @NonNull SharedPreferences.Editor editor) {
            byte[] bytes = Taste.SerializableTaste.serialize(value);
            if (bytes != null) {
                editor.putString(key, Base64.encodeToString(bytes, Base64.DEFAULT));
            }
        }
    }

    // Handle Serializable for rxPreference
    private void parseMethodAnnotations() {
        ...
        } else if (responseObjectType == Boolean.class) {
                rxPref = rx.getBoolean(key, defaultValues[0] == null ? null : Boolean.valueOf(defaultValues[0]));
            } else if (Serializable.class.isAssignableFrom(Types.getRawType(responseObjectType))) {
                SerializableAdapter adapter = new SerializableAdapter();
                rxPref = rx.getObject(key, defaultValues[0] == null ? null : Taste.SerializableTaste.deserialize(defaultValues[0].getBytes()), adapter);
        } else {
        ...
    }

This seems to work well and I was able to use it. Can you look over it? I can make a PR or, if you can, you can apply the changes. What do you think?

Hi! First of all, thank you for this lib. I have a simple question. Is it possible to read some variable in @Default annotation, maybe something like this:

@Default("GoogleMap.MAP_TYPE_NORMAL")

Thanks in advance for you reply.

This looks to be similar to #4. However, because there wasn't a clear solution identified, I wanted to create a separate issue.

I'm using Favor along with RxPreference. The application builds fine with minifyEnabled set to true. However, when it runs, I get the following exception:

Caused by: java.lang.ClassCastException: java.lang.Class cannot be cast to java.lang.reflect.ParameterizedType
   at com.cocosw.favor.MethodInfo.parseResponseType(Unknown Source)
   at com.cocosw.favor.MethodInfo.<init>(Unknown Source)
   at com.cocosw.favor.FavorAdapter.getMethodInfo(Unknown Source)
   at com.cocosw.favor.FavorAdapter.access$400(Unknown Source)
   at com.cocosw.favor.FavorAdapter$FavorHandler.invoke(Unknown Source)
   at java.lang.reflect.Proxy.invoke(Proxy.java:393)
   at $Proxy1.a(Unknown Source)
   at com.teralogics.test.TestApplication.onCreate(Unknown Source)
   at android.app.Instrumentation.callApplicationOnCreate(Instrumentation.java:1013)
   at android.app.ActivityThread.handleBindApplication(ActivityThread.java:4707)
   at android.app.ActivityThread.-wrap1(ActivityThread.java) 
   at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1405) 
   at android.os.Handler.dispatchMessage(Handler.java:102) 
   at android.os.Looper.loop(Looper.java:148) 
   at android.app.ActivityThread.main(ActivityThread.java:5417) 
   at java.lang.reflect.Method.invoke(Native Method) 
   at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:726) 
   at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:616) 

Within the TestApplication.onCreate, I do the following:

@Override
public void onCreate() {
    sApplication = this;

    super.onCreate();

    DevicePreference devicePreference = new FavorAdapter.Builder(this).build().create(DevicePreference.class);

    if (!devicePreference.uid().isSet()) {
        devicePreference.uid().set(UUID.randomUUID().toString());
    }
}

Definition of device preference is as follows:

@AllFavor
public interface DevicePreference {
    Preference<String> uid();
}

My ProGuard has the following entry (notice, I removed { *; } as it is not a valid -dontwarn syntax)

# Favor
-dontwarn com.cocosw.favor.**
-keep class com.cocosw.favor.** { *; }

The app runs fine in a non-minified debug build.

Got: @Commit @Default("-1") void setProjectId(int project); int getProjectId();

and now this: int selected = getSettings().getProjectId();

equals to Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Integer at android.app.SharedPreferencesImpl.getInt(SharedPreferencesImpl.java:240)

Warning:com.cocosw.favor.MethodInfo: can't find referenced class com.f2prateek.rx.preferences.RxSharedPreferences
Warning:com.cocosw.favor.MethodInfo: can't find referenced class com.f2prateek.rx.preferences.Preference
Warning:com.cocosw.favor.MethodInfo: can't find referenced class com.f2prateek.rx.preferences.RxSharedPreferences
Warning:there were 10 unresolved references to classes or interfaces.
         You may need to add missing library jars or update their versions.
         If your code works fine without the missing classes, you can suppress
         the warnings with '-dontwarn' options.
         (http://proguard.sourceforge.net/manual/troubleshooting.html#unresolvedclass)
Exception while processing task 
java.io.IOException: Please correct the above warnings first.

my proguard.txt (it's working)

# favor
-dontwarn com.cocosw.favor.** { *; }
-keep class com.cocosw.favor.** { *; }

Hello, I really wanna help to improve your library.

I have just a small contribution by now but I wanna help you as much as I can. How should I proceed? Should I open some issues about features that I think that makes sense? Or just implement then and submit for your review?

Best regards.

I got some problem with Proguard.

Information from Readme is not correct for 1st line,

-dontwarn com.cocosw.favor.** { ; } -keep class com.cocosw.favor.* { *; }

Also preferences was not create and stored until I have added information about to keep my interface with @Flavor too

-dontwarn com.cocosw.favor.** 
-keep class com.cocosw.favor.** { *; }
-keep interface {your.package}.{YourInterface} {
  <methods>;
}

This pull request is focused on resolving occurrences of Sonar rule squid:S1192 - “String literals should not be duplicated”. This PR will remove 70min of TD. You can find more information about the issue here: https://dev.eclipse.org/sonar/rules/show/squid:S1192 Please let me know if you have any questions. Fevzi Ozgul