Sample tests #39

flipper83 · 2016-02-16T23:52:51Z

adding test to sample
adding error handler sample.

+ Add test that check that show fake data disclaimer.

…tion

flipper83 · 2016-02-17T00:07:30Z

Thank you @pedrovgs for all support for this PR could be posible

Serchinastico · 2016-02-17T07:57:16Z

...idTest/java/com/karumi/rosie/sample/comics/view/activity/ComicSeriesDetailsActivityTest.java

+    startActivity();
+    onView(withId(R.id.rv_comics)).perform(RecyclerViewActions.scrollToPosition(1));
+
+    RecyclerViewInteraction.<ComicSeriesDetailViewModel>onRecyclerView(


Just a style issue but I'd move the recycler view check to a private method in order to make the test easier to read

all right!!!

Serchinastico · 2016-02-17T08:20:22Z

Good shit right there 👍, I include a patch with some typos corrected:

diff --git a/sample/src/androidTest/java/com/karumi/rosie/sample/comics/view/activity/ComicSeriesDetailsActivityTest.java b/sample/src/androidTest/java/com/karumi/rosie/sample/comics/view/activity/ComicSeriesDetailsActivityTest.java
index ba23a7c..26c0a65 100644
--- a/sample/src/androidTest/java/com/karumi/rosie/sample/comics/view/activity/ComicSeriesDetailsActivityTest.java
+++ b/sample/src/androidTest/java/com/karumi/rosie/sample/comics/view/activity/ComicSeriesDetailsActivityTest.java
@@ -60,7 +60,7 @@ import static org.mockito.Mockito.when;

 public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest {

-  private static final int ANY_COMIC_SERIE_ID = 1;
+  private static final int ANY_COMIC_SERIES_ID = 1;
   private static final String ANY_EXCEPTION = "AnyException";
   @Rule public IntentsTestRule<ComicSeriesDetailsActivity> activityRule =
       new IntentsTestRule<>(ComicSeriesDetailsActivity.class, true, false);
@@ -68,7 +68,7 @@ public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest
   @Inject
   ComicSeriesRepository comicSeriesRepository;

-  @Test public void shouldShowComicSeriesDetailWhenComicSerieIsLoaded() throws Exception {
+  @Test public void shouldShowComicSeriesDetailWhenComicSeriesIsLoaded() throws Exception {
     ComicSeries comicSeries = givenValidComicSeries();

     startActivity();
@@ -77,7 +77,7 @@ public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest
     onView(withId(R.id.tv_description)).check(matches(withText(comicSeries.getDescription())));
   }

-  @Test public void shouldShowComicIfComicSerieHaveComics() throws Exception {
+  @Test public void shouldShowComicIfComicSeriesHaveComics() throws Exception {
     ComicSeries comicSeries = givenValidComicSeries();
     List<ComicSeriesDetailViewModel> comics = givenComicData(comicSeries);

@@ -105,7 +105,7 @@ public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest
     onView((withId(R.id.loading))).check(matches(not(isDisplayed())));
   }

-  @Test public void shouldShowsErrorIfSomethingWrongHappend() throws Exception {
+  @Test public void shouldShowErrorIfSomethingWrongHappens() throws Exception {
     givenExceptionObtainingComicSeries();

     startActivity();
@@ -114,7 +114,7 @@ public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest
         matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)));
   }

-  @Test public void shouldShowsConnectionErrorIfHaveConnectionThroubles() throws Exception {
+  @Test public void shouldShowConnectionErrorIfHaveConnectionTroubles() throws Exception {
     givenConnectionExceptionObtainingComicSeries();

     startActivity();
@@ -125,7 +125,7 @@ public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest
   }

   private ComicSeries givenValidComicSeries() throws Exception {
-    ComicSeries comicSeries = getComicSeries(ANY_COMIC_SERIE_ID);
+    ComicSeries comicSeries = getComicSeries(ANY_COMIC_SERIES_ID);
     when(comicSeriesRepository.getComicSeriesDetail(any(Integer.class))).thenReturn(
         comicSeries);
     return comicSeries;
@@ -175,7 +175,7 @@ public class ComicSeriesDetailsActivityTest extends InjectedInstrumentationTest

   private ComicSeriesDetailsActivity startActivity() {
     Intent intent = new Intent();
-    intent.putExtra("ComicSeriesDetailsActivity.ComicSeriesKey", ANY_COMIC_SERIE_ID);
+    intent.putExtra("ComicSeriesDetailsActivity.ComicSeriesKey", ANY_COMIC_SERIES_ID);

     return activityRule.launchActivity(intent);
   }
diff --git a/sample/src/androidTest/java/com/karumi/rosie/sample/main/view/activity/MainActivityTest.java b/sample/src/androidTest/java/com/karumi/rosie/sample/main/view/activity/MainActivityTest.java
index 672aefc..366da3a 100644
--- a/sample/src/androidTest/java/com/karumi/rosie/sample/main/view/activity/MainActivityTest.java
+++ b/sample/src/androidTest/java/com/karumi/rosie/sample/main/view/activity/MainActivityTest.java
@@ -90,7 +90,7 @@ import static org.mockito.Mockito.when;
   @Rule public IntentsTestRule<MainActivity> activityRule =
       new IntentsTestRule<>(MainActivity.class, true, false);

-  @Test public void shouldShowsFakeDataBarWhenMarvelKeysNotHasBeenProvided() throws Exception {
+  @Test public void shouldShowFakeDataBarWhenMarvelKeysHasNotBeenProvided() throws Exception {
     givenFakeDataIsEnable();
     givenEmptyCharacters();
     givenEmptyComicSeries();
@@ -100,7 +100,7 @@ import static org.mockito.Mockito.when;
     onView(withId(R.id.tv_disclaimer)).check(matches(isDisplayed()));
   }

-  @Test public void shouldShowsErrorIfSomethingWrongHappend() throws Exception {
+  @Test public void shouldShowErrorIfSomethingWrongHappens() throws Exception {
     givenExceptionObtainingCharacters();
     givenEmptyComicSeries();

@@ -110,7 +110,7 @@ import static org.mockito.Mockito.when;
         matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)));
   }

-  @Test public void shouldShowsConnectionErrorIfHaveConnectionThroubles() throws Exception {
+  @Test public void shouldShowConnectionErrorIfHaveConnectionTroubles() throws Exception {
     givenConnectionExceptionObtainingCharacters();
     givenEmptyComicSeries();

@@ -130,7 +130,7 @@ import static org.mockito.Mockito.when;
         matches(not(isDisplayed())));
   }

-  @Test public void shouldShowsCharacterNameIfThereAreCharacters() throws Exception {
+  @Test public void shouldShowCharacterNameIfThereAreCharacters() throws Exception {
     List<Character> superHeroes = givenThereAreSomeCharacters(ANY_NUMBER_OF_CHARACTERS);

     startActivity();
@@ -157,7 +157,7 @@ import static org.mockito.Mockito.when;
     intended(hasExtra("CharacterDetailsActivity.CharacterKey", characterSelected.getKey()));
   }

-  @Test public void shouldShowsComicSeriesIfTheAreComicSeriesAndTabIsShowed() throws Exception {
+  @Test public void shouldShowComicSeriesIfTheAreComicSeriesAndTabIsShown() throws Exception {
     givenThereAreSomeCharacters(ANY_NUMBER_OF_CHARACTERS);
     List<ComicSeries> comicSeries = givenThereAreSomeComicSeries(ANY_NUMBER_OF_COMIC_SERIES);

@@ -281,7 +281,7 @@ import static org.mockito.Mockito.when;
     ComicSeries comicSeries = new ComicSeries();
     comicSeries.setKey(id);
     comicSeries.setName("ComicSeries - " + id);
-    comicSeries.setDescription("Description Comic Serie - " + id);
+    comicSeries.setDescription("Description Comic Series - " + id);
     return comicSeries;
   }

pedrovgs · 2016-02-18T11:04:01Z

sample/src/androidTest/java/com/karumi/rosie/sample/AncestorMatcher.java

+
+/*
+ * http://blog.sqisland.com/2015/05/espresso-match-toolbar-title.html
+ */


This is not right xD

copy paste :P

pedrovgs · 2016-02-18T11:08:51Z

...Test/java/com/karumi/rosie/sample/characters/view/activity/CharacterDetailsActivityTest.java

+
+    onView(allOf(withId(android.support.design.R.id.snackbar_text),
+        withText("Connection troubles. Ask to Ironman!"))).check(
+        matches(withEffectiveVisibility(ViewMatchers.Visibility.VISIBLE)));


Can't you use isDisplayed instead of this withEffectiveVisibility?

yes, this comes when I had a lot of problems with tests, and I made a lot of crazy things

I made some tests and I have problems with snackbars and isDisplayed :S

pedrovgs · 2016-02-18T11:18:47Z

Good job @flipper83! 👍 Just minor comments.

flipper83 · 2016-02-23T23:47:04Z

PR updated, please review the Readme changes, my english is not the same.

pedrovgs · 2016-02-24T09:12:20Z

README.md

@@ -248,6 +248,31 @@ public class SamplePresenter extends RosiePresenter<SamplePresenter.View> {
 	/*...*/
 }
 ```
+You can create your own factory that converts Exceptions to Error, here you can unify errors or add UI related info to your errors.


You can create your own ErrorFactory implementation to map Exceptions to Errors. In your implementation you can unify your error handling.

pedrovgs · 2016-02-24T09:25:03Z

Review the comments about the README.md and we are ready to publish!

Serchinastico · 2016-02-24T09:30:29Z

👍

Sample tests

Jorge J Barroso and others added 22 commits January 26, 2016 00:03

first espresso test with injector working correctly

3666a8d

Add test over collections, and added error basic code and test

09171e8

Refactor error system for make it generic and add error factory.

b7701d7

+ Add failing test that check that open comicseries

2fdff3b

+ Add test that check that show fake data disclaimer.

Fix checkstyle issue

af6cd13

Disable emulator animations

811ec56

Use a view pager idling resource to fix the race condition

3929bf0

Enable CI on travis

a8e11c3

test failing for snackbar an idling ¬¬

d77f712

add fakeTaskScheduled on unit tests.

3cb6a7d

Hide progress bar visibility on error

4541230

Get the tests working

92d3e13

Fix checkstyle issue

daacd49

Fix checkstyle issue

8bc35aa

Update travis configuration to avoid problems with the memory consump…

72fa62e

…tion

Remove not needed idling resource in top of the priority job queue

4ef139a

Remove another not needed idling resource

abe72b5

Remove not valid import

a12684e

Fix build error

e8daf1d

Add tests for characters detail

68f6499

Add comic detail tests.

56027e8

prepare pull requests

bbe06e9

Serchinastico reviewed Feb 17, 2016
View reviewed changes

pedrovgs reviewed Feb 18, 2016
View reviewed changes

Jorge J Barroso added 3 commits February 24, 2016 00:33

changes from pull request

e7771cf

fix error, strange error

1f103fe

Add error factory to on Readme

9b327ce

pedrovgs reviewed Feb 24, 2016
View reviewed changes

changes on readme from Code review.

0839aa6

flipper83 added a commit that referenced this pull request Feb 24, 2016

Merge pull request #39 from Karumi/sample-tests

243b9f1

Sample tests

flipper83 merged commit 243b9f1 into master Feb 24, 2016

flipper83 deleted the sample-tests branch February 24, 2016 18:50

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Sample tests #39

Sample tests #39

flipper83 commented Feb 16, 2016

flipper83 commented Feb 17, 2016

Serchinastico Feb 17, 2016

flipper83 Feb 23, 2016

Serchinastico commented Feb 17, 2016

pedrovgs Feb 18, 2016

flipper83 Feb 23, 2016

pedrovgs Feb 18, 2016

flipper83 Feb 23, 2016

flipper83 Feb 23, 2016

pedrovgs Feb 24, 2016

pedrovgs commented Feb 18, 2016

flipper83 commented Feb 23, 2016

pedrovgs Feb 24, 2016

flipper83 Feb 24, 2016

pedrovgs commented Feb 24, 2016

Serchinastico commented Feb 24, 2016

Navigation Menu

Sample tests #39

Sample tests #39

Conversation

flipper83 commented Feb 16, 2016

flipper83 commented Feb 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Serchinastico commented Feb 17, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrovgs commented Feb 18, 2016

flipper83 commented Feb 23, 2016

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrovgs commented Feb 24, 2016

Serchinastico commented Feb 24, 2016