Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Feedback from DroidsOnRoids #48

Closed
pedrovgs opened this issue Mar 9, 2016 · 6 comments
Closed

Feedback from DroidsOnRoids #48

pedrovgs opened this issue Mar 9, 2016 · 6 comments
Labels

Comments

@pedrovgs
Copy link
Contributor

pedrovgs commented Mar 9, 2016

@flipper83 @Serchinastico we have some feedback about Rosie in this blog post: http://www.thedroidsonroids.com/blog/android/rosie-lets-dive-into-clean-architecture/ There are some things we could improve like: change some methods visibility in the RosiePresenter to improve the class testability from the unit test point of view. What do you think?

@Serchinastico
Copy link
Contributor

Yup, the author makes a solid point about testing. The visibility of some of the classes she mentions are there for a reason though.
Maybe it's just a crazy idea but what about creating an artifact for testing purposes that expose those methods?

@pedrovgs
Copy link
Contributor Author

pedrovgs commented Mar 9, 2016

Maybe @pszklarska can give us more detailed feedback. We can not comment in the blog post and I don't find the DroidsOnRoids twitter :)

@pszklarska
Copy link

Hi guys, nice to see your response for my article ;) As I wrote, there were some issues that bothered me while testing. I mentioned them in article, but if you need more info, I'll be glad to help.

@pedrovgs why can't you comment in the blog post?

@pedrovgs
Copy link
Contributor Author

pedrovgs commented Mar 9, 2016

hahaha I didn't see the comments section at the end of the "other posts" links. Sorry :)

@pedrovgs
Copy link
Contributor Author

pedrovgs commented Mar 9, 2016

@pszklarska one of your suggestions is already in review #47

@pszklarska
Copy link

Great, so I wait for update :)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants