Moving Butter Knife and Renderers libraries from Rosie to the sample project, updated sample butterknife version 7.0.1 -> 8.0.1 #68
Conversation
|
Thank you so much @luis-ibanez 👍 |
|
Awesome PR 👍 |
|
I'm researching why the tests failed, it seems there is a problem finding the loading view inside the include. Will commit when fixed. |
|
Yup, we got to the same point. Butterknife doesn't bind the views correctly. Thanks for taking a look, we will wait for your update! |
|
Fixes #70 |
luis-ibanez
changed the title
|
|
||
| We have removed the direct support to Renderers and Butter Knife libraries on Rosie to simplify its use and make easier its support. The sample is still using this libraries, so you can find an example of how to integrate this libraries in your project. | ||
|
|
||
|
|
There was a problem hiding this comment.
@luis-ibanez we are not using a changelog for this project we use the release information to notify the release changes if needed.
| protected void onPreparePresenter() { | ||
| super.onPreparePresenter(); | ||
| ButterKnife.bind(this); | ||
| } |
There was a problem hiding this comment.
We should create another method invoked just after the setContentView method. Something like onPrepareActivity or just override setContentView method to add the butter knife call. Thoughts @Serchinastico?
initialization of view from onPreparePresenter to onPrepareActivity
|
@luis-ibanez you have some checkstyle violations: |
|
@pedrovgs the build failed again |
|
Sorry, I'm restarting it again..the problem is the Android Emulator and the Travis-CI environments :S |
|
I've no idea about what's going on with this build :S We always get a timeout during the dexing stage... :_( |
|
I close this PR just to response better to the #70 issue, and make the update in a separate PR given the problems making everything together is causing. |
|
ok |
There was a warning for using a @nullable over a @OnClick method in MarvelActivity.java, I have updated Butterknife, replace that @nullable for @optional and updated all the @Bind annotation for @BindView. Fix #70