Move butter knife and renderers to the sample #73
Conversation
|
Thanks @luis-ibanez the repository is not passing in Travis-CI due to compile errors. |
|
@luis-ibanez can you review the build output? The code is not compiling! |
Added MarvelRenderer
|
Thank you so much! 👍 |
|
@Serchinastico can you review this PR? |
| View view = inflater.inflate(layoutId, container, false); | ||
| ButterKnife.bind(this, view); | ||
| return view; | ||
| return inflater.inflate(layoutId, container, false); |
There was a problem hiding this comment.
To be consistent I'd add an onPrepareFragment method to let clients bind their views from their fragments as well. Include the view as a parameter.
There was a problem hiding this comment.
I was told no to do that and initialise it in onCreateView of the Fragment, I really don't have any preference in any of those solutions. @pedrovgs ?
There was a problem hiding this comment.
I think the current implementation is good enough :) IMHO we can already merge this PR :)
|
Besides the fragment method, it LGTM |
|
Until we decide what to do with the Fragments, I cleaned a little bit the PR |
This reverts commit 686d897. Revert "release 2.1.1" This reverts commit 687dd62. Revert "New list in UseCaseHandler to retain error adapters in a non-weak reference (#84)" This reverts commit 44ccdb5. Revert "Update README.md" This reverts commit 41e3756. Revert "Typo fix :) (#78)" This reverts commit 46d1b6a. Revert "Merge pull request #73 from luis-ibanez/move_libraries" This reverts commit 0000c3c, reversing changes made to 756ae9e.
Fixes #70