Allowing to implement RosiePresenter.View interfaces in base Fragments or Activity classes #90
Conversation
There was a problem hiding this comment.
Hi @felHR85! First of all, thank you so much for your contribution :) I have two major comments about this change and a question.
-
Instead of having a new method to get the interfaces to the super class, why don't we append the array of interfaces to the already created
interfacesarray. -
I'd like to cover this new behavior with a unit test before merging this PR. Could you add it?
My question about this implementation is related to big hierarchies. What if the class has three super classes? Could we implement this to support a deeper dependency tree?
|
Both comments are OK for me. I will proceed to add the unit test and simplify the method |
|
Great @felHR85. Just let me know once the code is ready to be reviewed again! Thanks 😃 |
Hello guys! First of all thank you very much for Rosie. It has been very helpful in the project We are working on.
I tried to implement my View interface in a Base Fragment class and I realized that was not possible because in RosiePresenter.class getViewInterfaceClass method was not looking for interfaces in any available super classes. I added a method that is called inside getViewInterfaceClass for seeking any RosiePresenter.View interfaces in any super class available if there is no RosiePresenter.View interfaces in the current class.
PS: I ran the tests but I got this error while testing the app sample:
android.support.test.espresso.NoMatchingViewException: No views in hierarchy found matching: (with id: com.karumi.rosie.sample:id/snackbar_text and with text...
Thank you!