Skip to content
This repository has been archived by the owner on Jan 9, 2020. It is now read-only.

Update gradle #97

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Update gradle #97

wants to merge 5 commits into from

Conversation

Aracem
Copy link
Contributor

@Aracem Aracem commented Jul 24, 2018

馃帺 What is the goal?

Update Gradle (tools, wrapper..) to improve the compilation time and take advantage of the last improvements in Android Studio 3.0.
Also, update dependencies to follow new implementation/api instead of compile standard, that helps to improve compilation times

How is it being implemented?

GIF

happy

Also, add a common configuration with variables in the Rosie gradle file
to easily change this configurations in the library and the samples at the
same time.
Also, added google() repository to gradle because now it's mandatory.

provided 'com.squareup.dagger:dagger-compiler:1.2.2'
annotationProcessor 'com.squareup.dagger:dagger-compiler:1.2.2'
compileOnly 'com.squareup.dagger:dagger-compiler:1.2.2'
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why the dagger dependency is added twice but I maintain them.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why xD

Copy link
Contributor

@pedrovgs pedrovgs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much @Aracem. This PR is really helpful. I was wondering if you could update the Gradle Wrapper this project contains. As we've updated the Gradle version, the wrapper should be updated too 馃槂


provided 'com.squareup.dagger:dagger-compiler:1.2.2'
annotationProcessor 'com.squareup.dagger:dagger-compiler:1.2.2'
compileOnly 'com.squareup.dagger:dagger-compiler:1.2.2'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't remember why xD

@Aracem
Copy link
Contributor Author

Aracem commented Jul 24, 2018

Should be updated:
https://github.com/Karumi/Rosie/pull/97/files#diff-fd9d61e37d939c941e7a62077f38d62dR22

I have to add a modification to make the CI accept the new Terms And Conditions when updating it. Let me ask a friend of mine about it

@pedrovgs
Copy link
Contributor

You are absolutely right @Aracem the wrapper is updated. I didn't see the file, my bad. We will wait until the build passes to merge this branch. Thank you so much 馃槂

@Aracem
Copy link
Contributor Author

Aracem commented Jul 25, 2018

The builds are broken due the com.android.library plugin, that download dependencies but Google adds a "accepts terms and conditions" question while downloading, so you have to configure CI to accept it.

Here is the solution: https://stackoverflow.com/a/45782695/628447
yes | sdkmanager --licenses

@Aracem Aracem force-pushed the update-gradle branch 4 times, most recently from 9f62aab to 67ba6f4 Compare July 25, 2018 09:50
Please, review this tutorial for a better understanding of this commit:
  https://developer.android.com/studio/build/gradle-plugin-3-0-0-migration

Apply this new rules to the gradle files, changing compile by implementation
and adding annotationProcessor. Also, edit the order of the repositories
jcenter() and google() to avoid download dependencies errors.
@Aracem
Copy link
Contributor Author

Aracem commented Jul 25, 2018

Please @pedrovgs review commit and commit before approving the PR. I had to introduce these changes due Checkstyle errors

I need help to resolve the Robolectric error. Let's see how we can resolve it

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants