New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better use drawable selector #1

Closed

splundid opened this issue May 29, 2020 · 1 comment

splundid commented May 29, 2020

android-image-picker/imagepicker/src/main/java/com/akvelon/imagepicker/PickerActivity.kt

Lines 37 to 38 in cd3071c

    
           private val enabledDrawable by lazy { ContextCompat.getDrawable(this, R.drawable.mult_select_bg_enabled) } 
        
           private val disabledDrawable by lazy { ContextCompat.getDrawable(this, R.drawable.mult_select_bg_disabled) }

It's probably better to use one selector drawable instead of multiple drawables with logic in code

Collaborator

RustemMuzafarov commented Jun 1, 2020

Yeah, thanks, good idea. Will be done in 1.0.1

RustemMuzafarov closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment