Develop #1
Closed
Develop #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronnieotieno
requested changes
Jul 26, 2021
| @@ -1,6 +1,6 @@ | |||
| <?xml version="1.0" encoding="UTF-8"?> | |||
| <project version="4"> | |||
| <component name="ProjectRootManager" version="2" languageLevel="JDK_11" default="true" project-jdk-name="JDK" project-jdk-type="JavaSDK"> | |||
There was a problem hiding this comment.
Please remove changes that arent related to the PR
| @@ -4,7 +4,7 @@ | |||
| <component name="GradleSettings"> | |||
| <option name="linkedExternalProjectsSettings"> | |||
| <GradleProjectSettings> | |||
| <option name="testRunner" value="PLATFORM" /> | |||
There was a problem hiding this comment.
Please remove the changes that arent related
There was a problem hiding this comment.
Noted. You mean the Non-Kotlin Files?
| @@ -38,10 +38,10 @@ Example in code, Kotlin: | |||
| override fun onCreate(savedInstanceState: Bundle?) { | |||
| super.onCreate(savedInstanceState) | |||
| //activity | |||
| imagePicker = ImagePicker(activity = this) | |||
There was a problem hiding this comment.
Nice, please o the same with Java example as well. Would be nice, wouldn't it 😊
|
Not really. Just the changes that aren't directly associated with the PR.
Some changes that were introduced by your android studio settings.
…On Mon, 26 Jul 2021, 19:55 Oyamo Brian, ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In .idea/gradle.xml
<#1 (comment)>
:
> @@ -4,7 +4,7 @@
<component name="GradleSettings">
<option name="linkedExternalProjectsSettings">
<GradleProjectSettings>
- <option name="testRunner" value="PLATFORM" />
Noted. You mean the Non-Kotlin Files?
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#1 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ALQSWTMVEDZWQZDU6QSEEZLTZWHRJANCNFSM5BAENWJA>
.
|
|
Why did you close and delete? The pr was super great |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Constructor overloading to make work easier while initialising from a fragment or activity