Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Develop #2

Merged
merged 5 commits into from Jul 26, 2021
Merged

Develop #2

merged 5 commits into from Jul 26, 2021

Conversation

oyamo
Copy link
Contributor

@oyamo oyamo commented Jul 26, 2021

No description provided.

ronnieotieno
ronnieotieno approved these changes Jul 26, 2021
View reviewed changes
Copy link
Owner

@ronnieotieno ronnieotieno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one, let me merge, will only revert the files in idea and misc file.

@ronnieotieno ronnieotieno merged commit 8b792ac into ronnieotieno:main Jul 26, 2021
@ronnieotieno
Copy link
Owner

Hey there. I merged this PR however when building the release in the Jitpack it failed because you pushed the settings. In the next one please don't use

git add. use git add - up. and only select the changes that affect the code and don't push changes to Gradle or misc/idea files. Then commit then stash the ones you haven't commited. Then pull and merge then push and open another PR.

@oyamo
Copy link
Contributor Author

oyamo commented Jul 27, 2021 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ronnieotieno ronnieotieno ronnieotieno approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@oyamo @ronnieotieno