So I've been hammering away at this for a day and I can't seem to get even basic queries to work with mono or flux.

Below is an example of a query to a user profile from the identity store. If I convert this into a future it works out of the box, but the moment I use a mono i get all my fields as null

{"data":{"currentUserProfile":{"firstname":null,"lastname":null,"username":null,"emailAddress":null}}}

And the query code:

@PreAuthorize("isAuthenticated()")
    fun currentUserProfile(context: GraphQLSecurityContext): Mono<UserProfile> {
        return context.securityContext.flatMap { sc ->
            val details = sc.authentication.details as UserCredential
            userIdentityService.findById(details.id).map { UserProfile.fromUserIdentity(it) }
        }

I don't seem to have a problem generating schema with mono. I have registered a monad hook, but it seems to do nothing.

Is there something I'm doing wrong? I know it does call the query method, but I can't seem to figure out I get a null response.

Library Version 1.4.2

Describe the bug When running a load test, I very early on get time-outs. I have a comparable implementation using Java, and it runs a whole lot longer. It's about 2 minutes vs. 30 minutes. I don't see any error in the logs. What will happen is that every second a couple of times a subscription will be started, a message will be received, through Kafka and Webflux, and then the subscription will be stopped again. A preliminary comparison can be found here.

To Reproduce At kafka-graphql-examples the implementation can be found. It's possible on mac/linux to run the whole test using the scripts. I know this is quite a lot, and the test is doing a lot more than needed. I might try to create a test in Kotlin, using the example project that produces a similar result.

Expected behavior To be at least on par with the java version, or be faster because of the use of coroutines.

I saw there was already an open issue for changing the subscription implementation, https://github.com/ExpediaGroup/graphql-kotlin/issues/358. It might fix the problem.

Is your feature request related to a problem? Please describe. I am frustrated when I try to mock the client for testing. I love the automatic generation of the kotlin files very much, so would prefer to continue to be able to do that. But when I mock I need to give every single field a value. As it is already marked as nullable I can put null into it, but with kotlin it has to be defined.

Describe the solution you'd like I would like a flag or even a default behaviour, that the nullable fields are generated with a default value of null, so they do not have to be specified when creating a new instance of the generated classes

Hi, I'm having some trouble with the GraphQL client (version 3.6.1). I'm getting an exception when GraphQLClient is trying to deserialize the response data to GraphQLResponse<HubCheckOut.Result>. The model itself looks fine and matches the JSON, but for some reason Jackson is not able to map it.

If I use a debugger to manually serialize to Map<String, Any> with the mapper it works, so the JSON is fine. Any ideas?

This is the generated model class:

const val HUB_CHECK_OUT: String =
    "mutation HubCheckOut(${'$'}hubID: ID!, ${'$'}employeeID: ID!) {\n    insertHubCheckedOutLogRecord(input: {hubId: ${'$'}hubID, employeeId: ${'$'}employeeID}) {\n        record {\n            shiftId\n        }\n    }\n}"

class HubCheckOut(
  private val graphQLClient: GraphQLClient<*>
) {
  suspend fun execute(variables: HubCheckOut.Variables, requestBuilder: HttpRequestBuilder.() ->
      Unit = {}): GraphQLResponse<HubCheckOut.Result> = graphQLClient.execute(HUB_CHECK_OUT,
      "HubCheckOut", variables, requestBuilder)

  data class Variables(
    val hubID: ID,
    val employeeID: ID
  )

  data class ShiftStateHubLogRecord(
    val shiftId: ID?
  )

  data class InsertHubLogCheckedOutRecordResponse(
    val record: HubCheckOut.ShiftStateHubLogRecord
  )

  data class Result(
    val insertHubCheckedOutLogRecord: HubCheckOut.InsertHubLogCheckedOutRecordResponse?
  )
}

And the exception:

Strange Map type java.util.Map: cannot determine type parameters
 at [Source: (String)"{"data":{"insertHubCheckedOutLogRecord":{"record":{"shiftId":"6387e498-2ac2-3c76-9b9e-f5248a348f8b"}}}}"; line: 1, column: 1]
com.fasterxml.jackson.databind.exc.InvalidDefinitionException: Strange Map type java.util.Map: cannot determine type parameters
 at [Source: (String)"{"data":{"insertHubCheckedOutLogRecord":{"record":{"shiftId":"6387e498-2ac2-3c76-9b9e-f5248a348f8b"}}}}"; line: 1, column: 1]
	at com.fasterxml.jackson.databind.exc.InvalidDefinitionException.from(InvalidDefinitionException.java:62)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerFactory.buildBeanDeserializer(BeanDeserializerFactory.java:227)
	at com.fasterxml.jackson.databind.deser.BeanDeserializerFactory.createBeanDeserializer(BeanDeserializerFactory.java:143)
	at com.fasterxml.jackson.databind.deser.DeserializerCache._createDeserializer2(DeserializerCache.java:414)
	at com.fasterxml.jackson.databind.deser.DeserializerCache._createDeserializer(DeserializerCache.java:349)
	at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCache2(DeserializerCache.java:264)
	at com.fasterxml.jackson.databind.deser.DeserializerCache._createAndCacheValueDeserializer(DeserializerCache.java:244)
	at com.fasterxml.jackson.databind.deser.DeserializerCache.findValueDeserializer(DeserializerCache.java:142)
	at com.fasterxml.jackson.databind.DeserializationContext.findRootValueDeserializer(DeserializationContext.java:491)
	at com.fasterxml.jackson.databind.ObjectMapper._findRootDeserializer(ObjectMapper.java:4711)
	at com.fasterxml.jackson.databind.ObjectMapper._readMapAndClose(ObjectMapper.java:4520)
	at com.fasterxml.jackson.databind.ObjectMapper.readValue(ObjectMapper.java:3466)
	at com.expediagroup.graphql.client.GraphQLClient.execute$suspendImpl(GraphQLClient.kt:91)
	at com.expediagroup.graphql.client.GraphQLClient$execute$1.invokeSuspend(GraphQLClient.kt)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
	at io.ktor.util.pipeline.SuspendFunctionGun.resumeRootWith(PipelineContext.kt:216)
	at io.ktor.util.pipeline.SuspendFunctionGun.loop(PipelineContext.kt:172)
	at io.ktor.util.pipeline.SuspendFunctionGun.access$loop(PipelineContext.kt:67)
	at io.ktor.util.pipeline.SuspendFunctionGun$continuation$1.resumeWith(PipelineContext.kt:122)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at io.ktor.util.pipeline.SuspendFunctionGun.resumeRootWith(PipelineContext.kt:216)
	at io.ktor.util.pipeline.SuspendFunctionGun.loop(PipelineContext.kt:172)
	at io.ktor.util.pipeline.SuspendFunctionGun.access$loop(PipelineContext.kt:67)
	at io.ktor.util.pipeline.SuspendFunctionGun$continuation$1.resumeWith(PipelineContext.kt:122)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at io.ktor.util.pipeline.SuspendFunctionGun.resumeRootWith(PipelineContext.kt:216)
	at io.ktor.util.pipeline.SuspendFunctionGun.loop(PipelineContext.kt:172)
	at io.ktor.util.pipeline.SuspendFunctionGun.access$loop(PipelineContext.kt:67)
	at io.ktor.util.pipeline.SuspendFunctionGun$continuation$1.resumeWith(PipelineContext.kt:122)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at io.ktor.util.pipeline.SuspendFunctionGun.resumeRootWith(PipelineContext.kt:216)
	at io.ktor.util.pipeline.SuspendFunctionGun.loop(PipelineContext.kt:172)
	at io.ktor.util.pipeline.SuspendFunctionGun.access$loop(PipelineContext.kt:67)
	at io.ktor.util.pipeline.SuspendFunctionGun$continuation$1.resumeWith(PipelineContext.kt:122)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at io.ktor.util.pipeline.SuspendFunctionGun.resumeRootWith(PipelineContext.kt:216)
	at io.ktor.util.pipeline.SuspendFunctionGun.loop(PipelineContext.kt:172)
	at io.ktor.util.pipeline.SuspendFunctionGun.access$loop(PipelineContext.kt:67)
	at io.ktor.util.pipeline.SuspendFunctionGun$continuation$1.resumeWith(PipelineContext.kt:122)
	at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:46)
	at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:56)
	at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
	at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
	at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source)
	at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
	at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source)
	at io.moia.driver.shift.validation.apitest.TestRun.start(TestRun.kt:94)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.junit.platform.commons.util.ReflectionUtils.invokeMethod(ReflectionUtils.java:686)
	at org.junit.jupiter.engine.execution.MethodInvocation.proceed(MethodInvocation.java:60)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$ValidatingInvocation.proceed(InvocationInterceptorChain.java:131)
	at org.junit.jupiter.engine.extension.TimeoutExtension.intercept(TimeoutExtension.java:149)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestableMethod(TimeoutExtension.java:140)
	at org.junit.jupiter.engine.extension.TimeoutExtension.interceptTestMethod(TimeoutExtension.java:84)
	at org.junit.jupiter.engine.execution.ExecutableInvoker$ReflectiveInterceptorCall.lambda$ofVoidMethod$0(ExecutableInvoker.java:115)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.lambda$invoke$0(ExecutableInvoker.java:105)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain$InterceptedInvocation.proceed(InvocationInterceptorChain.java:106)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.proceed(InvocationInterceptorChain.java:64)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.chainAndInvoke(InvocationInterceptorChain.java:45)
	at org.junit.jupiter.engine.execution.InvocationInterceptorChain.invoke(InvocationInterceptorChain.java:37)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:104)
	at org.junit.jupiter.engine.execution.ExecutableInvoker.invoke(ExecutableInvoker.java:98)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.lambda$invokeTestMethod$6(TestMethodTestDescriptor.java:212)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.invokeTestMethod(TestMethodTestDescriptor.java:208)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:137)
	at org.junit.jupiter.engine.descriptor.TestMethodTestDescriptor.execute(TestMethodTestDescriptor.java:71)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:135)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at java.base/java.util.ArrayList.forEach(ArrayList.java:1540)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.invokeAll(SameThreadHierarchicalTestExecutorService.java:38)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$5(NodeTestTask.java:139)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$7(NodeTestTask.java:125)
	at org.junit.platform.engine.support.hierarchical.Node.around(Node.java:135)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.lambda$executeRecursively$8(NodeTestTask.java:123)
	at org.junit.platform.engine.support.hierarchical.ThrowableCollector.execute(ThrowableCollector.java:73)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.executeRecursively(NodeTestTask.java:122)
	at org.junit.platform.engine.support.hierarchical.NodeTestTask.execute(NodeTestTask.java:80)
	at org.junit.platform.engine.support.hierarchical.SameThreadHierarchicalTestExecutorService.submit(SameThreadHierarchicalTestExecutorService.java:32)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestExecutor.execute(HierarchicalTestExecutor.java:57)
	at org.junit.platform.engine.support.hierarchical.HierarchicalTestEngine.execute(HierarchicalTestEngine.java:51)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:220)
	at org.junit.platform.launcher.core.DefaultLauncher.lambda$execute$6(DefaultLauncher.java:188)
	at org.junit.platform.launcher.core.DefaultLauncher.withInterceptedStreams(DefaultLauncher.java:202)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:181)
	at org.junit.platform.launcher.core.DefaultLauncher.execute(DefaultLauncher.java:128)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.processAllTestClasses(JUnitPlatformTestClassProcessor.java:99)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor$CollectAllTestClassesExecutor.access$000(JUnitPlatformTestClassProcessor.java:79)
	at org.gradle.api.internal.tasks.testing.junitplatform.JUnitPlatformTestClassProcessor.stop(JUnitPlatformTestClassProcessor.java:75)
	at org.gradle.api.internal.tasks.testing.SuiteTestClassProcessor.stop(SuiteTestClassProcessor.java:61)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.dispatch.ContextClassLoaderDispatch.dispatch(ContextClassLoaderDispatch.java:33)
	at org.gradle.internal.dispatch.ProxyDispatchAdapter$DispatchingInvocationHandler.invoke(ProxyDispatchAdapter.java:94)
	at com.sun.proxy.$Proxy5.stop(Unknown Source)
	at org.gradle.api.internal.tasks.testing.worker.TestWorker.stop(TestWorker.java:132)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:36)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:182)
	at org.gradle.internal.remote.internal.hub.MessageHubBackedObjectConnection$DispatchWrapper.dispatch(MessageHubBackedObjectConnection.java:164)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:412)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:64)
	at org.gradle.internal.concurrent.ManagedExecutorImpl$1.run(ManagedExecutorImpl.java:48)
	at java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
	at java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
	at org.gradle.internal.concurrent.ThreadFactoryImpl$ManagedThreadRunnable.run(ThreadFactoryImpl.java:56)
	at java.base/java.lang.Thread.run(Thread.java:834)

Hello, I have the following schema:

type Month implements Period {
   id: String!
   value: Int!
}

but the augmented (generated schema) decapitalizes the type, so instead of Month, I get month as the generated query. Is there any config where I can change this behaviour?

How can I build something like this:

class HelloQuery: Query {

    @IsAuthenticated
    fun helloAuthenticatedUser(): String = "Hello Authenticated User"

    @IsAdmin
    fun helloAdmin(): String = "Hello Admin"
}

base on: https://youtu.be/xaorvBjCE7A?t=580

Library Version "com.expediagroup:graphql-kotlin-spring-server:2.1.1"

Describe the bug I'm currently using spring webflux and spring server auto config package with graphql-kotlin, I am returning an instance of a class and it would work fine, but when I make changes or any changes for that matter, I would get these errors: I'm currently using spring-devtool and every time I make a change, it would build the file in intellij ide. This issue doesn't occur when I just stop and rebuild the entire server. Just wondering if this is a known issue or is it just me?

To Reproduce Steps to reproduce the behavior. Please provide: This is my sample code, which is very basic: Then go ahead and make any changes or add a println, then hit build in which devtool should kick in and reload the changes. Then if you fetch for the data again in playground, it will produce this issue.

Expected behavior This should happen:

But if I make any changes and the code get build with spring devtool, the second time I run it again, I would get this "Object is not an instance of declaring class". Btw, love the library and it's been awesome running with it, just wondering if this is an issue with spring-devtool

Is your feature request related to a problem? Please describe. I'm currently running my application in a serverless environment. Therefore, I am interested in minimizing startup time (recognizing that the JVM as a whole has limitations here). I've found that the creation of the GraphQLSchema object takes up the vast majority of my current startup time -- initializing takes about 4 seconds and about 75% of that seems to be GraphQLSchema construction.

Describe the solution you'd like I'd like a mechanism to build and serialize the GraphQLSchema so that it can simply be loaded at runtime, instead of the schema being generated at runtime based on runtime introspection.

Describe alternatives you've considered Obviously moving off of a serverless environment towards long-running server processes works around the issue. However, this is not always an ideal scenario at the early stages of a business looking to minimize costs when traffic is low.

Additional context Add any other context or screenshots about the feature request here.

Is it possible to use this with Hibernate "lazy-load" relations?

As of now, the Hibernate Session is closed after returning the result from the repository, and then when calculating the graphql and accessing the lazy fields it crashes because there's no session. Is there any way to use "lazy-load" relations with this library?

We came up with a documentation technique that works well for us (syncing both development teams and our product documentation team). We're trying to resolve the relevant Markdown documentation for each object, field, argument and enum value.

SchemaGeneratorHooks is an awesome general purpose vehicle for intercepting schema generation. I think it can be very helpful in this case, but it would have to be extended to include hook methods that would allow me to augment builder objects just before calling build(). That way I can call the builders' description method and add my own documentation. Specifically I'm asking for the inclusion of the following hooks:

fun willGenerateGraphQLObject(objectName: String, builder: graphql.schema.GraphQLObjectType.Builder): graphql.schema.GraphQLObjectType.Builder = builder

fun willGenerateGraphQLField(objectName: String, fieldName: String, builder: graphql.schema.GraphQLFieldDefinition.Builder): graphql.schema.GraphQLFieldDefinition.Builder = builder

fun willGenerateGraphQLEnumType(enumName: String, builder: graphql.schema.GraphQLEnumType.Builder): graphql.schema.GraphQLEnumType.Builder = builder

fun willGenerateGraphQLEnumValue(enumName: String, enumValue: String, builder: graphql.schema.GraphQLEnumValueDefinition.Builder): graphql.schema.GraphQLEnumValueDefinition.Builder = builder

fun willGenerateGraphQLArgument(objectName: String, fieldName: String, argumentName: String, builder: graphql.schema.GraphQLArgument.Builder): graphql.schema.GraphQLArgument.Builder = builder

I added the names of the objects/fields/arguments/enums to the hooks' contexts since it's difficult to extract that information from the builders directly.

What do you think?

Thanks a lot for a fantastic library!

This enables rewiring based on directives (see #60) by offering general purpose hooks that allows us to rewire/modify generated graphqltypes.

The base example for directive based authentication, would work with this: https://www.graphql-java.com/documentation/v11/sdl-directives/

With this hook available I can then use a helper class such as this can be used to wire up the directives: https://gist.github.com/d4rken/7cb60a6a7b315d25766ff15884f9b99b

The new hook has a placeholder WiringContext which would need to get some functionality to allow for feature parity with graphql-java's SchemaDirectiveEnvironment

I was a bit out of my depth there though and couldn't find a clean solution.

Theoretically we could just keep it empty until someone needs the functionality then provide it. As it's passed via "context" object this wouldn't lead to breaking changes. WiringContext is created inside the SchemaGenerator where it would have access to the necessary information it's just unclear in what form to provide it.

I think it comes down to how close we want to mirror graphql-java and it's SchemaDirectiveWiringEnvironment...

Library Version Kotlin Version: 1.8.0 (also tested 1.7.20)

id("com.expediagroup.graphql") version "6.3.3"

...

implementation("com.expediagroup:graphql-kotlin-spring-client:6.3.3") {
        exclude("com.expediagroup", "graphql-kotlin-client-jackson")
    }
implementation("com.expediagroup:graphql-kotlin-client-serialization:6.3.3")

Describe the bug After switching from Jackson to kotlinx.serialization the generated code no longer compiles. It fails in the step kotlinCompile with the exception.

org.jetbrains.kotlin.util.KotlinFrontEndException: Front-end Internal error: Failed to analyze declaration Variables
File being compiled: (30,3) in /Users/christian/dev/doms-ecom-integration/build/generated/source/graphql/main/test/CreateFulfilmentOption.kt
The root cause java.lang.AssertionError was thrown at: org.jetbrains.kotlin.resolve.lazy.descriptors.LazyClassDescriptor.getModality(LazyClassDescriptor.java:584)
	at org.jetbrains.kotlin.resolve.ExceptionWrappingKtVisitorVoid.visitDeclaration(ExceptionWrappingKtVisitorVoid.kt:43)
	at org.jetbrains.kotlin.psi.KtVisitorVoid.visitDeclaration(KtVisitorVoid.java:461)
	at org.jetbrains.kotlin.psi.KtVisitorVoid.visitDeclaration(KtVisitorVoid.java:21)
	at org.jetbrains.kotlin.psi.KtVisitor.visitNamedDeclaration(KtVisitor.java:406)

...

Caused by: java.lang.AssertionError: Recursion detected in a lazy value under LockBasedStorageManager@756f0f2d (TopDownAnalyzer for JVM)
	at org.jetbrains.kotlin.resolve.lazy.descriptors.LazyClassDescriptor.getModality(LazyClassDescriptor.java:584)
	at org.jetbrains.kotlinx.serialization.compiler.resolve.KSerializationUtilKt.getShouldHaveGeneratedSerializer(KSerializationUtil.kt:138)
	at org.jetbrains.kotlinx.serialization.compiler.extensions.SerializationResolveExtension.generateSyntheticClasses(SerializationResolveExtension.kt:78)

The generated code looks like this

@Generated
@Serializable
public class CreateFulfilmentOption(
  public override val variables: CreateFulfilmentOption.Variables,
) : GraphQLClientRequest<CreateFulfilmentOption.Result> {
  @Required
  public override val query: String = CREATE_FULFILMENT_OPTION

  @Required
  public override val operationName: String = "CreateFulfilmentOption"

  public override fun responseType(): KClass<CreateFulfilmentOption.Result> =
      CreateFulfilmentOption.Result::class

  @Generated
  @Serializable
  public data class Variables(
    public val input: CreateFulfilmentOptionInput,
    public val executionMode: ExecutionMode? = null,
  )

  @Generated
  @Serializable
  public data class Result(
    public val createFulfilmentOption: FulfilmentOption? = null,
  )
}

The problem seems to be related to the nested class Result. After moving it outside of CreateFulfilmentOption the error is gone

To Reproduce Generate client code with kotlinx serialiser and try to compile with the described version.

Expected behavior The generated code compiles

Describe the solution you'd like

Please upgrade Ktor to the newly release version 2.2.0 (from current version 2.0.3).

Describe alternatives you've considered

Sticking to Ktor 2.0.3 / up to 2.1.3 downstream is technically possible, but consumer will not be able to beneiot from new Ktor 2.2.0 features.

Additional context

Upgrading downstream to Ktor 2.2.0 results in java.lang.NoClassDefFoundError: kotlinx/atomicfu/AtomicFU.

Library Version com.expediagroup:graphql-kotlin-spring-server:7.0.0-alpha.0

Describe the bug When switchen to Spring Boot 3 com.expediagroup.graphql.server.spring.GraphQLAutoConfiguration does not get executed, because the old way of registering them via spring.factories has been removed. The new way needs a META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports-File.

Additional Info Details about the introduction of the new mechanism, and the deactivation of the old one.

As a workaround i can get my project to work, by registering com.expediagroup.graphql.server.spring.GraphQLAutoConfiguration myself with a META-INF/spring/org.springframework.boot.autoconfigure.AutoConfiguration.imports in my own application.

Library Version com.expediagroup:graphql-kotlin-spring-server:7.0.0-alpha.0

Describe the bug I get warned about CVE-2022-3171, because of the transitive dependency along

com.expediagroup:graphql-kotlin-spring-server:7.0.0-alpha.0
-> com.expediagroup:graphql-kotlin-federation:7.0.0-alpha.0
  -> com.apollographql.federation:federation-graphql-java-support:2.0.7
    -> com.google.protobuf:protobuf-java:3.21.5

This is supposed to be fixed since protobuf Version 21.7, which gets updated by com.apollographql.federation:federation-graphql-java-support since v.2.1.0

Is your feature request related to a problem? Please describe. GraphQL HTTP is a lightweight implementation of the GraphQL over HTTP spec. That repository also contains a number of tests that verify whether underlying server is compatible with HTTP spec or not. We should make sure that graphql-kotlin-spring-server is HTTP spec compliant and add its implementation to the list of tested libraries.

Describe the solution you'd like graphql-kotlin server implementation added to the HTTP spec repo that is fully compatible with the spec.

Describe alternatives you've considered N/A

Additional context Related: https://github.com/ExpediaGroup/graphql-kotlin/issues/1573

Is your feature request related to a problem? Please describe. Originally we chose Playground as it was much more feature rich than GraphiQL. Since then project was deprecated in favor of GraphiQL v2 which has full feature parity (and then recently un-deprecated with potential rewrite to reuse GraphiQL internals, still TBD).

Describe the solution you'd like Update spring-server to bundle GraphiQL instead of Playground.

Describe alternatives you've considered Since it is just including an extra HTML file we could potentially ship with both.

Additional context Playground status