Dear users of HoloColorPicker,

I am aware of the issue, but due to school and work I havent had much time to resolve it. It will try to work it out as soon as possible!!

Thanks Lars

Hi, first off, I like your color picker a lot and I want to thank you for developing it and releasing it to the public. I have been trying to make use of your color picker in my own project, however I ran into some problems:

When I try to add a bar to the ColorPicker, my android app crashes with an "Unfortunately, your app has stopped." error.

Code: Dialog d = new Dialog(this); d.setTitle("Color Picker:"); d.setContentView(R.layout.dialog_colorpicker); ColorPicker picker = (ColorPicker) findViewById(R.id.picker); SVBar svBar = (SVBar) findViewById(R.id.svbar); OpacityBar opacityBar = (OpacityBar) findViewById(R.id.opacitybar); picker.addSVBar(svBar); picker.addOpacityBar(opacityBar); d.show();

Layout XML:

<com.larswerkman.holocolorpicker.ColorPicker
    android:id="@+id/picker"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:layout_gravity="center"/>

<com.larswerkman.holocolorpicker.SVBar
    android:id="@+id/svbar"
    android:layout_width="322dp"
    android:layout_height="112dp"
    android:layout_gravity="center"
    android:layout_margin="8dip"/>

<com.larswerkman.holocolorpicker.OpacityBar
    android:id="@+id/opacitybar"
    android:layout_width="322dp"
    android:layout_height="112dp"
    android:layout_gravity="center"
    android:layout_margin="8dip"/>

Furthermore I would like to add that viewing the dialog_colorpicker.xml in Design mode gives a "Render error: Render error" in android studio. In Text mode everything is fine.

For the record I am fairly new to android development and have just started using android studio, so it is possible I have included/imported something wrong. But seeing as it displays just fine when I don't add the bars to the picker, everything appears to have been included fine.

I'm using your lib in dilog like that:

        AlertDialog.Builder adb = new AlertDialog.Builder(getActivity()).setTitle(title);
        LayoutInflater dialogInflater = getActivity().getLayoutInflater();
        View colorPickerLayout = dialogInflater.inflate(R.layout.dialog_colorpicker, null); //here I got only ColorPicker and svbar
        adb.setView(colorPickerLayout);
        final ColorPicker picker = (ColorPicker) colorPickerLayout.findViewById(R.id.picker);
        SVBar svBar = (SVBar) colorPickerLayout.findViewById(R.id.svbar);
        picker.addSVBar(svBar);
        //trying different ways to set new as old color exactly, but SVbar change position every time
        picker.setOldCenterColor(color);
        picker.setColor(color);
        svBar.setColor(color);
        adb.setPositiveButton("Set", new DialogInterface.OnClickListener() {
            public void onClick(DialogInterface dialog, int id) {
                listener.onBlurredAlertDialogPositiveClick(BlurredColorPickerDialog.this, picker.getColor());
            }
            })
            .setNegativeButton("Cancel", new DialogInterface.OnClickListener() {
                public void onClick(DialogInterface dialog, int id) {
                    listener.onBlurredAlertDialogNegativeClick(BlurredColorPickerDialog.this);
                }
            })
            .setOnCancelListener(new DialogInterface.OnCancelListener() {
                public void onCancel(DialogInterface dialog) {
                    listener.onBlurredAlertDialogCancel(BlurredColorPickerDialog.this);
                }
            });

and xml

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
    xmlns:app="http://schemas.android.com/apk/res-auto"
    android:layout_width="wrap_content"
    android:layout_height="wrap_content"
    android:paddingBottom="5dp">
    <com.larswerkman.holocolorpicker.ColorPicker
        android:id="@+id/picker"
        android:layout_width="wrap_content"
        android:layout_height="wrap_content"
        android:layout_gravity="center"
        app:color_wheel_radius="128dp"
        app:color_wheel_thickness="24dp"
        app:color_center_radius="54dp"
        app:color_center_halo_radius="60dp"
        app:color_pointer_radius="16dp"
        app:color_pointer_halo_radius="22dp"
        android:layout_alignParentTop="true"
        android:layout_centerHorizontal="true"
        />
    <com.larswerkman.holocolorpicker.SVBar
        android:id="@+id/svbar"
        android:layout_width="200dp"
        android:layout_height="112dp"
        android:layout_gravity="center"
        android:layout_margin="5dip"
        android:layout_below="@+id/picker"
        android:layout_centerHorizontal="true"/>
</RelativeLayout>

What i'm doing wrong? Is it bug in lib?

If you set bar_orientation_horizontal for portrait and unset it for landscape, after you rotate the device, you get the same value as in previously used layout.

This is how it was coded as part of #29, so I'm bringing here @tonyr59h to discuss it.

I fixed it by removing orientation related code from saturation and value bars from onSaveInstanceState and onRestoreInstanceState.

As far as I can see, there is no way to choose gray colors with this Color Picker, such as #B5B5B5 or #222222. If there is a was to do this, and a obvious one at that, I apologies for the submitting of this issue.

I Really love this spinner's design, but I hardly consider using an other one instead, due to this issue.

Hi all,

when I try to set the color of the picker through a call to setColor, it works. But immediatily after, if I call getColor it returns another color which is always the full green one. Any update to fix this problem?

Not really an issue. I need to be able to send the selected color as a string to a database. Is it possible to convert the selection to a string? If it is, how would I go about doing that? I'm very new to this library so any help in the right direction would be great. Thank you.

Before this change, the onColorChanged(...) event was fired hundreds of times while moving the color wheel. Now it is fired only once after the user released the color wheel again.

I'm looking for a good color picker to use in the preferences of my app. HoloColorPicker looks like a nice library. Any plans to create a "HoloColorPickerPreference"?

When I combine the picker with ValueBar and SaturationBar, the onChangeListener in ColorPicker.setNewCenterColor() is fired several times. Reason is that each bar does its color calculation on the center circle color value and sets its value to the newly calculated one.

So, having a ValueBar and a SaturationBar fires three events in case I rotate the Picker:

• on Picker Rotation complete (fully saturated and bright value)
• on ValueBar color calcuation complete (value dimished with brightness)
• on SaturationBar color calcuation complete (value desaturated)

I have no idea how to link color calculation correctly, so my quick and dirty hack is to introduce a boolean mEventMode with appropriate getter/setter and disable the firing of the Listener from each bar (touchEvent):

mPicker.setEventModeDisabled(true);
mPicker.setNewCenterColor(mColor);
mPicker.setEventModeDisabled(false);
mPicker.changeValueBarColor(mColor);
mPicker.changeOpacityBarColor(mColor);

Since this is dirty, I'll refrain from committing anything :)

Imo, synching color calculation and correct Bar isolation from colorPicker requires major rework, on the bright side, nice UI component...

Hi. I really like your color picker and want to use it in my app. However I found two problems with the color.

1. When you pick a color with a high saturate or value and then do a picker.setColor(picker.getColor()), the color changes a bit. I thought, this should not happen, so I looked around in the code and found, that the normalizeColor(int) method is a too complicated. I think to get an accurate value for the normColor variable, one could use the following lines, which solve the problem for me:

   Color.colorToHSV(color, mHSV);
   mHSV[1] = 1f;
   mHSV[2] = 1f;
   int normColor = Color.HSVToColor(Color.alpha(color), mHSV);
   

2. When you do a picker.setColor(Color.BLACK), the SVBar slider is set to white (saturate=0). I solved this by changing the if-block in the setColor(int) method of the ColorPicker:

   if (mHSV[1] < mHSV[2]) {
       mSVbar.setSaturation(mHSV[1]);
   } else {
       SVbar.setValue(mHSV[2]);
   }
   

I know, I could do a pull request with these changed, but I certainly don't know how to do this, so here is an issue for it. I hope it helps. Keep up the very good work.

Hello and thank you for this wonderful library. But, I want to ask you to make it focusable for using for example from DPAD navigation as for TV (KeyListener). Is it possible?

If someone still have interests to this project you can take a look to my "not exactly fork". I just take sikaiser fork, fixed a couple of bugs and adapted this view to use with androidx:preference and google.material libraries. So in my "fork" you can use ColorPicker as simple view or already prepared DialogPreference. Here is the link

Nice to meet you. I am a Japanese Developer and I prefer your library. I am always grateful for your help.

The way to write your README was a bit different, so I edited it. Please merge if you do not mind. Thank you for your consideration.

Thank for your library. I use your library in my app and found the touch event handle has bug.
When user click screen, touch event flow is down -> up(without move event in some phone), OpacityBar(ValueBara etc)'s color is change, but relative ColorPicker not change color.
This pr for fix this bug.
BTW, I upgrade build tools chain and fix type in setting.gradle.

Creating an App using 2 Holopickers, i accidentally stumbled upon some resizers for the picker (in another issue about the SVBar) Being :

            app:color_center_halo_radius="40dp"
            app:color_center_radius="30dp"
            app:color_pointer_halo_radius="22dp"
            app:color_pointer_radius="16dp"
            app:color_wheel_radius="70dp"
            app:color_wheel_thickness="24dp"

for instance then i started looking at for info on how to do something similar for the 'bars' but google didn't find an answer. but somehow i managed to find :

            app:bar_length="140dp"
            app:bar_pointer_halo_radius="14dp"
            app:bar_pointer_radius="10dp"
            app:bar_thickness="8dp"

i mus have been looking through the source-code, but that is a tad tricky for me, Java is not my first language and AS is taking up so much memory that many times webpages get put in the pagefile on the harddrive, which makes it all rather slow. Anyway the question i did not find any answer to is how can i remove the margins from the picker (or make them smaller) so that i can put them a little closer together while using "Constraint-layout". Basically anyway are there any other parameters i can modify.

Migrate to GradleMavenPush https://github.com/Vorlonsoft/GradleMavenPush

Reasons:

• Old plugin don't have updates for 4 years
• Better javadocs generation
• Better pom file generation
• Smaller gradle.properties
• You can easy migrate from Maven Central to JCenter by adding to your code IS_JCENTER = true only and register at https://bintray.com/bintray/jcenter