- Summary

Impoving UI

- Description for the changelog

Added slide animation of recyclerView with MotionLayout

- A picture or screenshot regarding change (not mandatory but encouraged)

Due to this code state always succesfull,

emitAll(fetchFromLocal().map {
           State.success<RESULT>(it)
       })

so after internet connection is back,

     ```
if (mViewModel.postsLiveData.value is State.Error || mAdapter.itemCount == 0) {
                    getPosts()
                }

this block of code does not work... what i can do fetch new result when immediately the connection is back,

First of all, awesome repository. Got a lot to learn in it. :smiley:

I've a doubt in your code.

Here, https://github.com/PatilShreyas/Foodium/blob/75e4541908c80ae2e4ec3221fb37ffc23ed5b094/app/src/main/java/dev/shreyaspatil/foodium/data/repository/NetworkBoundRepository.kt#L93-L94,

Why did you marked fetchFromRemote with @MainThread ? Should it be called from WorkerThread? :thinking:

Describe the bug/request JUnit "AssertThat" is deprecated use Google Truth instead of that.

Additional context In FoodiumServiceTest class the JUnit assertThat is used. Please use google truth instead of this.

While running tests for PostsDaoTest the tests keeps running without completing. But if i test with normal flow builder emitting item and asserting inside run blocking it completes and tests pass.

    val flow =  flow {
        emit(1)
    }

    assertThat(1, equalTo(flow.first()))

The above works inside runBlocking.

I found nothing similar to this issue on internet. Running on latest android studio. Am i missing anything

- Summary Use the Android Sharesheet to provide the share functionality, allowing for a more modern looking share menu on Android 10 (API level 29) and above. This will also add the ability to show rich content to previews.

- Description for the changelog Handles the share action by creating an Intent with ACTION_SEND and uses the Intent.createChooser to return a share sheet intent.

- A picture or screenshot regarding change (not mandatory but encouraged) On Android 10,

On Android 6,

Closes #48

There will be a scenario in which we won't need to save the data to database and use values directly from the network. Can you share a similar version of NetworkBoundRepository to perform the same.

Hi @PatilShreyas how about we improve the PostListAdapter with Visitable Pattern? So we can add view items more dynamically in the app and create the factory for the ViewHolders.

And also I think setPosts function in PostListAdapter should not use notifyDataSetChanged to update the list, if we use that the DiffUtil.ItemCallback will become useless because the adapter will re-render the all items which resulted in blinking page.

Instead we could use submitList(items) provided by ListAdapter that PostListAdapter extends to only re-render the items which data have changed with the correct animation.

Thank you 🙏

Ref: https://proandroiddev.com/writing-better-adapters-1b09758407d2

- Summary

Junit AssertThat is deprecated so i use Google truth instead of it.

- Description for the changelog

- A picture or screenshot regarding change (not mandatory but encouraged)

- Summary

Move the activity transaction logic to the target activity using the starter pattern. This pattern really helps when we are working in collaborative projects. When a change is made, say a new extra parameter is required for an activity, this wouldn't throw a compile-time error, but our app will crash during runtime.

With this, we can catch during compilation, and project contributors can know the required params for starting the activity.

More information on this pattern: https://blog.mindorks.com/learn-to-write-good-code-in-android-starter-pattern

- Description for the changelog

Instead of starting activities by creating Intent in the calling method, we call a function which is written in the Activity to start the activity.

Existing code:

  val intent = Intent(this, PostDetailsActivity::class.java)
        intent.putExtra(PostDetailsActivity.POST_ID, post.id)

  val options = ActivityOptionsCompat.makeSceneTransitionAnimation(
        this,
        imageView,
        imageView.transitionName
   )

 startActivity(intent, options.toBundle())

Updated:

 val options = ActivityOptionsCompat.makeSceneTransitionAnimation(
       this,
       imageView,
       imageView.transitionName
 )

 PostDetailsActivity.start(this, post.id, options)

- A picture or screenshot regarding change (not mandatory but encouraged)

Describe the bug/request Use the Android Sharesheet to provide the share functionality, allowing for a more modern looking share menu on Android 10 (API level 29) and above. This will also add the ability to show rich content to previews.

So the UI for the share tray could something like this post this change:

Additional context Essentially, the following change will be done:

For all types of sharing, create an intent and set its action to Intent.ACTION_SEND. In order to display the Android Sharesheet you need to call Intent.createChooser() , passing it your Intent object. It returns a version of your intent that will always display the Android Sharesheet.

Source: link

Should we not use distinctUntilChanged() in dao?.

      @Query("SELECT * FROM ${Post.TABLE_NAME} WHERE ID = :postId")
      fun getPostById(postId: Int): Flow<Post>

      fun getPostByIdUntilChanged(id: Int) = getPostById(id).distinctUntilChanged()

cause if we update a unrelated row the query also emits data with the same result again. https://medium.com/androiddevelopers/room-flow-273acffe5b57

Originally posted by @raghunandankavi2010 in https://github.com/PatilShreyas/Foodium/discussions/61