I made a tag for no reason in particular, and when I attempt to delete it the app crashes. Not sure if this is because I'd already had sessions on that tag or not.

I often use my phone for tasks while working, which means that the Goodtime app winds up in the background and Android sometimes decides to pause it. (To reproduce this consistently, enable Settings > Developer options > Don't keep activities.) This means that I'll sometimes notice half an hour later that there's still 15 minutes left of a 25-minute session.

I tried to fix this myself, but I got confused trying to understand how the preferences are set up. Is there a particular reason that some of the preferences (e.g. mSessionTime, mBreakTime, mDisableWifi) are stored in variables and saved into the bundle instead of using mPref.get*() each time they're needed?

First off, I want to thank you for this app. It's very clean, nice and is foss.

However, I noticed what appears to be a bug. I just finished my 12th session and I got a 5 min break (instead of a 15-minute one). The small cup of coffee says that 12 sessions are completed. I don't think the 8th was skipped.

First of all, thank you for this app! I'm using it everyday.

However, I noticed that when I finished a task and wanted to take my break, or during a break I skiped the session, the current session was not saved in the statistics.

It would be cool if you could add a stop option, like a double-click to close a session, or a break.

I've activated long breaks in the app and set the number of session before a long break to 4. The problem is that after just two sessions a long break is activated instead of a short one. I'm using 2.0.10 of the app on Android version 9.

First of all, thanks so much for making this great app!

I use this app in the fullscreen mode with the screen on, so the phone shows a visual reminder that I'm on a timer. However because I usually work with headphones on, I don't hear the vibration notification (and can't use sound because it would disturb people around me). I was therefore wondering whether it would be possible to add a "flashing" notification option that would signal the time is up by inverting the colors of the screen repeatedly (so black text on white alternating with white text on black). This would be noticeable and wouldn't disturb the people around me.

Thanks in advance for considering!

As seen in #22, the way preferences are handled is a bit confusing and disjointed. This change puts all of the preference getters in a separate Prefs class, which has several benefits:

1. Removes members of MainActivity that were storing some of the preferences, along with the code to bundle and unbundle them.
2. Puts all of the preferences in a single place where they can easily be seen.
3. Removes code duplication where some preferences were gotten in multiple places. If these default was to be changed the getters would have had to have been altered in multiple places; with this change only the one place in the Prefs class needs to be altered.

I'm submitting this as a PR separate from the fix for #22 as I haven't implemented that yet and I wanted to avoid merge conflicts later on.

I have some redesign ideas to improve Goodtime.

1. Overflow menu is typically used to display a menu. Goodtime uses it for letting a user select a label. IMHO I keep using it how I would use overflow menu in rest of the Android environment to open a menu. And inside the statistics a different icon is being used for labels.
2. I should be able to see a the labels and their number of pomodoro completed.
3. The bottom bar may possibly let me go to statistics directly.

Some possible suggestions from my side.

1. Use same icon for labels.
2. What about if we use an Exposed Dropdown list instead of a dialog? This would not require much hand movement.
3. Statistics button in the bottom bar.
4. Display label at the top of the timer.
5. Display x number of label stats in bottom.

Maybe we could hide these in full screen and display when a user clicks on the screen. Maybe we could display this permanently in the non-full-screen view in case user wants to see it.

If you think these ideas are something you would be willing to incorporate then I can try to find some time to send pull requests.

On a Huawei Y6 (2017) with Android version 6.0 (patch level: August 5, 2018), the LED notifications don't seem to work: the LED doesn't light up when the time ends. I'm running with Vibration: None and Notification sound: off. Even with Vibration active, the LED doesn't light up.

Things that could be done:

• Dissect the elements of these app
  • https://play.google.com/store/apps/details?id=com.dotsaft.sat.pomodoromoon
  • https://play.google.com/store/apps/details?id=com.wlxd.pomochallenge
• Design the application layout (UI) to be compatible with Goodtime
• Writing the app to be compatible with Goodtime's default workflow

I open this issue to gather some more untranslated strings (following #122 now closed) and formulate some remarks on text in UI.

Non localized strings :

• Menu > Open Source Licences > Licenses (as seen in #122)
• Menu > About > About
• In intro, Back and Next buttons tooltip on long press

Inconstistancies:

• In French, Upgrade translates to "Mise à niveau" or "Mettre à niveau" (Upgrade can be a word or a verb respectively). I did not touch your translation of "Version Premium" but it is not litterally equivalent. Perhaps the english string would also benefit from being more explicit as Premium Version?
• Menu > Statistics > Select label > all --> Should be All with caps
• Date format in statistics does not adapt to language
• I assume Insistent notification is not the same as Persistant notification. Insistant repeat, while persistant stay forever without repeating. I think a notification cannot be insistant, as a thing, it does not have will of its own. Something more impersonal would be better, like 'Repeat notification until aknowledged' or a better formulation.
• Moves the timer while the screen is on : I don't understand what this feature does. The timer goes on if screensaver on, Only if this feature is turned on? For me it is unclear what this option does with this formulation.

I have my short breaks set to 5 minutes and 15-minute long breaks set to activate after every 4 sessions. But I've noticed that the long breaks aren't activating at the proper time. Either I see the long break at an unexpected time (say, after 7 sessions), or I only get 5 minute breaks; I'm not certain which one is happening because it's difficult to test without actually doing the Pomodoros. Skipping ahead by swiping right on the timer does show the breaks at the expected intervals though.

The only possibility that came to mind was the need to reset the timer on each new day, which I do anyways, but is probably already the default after the app is closed (if it isn't, perhaps we could get this as a setting to avoid the need to remember to reset?). I haven't seen any bug reports on a similar problem, so since I've already gone through the settings, I suspect the problem with getting long breaks is either due to a hidden feature (e.g. maybe I'm waiting too long after some Pomodoros) or a bug.

I use fullscreen mode in combination with the minutes-only timer design. However, when I open the app, it is hard to judge if the timer is actually running or currently paused (which is the case after opening the app), because it does not move and you can not see the notification bar to check whenever the phone is in DND mode. If I then press the timer twice to go into the real pause mode, it blinks - which is a clear indication of pause. For the initial display though, it would be nice to see that the timer is not running - maybe indicate that with a little symbol or text below the timer, that the session has to be started.

I tried adding logs in the project but could now figure out the reason why... But if you try to stop the sesssion from the notification(or sometimes from the mainactivity) then too it's not saving the session. The code execution comes to the addSession function but doesn't work

Hi

I work in a silent environment, but have my earphones connected to the phone. My phone is in silent mode, vibrations only. Would it be possible to have an option to play the end of timer sound on the earphones. I think now they are not playing because the phone is in silent mode. If I turn on "override sound profile", I think the phone will ring both in the earphones and through the speaker, like an alarm. I would like the app to notify me with a sound in my earphones, like any music app.

Thank you for the great app

Just wanted to ask you to consider if Material You might be a good fit for this project. I think it'll be great with the present style of minimal branding and could also serve as a nice marketing point.