Hello

I am using PdfDocument to crerate PDF file. I am saving this file to app's Internal filesDir. Now when I run below code I am getting "Pdf has been corrupted" Toast message

startActivity(new PdfViewerActivity().Companion.launchPdfFromPath(Activity4.this, file.getAbsolutePath(), "", "", false));

So what can I do?

Thank you

The 1.0.8 release on Jitpack is empty / NotFound: https://jitpack.io/com/github/afreakyelf/Pdf-Viewer/1.0.8/ but the version name with a v prefix works: https://jitpack.io/com/github/afreakyelf/Pdf-Viewer/v1.0.8/

Is your feature request related to a problem? Please describe. I'm currently using PdfRendererView in my project. I want to add pinch-to-zoom functionality to it.

Describe the solution you'd like I would like to enable this feature with a boolean flag, such as: pdfRenderView.isPinchZoomEnabled = true

Describe alternatives you've considered Not possible currently.

I'm working on an app that has pdf urls in a json response, but the library doesn't seem to work with those. Do you possibly have a potential workaround and use for this?

Ui Page number

You need to add the custom string to strings.xml file and override the required strings.xml values.

Default:

<string name="pdfView_page_no">%1$s of %2$s</string>

Custom:

<string name="pdfView_page_no" >%1$s / %2$s</string>

#hacktoberfest

Please add a hacktoberfest topic

Thanks for your nice work. English is not my first language, I will try my best to describe my problem.

I implemented my own PdfViewerActivity by using PdfRendererView. After opening a big pdf file, like more than 200 pages, the render core will try to build the bitmap all of the pages. This is because that the height of the recycler view item is wrap_content, which means 0 pixel. So the recycler view will try to load as more items as possible which seems like "block" the rendering. And, buildBitmap runs in a GlobalScope, the jobs won't be canceled when activity is destroyed. After close the large pdf and try to open a small pdf file, the rendering is still blocked since there are still lots of jobs remaining.

I think this can be fixed by giving list item a default height, such as 480dp, so that the recycler view won't request a lots of buildBitmap jobs.

• Set target and compile SDK version to API 32. • Upgraded Gradle version to 7.1.2. • Built project in Android Studio 2021.1.1 Patch 2 (Bumblebee). • Added Java 11 support to project. • Added Jetpack ViewBinding support to example project. • Updated project Kotlin version to 1.6.10 • Updated all internal dependencies. • Upgraded project version to 1.1

Add customizations for these elements/attributes

• ActionBar background color
• ActionBar title text appearance
• Navigation icon
• Navigation icon tint
• Download icon
• Download icon tint

App crashed Fatal Exception: java.lang.RuntimeException: Unable to stop activity {com.letzconnect/com.rajat.pdfviewer.PdfViewerActivity}: java.lang.IllegalStateException: Already closed To Reproduce Steps to reproduce the behavior:

1. open PdfViewerActivity
2. minimize the app
3. Reopen the app from the minimized tray or from the launcher icon.
4. the app will get crashed

Cause onStop() binding.pdfView.closePdfREnder() if you cant reproduce the case ping me.

• Added pdfView_page_margin as an attribute to change spacing (Right, Left, Top, Bottom) from the pages Or use the following attribute to add space for each edges:

<com.rajat.pdfviewer.PdfRendererView
    android:id="@+id/pdfView"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    app:pdfView_divider="@drawable/divider"
    app:pdfView_engine="internal"
    app:pdfView_enableLoadingForPages="true"
    app:pdfView_page_marginRight="10dp"
    app:pdfView_page_marginLeft="10dp"
    app:pdfView_page_marginTop="5dp"
    app:pdfView_page_marginBottom="5dp"
/> 

• Added loading view for each page. It's available by using pdfView_enableLoadingForPages attribute.
• Optimise rendering PDF process by using CoroutineScope instead of GlobalScope

Breaking Changes

• Added night/light mode background for PdfViewerActivity. If you enable spacing, it will show the background of this activity.
• Remove background from the list of pages (PinchZoomRecyclerView) to let developers add a custom background for PDF viewer. It may affect to see the PDF viewer result by showing the parent background.

Gif:

Please add the Double Tap to Zoom feature, right now user's are not aware the PDF can be zoomed or not, some users don't explicitly try to Pinch to Zoom and leave it thinking the PDF can not be zoomed. It'll be great if Double Tap to Zoom can be by default.

When I am using the v1.0.1 it's throwing the error PDF has been corrupted but when I am downgrading it to v1.0.6 then it's working fine.

Kindly revert any changes if you have done in v1.0.1 which might be causing the aformentioned error.

Describe the bug We performed an analysis on our code with Veracode and detected the follow flaw on library, especifically on class PdfRendererCore.kt

CWE-73: External Control of File Name or Path Flaw Category: Directory Traversal Description: The software allows user input to control or influence paths or file names that are used in filesystem operations.

This could allow an attacker to access or modify system files or other files that are critical to the application. Path manipulation errors occur when the following two conditions are met:

1. An attacker can specify a path used in an operation on the filesystem.
2. By specifying the resource, the attacker gains a capability that would not otherwise be permitted. For example, the program may give the attacker the ability to overwrite the specified file or run with a configuration controlled by the attacker.

Attack Vector: pdfViewer/src/main/java/com/rajat/pdfviewer/PdfRendererCore.kt: 52 and pdfViewer/src/main/java/com/rajat/pdfviewer/PdfRendererCore.kt: 65

Additional context Veracode scan is required by our client and managed by him in regards to the process to point out a false negative. So it would be nice to point out if there are any risks or changes that can be made. Thanks.

When there are more than 10 pages in a Pdf File then it takes so much time to load and its did not loads pages properly when we are having more pages in Pdf