I've integrated Mapbox.js as the default Web map provider and would like to contribute it to AirMapView. All that's needed to make it work is to signup for a free Mapbox account and add your Access Token and MapId (this is documented in README as part of this PR as well as the updated Sample app).

Please let me know if you have any questions. Thanks!

/cc @petzel @lxdvs

Don't force enabling location permissions when loading map. First commit needs to be taken out once the PR for it is merged.

Resolves https://github.com/airbnb/AirMapView/issues/97

@felipecsl @petzel @gpeal

Google provides a utility library named android-map-utils, which includes many features not included directly in Google Maps, like :

• clustering
• heat maps
• GeoJSON support
• KML support

Obviously, this library expects the APIs from Google Maps, so it cannot work with AirMapView.

Since this library is open-source, I started integrating it in AirMapView. A working demo can be found at this address : https://github.com/acq/AirMapView/tree/map-utils. The only feature that does not work yet is custom tiles (and others require more work, like custom images for markers). Here are some screenshots:

In this proof of concept, several features needed to be added or reworked in order the library to work. This includes ground overlays, custom image markers on web maps, changed APIs (for example: AirMapPolyline), various bug fixes, ...

This code is not ready to be merged, but raises several questions:

• are you interested in having those features? part of those features?
• do you want them inside of AirMapView or in their own library (like android-map-utils exists currently), in order to keep AirMapView light?
• I modified the package of these utils, so this library could exist in the same environment than the "old" android-map-utils. What package should be used?
• are you open to the modification of current AirMapView APIs?

Thanks!

With the sample app installed on a UK based device, Nexus 6 running Lollipop

1. Change device language to Spanish / German etc
2. Select 'Use Google Web Map' or 'Use MapBox Map'
3. RESULT: the markers are incorrectly placed in a horizontal line across globe

If you change the language to certain Asian ones - Chinese, Thai for example, the markers are correctly placed.

Native Google Maps needs WRITE_EXTERNAL_STORAGE permission on Android M, so we should check for that as well before assuming that it is supported. This prevents AirMapView from crashing on M.

@petzel @nwadams

Hey,

looks like the library asks for a location permission on behalf of us. What I'd like to achieve is to ask for this permission on my own.

From what I can see checkLocationPermissions() checks if permission is granted and asks for it if not. This method is used only from setMyLocationEnabled() method. This would be acceptable if, as a workaround, I could pass false to it and avoid asking. Unfortunately in NativeGoogleMapFragment init() method there's a setMyLocationEnabled(true) call which forces asking for permission.

Is this correct or am I missing something?

As for me, the ideal solution would be to completely remove asking for this permission from AirMapView and leave it to developer's decision. Another, that would probably work for most of people, would be to remove setMyLocationEnabled(true) from mentioned init() method.

What do you think?

In a project I'm doing I realized that I needed to show the user location on the map. As I didn't find any way to directly do this, I coded something that should work on both native and webview versions.

This return a error when I try to compile. The build of gradle works well, but the app, not.

Error:Execution failed for task ':app:dexDebug'.
> com.android.ide.common.process.ProcessException: org.gradle.process.internal.ExecException: Process 'command '/usr/lib/jvm/java-7-openjdk-amd64/bin/java'' finished with non-zero exit value 2

@felipecsl @nwadams

this just adds the amazon module.

since it is an aar, android studio won't build it if simply included in libs - it has to be imported as a new module

Change summary:

onLocationPermissionsGranted is called only when location permissions were granted. We should set location enabled as true and show the location button.

tested on the sample app

How was it tested?

• [X] Built and ran on simulator
• [X] Built and ran on device

Please review:

@felipecsl

Allowing the user to set not only MyLocationEnabled but also ZoomControlsEnabled and MyLocationButtonEnabled

Attempts to address https://github.com/airbnb/AirMapView/issues/103

Hey there!

I'd like to report a security issue but cannot find contact instructions on your repository.

If not a hassle, might you kindly add a SECURITY.md file with an email, or another contact method? GitHub recommends this best practice to ensure security issues are responsibly disclosed, and it would serve as a simple instruction for security researchers in the future.

Thank you for your consideration, and I look forward to hearing from you!

(cc @huntr-helper)

TouchListener simply will not work since mapview itself is using touchlistener inside of it. What if we want to detect action up by our own touchlistenr? Please provide solution.

I accidentally published this breaking change https://github.com/airbnb/AirMapView/pull/136 to Airbnb Artifactory for version 1.9.0.

This version, 1.9.1, removes the breaking change. I'll have a releases to update airmapview version in the Android app to 1.9.1.

Do not merge this into master