Apologies if this has been previously asked.

I'm following the articles and the samples - the dependency rule states you can only point inwards.

In the sample, the data layer repository is implementing the domain layer repo interface. Isn't this breaking the rule? I've tried to understand why this is acceptable but to no avail,

Can someone fill me in ?

Had crash on first launch. After i clicked on load sample data. 12-23 12:46:53.522 2958-2958/com.fernanependocejas.android10.sample.presentation E: FATAL EXCEPTION: main Process: com.fernanependocejas.android10.sample.presentation, PID: 2958 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.fernanependocejas.android10.sample.presentation/com.fernandocejas.android10.sample.presentation.view.activity.UserListActivity}: java.lang.NullPointerException at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2184) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2233) at android.app.ActivityThread.access$800(ActivityThread.java:135) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1196) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:136) at android.app.ActivityThread.main(ActivityThread.java:5001) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:785) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:601) at dalvik.system.NativeStart.main(Native Method) Caused by: java.lang.NullPointerException at com.fernandocejas.frodo.aspect.LogObservable.methodAnnotatedWithRxLogObservable(LogObservable.java:27) at com.fernandocejas.android10.sample.data.net.RestApiImpl.userEntityList(RestApiImpl.java) at com.fernandocejas.android10.sample.data.repository.datasource.CloudUserDataStore.userEntityList(CloudUserDataStore.java:51) at com.fernandocejas.android10.sample.data.repository.UserDataRepository.users(UserDataRepository.java:54) at com.fernandocejas.android10.sample.domain.interactor.GetUserList.buildUseCaseObservable(GetUserList.java:41) at com.fernandocejas.android10.sample.domain.interactor.UseCase.execute(UseCase.java:59) at com.fernandocejas.android10.sample.presentation.presenter.UserListPresenter.getUserList(UserListPresenter.java:113) at com.fernandocejas.android10.sample.presentation.presenter.UserListPresenter.loadUserList(UserListPresenter.java:77) at com.fernandocejas.android10.sample.presentation.presenter.UserListPresenter.initialize(UserListPresenter.java:68) at com.fernandocejas.android10.sample.presentation.view.fragment.UserListFragment.loadUserList(UserListFragment.java:155) at com.fernandocejas.android10.sample.presentation.view.fragment.UserListFragment.onActivityCreated(UserListFragment.java:76)

Great repo. However, I didn't like the multiple activity design. This version only uses a single MainActivity and three fragments.

I am relatively new to dependency injection and Dagger2 so I'd appreciate any feedback you might have.

If you want this to go into a separate branch, just let me know.

This is not an issue. It's really a clearly defined architecture. A lot of technologies are introduced into the architecture, I 've never used them before, Dagger, RxAndroid, Butternife, etc. But I am little confused by the fine defined UseCases, for example , GetUserList, GetUserDetails for user usecases. If I want to do user search, I must define SearchUser usecase, I want to do CRUD for many many Objects, I need to write hands of usecases separately. And, I'm not sure how to pass parameters to the usecases. For example, GetUserDetails, pass the userId by constructor in UserModule. How can I pass a search critera to SearchUser UseCase? A Map? Or a Model? Is there another way instead of constructor?

Thank you very much for any suggestion.

In the current approach, every time after the orientation changes, the use case is executed once again. It would be a good solution if there would be a way to reuse the current operation after the orientation change, if the previous one is still running

Dagger 2 has implicit dependency:

+--- com.google.dagger:dagger:2.0.2
|    \--- javax.inject:javax.inject:1

Domain and Data modules don't depend on any class from the Dagger 2 API. They need only @Inject annotation, so it makes no sense to have the entire library in classpath.

Hi, i have general question. I have checked test code.

In Data layer test, test class only tests if some method is called, and does not care about result of method. Example, RepositoryTest only tests if method for getting User object is called, but it does not check if it really gets User object from that method. Same for DataStore classes.

In Domain layer, again same thing for UseCases. It only tests if UseCase calls some repository method. Does not care about if it really gets result from that method.

In Presentation layer, again PresenterTest only tests if Presenter calls some method of UseCase.

Question:

1. What is point of "testing only if method is invoked" :grey_question:
2. Why none of the Test classes care about the result of method they've called :grey_question: Example, Presenter only checks if it calls useCase method, but why it does not check if view.showContent() is called after useCase returns data? There is no test for if UserCache is able to return right data?

Sorry if i am missing sth

During get users from API on Samsung devices with Android < 5 always throwing fatal error.

Reproduces on devices:

• Samsung GT-i9300, Android 4.4.4
• Samsung SM-T530, Android 4.4.2
• Samsung Nexus S, Android 4.1.2

On Samsung SM-G531F, Android 5.1.1 worked correctly

May be bug reproduced for all devices on Android < 5 (no-samsung devices with v4.. not available for me).

Error listing:

E/AndroidRuntime: FATAL EXCEPTION: main Process: com.fernanependocejas.android10.sample.presentation, PID: 31028 java.lang.VerifyError: com/fernandocejas/android10/sample/data/net/RestApiImpl$AjcClosure1 at com.fernandocejas.android10.sample.data.net.RestApiImpl.userEntityList(RestApiImpl.java:53) at com.fernandocejas.android10.sample.data.repository.datasource.CloudUserDataStore.userEntityList(CloudUserDataStore.java:51) at com.fernandocejas.android10.sample.data.repository.UserDataRepository.users(UserDataRepository.java:54) at com.fernandocejas.android10.sample.domain.interactor.GetUserList.buildUseCaseObservable(GetUserList.java:41) at com.fernandocejas.android10.sample.domain.interactor.UseCase.execute(UseCase.java:60) at com.fernandocejas.android10.sample.presentation.presenter.UserListPresenter.getUserList(UserListPresenter.java:115) at com.fernandocejas.android10.sample.presentation.presenter.UserListPresenter.loadUserList(UserListPresenter.java:79) at com.fernandocejas.android10.sample.presentation.presenter.UserListPresenter.initialize(UserListPresenter.java:70) at com.fernandocejas.android10.sample.presentation.view.fragment.UserListFragment.loadUserList(UserListFragment.java:158) at com.fernandocejas.android10.sample.presentation.view.fragment.UserListFragment.onViewCreated(UserListFragment.java:80) at android.app.FragmentManagerImpl.moveToState(FragmentManager.java) at android.app.FragmentManagerImpl.moveToState(FragmentManager.java) at android.app.BackStackRecord.run(BackStackRecord.java) at android.app.FragmentManagerImpl.execPendingActions(FragmentManager.java) at android.app.Activity.performStart(Activity.java) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java) at android.app.ActivityThread.access$800(ActivityThread.java) at android.app.ActivityThread$H.handleMessage(ActivityThread.java) at android.os.Handler.dispatchMessage(Handler.java) at android.os.Looper.loop(Looper.java) at android.app.ActivityThread.main(ActivityThread.java) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java) at dalvik.system.NativeStart.main(Native Method)

I think the code hides a potential issue that might appear with a minor change to the requirements. It calls Butterknife.unbind() in onDestroyView(). Also it calls view methods from Subscriber and unsubscribes in onDestroy(). If one of Subscriber's callbacks is called between onDestroy() and onDestroyView() we will get a NPE. I think it's not possible to reproduce the issue in this particular sample. Howerver, in a more complicated application that is using fragments' backstack it might be a problem.

According to this article here, they said that:

Don't use Observable.create() if you can, it's very easy to shoot yourself in the foot! (and then shoot again for each new subscriber!)

I like how you architectured your application but, in a real android app. you would't want to waste resources and make new network request every time the user does something as simple as rotating their phone.

Hello, if this project has player that can play the movie,which layer should mediaplayer be, Fragment, viewmodel or usecase? I searched on the internet and I can't find solutions, thanks.

When initiating a build on the command line, I am seeing a very old NDK warning. I have ndk-bundle installed. There is no local.properties file at project root. Log:

Android-CleanArchitecture git:(master) ./gradlew clean build
To honour the JVM settings for this build a new JVM will be forked. Please consider using the daemon: https://docs.gradle.org/4.1/userguide/gradle_daemon.html.
Daemon will be stopped at the end of the build stopping after processing
Configuration on demand is an incubating feature.

> Configure project :data
NDK is missing a "platforms" directory.
If you are using NDK, verify the ndk.dir is set to a valid NDK directory.  It is currently set to /Users/shipit/Library/Android/sdk/ndk-bundle.
If you are not using NDK, unset the NDK variable from ANDROID_NDK_HOME or local.properties to remove this warning.

Hello, dear CleanArchitecture team, first I have to thank you for this amazing open-source project to help out the community, secondly, I need to ask is there any video on this project or a full document to learn this whole project implementation?

I am an Android developer and I've been using MVC till now, but I want to switch to this AMAZING architecture now, honestly, I don't know where to begin to understand the logic of this Architecture, is there any roadmap that I can follow to learn this architecture which one of you have used before? I appreciate it if anyone can help me with a link or a video for documentation.

Thanks in advance.

Hi,

I was reading your project and there's something regarding the use of Schedulers on UseCase that I don't well understand.

Note that I'm quite new to android programming so please forgive me if I say something terribly wrong! 😅

So, why the UseCase needs a ThreadExecutor for the "backend" computation and a Scheduler to execute the observer? Why not ask for the same type?

I mean, if the reason to ask for a ThreadExecutor is to be free to use whatever executor you want, why the same thing doesn't apply for observeOn? Why can't we ask again for another ThreadExecutor and simply call observeOn(Schedulers.from(executor))? (Note: I understand that is very simple to refer to the main thread using Schedulers thanks to AndroidSchedulers.mainThread(). There isn't a so simple way to obtain the main ThreadExecutor on Android?)

And why we can't achieve the same result asking for two Schedulers? I mean, if I want simply use Schedulers.io() as background scheduler, how can I pass it to the UseCase? If the UseCase was asking for a Scheduler also for subscribeOn, I could pass Schedulers.io() or a custom scheduler (created with Scheduler.from(myThreadExecutor)) based on my need.

Thanks in advance!