A material-design Hacker News Android reader

Many HN posts are pdfs (e.g. Research papers, scientific reviews,...). It would be nice for this app to support them Device: Google Pixel, SDK: 26, app version: 74

Hi hidroh,

I have just installed your app and I have to say that it is amazing :) I really like the look and it works well. I don't have the Google Play Store on my smartphone for privacy reasons, thus I mostly use apps from alternative appstores, mainly F-droid (https://f-droid.org/). I downloaded yours using the Google Play Downloader software (https://codingteam.net/project/googleplaydownloader). There are actually two apps on F-droid to read HN, but they are not as good as yours. Thus, I was wondering if you already thought about proposing Materialistic on F-droid. I think it might be a good idea.

My 2 cents...

First draft of the PDF support implementation.

For rendering PDF, we use PDF.js to render PDF in a WebView. To provide PDF doc (which could be quite big) we stream it via the Android<->JavaScript bridge, PDF.js requests chunks it needs, and we serve them from the Android side through that bridge.

So, currently it works this way:

We check in WebFragment's downloadListener if the mime type is application/pdf, and if yes - we download the PDF file, and then start rendering the PDF loader (just an HTML file, that initializes PDF.js and hooks up the bridge, and also exposes some additional API (e.g. for zoom).

The bridge provides access to the downloaded file, via RandomAccessFile. We need to support random access, therefore we can't use OkHttps BodyResponse and its streams, because it only allows to read forward, and doesn't support going back.

The only way to make proper zoom is to rely on built-in WebView's zoom. So, I render PDF first with scale factor == 2, then set initial scale of WebView to 1%, which makes it to max scale out so it fits the window size.

PDF.js render itself into a container you provide. Built-in PDF.js PdfViewer uses the container's height to figure out what pages it needs to load/render. Since in Materialistic the WebView's height wraps the content, we should use window's height instead of container's height for that. So, we inherit our custom CustomPdfViewer from PdfViewer and override that functionality.

The only HTML/JS stuff I wrote is in assets/pdf/index.html and assets/pdf/script.js. All other stuff in assets/pdf/vendor/pdf.js/ is taken from the PDF.js repo without any changes.

@hidroh, please take a look, and give me feedback on a general approach. Please disregard the tests for now, I'll focus on them later, when the functionality gonna be in place and correct.

Thanks!

First off I'm a big fan of this app. Lately i'm having issues with saving stories for offline use. The comments download, but the app refuses to store the article (both readability and normal). After saving some articles in a row, the app flat out refuses to show me any article even. The widget refreshes badly too. There are duplicate entries after manually refreshing. When the widget updates at the set interval without an internet connection, the refresh time get's updated but the articles stay the same. Clearing the app cache solves both problems, but i don't want to keep resetting the app like this every day. Os: Oxygenos 3.1.4 Phone: oneplus X Device: OnePlus ONE E1003, SDK: 23, app version: 65

I can consistently reproduce a crash;

1. Open app
2. Press the comment shortcut on a post
3. Wait for load
4. Go back
5. Press the comment shortcut on the same post (or any others)
6. Crash 👎

Let me know if there's anything else I can do to further help.

Hi, I have been upvoting a few stories and comments over the past week. But recently, when I logged in from the web, I cannot see those in my profile. I think there is something wrong and the upvotes are not going through to HN. You can reach me on [email protected] if you have any questions. Thanks, Niranjan Device: Huawei Nexus 6P, SDK: 23, app version: 54

If cache is not present then app should reload the story from the website. Currently is just shows all the stories but on opening it is blank. might be related to #448 maybe cache is the problem there too.

Hey @hidroh,

I'm curious what your thoughts are for including a text post at the top of the comments page. It would be really nice to see the OP along with the comments. I dislike that I have to open the article view if I want to see the post. Ideally, the app should hide the article view for a post that goes back to HN and display the post with comments.

I'd be down to work on this feature and submit a PR.

When you scroll through a text post, you actually cannot read the last words on 2-3 last lines because of the Fullscreen icon. It would be cool to at least be able to scroll the height of the button or more, depends on you. [Nexus 5X] Thanks for looking into this. :)

It is a bit annoying to not be able to share a post from the app and have the post title in there, currently it only sends the URL, so I have to open in external browser and share from there.

Currently there is no way to know where I ended up last time I opened the app, and there is no visual clue on what posts are new versus what I've read before ( talking about titles, not opening the post page itself ).

It'd be great if we can implement a way to mark items as read by scrolling, just like Feedly does now, so you can storm through issues and be sure not to miss anything important. Or maybe a new flag to flag newer post since the last application run.

Description

I occasionally met with this bug when I tried to update the top stories by scrolling

Environment

Android: Android 9.0 App Version: 3.3

Logcat

01-01 12:00:25.956 4989 4989 E AndroidRuntime: FATAL EXCEPTION: main 01-01 12:00:25.956 4989 4989 E AndroidRuntime: Process: io.github.hidroh.materialistic, PID: 4989 01-01 12:00:25.956 4989 4989 E AndroidRuntime: java.lang.IllegalStateException: Exception thrown on Scheduler.Worker thread. Add onError handling. 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.android.schedulers.LooperScheduler$ScheduledAction.run(LooperScheduler.java:112) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at android.os.Handler.handleCallback(Handler.java:873) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at android.os.Handler.dispatchMessage(Handler.java:99) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at android.os.Looper.loop(Looper.java:193) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at android.app.ActivityThread.main(ActivityThread.java:6669) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at java.lang.reflect.Method.invoke(Native Method) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:858) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: Caused by: rx.exceptions.OnErrorNotImplementedException: length=500; index=500 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.internal.util.InternalObservableUtils$ErrorNotImplementedAction.call(InternalObservableUtils.java:386) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.internal.util.InternalObservableUtils$ErrorNotImplementedAction.call(InternalObservableUtils.java:383) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.internal.util.ActionSubscriber.onError(ActionSubscriber.java:44) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.observers.SafeSubscriber._onError(SafeSubscriber.java:153) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.observers.SafeSubscriber.onError(SafeSubscriber.java:115) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.exceptions.Exceptions.throwOrReport(Exceptions.java:212) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:139) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.internal.operators.OperatorObserveOn$ObserveOnSubscriber.call(OperatorObserveOn.java:224) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.android.schedulers.LooperScheduler$ScheduledAction.run(LooperScheduler.java:107) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: ... 7 more 01-01 12:00:25.956 4989 4989 E AndroidRuntime: Caused by: java.lang.ArrayIndexOutOfBoundsException: length=500; index=500 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.widget.StoryRecyclerViewAdapter$4.onInserted(StoryRecyclerViewAdapter.java:399) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.recyclerview.widget.BatchingListUpdateCallback.dispatchLastEvent(BatchingListUpdateCallback.java:61) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.recyclerview.widget.BatchingListUpdateCallback.onRemoved(BatchingListUpdateCallback.java:96) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.recyclerview.widget.DiffUtil$DiffResult.dispatchUpdatesTo(DiffUtil.java:911) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.widget.StoryRecyclerViewAdapter.setUpdated(StoryRecyclerViewAdapter.java:396) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.widget.StoryRecyclerViewAdapter.setItems(StoryRecyclerViewAdapter.java:283) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.ListFragment.onItemsLoaded(ListFragment.java:249) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.ListFragment.lambda$onActivityCreated$4(ListFragment.java:187) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.ListFragment.$r8$lambda$KCbw5lT5IwQLfeH-hTN8C5vik10(Unknown Source:0) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.ListFragment$$ExternalSyntheticLambda2.onChanged(Unknown Source:4) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.lifecycle.LiveData.considerNotify(LiveData.java:133) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.lifecycle.LiveData.dispatchingValue(LiveData.java:151) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.lifecycle.LiveData.setValue(LiveData.java:309) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at androidx.lifecycle.MutableLiveData.setValue(MutableLiveData.java:50) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.StoryListViewModel.setItems(StoryListViewModel.java:47) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.StoryListViewModel.lambda$refreshStories$3(StoryListViewModel.java:42) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.StoryListViewModel.$r8$lambda$yA_bLy3goAa16fjN4fE6mDqYKaM(Unknown Source:0) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at io.github.hidroh.materialistic.StoryListViewModel$$ExternalSyntheticLambda3.call(Unknown Source:4) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.internal.util.ActionSubscriber.onNext(ActionSubscriber.java:39) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: at rx.observers.SafeSubscriber.onNext(SafeSubscriber.java:134) 01-01 12:00:25.956 4989 4989 E AndroidRuntime: ... 9 more

Environment

Android: Android 9.0 App Version: 3.3

ScreenRecord

https://user-images.githubusercontent.com/120108516/210244787-2167ec8b-d395-4f6f-a60e-541795b8440c.mp4

Clicked the email and crashed.

Logcat

FATAL EXCEPTION: main Process: io.github.hidroh.materialistic, PID: 26422 java.lang.NullPointerException: Attempt to invoke interface method 'java.lang.String java.lang.CharSequence.toString()' on a null object reference at java.lang.String.contains(String.java:2196) at io.github.hidroh.materialistic.AppUtils.openWebUrlExternal(AppUtils.java:105) at io.github.hidroh.materialistic.AppUtils$1.onTouch(AppUtils.java:166) at android.view.View.dispatchTouchEvent(View.java:12509) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3030) at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2719) at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:440) at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1830) at android.app.Activity.dispatchTouchEvent(Activity.java:3400) at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(WindowCallbackWrapper.java:69) at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:398) at android.view.View.dispatchPointerEvent(View.java:12752) at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:5106) at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:4909) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4426) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4479) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4445) at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:4585) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4453) at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:4642) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4426) at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:4479) at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:4445) at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:4453) at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:4426) at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:7092) at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:7061) at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:7022) at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:7195) at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:186) at android.os.MessageQueue.nativePollOnce(Native Method) at android.os.MessageQueue.next(MessageQueue.java:326) at android.os.Looper.loop(Looper.java:160) at android.app.ActivityThread.main(ActivityThread.java:6669) at java.lang.reflect.Method.invoke(Native Method)

Would be nice to have setting to redirect twitter links to chosen nitter server.

For now I created app twitter2nitter which will redirect if you share twitter link to it.

But as I say in this situation baked in option would be noice.

Currently, sharing a comment shares the content of the comment but not a link to the comment itself. Sometimes you want to save a comment for later to go back to it...

I reset my phone but I cannot find the app to the play store in order to re-install it. Is it a problem with my device or a general one? Can I find it somewhere else?