Yet Another Hacker News Android Client

Can't tell if the text is white or not there at all

This happens on my Nexus 6P, screenshot below, the hyperlink should be on the third line (where the gap followed by a slash is)

The menu icons in menu_comments.xml are different sizes; the share icons from action_share are bigger than the normal size for a menu icon. They should be 24dp (guidelines), but appear to be 36dp instead. The icons for action_article and action_bookmark and the up button are the correct size.

I tried fixing the share button by adding android:icon="@drawable/ic_share" (to at least set the share icon to the correct size, as the ic_share draw able is the correct size) to the item, but I didn't see any change as a result.

Got help from @Chainfire and tried: http://stackoverflow.com/a/24472038 & http://stackoverflow.com/a/21922282. The icon changed, but it got for some reason it scaled up and became blurry, so neither worked (I tried with your @drawable/ic_share and the built in @drawable/abc_ic_menu_share_mtrl_alpha).

I think android.support.v7.widget.ShareActionProvider just hasn't been updated to meet the new guidelines.

Possible solution: switch to another share implementation. I wouldn't mind attempting to handle this; it would be a good learning experience for me. Any suggestions/thoughts?

Great client, by the way. Installed it yesterday and I've really been enjoying it. Seems very well written, too.

Don't think this one is going to require much description. In the newest update, scroll up or down in the in-app browser. (Look at the navbar). Moto G, 5.1

I noticed that the icons didn't look quite right so I just wanted to fix them with the icons from the material icon pack, but that led to some other problems which in turn resulted in having to change the layout quite substantially. I want to add that I'm still very new to android development so any feedback here is welcome!

Merry Christmas @malmstein!!!

This PR contains the fix for #31. The fix is based on:

• Update Travis-CI configuration. Travis-CI does not support Android Build tools 23.0.2 so I've changed the version used to the one supported: 23.0.1.
• Update the root build.gradle file to remove some not needed dependencies.
• Remove some code was not compiling. Please review this carefully, I don't why was not compiling.

The problem you had with your Travis-CI configuration it's not related to the application build. The problem is in your artefacts repository hosted at http://ci.novoda.com/maven/releases which is completely down or not accesible from the Travis-CI environment. Http requests to this repository were getting timeouts continuously and that's why all your Travis-CI builds were failing.

I think it could be useful to utilize the new Chrome Custom Tabs that has come out for the in app browser. Some benefits:

• Uses a Chrome instance, so logins and such will be used in the app.
• Will still look like a normal WebView within the app
• Can pre-load URLs. I think a good use case for this would be when a user reads the comments, they could pre-load the URL

Just an idea.

There should be a ripple on the icons when they're touched or held down. Seems like only the article and comments menu icons are problematic.

I've had this issue in one of my own apps and I'm not sure what the solution is.

When viewing an article and then going to recents, you can't get back to the main article list without launching it from the launcher

Repro steps:

• Open an article
• Press the home button
• Press recents and select yahnac
• Press the back (or up) button on the article view

Expected result: The app will go back to the list of articles

Actual result: The app exits and you return to your previous app.

Thanks :)

Hi @malmstein

I found this app on the Google Play Store. This guy just took your source code, added some ads in it and put it on the Store, without warning this is free software...

As you are the owner of the source code, feel free to open a request to google here to remove the false app from the Store, if it's your wish ;)

Don't forget to tell Google that:

• The app is licensed under Apache v2 license and this guy is violating it;
• He is falsely claiming he made the app;
• Provide screenshots of your app and a link to the real (yours) app.

This patch fixes issue #48.

Html.fromHtml() adds newline characters to the end of the styled text if the comment consists of multiple paragraphs (<p>..</p> <p>..</p>).

After some comments there is an empty line (see screenshot). CommentsParser already filters empty spans but maybe the markup has changed a bit (like it did in #46).

Incremental compilation. Gradle recompile only the classes that were affected by a change. This feature is the default since Gradle 4.10. For an older versions, we can activate it by setting options.incremental = true.

===================== If there are any inappropriate modifications in this PR, please give me a reply and I will change them.

The "best" tab is great for getting up to date with HN, but when I have been offline for four days it will also display news from eight days ago, interleaved with the rest. It would be great to be able to mark items as read (swiping or otherwise), or at least define the maximum age of a post to be considered relevant.

An example case: the last post by PG has been there in my top three articles for an entire week. Past the first two days, it's just noise.

When scrolling the comments view, it's not uncommon to scroll up a couple of lines to read something that you may have passed by skimming too fast. When you do that, the header will appear scrolling down and hiding the information that I wanted to see, forcing to scroll up even more. With a long post, this can happen multiple times.

Adding a bigger amount of scroll up to trigger the display of the header would solve this. This could get tricky with the initial page of comments.

This is not an important issue, and could just be ignored if the implementation is not trivial.

Some people (myself included) have chosen not to install Google Play services on their devices. It'd be nice to have this app published on F-Droid to make it more accessible.