Description

https://detekt.dev/ https://pinterest.github.io/ktlint/

At some point it would be nice to get these setup in the project so developers can focus more on contributions and have these checkers as part of CI.

Additional Information

No response

📑 What does this PR do?

This PR adds support for Detekt as discussed on issue #11

The rule add here are the default ones with some tweaks for Jetpack Compose. Such function naming, complexity, compose annotations and Twitter Comose Rules

✅ Checklist

• [x] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [x] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

• Run ./gradlew detekt to run Detekt for the entire project
• Run ./gradlew module:detekt to run Detekt on a specific module

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

🖼️ Screenshots (if applicable):

Description

When talking about a product it is mandatory to have a proper name which can be remembered and linked to its functionality. Like the community once came up with Boaty McBoatface we should be able to find some good names as well.

Let's first collect some ideas and later on we can start a poll for the decision.

Additional Information

No response

Description of the bug

./gradlew installDebug, open the App, it will crashed.

Steps To Reproduce

1. git clone https://github.com/AndroidDev-social/MastodonCompose.git
2. ./gradlew installDebug, open the App, holder seconds in login screen, it will crash

Additional Information

Android Version: Android 13 OS: Pixel experience the crash log 2022-11-25 07:57:49.860 28704-28704/? E/AndroidRuntime: FATAL EXCEPTION: main Process: social.androiddev.mastodon, PID: 28704 java.lang.NullPointerException: decodeByteArray(byteArray, 0, byteArray.size) must not be null at social.androiddev.common.utils.ImageLoadingKt.loadImageIntoPainter(ImageLoading.kt:21) at social.androiddev.common.utils.ImageLoadingKt$loadImageIntoPainter$1.invokeSuspend(Unknown Source:13) at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33) at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106) at kotlinx.coroutines.internal.LimitedDispatcher.run(LimitedDispatcher.kt:42) at kotlinx.coroutines.scheduling.TaskImpl.run(Tasks.kt:95) at kotlinx.coroutines.scheduling.CoroutineScheduler.runSafely(CoroutineScheduler.kt:570) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.executeTask(CoroutineScheduler.kt:750) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.runWorker(CoroutineScheduler.kt:677) at kotlinx.coroutines.scheduling.CoroutineScheduler$Worker.run(CoroutineScheduler.kt:664) Suppressed: kotlinx.coroutines.DiagnosticCoroutineContextException: [androidx.compose.ui.platform.MotionDurationScaleImpl@39a2b44, androidx.compose.runtime.BroadcastFrameClock@c6b542d, StandaloneCoroutine{Cancelling}@526bd62, AndroidUiDispatcher@afeaef3] 2022-11-25 07:57:49.864 1440-28746/? I/Dro

📑 What does this PR do?

• Renamed MastodonApiImpl to MastodonApiKtor and marked internal. Added Koin bean to provide the interface MastodonApi which encapsulates implementation.
• Marked AuthenticationRepositoryImpl as internal. Added Koin bean to provide the interface AuthenticationRepository which encapsulates implementation.
• Created network and repository koin modules
• Created new di module for shared DI as well as entry point for resolving all DI modules cross platform and cross project

✅ Checklist

• [x] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [x] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• What is remaining to be implemented in this PR? Mention a list of them

🖼️ Screenshots (if applicable):

📑 What does this PR do?

• I added the first example of a network call with more end-to-end architecture between different modules. This example is the authentication call done to register the client app, before taking them to OAuth for login.

At a high level here is how the changes look:

• Updated the domain module to not depend on data module. IMO it should be independent and only depend on platform agnostic shared utilities such as kotlin-utils. (Open for discussion!)
• Added new module under data for repository implementations that wrap network and persistence. data now has network , persistence and repositories
• domain module now has interfaces for repositories, and a new use case has been added that works directly with the repository interface.
• data.network has been updated to expose the relevant mastodon API for authenticating an application
• data.repositories has a new class that implements the AuthenticationRepository interface, and calls the API in data.network to perform the authentication request, then takes the response client metadata and will store in cache via a data.persistence source (TODO added in PR here)

I would appreciate any thoughts, questions, feedback on the PR about the dependency graph and architecture set here in addition to whatever else. Thanks :slightly_smiling_face:

✅ Checklist

• [ ] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• What is remaining to be implemented in this PR? Mention a list of them

🖼️ Screenshots (if applicable):

📑 What does this PR do?

The login is done through a Webview. So I set up two implementations of the Webview, one on Android and the second on desktop.

The pr aims to identify a viable solution to use a Webview on a desktop. For this, I used JavaFX without going through the official plugin because it is not currently possible to use it in the module alongside the Android Library plugin.

✅ Checklist

• [ ] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• Find a viable solution to use webview on desktop
• Look at all the places where I put TODO 😬

🖼️ Screenshots (if applicable):

https://user-images.githubusercontent.com/795846/205469581-50d062e3-8a3b-4bb8-aa24-6e6dae125096.mov

📑 What does this PR do?

Add Spacers to start creating our own design language

✅ Checklist

• [x] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

🖼️ Screenshots (if applicable):

Description

We should add iOS targets to our modules (data and domain layers) as early as possible, even without creating the iOS project. This way we will prevent putting jvm specific code to the common source sets.

Additional Information

No response

Description

Since this will be at some point a topic in terms of testing and has some implications - are we going for mocks?

Currently, there 3 Frameworks (I know of):

Mockative -> not sure if this is still active MocKMP KMock -> my baby/you can play with it here

Additional Information

A few words to KMock - I am currently preparing my next iteration of, which will bring, aside from some dependencies updates, some new stuff. But I will need a bit time for that. However, KMock is a bit different to mockk or Mockito if you are used to it, so I recommend trying it upfront. The big plus is no worries about the setup since the KMock's gradle plugin will do it. It is tightly tested so most limitation are known this far.

Description

There are many licenses out there, we should find a license where most of the contributors are happy with.

• should not prohibit the usage of closed source libraries
• should prevent people from making money based on the community contribution

Additional Information

• https://opensource.org/licenses
• https://creativecommons.org/about/cclicenses/

📑 What does this PR do?

Authenticate using an external browser on desktop, creating an interface that works on both desktop and android. Making this a draft pr for now because while I'm happy with the functionally I'm not super happy on how things are organized and would like some input there.

✅ Checklist

• [ ] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• What is remaining to be implemented in this PR? Mention a list of them

🖼️ Screenshots (if applicable):

📑 What does this PR do?

WIP the basic toot creation feature :

1. UI layer (in progress)
2. domain (todo)
3. data (todo)

✅ Checklist

• [ ] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• What is remaining to be implemented in this PR? Mention a list of them

🖼️ Screenshots (if applicable):

Desktop demo

https://user-images.githubusercontent.com/795846/209015060-f33e2c4f-e93d-4ff7-ab29-6200c3301c55.mov

📑 What does this PR do?

As part of https://github.com/AndroidDev-social/DodoForMastodon/issues/107, navigate user to sign in flow once authenticated.

✅ Checklist

• [ ] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [ ] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• Use case to control auth state, exposed via flow

🖼️ Screenshots (if applicable):

📑 What does this PR do?

Adds an image loading library Adds a html parsing library displays the avatar parses content html and displays as annotated string with links in blue

✅ Checklist

• [x] My pull request adheres to the code style of this project
• [ ] My code requires changes to the documentation
• [ ] I have updated the documentation as required
• [x] All the tests have passed

🧪 How can this PR been tested?

🧾 Tasks Remaining: (List of tasks remaining to be implemented)

• What is remaining to be implemented in this PR? Mention a list of them

🖼️ Screenshots (if applicable):

Description

for now, is just add a dummy TopAppBar to the root screen hierarchy when logged in, and add a settings icon that takes you to a new screen with a simple logout button. You'll need to also add logic for clearing/deleting the right user session data which may only be local, not sure yet. Plz feel free to create a GitHub issue with this info if there isn't one already

Additional Information

No response