Hello,

Love using hamkrest! but I have one gripe with it. IntelliJ doesn't show the "show difference" option when an assertion fails. This is quite handy when you're asserting the contents of data classes.

A quick google shows that IntelliJ offers this functionality simply by checking a regular expression. Would it be possible to change the description strings so that IntelliJ shows the "show difference" option when using hamkrest?

Kind regards,

Ewout.

http://hamcrest.org/JavaHamcrest/javadoc/1.3/org/hamcrest/Matchers.html#containsInAnyOrder(T...)

assertThat(listOf("foo", "bar"), containsInAnyOrder("bar", "foo"))

I called the matcher containsAllbut there are couple problems with this name:

• this matcher is based on IsIterableContainingInAnyOrder which means "equal iterables ignoring order of elements". It's not the same as equal Set objects and not the same as Collection.containsAll.
• when used inside apply closure, it clashes with built-in containsAll function (see https://github.com/dkandalov/hamkrest/blob/c421c419294236336db8000bae1325321889208b/src/test/kotlin/com/natpryce/hamkrest/collection_matchers_tests.kt#L166-L166)

I also have doubts that current mismatch description is good. Also passing custom "equality" matcher and nested iterables API looks a bit clunky.

While doing some checks on the same item that requires checking multiple things it occurred to me that this function:

fun <T> assertThat(actual: T, criteria: Matcher<T>) {
    _assertThat(null, actual, criteria)
}

could be more convenient as:

fun <T> assertThat(actual: T, vararg criteria: Matcher<T>) {
    criteria.foreach {_assertThat(null, actual, it) }
}

Hi,

I stumbled across Hamkrest only recently, as I'd been incorrectly assuming that these were the only implementations of Hamcrest matchers. And I also see that Hamkrest has existed now for almost 3 years, which would seem to suggest that there are no plans to move it under the Hamcrest umbrella either.

Can you tell me what Hamkrest's roadmap is please? I can't help but think of the Yammer/CodaHale/DropWizard metrics library here and wonder if the Hamkrest artifacts could ever mutate in such a way.

Thanks, Chris

In IntelliJ, opening the 'External Libraries' view and finding Hamkrest, some of the 'files' are listed with a .class extension (CollectionMatchers.class) and some are not (CaseSensitity). The source for the latter is shown, the former just shows a decompiled version.

It applies Maven and Gradle projects imported into IntelliJ, and certainly hampers my ability to work out how to use the library.

This might be outside of the scope of this assertion library but a kotlin friendly way of declaring multiple assertions in a single test would be nice to add.

I'm opening this issue due to the discussion in the Junit5:

https://github.com/junit-team/junit5/issues/924

Is this outside the scope of this project? If not, this method should probably throw the org.opentest4j.MultipleFailuresError which would require creating a dependency on opentest4j

Trying to do my due diligence and document and credit all libraries I am using including noting the license, but I notice that you haven't actually declared a license in GitHub

Probably because it's a Kotlin function as well. It's just a minor annoyance that I've been having. Does anyone have workarounds or alternatives that I don't know about? Using assertThat instead of assert.that works fine.

What sort of an assertion framework doesn't have support for maps? Once I'd recovered from my shock at this blatant and malicious omission, I knocked something together quickly.

Note the particular horrid cast. Better suggestions very welcome (Denton's only suggestion was 'invoke the Nat').

Cheers 😄

Hi, I'm trying to install by adding to my app's build.gradle:

testCompile 'com.natpryce.hamkrest:1.4.2.0'

but wasn't in your README, and it fails to resolve, and I found that this plugin is missing on plugins.gradle.org. I haven't authored a plugin myself but I believe this just requires publishing to plugins.gradle.org. That would make this library infinitely more useful. Thanks!

Right now there're tons of libs relying on Hamcrest matchers, such as rest-assured, which is also has Kotlin support.

When I saw your library first time I was pretty surprised. It was until I realised that Hamkrest is not compatible with Hamcrest interfaces. That's really disappointing, as all of your syntactic sugar renders useless for me. The only question is why?

Maybe is it possible to make your awesome lib compatible with Hamcrest?

If not, don't you know any alternatives?

It would be nice to have comparison matchers that could be used like this:

@Test
fun comparisonExample() {
    val duration = getDurationFromSomewhare()
    assertThat(duration, isLessThan(Duration.ofSeconds(2)))
}

Hey there 👋, first of all thanks for your work on HamKrest!

I've got a suggested change: would you be willing to use this GitHub Action to automatically keep Gradle Wrapper updated to latest release?

What does "Update Gradle Wrapper Action" do? It can be configured to run at scheduled intervals (e.g. daily or weekly) and will check whether the Wrapper script in the repo is up-to-date to the latest Gradle release: in case a new Gradle version is available, it will create a PR to update the Wrapper. And that's it!

Why is that a good thing? Well, first of all it alleviates the chore of manually updating the Wrapper, as you got a task that keeps track of new Gradle releases for you! More importantly, it boosts security around the Wrapper update and usage processes: this actions verifies that the gradle-wrapper.jar file has not been tampered with (uses checksum comparison), and it sets the distributionSha256Sum property so that the new Gradle binary itself will be verified locally upon download.

Where can I find more about? The README contains quite detailed information!

In this PR I propose adding a new workflow which runs the action every day at midnight (but feel free to adjust the frequency as you prefer). I've verified it works correctly in my fork of the repo: as your Wrapper is already up-to-date in this moment, you can see here that the action detects no changes are needed. However, you can see an example of an automated PR in other projects using the action.

The action is under active development, you can have a look at the list of inputs currently supported. There's new features coming up soon and if you'd like to request any particular change just let me know!

I'd love to see the action used by HamKrest and I genuinely hope you can find this useful. Would love your feedback! ❤️

Is it possible to add hamkrest as test dependency in multiplatform package?

I am trying to do this commonTest { dependencies { implementation kotlin('test-common') implementation kotlin('test-annotations-common') implementation 'com.natpryce:hamkrest:1.7.0.0' } }

but that doesn't work. I can see the lib in Intellij but classes are not accessible in tests

Something that would just make writing test simpler:

/**
 * Matches a collection with a size that is equal to [size].
 */
fun hasSize(size: Int) = has(Collection<Any>::size, equalTo(size))