Hi,

I started making Finnish translation for pretty time but realized that Finnish being awkward language needs different values for name/pluralName depending whether the duration is in the past or future. eg. 1 minute ago = 1 minuutti sitten 1 minute from now = 1 minuutin päästä 3 minutes ago = 3 minuuttia sitten 3 minutes from now = 3 minuutin päästä

As you can (probably ;) see Finnish word minuutti (= minute) conjugation is different for past and future and it also depends if the duration is singular or not. So using just the past and future suffix leads to grammatically incorrect durations.

I could give this a stab my self but was just wondering what would be the best way to tackle this.

java.lang.ExceptionInInitializerError at com.sickboots.sickvideos.b.run(Unknown Source) at java.lang.Thread.run(Thread.java:856) Caused by: java.util.MissingResourceException: Can't find resource for bundle 'org.ocpsoft.prettytime.i18n.Resources_sv_SE', key '' at java.util.ResourceBundle.missingResourceException(ResourceBundle.java:237) at java.util.ResourceBundle.getBundle(ResourceBundle.java:229) at java.util.ResourceBundle.getBundle(ResourceBundle.java:160) at a.b.a.b.b.b(Unknown Source) at a.b.a.b.b.a(Unknown Source) at a.b.a.c.a(Unknown Source) at a.b.a.c.(Unknown Source) at com.sickboots.sickvideos.database.j.(Unknown Source) ... 2 more

I just added prettytime-integration-jstl as dependency to my pom.xml of my webproject. Running mvn tomcat7:run results in this exception:

Aug 09, 2013 2:07:57 AM org.apache.catalina.core.ContainerBase startInternal
SEVERE: A child container failed during start
java.util.concurrent.ExecutionException: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[/example]]
    at java.util.concurrent.FutureTask$Sync.innerGet(FutureTask.java:252)
    at java.util.concurrent.FutureTask.get(FutureTask.java:111)
    at org.apache.catalina.core.ContainerBase.startInternal(ContainerBase.java:1123)
    at org.apache.catalina.core.StandardHost.startInternal(StandardHost.java:800)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1559)
    at org.apache.catalina.core.ContainerBase$StartChild.call(ContainerBase.java:1549)
    at java.util.concurrent.FutureTask$Sync.innerRun(FutureTask.java:334)
    at java.util.concurrent.FutureTask.run(FutureTask.java:166)
    at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1145)
    at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:615)
    at java.lang.Thread.run(Thread.java:724)
Caused by: org.apache.catalina.LifecycleException: Failed to start component [StandardEngine[Tomcat].StandardHost[localhost].StandardContext[/example]]
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:154)
    ... 7 more
Caused by: java.lang.LinkageError: loader constraint violation: loader (instance of org/apache/catalina/loader/WebappClassLoader) previously initiated loading for a different type with name "javax/servlet/ServletContext"
    at java.lang.ClassLoader.defineClass1(Native Method)
    at java.lang.ClassLoader.defineClass(ClassLoader.java:792)
    at java.security.SecureClassLoader.defineClass(SecureClassLoader.java:142)
    at java.net.URLClassLoader.defineClass(URLClassLoader.java:449)
    at java.net.URLClassLoader.access$100(URLClassLoader.java:71)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:361)
    at java.net.URLClassLoader$1.run(URLClassLoader.java:355)
    at java.security.AccessController.doPrivileged(Native Method)
    at java.net.URLClassLoader.findClass(URLClassLoader.java:354)
    at org.apache.catalina.loader.WebappClassLoader.findClass(WebappClassLoader.java:1189)
    at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1680)
    at org.apache.catalina.loader.WebappClassLoader.loadClass(WebappClassLoader.java:1558)
    at org.springframework.web.SpringServletContainerInitializer.onStartup(SpringServletContainerInitializer.java:177)
    at org.apache.catalina.core.StandardContext.startInternal(StandardContext.java:5280)
    at org.apache.catalina.util.LifecycleBase.start(LifecycleBase.java:150)
    ... 7 more

I really don't know what's the problem here, but when commenting out these dependencies I can startup my webapp without any problems. My webapp is configured using JavaConfig and uses Spring. If some more information is necessary just tell me.

week, month too and maybe other result += ">>>"+durationQuantity; // I try return anything but always return only "тиж" need "тиждень" in tests all work fine, good. in real application decorate not work.

            PrettyTime prettyTime = new PrettyTime(history.getDate());
            prettyTime.setLocale(new Locale("ua"));
            prettyTime.format(prettyTime.calculatePreciseDuration(new Date()))

if (t instanceof Week) {
            return new TimeFormat() {
                @Override
                public String decorate(Duration duration, String time) {
                    String result = duration.isInFuture() ? "через " : "";
                    long durationQuantity = Math.abs(duration.getQuantity());
                    if (durationQuantity == 1L) {
                        result += time + "день";
                    } else {
                        result += time + "ні";
                    }
                    result += ">>>"+durationQuantity;
                    if (duration.isInPast()) {
                        result += " тому";
                    }
                    return result;
                }

                @Override
                public String decorateUnrounded(Duration duration, String time) {
                    String result = duration.isInFuture() ? "через " : "";
                    long durationQuantity = Math.abs(duration.getQuantity());
                    if (durationQuantity == 1L) {
                        result += time + "день";
                    } else {
                        result += time + "ні";
                    }
                    if (duration.isInPast()) {
                        result += " тому";
                    }
                    result += ">>>"+durationQuantity;
                    return result;
                }

                @Override
                public String format(Duration duration) {
                    return Math.abs(duration.getQuantity()) + " тиж";
                }

                @Override
                public String formatUnrounded(Duration duration) {
                    return Math.abs(duration.getQuantity()) + " тиж";
                }
            };
        }

Please consider applying this upgrade. Currently rounding is forced, so in fact there is no way to display precise time. One can calculate list of Durations, but then if we have for example (3 hours, 45 minutes, 55 seconds) to display, after formatting each Duration separately we end up with: (4 hours, 46 minutes, 55 seconds). This patch introduces optional rounding and optional decorating (but old interface remains intact with previous defaults) and handy interface to do so. Calling PrettyTime.format(List) can give results like: ''3 days 22 hours 34 minutes from now".

When using the formatDuration(Date) method in Locale.GERMAN the translations are not accurate.

Problem

• Days: 5 Tagen should be 5 Tage
• Months: 5 Monaten should be 5 Monate
• Years: 5 Jahren should be 5 Jahre
• Decade: 5 Jahrzenten should be 5 Jahrzente
• Century: 5 Jahrhunderten should be 5 Jahrhunderte
• Millenium: 5 Jahrtausenden should be 5 Jahrtausende

However These words are correct for the format(Date) method. Example:

• vor 5 Tagen
• vor 5 Monaten
• etc.

Explanation

Nouns do have a case (Kasus) when used in a sentence in german (and some other languages?). (see https://en.wikipedia.org/wiki/Grammatical_case)

This means that words would need to be translated for the different grammatical cases.

Instead of just this translation:

{ "SecondPluralName", "Sekunden" }

You'd need to have these:

{ "SecondPluralNameNominative", "Tage" }
{ "SecondPluralNameDative", "Tagen" }

Which would be very annoying.

Possible Solution

You should translate whole sentences and parameterize them instead of trying to translate single words and then later sticking them together, because that will result in errors like these in the long term.

Highly relevant video: https://www.youtube.com/watch?v=GAgp7nXdkLU

It looks like by default, all durations below 5 minutes are labelled "moments ago".

Is there a simple way to control this tolerance? Is it rounding?

I would like to show:

• minutes ago
• seconds ago

Milliseconds ago are fine to show as "moments ago".

On the website, it even says: Convert elapsed timestamps, like, "in 3 minutes!"

Repost from forums: http://ocpsoft.org/support/topic/5-minutes-is-default-minimum-duration

Make use of features added in Java 8, and add methods that accept the java.time date/time types.

This fixes https://github.com/ocpsoft/prettytime/issues/109.

Also, i suggest incorporating well-tested gettext I10n expressions for determining plural form of specific language word:

http://translate.sourceforge.net/wiki/l10n/pluralforms

I used PrettyTime in a personal project and @fbiville realized there was a typo in French... So I quickly went to GitHub to make a pull request before he could do so :) .

In French, DecadeName is written décennie, not décénie.

Very nice project by the way!

I added the dependency to my app build gradle. I see org.ocpsoft.prettytime imported in my external library, and packages such as Duration, LocaleAware, but not the nlp package. I'm using Android Studio 3.5.0. Did I miss anything?

Hello. I'm doing a tutorial of Java Brains and he use your team dependency at 30:38 , here is the link: https://youtu.be/tfmFRrPz52s

but things is going wrong when I import your dependency and get some error, I think that it is from your side. Here is the log and I'm using IntelliJ idea, maven project. "Could not find artifact org.ocpsoft.prettytime:prettytime-integration-jsf:pom:unknown in central (https://repo.maven.apache.org/maven2) " This is when I add version to the dependency, seems nothing downloaded Because then I can not use PrettyTime object in my code

The PrettyTime codebase could be refactored to make use of the ChronoUnit enum and Duration and Period classes, instead of defining the current implementations manually.

This commit introduces the maven spotless plugin to the project that can format the source code using "mvn spotless:apply" based on the configuration in the parent pom.xml. Also it will perform a spotless:check during the verify phase to ensure that all files are properly formatted.

When trying to contribute to this project, I was very surprised to see that a lot of unit tests are failing.

After digging into the code I realized that this results most probably from using current dates in the tests. However, this is a problem because a year in reality has a different amount of millis depending on the current date, but a year in prettytime has always 31556925960 millis (about 365,242 days). So current date minus 1 year will format as "one year ago" in a leap year (i.e. the duration contains the leap day), but as "12 months ago" in all other years.

To fix this all tests should be based on defined dates, so they will produces the same results no matter when the tests are executed.

See the adjusted test in https://github.com/ocpsoft/prettytime/pull/229 as an example

When I try to format duration of 60 seconds or less it gives me empty string regardless of locale.

        val seconds = 30L
        val locale = Locale("en", "US")
        val t = PrettyTime(Date(1000 * seconds), locale)
            .calculatePreciseDuration(Date(0))
        val result = PrettyTime(locale).formatDurationUnrounded(t)

        assertThat(result).isEqualTo("30 seconds")