stopVideoRecording() always returns false, with no error

  private var tmpVideoFile: File? = null

  @SuppressLint("SimpleDateFormat")
  @Throws(IOException::class)
  private fun getNewVideoFile(): File {
    // Create an image file name
    val timeStamp: String = SimpleDateFormat("yyyyMMdd_HHmmss").format(Date())
    val directory = "${Environment.getExternalStorageDirectory().absolutePath}/filmit/videos".also { File(it).mkdirs() }
    return File(directory, "$timeStamp.mp4")
  }

  @SuppressLint("MissingPermission")
  private fun listenToVideoRecordEvent() {
    publisherDisposable = videoRecordEventPublisher.subscribe {
      if (it) {
        recordVideoFrame.visibility = View.VISIBLE
        tmpVideoFile = getNewVideoFile()
        recordVideoCamera.startVideoRecording(tmpVideoFile!!) {
          // Configure video (MediaRecorder) parameters
          audioEncoder = AudioEncoder.Aac
          videoFrameRate = 60
          videoStabilization = true
          videoEncoder = VideoEncoder.H263
        }
      } else {
        if(recordVideoCamera.stopVideoRecording()) {
          uploadTmpVideo()
        } else {
          Log.e(TAG, "failed to save video to file")
          Log.d(TAG, tmpVideoFile.toString())
        }
        recordVideoFrame.visibility = View.GONE
      }
    }

  }

Describe the bug I have get much crash with Error opening camera with id 0

Using ProGuard YES

Screenshots If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

• Device: [Huawei Honor V20]
• OS: [Android 9.0]

Additional context / stacktrace Fatal Exception: com.priyankvasa.android.cameraviewex.CameraViewException: Error opening camera with id 0 (error: 4) at com.priyankvasa.android.cameraviewex.Camera2$cameraDeviceCallback$2$1.onError(Camera2.java:62) at android.hardware.camera2.impl.CameraDeviceImpl$CameraDeviceCallbacks.notifyError(CameraDeviceImpl.java:1922) at android.hardware.camera2.impl.CameraDeviceImpl$CameraDeviceCallbacks.lambda$Sm85frAzwGZVMAK-NE_gwckYXVQ(CameraDeviceImpl.java) at android.hardware.camera2.impl.-$$Lambda$CameraDeviceImpl$CameraDeviceCallbacks$Sm85frAzwGZVMAK-NE_gwckYXVQ.accept(-.java:8) at com.android.internal.util.function.pooled.PooledLambdaImpl.doInvoke(PooledLambdaImpl.java:258) at com.android.internal.util.function.pooled.PooledLambdaImpl.invoke(PooledLambdaImpl.java:182) at com.android.internal.util.function.pooled.OmniFunction.run(OmniFunction.java:77) at android.os.Handler.handleCallback(Handler.java:907) at android.os.Handler.dispatchMessage(Handler.java:105) at android.os.Looper.loop(Looper.java:216) at android.os.HandlerThread.run(HandlerThread.java:65)

Hi. In Android camera 2 API there is implementation levels, I couldn't find any way, for checking implementation level. So how I can get implementation level?

Link to documentation https://developer.android.com/reference/android/hardware/camera2/CameraCharacteristics.html#INFO_SUPPORTED_HARDWARE_LEVEL

Good day sir. I am a graphic designer and i am interested in designing a logo for your good project. I will be doing it as a gift for free. I just need your permission first before I begin my design. Hoping for your positive feedback. Thanks

Describe the bug The latest batch of changes merged into developed has introduced an issue. If you launch your CameraActivity from another activity, then leave the camera, go back and forth a few times eventually it all locks up.

I have provided a simple activity that I used to reproduce the issue off of the development branch. When I switch to my fork that does not have your latest changes I am able to open the camera as many times as I want without issue. To Reproduce Pull request that demonstrates the issue: https://github.com/pvasa/cameraview-ex/pull/118

1. Have an activity that you launch the camera from
2. Go back out of the camera
3. Go in and out of the camera a few times and it will fail

Expected behavior Before the latest batch of changes the issue did not occur.

Using ProGuard

• [ ] with ProGuard
• [X ] without ProGuard

Device (please complete the following information):

• Device: LG G6
• OS: 8.0
• App version [2.7.0]

Can you point me in the right direction on how to set the aspect ratio for capturing an image with Camera2? The equivalent of setPictureSize on Camera1. I would like to do something similar to what we did with videos and allow taking photos in 4:3 or 16:9. Currently with a full screen preview the captured image is 4:3.

Currently the library will choose the highest video size in the current aspect ratio and based on the preview width/height. We should be able to specify exactly which size we want to record in. For example preview could be any size or shape but record in 1080p or 720p.

Added:

• Get the supported video sizes for the current camera
• Set the video size using VideoConfiguration

Describe the bug Capture doesn't work after stopping and restarting the camera in release 2.7.0. An error is not generated and the picture taken listener is not invoked. This showed up in this latest release (2.7.0), it doesn't seem to occur on 2.6.1.

To Reproduce Steps to reproduce the behavior:

1. Start camera using start
2. Stop camera using stop(false)
3. Start camera again using start
4. Call capture and the dimming UI animation occurs but addPictureTakenListener or addCameraErrorListener are never called

Expected behavior Calling capture should call either the error listener or the picture taken listener.

Using ProGuard

• [x] with ProGuard
• [ ] without ProGuard

Device (please complete the following information):

• Device: S8+
• OS: 8.0.0
• API: 27
• App version 0.1

Branch Name (if using as a local module)

• [ ] master
• [ ] development
• [x] release
• [ ] other (please specify)

Currently in order to record a landscape video you have to leave the orientation unlocked. This results in a jarring experience when the device changes from portrait to landscape. A better approach would be to allow the device to be fixed to portrait or userPortrait. When the recording or picture is taken it would be taken in the correct orientation based on the device orientation.

Setting the activity to android:screenOrientation="userPortrait" locks the orientation but videos and images are taken in portrait even when rotated to landscape.

For Camera1 you would use camera.setDisplayOrientation, which is already being done in Camera1.kt. For Camera2 I though it was supposed to just work by default since there is no setDisplayOrientation. However, it is not working.

I will start looking into how this is supposed to work and see if I can come up with a fix. If you have any tips they would be welcomed.

Hello, Finally i set like this:

cameraView.setCameraMode(Modes.CameraMode.VIDEO_CAPTURE); cameraView.enableCameraMode(Modes.CameraMode.VIDEO_CAPTURE);

String root = Environment.getExternalStorageDirectory().toString(); File myDir = new File(root + "/cubeTok"); myDir.mkdirs();

String timeStamp = new SimpleDateFormat("yyyyMMdd_HHmmss").format(new Date()); String fname = "cubeTok_" + timeStamp + ".mp4";

File file = new File(myDir, fname); cameraView.startVideoRecording(file);

But it's give an Exception: "com.priyankvasa.android.cameraviewex.CameraViewException: Unable to start video recording.

Is there anything lake to put? Please me to solve this.

Thanks.

I have closed the other PR and remade the changes from the latest development branch. I also refactored and made the changes simpler for the user. Almost all new phones come with more than 2 cameras now and in some cases 4 or 5 cameras.

CameraView: start() -> User can still call this to start the camera, getting the default rear facing

start(cameraId) -> New feature to allow starting right to a camera, for example remembering that the user was on the back camera.

nextCamera() -> New feature that will cycle through all of the devices cameras, in the order that the device presents them. Example: 0 (rear), 1 (front), 2 (rear) for a LG G5 or LG G6.

Hi, I am getting following exception while start camera. and my goal is to capture video and continues frames.

Please help me to solve this issue.

com.priyankvasa.android.cameraviewex.CameraViewException: Unable to start video recording. java.lang.ArithmeticException: divide by zero Unable to start video recording.

My code is --

<com.priyankvasa.android.cameraviewex.CameraView
    android:id="@+id/camera"
    android:layout_width="match_parent"
    android:layout_height="match_parent"
    android:adjustViewBounds="true"
    android:keepScreenOn="true"
    app:aspectRatio="4:3"
    app:autoFocus="continuous_video"
    app:awb="auto"
    app:cameraMode="continuous_frame|video_capture"
    app:continuousFrameSize="W1440,1080"
    app:facing="back"
    app:flash="off"
    app:jpegQuality="high"
    app:noiseReduction="high_quality"
    app:opticalStabilization="true"
    app:outputFormat="jpeg"
    app:pinchToZoom="false"
    app:shutter="short_time"
    app:singleCaptureSize="1920,H1080"
    app:touchToFocus="false"
    app:zsl="true" />

override fun onViewCreated(view: View, savedInstanceState: Bundle?) { super.onViewCreated(view, savedInstanceState)

    // Callbacks on UI thread
    _binding?.camera?.addCameraOpenedListener { /* Camera opened. */ }
        ?.addCameraErrorListener { t: Throwable, errorLevel: ErrorLevel -> /* Camera error! */
            Log.d("AAAAAA  ", "addCameraErrorListener")
        }
        ?.addCameraClosedListener { /* Camera closed. */
            Log.d("AAAAAA  ", "addCameraClosedListener")
        }

}

override fun onResume() {
    super.onResume()
    if (ActivityCompat.checkSelfPermission(
            requireContext(),
            Manifest.permission.CAMERA
        ) != PackageManager.PERMISSION_GRANTED
    ) {
        // TODO: Consider calling
        //    ActivityCompat#requestPermissions
        // here to request the missing permissions, and then overriding
        //   public void onRequestPermissionsResult(int requestCode, String[] permissions,
        //                                          int[] grantResults)
        // to handle the case where the user grants the permission. See the documentation
        // for ActivityCompat#requestPermissions for more details.
        return
    }
    _binding?.camera?.start(Modes.DEFAULT_CAMERA_ID)

// _binding?.camera?.setCameraMode(Modes.CameraMode.SINGLE_CAPTURE or Modes.CameraMode.CONTINUOUS_FRAME or Modes.CameraMode.VIDEO_CAPTURE) // _binding?.camera?.setCameraMode(Modes.CameraMode.VIDEO_CAPTURE)

// OR keep other modes as is and enable video capture mode // _binding?.camera?.enableCameraMode(Modes.CameraMode.VIDEO_CAPTURE)

// Callback on UI thread _binding?.camera?.addVideoRecordStartedListener { /* Video recording started */ Log.d("AAAAAA ", "Video recording started") }

// Callback on UI thread _binding?.camera?.addVideoRecordStoppedListener { isSuccess -> // Video recording stopped Log.d("AAAAAA ", "Video recording stopped") // isSuccess is true if video was recorded and saved successfully }

    _binding?.camera?.setContinuousFrameListener {
        Log.d("AAAAAA  ", "Continuous Frame Listener")
        showFramePreview(it)
    }

    val direct = File(Environment.getExternalStorageDirectory().toString() + "/capture_video")
    if (!direct.exists()) {
        val wallpaperDirectory = File("/sdcard/capture_video/")
        wallpaperDirectory.mkdirs()
    }
    val file = File("/sdcard/capture_video/", "video_" + System.currentTimeMillis() + ".mp4")
    if (file.exists()) {
        file.delete()
    }

    _binding?.camera?.startVideoRecording(file) {
        // Configure video (MediaRecorder) parameters
        audioEncoder = AudioEncoder.Aac
        videoFrameRate = 30
        videoStabilization = true
    }
}

I have oneplus nord ce2 device with android 11 version

I have tried to implement this library but when I start app it is showing only white screen

• Device: Oneplus nord ce2
• OS: Android 11

Also I have tried with emulator with android 12

In emulator I'm getting this error while capturing image

2022-03-24 16:19:36.598 10182-10374/com.pathquestap E/CameraCaptureSession: Session 0: Exception while stopping repeating: android.hardware.camera2.CameraAccessException: CAMERA_ERROR (3): The camera device has encountered a serious error at android.hardware.camera2.impl.CameraDeviceImpl.checkIfCameraClosedOrInError(CameraDeviceImpl.java:2350) at android.hardware.camera2.impl.CameraDeviceImpl.stopRepeating(CameraDeviceImpl.java:1277) at android.hardware.camera2.impl.CameraCaptureSessionImpl.close(CameraCaptureSessionImpl.java:579) at android.hardware.camera2.impl.CameraCaptureSessionImpl$2.onDisconnected(CameraCaptureSessionImpl.java:790) at android.hardware.camera2.impl.CameraDeviceImpl$7.run(CameraDeviceImpl.java:259) at android.os.Handler.handleCallback(Handler.java:938) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.os.HandlerThread.run(HandlerThread.java:67)

Want to raise 2 points:

First is that the callbacks of the library are using kotlin and prefer lambda expressions. The code is not designed to work well with java 7. For example: camera.addCameraOpenedListener() Please mention this in prerequisite to use this library, or provide support/guide for using it along with Java 7.

Second, After adding library dependency, got error during build: More than one file was found with OS independent path 'META-INF/atomicfu.kotlin_module'

Expected behavior Build should work without causing conflicts.

Using ProGuard

• without ProGuard

Device (please complete the following information):

• Device: NA
• OS: NA
• API: 29
• App version 3.5.5-alpha minSdkVersion 21 targetSdkVersion 29 compileSdkVersion 29 gradle 3.5.3 using Java 7

To fix this, had to add following in app level gradle:

packagingOptions {
        pickFirst  'META-INF/*'
}

Any reason why this is happening?

My dependencies:

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation 'androidx.appcompat:appcompat:1.1.0'
    implementation 'androidx.constraintlayout:constraintlayout:1.1.3'
    // request permission
    implementation 'com.karumi:dexter:6.0.1'

    // CameraViewEx
    // https://github.com/pvasa/cameraview-ex?utm_source=android-arsenal.com&utm_medium=referral&utm_campaign=7320
    implementation "com.priyankvasa.android:cameraview-ex:3.5.5-alpha"

    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'androidx.test.ext:junit:1.1.1'
    androidTestImplementation 'androidx.test.espresso:espresso-core:3.2.0'
}

The camera just freezes when shooting with FLASH_ON and after a small moment this error comes out 2019-09-26 03:38:21.827 17385-17385/com.waynyo.debug E/CameraFragment$onCreateView: com.priyankvasa.android.cameraviewex.CameraViewException: Error opening camera with id 0 (error: 4) at com.priyankvasa.android.cameraviewex.Camera2$cameraDeviceCallback$2$1.onError(Camera2.kt:145) at android.hardware.camera2.impl.CameraDeviceImpl$CameraDeviceCallbacks.notifyError(CameraDeviceImpl.java:1929) at android.hardware.camera2.impl.CameraDeviceImpl$CameraDeviceCallbacks.lambda$Sm85frAzwGZVMAK-NE_gwckYXVQ(Unknown Source:0) at android.hardware.camera2.impl.-$$Lambda$CameraDeviceImpl$CameraDeviceCallbacks$Sm85frAzwGZVMAK-NE_gwckYXVQ.accept(Unknown Source:8) at com.android.internal.util.function.pooled.PooledLambdaImpl.doInvoke(PooledLambdaImpl.java:258) at com.android.internal.util.function.pooled.PooledLambdaImpl.invoke(PooledLambdaImpl.java:182) at com.android.internal.util.function.pooled.OmniFunction.run(OmniFunction.java:77) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:214) at android.os.HandlerThread.run(HandlerThread.java:65)

Steps to reproduce the behavior:

1. set FLASH_ON 2.Shoot with the camera

Expected behavior Give the image correctly with no freezes

Using ProGuard

• [x] without ProGuard

Screenshots If applicable, add screenshots to help explain your problem.

Device (please complete the following information):

• Device: Galaxy Note 9
• OS: Android 9
• API: 28

Describe the bug 9/12/19 Update: I was totally incorrect about what was going on. The ZTE Cymbal T runs android 5 but when it tries to use Camera2 it is falling back to Camera1. This issue here is with Camera1 and not Camera2. I have also validated that the Camera2 functionality works perfectly on a Nexus 6, only when using Camera1 is it upside down. Because of this I consider it a much lower of a priority.

Some devices have cameras installed in the device in non-standard orientations, usually with the front camera (selfie). Examples are some of the Nexus 5/6 devices and a test device I have, ZTE Cymbal T. The issue here is only with Camera1 and only with the preview. The recorded video is in the correct orientation.

I did some tests forcing the camera into Camera1 and then tested the fix on the broken device and on a device that did not have the problem.

Steps performed:

1. Holding phone portrait, back camera:
2. Holding phone portrait, switch to selfie camera:
3. Rotate phone to landscape, switch to back camera
4. Holding phone in landscape: switch to selfie camera:

With my changes in place : https://github.com/pvasa/cameraview-ex/pull/209

ZTE Cymbal T: Camera locked in portrait

1. deviceRotation=0, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=90
2. deviceRotation=0, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=270
3. deviceRotation=90, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=90
4. deviceRotation=90, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=270

Xaiomi: Camera locked in portrait

1. rotationDegrees=0, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=90
2. rotationDegrees=0, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=90
3. rotationDegrees=90, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=90
4. rotationDegrees=90, WindowManager.rotation=0, getCameraDegrees()=0, displayOrientation=90

Try it out on a few devices forcing the camera to use Camera1 and see if it also works correctly for you.

Device (please complete the following information):

• Device: ZTE Cymbal T
• OS: Android 5.1