Some tasks left, but i think we are already on a good way

• [x] Syntax Highlighting (needs another lib i think)
• [x] Different Header levels do not work properly yet in edit mode
• [x] Fix coloring on search
• [ ] Check if we can prevent selection of tasks when toggling checkboxes
• [x] Check if a checkbox can be toggled when clicking on the checkbox directly (not the text)
• [x] Check external links, especially fix or remove links in checkboxes (affects maybe only edit mode?)
• [x] Make sure that internal links work
• [x] Styling (should be as close as possible to the webapp)
  • [x] Codeblocks should always use monospace font
  • [x] Closing fence of cosing blocks are different from opening blocks
• [x] Extract plugins where possible to make them reusable
• [x] Centralize the configurations
  • [x] Respect monospace font setting
  • [x] Respect font size setting
• [x] Use Markwon on all places where previously RxMarkdown has been used (e. g. widgets)

Hey @stefan-niedermann, cool app.

Would be awesome if you could enhance this app with a widget. Then I would start using it as my new standard app for Notes. :)

Hi,

I just installed the app from F-Droid on my Andoid phone (Cyanogen 13.0, Android 6.0.1) and my tablet (Cyanogen 12.1, Android 5.1.1).

On both devices, I can't connect to my ownCloud instance (I get an error message about a "failed login"). I tried with other accounts on the same server, in both http and https, same issue. Unfortunately I can't test on an other ownCloud instance for now.

I installed the Notes app from the official Github repo (ownCloud 9.1.0, Notes 2.0.2).

Tell me if you need whatever information or log message.

Thanks :)

Proof of concept

Noticed problem: With enabled password protection, SingleNoteWidgets can no longer be opened. ~~Opening a note from the NotesListWidget works flawlessly.~~ Can you maybe have a look at this special case @dan0xii? The widgets are still a mystery for me with all the PendingIntent magic 😅😅

see https://github.com/stefan-niedermann/nextcloud-notes/pull/180#issuecomment-285417285:

Currently the transifex push fails, because the nextcloud-bot get rejected with "protected branch hook declined".

Android 6.0.1 Nextcloud Notes 2.2.0 Nextcloud app 3.9.2

Nextcloud Notes continuously crashes, this has started happening with new Nextcloud app update.

This is the error:

[01-01 18:46:55.819 31167:31190 E/AndroidRuntime]
FATAL EXCEPTION: AsyncTask #2
Process: it.niedermann.owncloud.notes, PID: 31167
Theme: themes:{default=, fontPkg:org.mmk2410.cyngn.theme.fira}
java.lang.RuntimeException: An error occurred while executing doInBackground()
	at android.os.AsyncTask$3.done(AsyncTask.java:309)
	at java.util.concurrent.FutureTask.finishCompletion(FutureTask.java:354)
	at java.util.concurrent.FutureTask.setException(FutureTask.java:223)
	at java.util.concurrent.FutureTask.run(FutureTask.java:242)
	at android.os.AsyncTask$SerialExecutor$1.run(AsyncTask.java:234)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1113)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:588)
	at java.lang.Thread.run(Thread.java:818)
Caused by: java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.length()' on a null object reference
	at org.json.JSONTokener.nextCleanInternal(JSONTokener.java:116)
	at org.json.JSONTokener.nextValue(JSONTokener.java:94)
	at org.json.JSONArray.<init>(JSONArray.java:92)
	at org.json.JSONArray.<init>(JSONArray.java:108)
	at it.niedermann.owncloud.notes.util.ServerResponse$NotesResponse.getNotes(ServerResponse.java:37)
	at it.niedermann.owncloud.notes.persistence.NoteServerSyncHelper$SyncTask.pullRemoteChanges(NoteServerSyncHelper.java:351)
	at it.niedermann.owncloud.notes.persistence.NoteServerSyncHelper$SyncTask.doInBackground(NoteServerSyncHelper.java:277)
	at it.niedermann.owncloud.notes.persistence.NoteServerSyncHelper$SyncTask.doInBackground(NoteServerSyncHelper.java:248)
	at android.os.AsyncTask$2.call(AsyncTask.java:295)
	at java.util.concurrent.FutureTask.run(FutureTask.java:237)
	... 4 more

I have configured two accounts in the Notes app:

1. my account on Disroot.org
2. an account on my local Nextcloud server (located on my internal network)

I've noticed that for the second account (on my local server) there is no profile picture shown although it is configured in the Nextcloud account settings. It only shows the generic profile icon. I've tried with different pictures but none was displayed as profile picture.

My config is: Server Fedora 31 (latest updates) Nextcloud 17.0.2 Nextcloud client 2.4.0

In order to decrease the likelihood to delete a note accidentally, a short vibration warns the user when she/he begins to move a note in the note list.

Every now and then, snchronization stops working. If I manually initiate a sync, I get the message:

"synchronization failed: no network connection"

This is statement is not true, since the notes app is the only one of this opinion on my phone (including other apps that use the same nc instance). When force closing and reopening the APP, everything works fine.

catlog.txt

Open issues

Caching (ETag, Modified)

• [x] Move e tag and last modified into account-table in database
• [x] Clean up old e tag and last modified SharedPreferences in database upgrade process
• [x] :construction: Something is wrong with the modified date - all my notes appear as last modified 1970.

Migration

• [x] In database upgrade process create first account entry in account-table with the existing entry from the SharedPreferences (also copy etag and last modified from SharedPreferences to first account entry)
• [x] Remove the now no longer needed SharedPreferences for the account settings
• [x] Make sure that this not yet authenticated account asks smoothly the SSO for permission on first sync
  • [x] Android 9
  • [ ] :construction: Android 8 (to be tested)
  • [x] Android 7
  • [ ] :construction: Android 6 (to be tested)
  • [ ] :construction: Android 5 (to be tested)
  • [x] Android 4
• [x] Indexes for the table_accounts
• [x] Foreign key from account_id in table_notes to id in table_accounts does not work yet
• [x] Remove TrustPreference from PreferencesFragment

Widgets

• [x] @dan0xii the widgets do currently not store the account id from the note. They will have to, otherwise will switching account break the widgets.
• [x] Widgets do not switch the active account in the app
• [x] Note list widget appears to only show one account regardless of which is active in the main app
• [x] Single note widget says "Note not found" after upgrade

Dark theme

• [x] The font in the header and the new accounts list in the drawer look ugly and wrong with the dark theme.

Follow-Up issues

• [ ] Move widget configurations from SharedPreferences to database

Old name: Could not connect to server if strong ciphers being used.

Hallo, Since i enable http2 and strong ciphers on my Apache2 I could not connect anymore to my server with this app. Error message is:

    javax.net.ssl.SSLHandshakeException:Handshake Failed

Setup is as here: https://gist.github.com/GAS85/42a5469b32659a0aecc60fa2d4990308

Update: SSL config

   SSLCipherSUite "ECDHE-ECDSA-AES256-GCM-SHA384:ECDHE-RSA-AES256-GCM-SHA384:ECDHE-ECDSA-CHACHA20-POLY1305:ECDHE-RSA-CHACHA20-POLY1305:ECDHE-ECDSA-AES128-GCM-SHA256:ECDHE-RSA-AES128-GCM-SHA256:ECDHE-ECDSA-AES256-SHA384:ECDHE-RSA-AES256-SHA384" 

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Is your feature request related to a problem? Please describe. If you have long check lists it gets annoying to have lots of checked items and you need to scroll up and down to get to the unchecked items.

Describe the solution you'd like

A new view / variant of read view which hides checked items would be great. A configurable time (default 10s ?) before they actually disappear would be great to be able to correct misclicking.

Describe alternatives you've considered Maybe this would be a sufficient solution for #1521

Background

I've been using Notes for some work I'm often sharing with other people that don't necessarily care for Nextcloud and Markdown. I also tend to work on my Android tablet, which limits what I can do with files, including using something like pandoc to easly convert Markdown to .odf, .docx or PDF. To this end, I would like to have an easy ability to print a note, either using a native print to PDF 'printer' or just directly to a network connected printer via Android's API.

I am willing to put a bounty on this feature or pledge support if this feature is implemented. There is an app that does this in an unsatisfactory capacity (and is another app) that wants $15 for a yearly subscription, so I'd rather send it this project's way.

Scope

A minimum scope for this feature would be just direct printing of the Markdown file without rendering. Android API Guide - Printing.

Nice to haves:

• Rendering Markdown before printing (or priting rendered from View mode)
• Ability to print a portion of the file (i.e. by pre-selecting)
• Ability to set page breaks (something Markdown implementations generally lack, so likely out of scope)
• Ability to set headers and footers for printing (title, page numbers)

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug

My notes do not appear. Neither of my two accounts appear either. Nextcloud app is installed and working fine, and has two Nextcloud accounts in the app linked using DavX.

I would just uninstall and reinstall, however I have a handful of notes that have yet to sync, and I don't want to lose these. If I could access the sqlite db, I would grab them then reinstall.

Error message when opening the App:

App Version: 3.6.0
App Version Code: 3006000
App Flavor: play

Files App Version Code: 30220390

---

OS Version: 4.9.193-perf(8450100201101)
OS API Level: 29
Device: judyln
Manufacturer: LGE
Model (and Product): LM-G710 (judyln_lao_com)

---

com.nextcloud.android.sso.exceptions.NoCurrentAccountSelectedException: No account selected yet
	at com.nextcloud.android.sso.helper.SingleAccountHelper.getCurrentAccountName(SingleAccountHelper.java:47)
	at com.nextcloud.android.sso.helper.SingleAccountHelper.getCurrentSingleSignOnAccount(SingleAccountHelper.java:54)
	at it.niedermann.owncloud.notes.main.MainActivity.lambda$onCreate$7$it-niedermann-owncloud-notes-main-MainActivity(MainActivity.java:174)
	at it.niedermann.owncloud.notes.main.MainActivity$$ExternalSyntheticLambda24.run(Unknown Source:2)
	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
	at java.lang.Thread.run(Thread.java:919)

To Reproduce Steps to reproduce the behavior:

1. Open the application
2. Error message appears immediately. If I click on Close, it shows a circle animation and continues to spin non stop.

No account is selected or available. Clicking on the 3 line menu shows an empty menu.

Expected behavior

It used to open up and show all of my notes.

Screenshots

Smartphone (please complete the following information):

• Nextcloud Notes-Version (android app): App Version: 3.6.0 App Version Code: 3006000 App Flavor: play

Files App Version Code: 30220390

• Android-Version: OS Version: 4.9.193-perf(8450100201101) OS API Level: 29

• Device: Device: judyln Manufacturer: LGE Model (and Product): LM-G710 (judyln_lao_com)

Server

• Nextcloud version: 23.0.5
• Nextcloud Notes version (server app): 4.5.1

Stacktrace

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug When you initially start your phone, the widget says "Note not found" instead of something like "Loading note …".

To Reproduce Steps to reproduce the behavior:

1. Restart your phone
2. Check the widget text

Expected behavior The text says "Loading note …" until we can certainly either show it, or really know that it has not been found.

Smartphone (please complete the following information):

• Nextcloud Notes-Version (android app): 3.7.0
• F-Droid or Play Store: F-Droid
• Android-Version: 10 (Lineage)
• Device: Fairphone 2

Hi,

out of the sudden I can't sync my Android App with my server anymore.

This is the log:

App Version: 3.6.0
App Version Code: 3006000
App Flavor: play

Files App Version Code: 30230051

---

OS Version: 4.9.186-perf+(052001A003004902006556692)
OS API Level: 29
Device: H8324
Manufacturer: Sony
Model (and Product): H8324 (H8324)

---

java.lang.Exception: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was BEGIN_ARRAY at line 1 column 2 path $
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:145)
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:94)
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
 at java.lang.Thread.run(Thread.java:919)


java.lang.Exception: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was BEGIN_ARRAY at line 1 column 2 path $
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:145)
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:94)
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
 at java.lang.Thread.run(Thread.java:919)


java.lang.Exception: com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was BEGIN_ARRAY at line 1 column 2 path $
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pushLocalChanges(NotesServerSyncTask.java:158)
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:94)
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
 at java.lang.Thread.run(Thread.java:919)


com.google.gson.JsonSyntaxException: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was NUMBER at line 1 column 5 path $[0]
 at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:270)
 at com.google.gson.internal.bind.TypeAdapterRuntimeTypeWrapper.read(TypeAdapterRuntimeTypeWrapper.java:41)
 at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:82)
 at com.google.gson.internal.bind.CollectionTypeAdapterFactory$Adapter.read(CollectionTypeAdapterFactory.java:61)
 at com.google.gson.Gson.fromJson(Gson.java:1058)
 at com.google.gson.Gson.fromJson(Gson.java:1016)
 at com.nextcloud.android.sso.api.NextcloudAPI.convertStreamToTargetEntity(NextcloudAPI.java:159)
 at com.nextcloud.android.sso.api.NextcloudAPI.lambda$performRequestObservableV2$1$com-nextcloud-android-sso-api-NextcloudAPI(NextcloudAPI.java:130)
 at com.nextcloud.android.sso.api.NextcloudAPI$$ExternalSyntheticLambda2.subscribe(Unknown Source:6)
 at io.reactivex.internal.operators.observable.ObservableFromPublisher.subscribeActual(ObservableFromPublisher.java:31)
 at io.reactivex.Observable.subscribe(Observable.java:12284)
 at io.reactivex.internal.operators.observable.ObservableSingleMaybe.subscribeActual(ObservableSingleMaybe.java:31)
 at io.reactivex.Maybe.subscribe(Maybe.java:4290)
 at io.reactivex.Maybe.blockingGet(Maybe.java:2320)
 at io.reactivex.Observable.blockingSingle(Observable.java:5381)
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.pullRemoteChanges(NotesServerSyncTask.java:219)
 at it.niedermann.owncloud.notes.persistence.NotesServerSyncTask.run(NotesServerSyncTask.java:96)
 at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:462)
 at java.util.concurrent.FutureTask.run(FutureTask.java:266)
 at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
 at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
 at java.lang.Thread.run(Thread.java:919)
Caused by: java.lang.IllegalStateException: Expected BEGIN_OBJECT but was NUMBER at line 1 column 5 path $[0]
 at com.google.gson.stream.JsonReader.beginObject(JsonReader.java:395)
 at com.google.gson.internal.bind.ReflectiveTypeAdapterFactory$Adapter.read(ReflectiveTypeAdapterFactory.java:259)
 ... 21 more

Hi first really thankful and appreciating your hard word kindly I would like to ask implementation of do and undo feature like the picture below and thanks again👍

Please use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Is your feature request related to a problem? Please describe.

Describe the solution you'd like

Describe alternatives you've considered

Additional context