Hi, I'm using tinylog version 2.0.0 on Android and it worked great. However I recently released my new app and I found out that the log file never gets created. So I started to investigate the issue. What I found out is that as soon as I enable proguard on my release build I receive following output on the logcat when I log something

LOGGER WARN: No logging framework implementation found in classpath. Add tinylog-impl.jar for outputting log entries.

My tinylog.properties file looks like this

writer=rolling file
writer.file=/data/data/test.grill.com/files/test_logs/test_log.txt
writer.level=info
writer.policies=size: 5mb
writer.format={date: HH:mm:ss.SSS} [{thread}] {level}:\n{message}

and it is located in my resources folder. Everything is working when I'm not enabling proguard. Are there some proguard rules which needs to be added when using tinylog with proguard?

Edit: seems that the ServiceLoader could not get anyResourses

classLoader.getResources(name);

returns an empty Enumeration when enabling proguard.

Running SharedFileWriterTest on Linux I get test failures as described here: https://github.com/jotomo/tinylog/commit/0b41014894d5986d163e266411d993abaa1ca9ee, indicating a problem when writing to a log file concurrently. @pmwmedia I'm assuming you're running Windows. TravisCI would run the tests on Linux - I've seen you tested TravisCI but dropped it again. Remember why?

Updated: running a Linux system natively, or a Linux VM on a Linux hosts, there are intermittend build failures in tests that inherit from AbstractTimeBasedPolicy (mostly in WeeklyPolicyTest). These failures occur 1-3 times out of 10 on an Arch Linux system (as December 2015). It seems that the SystemTimeMock is not thread-safe and occassionally returns the actual system time, leading to test failures.

Description

Linked issue: #194

Definition of Done

• [x] There are no TODOs left in the code
• [x] Code style follows the tinylog standard
• [x] All classes and methods have Javadoc
• [x] Changes are covered by JUnit tests including corner cases, errors, and exception handling
• [x] Maven build works including compiling, tests, and checks (mvn verify)
• [x] Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)

Documentation

Additions or amendments for the public documentation:

Writer | Property Value | Description :------------------------------------------ |:-------------- |:------------ ... JSON Writer | json | Writes log entries to a json file

...

JSON Writer

The JSON writer writes log entries to a defined json file. It supports custom field configuration with the syntax writer.field.FIELDNAME = FORMAT. With appending mode off, the file is reset with new log entries. The format can be configured like in other writers. Example:

writer         = json
writer.file    = log.json
writer.charset = UTF-8 
writer.append  = true
writer.field.message = message
writer.field.date = date
writer.field.lvl = level

Agreements

• [x] I agree that my changes will be published under the terms of the Apache License 2.0
• [x] I agree that my GitHub user name will be published in the release notes

I don't know why this exception throw when i adds via gradle collect dependencies and in bundle i have all impl module classes.

I also noticed that many have the same problem.

Gradle dependencies:

Embed configuration:

Jar configuration:

Hello, have you thinking about providing module-info.java module descriptor then TinyLog to be compatible with Java Platform Module System and make possible creating of runtime image with jlink ?

Describe the issue Currently, the writer leaves the ] out and keeps the last , which is invalid json. I think we should let the json log file always stay in a syntactic correct state. One would not be able to parse the file while it does not match JSON spec.

Currently the close method performs the last steps needed to bring it in that state by calling postProcess. Maybe we could handle the logic of postProcess everytime we write an entry. The new close method should then only handle writer.flush() and writer.close()

The file currently looks like this:

[
	{
           ...
	},

To Reproduce

1. configure properties to use json writer
2. start application
3. write any entry
4. use the json for anything other while application is running

Environment tinylog version: 2.4 Java version: 15

Description

The Java property configuration loader is made more generic and as service so that user loaders (YAML, JSON) become possible. Besides the ConfigurationLoader interface and its implementation this requires public access to some classes and methods.

Linked issue: #114

Definition of Done

• [x] There are no TODOs left in the code
• [x] Code style follows the tinylog standard
• [x] All classes and methods have Javadoc
• [x] Changes are covered by JUnit tests including corner cases, errors, and exception handling
• [x] Maven build works including compiling, tests, and checks (mvn verify)
• [x] Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)

Documentation

Additions or amendments for the public documentation:

It has API effect with the new configuration loader service.

Agreements

• [x] I agree that my changes will be published under the terms of the Apache License 2.0
• [x] I agree that my GitHub user name will be published in the release notes

Describe the bug When using slf4j-tinylog the correct class is not logged

To Reproduce Steps to reproduce the behavior:

1. Use tinylog, tinylog-api and slf4j-tinylog
2. Run an application that uses slf4j e.g. Flyway
3. It runs and logs incorrectly, e.g.

2021-01-01 15:33:23 [io-executor-thread-1] org.flywaydb.core.internal.logging.slf4j.Slf4jLog.info() INFO: Flyway Community Edition 7.3.1 by Redgate 2021-01-01 15:33:23 [io-executor-thread-1] org.flywaydb.core.internal.logging.slf4j.Slf4jLog.info() INFO: Database: jdbc:postgresql://127.0.0.1:6432/test (PostgreSQL 13.1) 2021-01-01 15:33:23 [io-executor-thread-1] org.flywaydb.core.internal.logging.slf4j.Slf4jLog.info() INFO: Current version of schema "public": 1.1

Where these entries belong to different classes, e.g. the first is run from a class called VersionPrinter.

Environment tinylog version: 2.2.1 Java version: 15

Description

Linked issue: #159

Definition of Done

• [x] There are no TODOs left in the code
• [x] Code style follows the tinylog standard
• [x] All classes and methods have Javadoc
• [x] Changes are covered by JUnit tests including corner cases, errors, and exception handling
• [x] Maven build works including compiling, tests, and checks (mvn verify)
• [x] Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)

Documentation

Additions or amendments for the public documentation:

Agreements

• [x] I agree that my changes will be published under the terms of the Apache License 2.0
• [x] I agree that my GitHub user name will be published in the release notes

see https://github.com/pmwmedia/tinylog/issues/149

I'm not sure how to implement the assertions in the test. The build is not working on my machine (javac 11.0.7)

tinylog/tinylog-api/src/main/java/org/tinylog/runtime/LegacyJavaRuntime.java:[58,43] cannot find symbol
[ERROR]   symbol:   class Reflection
[ERROR]   location: package sun.reflect

If you find the idea acceptable, could you please help me with this part? Thank you!

Description

Linked issue: #201

This change allows a single TaggedLogger to log to multiple tags, instead of having to create individual logger for each tag.

Definition of Done

• [x] I read contributing.md
• [x] There are no TODOs left in the code
• [x] Code style follows the tinylog standard
• [x] All classes and methods have Javadoc
• [x] Changes are covered by JUnit tests including edge cases, errors, and exception handling
• [x] Maven build works including compiling, tests, and checks (mvn verify)
• [x] Changes are committed by a verified email address that is assigned to the GitHub account (https://github.com/settings/emails)

Documentation

Additions or amendments for the public documentation:

• Tags will need to be updated with the addition of the new tags method.

Agreements

• [x] I agree that my changes will be published under the terms of the Apache License 2.0 (mandatory)
• [x] I agree that my GitHub user name will be published in the release notes (optional)

This PR contains the following updates:

| Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | org.mockito:mockito-junit-jupiter | 4.10.0 -> 4.11.0 | | | | | | org.mockito:mockito-inline | 4.10.0 -> 4.11.0 | | | | | | org.mockito:mockito-android | 4.10.0 -> 4.11.0 | | | | |

Release Notes

Configuration

📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Enabled.

♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about these updates again.

• [ ] If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

Describe the bug When logging an error at the end of a while loop and logging info at the beginning the info message get's displayed first if the loop continues

2022-12-28 14:06:14 [main] -> DEBUG: Input['asfd'] was issued
2022-12-28 14:06:14 [main] -> INFO: Select a version [PROXY, GAME_SERVER]
af
2022-12-28 14:06:15 [main] -> DEBUG: Input['af'] was issued
2022-12-28 14:06:15 [main] -> INFO: Select a version [PROXY, GAME_SERVER]
2022-12-28 14:06:15 [main] -> ERROR: Couldn't verify input
adf
2022-12-28 14:06:15 [main] -> DEBUG: Input['adf'] was issued
2022-12-28 14:06:15 [main] -> INFO: Select a version [PROXY, GAME_SERVER]
2022-12-28 14:06:15 [main] -> ERROR: Couldn't verify input

To Reproduce Steps to reproduce the behavior:

import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
import org.tinylog.kotlin.Logger
import kotlin.reflect.KClass
import kotlin.reflect.cast

class Question<T: Any>(private val text: String, private val type: KClass<T>, private val answers: List<T> = emptyList()) {

    init {
        if (!(type == String::class || type == Boolean::class || type == Char::class ||
                    type == Short::class || type == Int::class || type == Long::class ||
                    type == Float::class || type == Double::class || type.isEnum)) {
            throw UnsupportedOperationException("Question only supports primitives, but was $type")
        }
    }

    @Suppress("MemberVisibilityCanBePrivate")
    lateinit var answer: T
        private set

    suspend fun askConsole(): Question<T> {
        do {
            Logger.info(text + if (answers.isNotEmpty()) answers.joinToString(prefix = " [", postfix = "]", separator = ", ") else "")
            val input = withContext(Dispatchers.IO) {
                readln()
            }
            Logger.debug("Input['$input'] was issued")
            try {
                val cast = type.cast(when (type) {
                    String::class -> input
                    Boolean::class -> input.toBooleanStrict()
                    Char::class -> {
                        val charArray = input.toCharArray()
                        if (charArray.size > 1) {
                            throw IllegalArgumentException()
                        }
                        charArray.first()
                    }

                    Short::class -> input.toShort()
                    Int::class -> input.toInt()
                    Long::class -> input.toLong()
                    Float::class -> input.toFloat()
                    Double::class -> input.toDouble()
                    else -> {
                        if (!type.isEnum) {
                            throw UnsupportedOperationException()
                        }

                        type.enumConstants.find {
                            (it as Enum<*>).name.equals(input, ignoreCase = true)
                        } ?: throw IllegalArgumentException()
                    }
                })

                if (answers.isNotEmpty() && !answers.contains(cast)) {
                    Logger.error("Wrong answer")
                } else {
                    answer = cast
                }
            } catch (e: Exception) {
                Logger.error("Couldn't verify input")
            }
        } while (!::answer.isInitialized)

        return this
    }
}

Environment tinylog version: 2.5.0 Kotlin version: 1.7.21

Hi everyone,

let's say we have 20 different java applications/services running in an application server (Tomcat, etc.). Each application has it's own valid log configuration, stored in a collective, single tinylog configuration file, which is used for the logging configuration of all applications, e.g.

tinylog.properties

writerSERVICE1 = rolling file
writerSERVICE1.tag = SERVICE1
writerSERVICE1.format = {date:yyyy-MM-dd HH:mm:ss.SSSZ} | {class-name} | {message}
writerSERVICE1.level = info
writerSERVICE1.file = /some/logpath/service1.{date:yyyyMMdd}.{count}.log
writerSERVICE1.policies = daily, size: 10mb
writerSERVICE1.backups = 5

writerSERVICE2 = rolling file
writerSERVICE2.tag = SERVICE2
writerSERVICE2.format = {date:yyyy-MM-dd HH:mm:ss.SSSZ} | {class-name} | {message}
writerSERVICE2.level = info
writerSERVICE2.file = /some/logpath/service2.{date:yyyyMMdd}.{count}.log
writerSERVICE2.policies = daily, size: 10mb
writerSERVICE2.backups = 5
[...]
writerSERVICE20 = rolling file
writerSERVICE20.tag = SERVICE20
writerSERVICE20.format = {date:yyyy-MM-dd HH:mm:ss.SSSZ} | {class-name} | {message}
writerSERVICE20.level = info
writerSERVICE20.file = /some/logpath/service20.{date:yyyyMMdd}.{count}.log
writerSERVICE20.policies = daily, size: 10mb
writerSERVICE20.backups = 5

Applications are mainly using their own Tag for logging, for example SERVICE1 uses the following code to log messages to its designated logfile: Service1Impl.java

public static final TaggedLogger SERVICE1_LOGGER = Logger.tag("SERVICE1");

//[...]
SERVICE1_LOGGER1.info("Some Info");
SERVICE1_LOGGER1.error("Some error");

Applications are running fine with this configuration in the application server and whenever each Service is called, each logging message is stored in its own logfile, as intended.

Open file descriptors: However when inspecting the open file descriptors under a Linux System, f.e. with the command lsof -a -p APPLICATION_SERVER_PID | grep service1 | grep .log what you see is up to 20 different open file descriptors for the same logfile.

It looks like file descriptors are opened by each service (20) for each tag (20), regardless if the tag is used or not. So if each service already logged an initial message with the configuration above (in tinylog.properties), we can see up to 400 (20x20) open file descriptors, eventhough each service really only used its own Logging Tag for logging purposes.

There might be a possibility this introduces problems (Exceptions - Too many open files), because of a default maximum open files per process limit under linux. One can inspect that limit with the linux command:

ulimit -a
[...]
open files                      (-n) 1024

Is there a way, so that the file descriptors are opened only when they are really used ? My first idea would be to either

1. raise the maximum open file per process limit (this requires a manual operation from the system administrator)
2. to split up the configuration file (tinylog.properties), so each service has its own configuration file, only with that logging tag configuration. (The latter might solve the file descriptor problem but introduces new problems ...)

In my opinion, a single configuration file seems much easier to handle than 20 different files. Also since tinylog 2.4 #201 it's possible to create a tagged logger with multiple tags that issues each log entry to all defined tags. So with multiple configuration files, you would have to configure a tag used by multiple services again and again, in multiple different files, ugh...

Do you have any other ideas ? Is there a way, so that file descriptors are only created f.e. the first time they are used ?

Thanks in Advance !!

This issue lists Renovate updates and detected dependencies. Read the Dependency Dashboard docs to learn more.

Pending Branch Automerge

These updates await pending status checks before automerging. Click on a checkbox to abort the branch automerge, and create a PR instead.

• [ ] Update dependency com.puppycrawl.tools:checkstyle to v10.6.0

Open

These updates have all been created already. Click a checkbox below to force a retry/rebase of any.

• [ ] Update mockito monorepo to v4.11.0 (org.mockito:mockito-junit-jupiter, org.mockito:mockito-inline, org.mockito:mockito-android)

Detected dependencies

• [ ] Check this box to trigger a request for Renovate to run again on this repository

I would like to have a core library.

It doesn't contain too much features.

Only core features.

Tinylog is still too fat.

Don't add features,It immediately becomes Log4j2.