• Merge album and artist by name. This circumvents a bug in Android where a same album (resp. artist) can be parsed and classified under different IDs.

• Rely on genre info extracted directly from JAudioTagger lib. This circumvents a bug in Android where the genre info does not match that specified in the ID3 tags.

• Fix the album year information (was not extracted correctly by Android).

• Artist/album name sorting is accent insensitive (ie. Élodie among Evanescence and Echo)

• Fix the by-year ordering in the Songs tab - since it relies on the year info provided by MediaStore (which is buggy)

• add menu option to force rescanning ID3 tags

--

Pending issues to tackle:

• [x] First run UI to give visual feedback to the potentially slow import of MediaStore data to Discog database

• [x] refresh discog on blacklist update (put a folder in the blacklist after indexation, those title will remain inside a genre category for some time before being removed)

• [x] 'sort by date added' on album tab is not correct

• [x] Every time a go in the setting and come back (without changing anythin), the async cache is redone

• [x] First run: After discog scanning is done, the album/artist tab remains empty. A reload (quit/reenter Vinyl) is needed

• [x] force close and restart: the discog is recan as if it's empty or entirely outdated

• [x] multi-artist album: only one album (with 1 artist) is shown on album tab -> show muitlple albums with same name and different artists

• [x] delete the last song of an album/of an artist: the album and artist tab is not refreshed

Playback ends at the end of the song. Have to repeatedly press play for each song to resume playback.

Device info:

At the beginning, my goal was just to get a cleaner search screen as I found it quite different than the rest of the UI. In the end I added round corner to pretty much every item of the main activity (album and song have them and artist are completely round). See below, screen that are different than before:

Describe the bug it takes about 5 seconds to load, almost every time i open the main screen.

To Reproduce

1. get 100gb of songs
2. open the app
3. go to settings or remove from recent apps
4. get back to the main landing screen

Expected behavior it should be as fast as max four https://github.com/MaxFour/Music-Player/issues/87#issuecomment-698898223

Screenshots i hope there's no need.

Smartphone (please complete the following information):

• Device: nokia 7.2
• Android Version: 10
• ROM: stock
• Vinyl Music Player Version: 0.24.0

Additional context everything else seem to work about the same as maxfour... including the same issues https://github.com/MaxFour/Music-Player/issues/88

Description Sometimes I am getting duplicates of the media player notification, and the old ones can't be cleared. It looks like I have different queues from different apps, but only one of them correctly shows what's playing. This is not a problem with the classic notification, only the modern one.

To Reproduce Steps to reproduce the behavior:

1. Open Vinyl and start playing music
2. Check to make sure the player notification is there
3. Pause the music
4. Go to the app switcher
5. Close Vinyl
6. Reopen Vinyl
7. Start playing music again
8. Check notifications, it should have created a duplicate

Expected behavior I would have expected the older media player notifications to be cleared out, or at least clearable.

Screenshots

Smartphone:

• Device: Samsung Galaxy S20+ 5G
• Android Version: 11
• ROM: One UI 3.1
• Vinyl Music Player Version: 1.2.0

Additional context In order to clear the duplicates, I've found that rebooting my device helps; attempting to remove them by long pressing or swiping doesn't do anything. Also, I have a feeling that this is specifically an issue with some/all Android 11 devices due to the changes they made to the media player notifications.

Describe the bug Vinyl starts, then crashes

To Reproduce Steps to reproduce the behavior:

1. Start Vinyl
2. Changelog appears (asks for permissions on a new install)
3. Vinyl crashes before I can tap on anything
4. "Unfortunately, Vinyl Music Player has stopped. Open app again" message appears
5. On subsequent attempts, the app starts and crashes.

Expected behavior Vinyl starts, changelog appears, it starts indexing audio files

Screenshots none

Smartphone (please complete the following information):

• Device: LG G5 (RS988)
• Android Version: 7.0
• ROM: stock (kernel 3.18.31, build NRD90U, software version RS98821d)
• Vinyl Music Player Version: 1.2.0 (latest as of 13 May 2021)

Additional context Issue occurs both after upgrade from 1.1.2 and after uninstalling and reinstalling.

This MR is a work in progress"

I like to listen to album randomly (and not just song) and I don't seems to be the only one (see https://github.com/AdrienPoupa/VinylMusicPlayer/issues/255 and https://github.com/AdrienPoupa/VinylMusicPlayer/issues/233)

This is done by adding a new shuffling mode (disabled by default as icon can be confusing when you don't know what it do:

Moreover when activated, a new song will be added at the end of the playing queue to show which random album was chosen to be played next. The menu of this album is there to allow you to change the next album in three different mode:

• randomly
• following the last song of the queue genre
• following the last song of the queue artist

There is a listen album history and a searched next album history so that the shuffle mode will not always pick the same album over and over again (limited to a depth of from 0 to 9 album as it is just there for better user experience)

In preferences (at the end of "Now playing"), you can choose the depth of those history and the criteria used to search the next ablum (by genre, artist or randomly with fallback option if no other album outside the listen history is found following those criteria)

Describe the bug I cannot add any song to a playlist or to favorites

To Reproduce Steps to reproduce the behavior:

1. Click on the add to favorites button or add to playlist button

Is your feature request related to a problem? Please describe. I'm always frustrated when the app can't see and play opus file.

Describe the solution you'd like I want this app to be able to read and play opus file. Please take some codec from other sources and put it in the app.

Describe alternatives you've considered If integrating a codec into the app is difficult, just make add on like what MiX explorer do.

Additional context This is a screenshot where i put some opus files. The app can't detect and play them.

Describe the bug Images are flickering whenever some "data refreshing" operation is done.

To Reproduce Steps to reproduce the behavior:

1. Go to Settings > Images > Turn on Ignore Media Store Covers
2. There are many ways to reproduce this:

• Long press a song and then unselected
• Go to a playlist and rearrange and item
• Leave the app in background and then come back also causes flickering

Expected behavior Images should not flicker when Ignore Media Store is activated. (Just like it does with that option deactivated)

Smartphone (please complete the following information):

• Device: Essential Phone PH-1
• Android Version: 9.0
• ROM: Stock
• Vinyl Music Player Version: 0.21.1

0.21.0 does crash after finishing the welcome screens. The menu bar is shown for second and before any song is listed the app crashes on two Android 9 devices (Google Pixel 2 and Sony XZ1). The app runs normal on Android 7.1.2 (LOS14.1).

Is your feature request related to a problem? Please describe. Purely a feature that would be nice to have. I'd like to have my playlists Alphabetized so I can easily find songs on it.

Describe the solution you'd like I'm sure it's simple to imagine, I'd like an option in the menu at the topright of a playlist to include 'sort'. This can either be simply 'Sort Alph.' or have a sub-menu (Like in Songs) where you can sort via other methods. It would also be nice to make Asc/Desc be on/off, so one can choose sort title a-z, title z-a, artist a-z, artist z-a, year, date added, etc.

Describe alternatives you've considered I think I've seen an app that does this, but I'd prefer this app grow and be better/I like the playlist saving feature a lot.

This is an everyday problem (I love Vinyl :))

Is your feature request related to a problem? Please describe. I'm frustrated when I use Vinyl's file browser to play all files of a folder. Each time I open context menu of folder, and look for "Play files" (or something like that); but I remember "oh yes, I forgot, there's no option to replace current playlist from files. So I've to:

• open playlist (from the bottom)
• clic hamburger menu on top right
• select "clear playlist"
• go back to file explorer (hopefully the context is kept, thanks to material design)
• long clic on my folder to make context menu appears
• finally select "add to playlist"

Describe the solution you'd like

• a "play" option that is equivalent to clear playlist than "add to playlist"

Describe alternatives you've considered

• find another open source player (but I'm too lazy to search for hours, and I know that I can't find better ;) )
• suicide (it's probably a little over-reacting)
• make a PR ?

Thanks !

Bug Song title name not changing after previous song ended and it shows as its paused in previous song

To Reproduce

1. Play some song
2. Let it finish playing or skip to next song
3. See the notification panel (I also turned on and off "Classic Notification Design a few times in between)

Screenshots What's playing: Whats Shown:

Smartphone:

• Device: Samsung A31
• Android Version: 12
• Vinyl Music Player Version: 1.3.0 (latest)

Addresses #581

First of all, thanks to the maintainers of this project ! I have been using Vinyl for the past couple of years or so, and its overall quality helped me change the way I listen to music.

I would like to contribute back to this project which brings me so much.

As described in the open issue, this behavior is quite common in music apps (ex: Sonos, Spotify) and certainly helps listeners of english-named artists to unclutter their "T" letter.

Describe the bug If you scroll, starting at the top of a playlist, using the scroll bar, the app crashes.

To Reproduce Steps to reproduce the behavior:

1. Open a playlist
2. Scroll down using the scroll bar
3. App crashes

Expected behavior No crash

Smartphone (please complete the following information):

• Device: Pixel 5
• Android Version: Android 13
• ROM: CalyxOS
• Vinyl Music Player Version: 1.3.0

Additional context

Crash only happens whe scrolling from the top of a playlist and using the scroll bar.

FATAL EXCEPTION: main
Process: com.poupa.vinylmusicplayer, PID: 20955
java.lang.ClassCastException: com.poupa.vinylmusicplayer.adapter.song.AbsOffsetSongAdapter$ViewHolder cannot be cast to com.poupa.vinylmusicplayer.adapter.song.OrderablePlaylistSongAdapter$ViewHolder
	at com.poupa.vinylmusicplayer.adapter.song.OrderablePlaylistSongAdapter.onCheckCanStartDrag(Unknown Source:0)
	at com.h6ah4i.android.widget.advrecyclerview.draggable.DraggableItemWrapperAdapter.canStartDrag(Unknown Source:12)
	at com.h6ah4i.android.widget.advrecyclerview.draggable.RecyclerViewDragDropManager.canStartDrag(Unknown Source:52)
	at com.h6ah4i.android.widget.advrecyclerview.draggable.RecyclerViewDragDropManager.handleActionDown(Unknown Source:34)
	at com.h6ah4i.android.widget.advrecyclerview.draggable.RecyclerViewDragDropManager.onInterceptTouchEvent(Unknown Source:44)
	at com.h6ah4i.android.widget.advrecyclerview.draggable.RecyclerViewDragDropManager$1.onInterceptTouchEvent(Unknown Source:2)
	at androidx.recyclerview.widget.RecyclerView.findInterceptingOnItemTouchListener(Unknown Source:22)
	at androidx.recyclerview.widget.RecyclerView.onInterceptTouchEvent(Unknown Source:9)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2653)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at com.sothree.slidinguppanel.SlidingUpPanelLayout.dispatchTouchEvent(Unknown Source:197)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:3121)
	at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:2745)
	at com.android.internal.policy.DecorView.superDispatchTouchEvent(DecorView.java:498)
	at com.android.internal.policy.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1899)
	at android.app.Activity.dispatchTouchEvent(Activity.java:4262)
	at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(Unknown Source:2)
	at androidx.appcompat.view.WindowCallbackWrapper.dispatchTouchEvent(Unknown Source:2)
	at com.android.internal.policy.DecorView.dispatchTouchEvent(DecorView.java:456)
	at android.view.View.dispatchPointerEvent(View.java:15263)
	at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:6548)
	at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:6348)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5804)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
	at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:5992)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
	at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:6049)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
	at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:5861)
	at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:5827)
	at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:5835)
	at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:5808)
	at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:8857)
	at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:8808)
	at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:8777)
	at android.view.ViewRootImpl$WindowInputEventReceiver.onInputEvent(ViewRootImpl.java:8980)
	at android.view.InputEventReceiver.dispatchInputEvent(InputEventReceiver.java:267)
	at android.os.MessageQueue.nativePollOnce(Native Method)
	at android.os.MessageQueue.next(MessageQueue.java:335)
	at android.os.Looper.loopOnce(Looper.java:161)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7898)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:936)

Describe the bug The song displayed on the lock screen is one song behind. If you just start playing music then try viewing it on the lock screen the song listed is always before.

To Reproduce Steps to reproduce the behavior:

1. Play a song
2. Shut screen off
3. Turn screen on

Expected behavior The song updates when you skip a section of the song with the progress bar. I think it isn't updating properly when you skip and/or turn the screen on

Screenshots

Smartphone (please complete the following information):

• Device: Galaxy S10 Lite
• Android Version: Andriod 12
• ROM: OneUI
• Vinyl Music Player Version: 1.3.0

Additional context This becomes quite a hassle when running and biking.