After add library crash FATAL EXCEPTION: main java.lang.NoSuchMethodError: No static method zzb(Ljava/lang/Object;Ljava/lang/Object;)Ljava/lang/Object; in class Lcom/google/android/gms/common/internal/zzbo; or its super classes (declaration of 'com.google.android.gms.common.internal.zzbo com.google.firebase.provider.FirebaseInitProvider.attachInfo(Unknown Source)

When a MapAdapter is initialized with an empty list of items, it crashes.

java.lang.IndexOutOfBoundsException: Index: 0, Size: 0
    at java.util.ArrayList.get(ArrayList.java:437)
    at ca.llamabagel.transpo.features.map.MapAdapter.onCreateAnnotation(MapAdapter.kt:41)
    at nz.co.trademe.mapme.MapMeAdapter.createAnnotation(MapMeAdapter.kt:91)
    at nz.co.trademe.mapme.MapMeAdapter.applyUpdates(MapMeAdapter.kt:126)
    at nz.co.trademe.mapme.MapMeAdapter.consumePendingUpdateOperations$mapme_debug(MapMeAdapter.kt:514)
    at nz.co.trademe.mapme.MapMeAdapter$updateChildViewsRunnable$1.run(MapMeAdapter.kt:502)
    at android.os.Handler.handleCallback(Handler.java:789)
    at android.os.Handler.dispatchMessage(Handler.java:98)
    at android.os.Looper.loop(Looper.java:
    at android.app.ActivityThread.main(ActivityThread.java:
    at java.lang.reflect.Method.invoke(Native Method)
    at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:767)

Since MapMeAdapter inherits ListUpdateCallback from the legacy support library, the adapter cannot be used with androidX's DiffUtil.DiffResult.dispatchUpdatesTo().

I don't know if it's a bad use of the library or not, but when performing the following sequence of actions, bad things can occur.

1. Create a list with one item and create an adapter with it
2. Call notifyDataSetChanged(). After that, getItemCount() gets called, returning 1 as result.
3. Immediately, and before the adapter is able to refresh its annotations, remove the single item from the list
4. Call notifyDataSetChanged(). After that, getItemCount() gets called, returning 0 as result.
5. In the next view refresh, the adapter calls onCreateAnnotation(...) with position=0, leading to a crash since there are no items in the list.

Apparently, the adapter remembers the first amount of annotations to be added to the map, but the second call to notifyDataSetChanged() does not get taken into account.

Hi when updating to 1.0.5 for the google maps version the base dependency is not referenced correctly in the pom.xml

<?xml version="1.0" encoding="UTF-8"?>
<project xmlns="http://maven.apache.org/POM/4.0.0" xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd" xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance">
  <modelVersion>4.0.0</modelVersion>
  <groupId>nz.co.trademe.mapme</groupId>
  <artifactId>googlemaps</artifactId>
  <version>1.0.5</version>
  <packaging>aar</packaging>
  <description>MapMe is an Android library that brings the adapter pattern to Maps, simplifying the management of markers and annotations.</description>
  <name>MapMe GoogleMaps</name>
  <url>https://github.com/TradeMe/MapMe.git</url>
  <licenses>
    <license>
      <name>MIT License</name>
      <url>http://www.opensource.org/licenses/mit-license.php</url>
      <distribution>repo</distribution>
    </license>
  </licenses>
  <scm>
    <url>https://github.com/TradeMe/MapMe.git</url>
  </scm>
  <dependencies>
    <dependency>
      <groupId>com.google.android.gms</groupId>
      <artifactId>play-services-maps</artifactId>
      <version>11.8.0</version>
    </dependency>
    <dependency>
      <groupId>com.android.support</groupId>
      <artifactId>appcompat-v7</artifactId>
      <version>27.0.1</version>
    </dependency>
    <dependency>
      <groupId>MapMe</groupId>
      <artifactId>mapme</artifactId>
      <version>unspecified</version>
    </dependency>
    <dependency>
      <groupId>org.jetbrains.kotlin</groupId>
      <artifactId>kotlin-stdlib-jre7</artifactId>
      <version>1.2.31</version>
    </dependency>
  </dependencies>
</project>

Since DiffUtil is usually used quite heavily with this library, I thought it might be useful to add an adapter with an interface similar to ListAdapter which greatly simplifies doing asynchronous diffs for an adapter.

This implementation is based on ListAdapter and uses the AsyncListDiffer class to perform the diff and dispatch it to the adapter.

Some tests still need to be written.

Fixes a crash caused by pending updates attempting to operate on an annotation list that is no longer there.

This PR also updates the library to AGP 3.0.1 and updates some out of date dependencies.

Fixes #17

Hi,

hope find you well with this cold call.

I am an author of mocking framework for Kotlin

I see you are using mockito-kotlin.

I just want you to be aware that there is solution that fully supports Kotlin and ask to try it in your new/current projects.

I can help you if you answer to this issue.

Thanks and please star it

Removing the type from MapAnnotation greatly simplifies the API. The type was something the user didn’t need to know about, so isn’t required in the API.

Removing it means we have to do a cast when interacting with the map in the annotation factory, but the annotation factory is typed so this is pretty safe.

Hi, I'm using Google Maps utils library to add a KML Layer to map.

All works fine (both annotations and kml layers) but when I click on marker to open a bottomsheetdialog, the listener never called and the marker shows the info windows. If I disable the adding of KML, all works correctly.

How can I fix?

The mapView is treated as Nullable throughout MapMeAdapter but when attaching, only a NonNull View is accepted. Even as SupportMapFragment is inflated in a parent's onCreateView, upon configuration changes onMapReady might be called before onCreateView of the parent so if the attaching is done in onMapReady the only possible valid View to pass is the one fetched by requireView() but that View has yet not been created and an IllegalException will be thrown.

Instead if getView() that is Nullable would be allowed, things would work out.

Hi i use this lib for city directory app and it cause app lag. I measure performance and I got that these methods slow down app I share my logcat details

I/Default-IBlockHandler: nz.co.trademe.mapme.MapAdapterHelper\dispatchSecondPass costed 3122 I/Default-IBlockHandler: nz.co.trademe.mapme.MapAdapterHelper\dispatch costed 3123 I/Default-IBlockHandler: nz.co.trademe.mapme.MapMeAdapter\applyUpdates costed 2155 I/Default-IBlockHandler: nz.co.trademe.mapme.MapMeAdapter\consumePendingUpdateOperations$mapme_release costed 5278 I/Default-IBlockHandler: nz.co.trademe.mapme.MapMeAdapter$updateChildViewsRunnable$1\run costed 5278

as you see it took near 5.3 sec to update ui

please help me

I would like to add a custom animation when markers are attached to the adapter. Following the provided sample code from the README, the alpha animation works perfectly on my created markers (https://github.com/TradeMe/MapMe#animations):

override fun onAnnotationAdded(annotation: MapAnnotation) {
        if (annotation !is MarkerAnnotation) return

        ObjectAnimator.ofFloat(annotation, "alpha", 0f, 1f)
                .apply {
                    duration = 150
                    interpolator = DecelerateInterpolator()
                    start()
               }
}

However, when I try to implement a different animation, it doesn't seem to work, i.e. the markers simply pop up without any animation? I've tried translation, rotationand scale as follows:

ObjectAnimator.ofFloat(annotation, "translationX", 100f).apply {
    duration = 1000
    start()
}

ObjectAnimator.ofFloat(annotation, "rotation", 360f).apply {
    duration = 1000
    start()
}

ObjectAnimator.ofFloat(annotation, "scaleX", 2f).apply {
    duration = 1000
    start()
}

Am I doing something wrong or is alpha the only supported animation on markers? Btw.: I am using the default google maps marker icon, i.e.:

factory.createMarker(LatLng(item.lat, item.lon), null, item.title)