I am using a OnePlus 7T, ad-free detects that an ad is being played but it does nothing about it, the ad continues to play.

PS: I'm using the mute plug-in.

thank you very much for this app, still works like a charm. in addition to adding a +1 to previously posted requests for other apps (notably Deezer and Spotify Lite) i was wondering if it could be extended to Accuradio. thank you for your time.

Using Essential phone PH-1, using latest version of Spotify and Ad-Free. Most of the time, the phone would unmute before the ad finishes so a few seconds of ads would be played. Is there any way to unmute at the right time? Even just extend a few more seconds to mute the music would be less distracting.

> Task :app:lintVitalRelease FAILED
/builds/2/fdroiddata/build/ch.abertschi.adfree/app/build.gradle:10: Error: Google Play requires that apps target API level 30 or higher.
 [ExpiredTargetSdkVersion]
        targetSdkVersion 27
        ~~~~~~~~~~~~~~~~~~~
   Explanation for issues of type "ExpiredTargetSdkVersion":
   As of the second half of 2018, Google Play requires that new apps and app
   updates target API level 26 or higher.
   Configuring your app to target a recent API level ensures that users
   benefit from significant security and performance improvements, while still
   allowing your app to run on older Android versions (down to the
   minSdkVersion).
   To update your targetSdkVersion, follow the steps from "Meeting Google Play
   requirements for target API level",
   https://developer.android.com/distribute/best-practices/develop/target-sdk.
   html
   https://support.google.com/googleplay/android-developer/answer/113469#targetsdk
   https://developer.android.com/distribute/best-practices/develop/target-sdk.html
1 errors, 0 warnings
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:lintVitalRelease'.
> Lint found fatal errors while assembling a release target.
  
  Fix the issues identified by lint, or create a baseline to see only new errors:

android { lint { baseline = file("lint-baseline.xml") } }

For more details, see https://developer.android.com/studio/write/lint#snapshot

Could you please take a look? Thanks!

Phone: Samsung S8, latest vendor firmware (Android 9).

When listening to Spotify with headphones (wired, jack), the interdimensional cable is played on the phone's loudspeaker.

Thanks for the awesome software! ;-)

When ever I play any podcast it automatically mutes. It works fine for ads but it shouldn't happen for my currently playing podcast. I'm using OnePlus 6, android os 10. Oxygen OS 10.3.6

I'm running Android 6.0.1. I have tried it with Spotify 8.5.36.747 and the beta 8.5.39.234. It activates as soon as I start playing music on Spotify and will not stop. I tried upgrading to 1.2.1 to see if it worked, as I have been downgrading back to 1.0 each time. I did not keep a copy of the apk, and now it is removed from F-Droid. Is there a way to remedy this or downgrade back to 1.0, so I can use the app? Edit: I have found a copy of the apk from F-Droid's website on the Wayback Machine, which again, does function as expected. Is there any reason why 1.0 works but newer versions do not?

I really like that some developers try to put some funny features into their apps. Really appreciate them making me smiling. But I don't understand "Play until end" option...

There should be two options only: "play local music file until spotify ad ends" or "play until end of music file, regardless if spotify ad already ended before".

What does Ad-Free need full network access for? I guess it has been added in order to download the music file of Interdimensional Cable but this feature has been discontinued.

Since As-Free has full access to notifications, it could technically (!) upload user notifications somewhere (yes, it's open source and in F-Droid). I truly believe that it doesn't, but if this permission is not necessarily needed, it should be removed.

Also, for what does the app need "view network connections" and "read the contents of your shared storage" permissions?

related to the file chooser view for selection of audio tracks.

Android version: 28
Device: samsung SM-G960U
App version: 33
Time: 2019-11-25-22:09:20
Root cause:
android.view.WindowManager$BadTokenException: Unable to add window -- token android.os.BinderProxy@99507bb is not valid; is your activity running?
at android.view.ViewRootImpl.setView(ViewRootImpl.java:1056)
at android.view.WindowManagerGlobal.addView(WindowManagerGlobal.java:381)
at android.view.WindowManagerImpl.addView(WindowManagerImpl.java:93)
at android.app.Dialog.show(Dialog.java:470)
at com.github.angads25.filepicker.view.FilePickerDialog.show(FilePickerDialog.java:417)
at ch.abertschi.adfree.plugin.localmusic.LocalMusicView.showFolderSelectionDialog(LocalMusicView.kt:98)
at ch.abertschi.adfree.plugin.localmusic.LocalMusicPlugin.chooseDirectory(LocalMusicPlugin.kt:141)
at ch.abertschi.adfree.plugin.localmusic.LocalMusicView$onCreate$4.onClick(LocalMusicView.kt:71)
at android.view.View.performClick(View.java:7333)
at android.widget.TextView.performClick(TextView.java:14160)
at android.view.View.performClickInternal(View.java:7299)
at android.view.View.access$3200(View.java:846)
at android.view.View$PerformClick.run(View.java:27773)
at android.os.Handler.handleCallback(Handler.java:873)
at android.os.Handler.dispatchMessage(Handler.java:99)
at android.os.Looper.loop(Looper.java:214)
at android.app.ActivityThread.main(ActivityThread.java:6986)
at java.lang.reflect.Method.invoke(Native Method)
at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:494)
at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)

Spotify lite is out of beta currently at 0.13.0.79 version, tested it and the ad blocking is not working. The notifications seem similar to the normal app. Any chance to get support for it? Thank you

Hi abertschi/ad-free!

This is a one-off automatically generated pull request from LGTM.com :robot:. You might have heard that we’ve integrated LGTM’s underlying CodeQL analysis engine natively into GitHub. The result is GitHub code scanning!

With LGTM fully integrated into code scanning, we are focused on improving CodeQL within the native GitHub code scanning experience. In order to take advantage of current and future improvements to our analysis capabilities, we suggest you enable code scanning on your repository. Please take a look at our blog post for more information.

This pull request enables code scanning by adding an auto-generated codeql.yml workflow file for GitHub Actions to your repository — take a look! We tested it before opening this pull request, so all should be working :heavy_check_mark:. In fact, you might already have seen some alerts appear on this pull request!

Where needed and if possible, we’ve adjusted the configuration to the needs of your particular repository. But of course, you should feel free to tweak it further! Check this page for detailed documentation.

Questions? Check out the FAQ below!

FAQ

Currently, if I use local music mode and set play until end to true, the ad-substitution music will play until end, but the ad is usually far shorter than that. Consequently, when the music player app, Spotify, for example, is unmuted again, it has been playing its own music for a while.

It will be better for me to have ad-free somehow pause the music playback of Spotify (maybe simulating a media control key?) when the ad ends while substitution music still playing. After that, restart playback when unmuting Spotify.

Thank you for your awsome work! :smile:

Issue: This app will not mute the ad source unless it is coming from one single source.

SCENARIO: So if you stream music via Spotify to your bluetooth speaker and decide to watch something on your phone or play a game. The app will mute the audio of the app currently streaming audio to the phones speakers but not mute the source for a bluetooth speaker. If you play the audio streams to one device (phone, bluetooth, wired speaker, etc) it will correctly detect the right app to mute. But it won't work if the music streaming app that has ads is separated from the phone source while the phone is still using other apps that produce sound.

I hope that makes sense... If you wish to replicate this then set the spotify app to play from a bluetooth speaker and load up a game on your phone with its output directed via your phone.

It shows the word "AD" in notification when ad is playing so I think it's not a complicated ad so hoping you can add it!

Thank you for this app!