Hi,

When using your lib, it's crashing at com.flaviofaria.kenburnsview.Transition. (Transition.java:53)

I saw it's because of an exception you throw, but I'd like to know where it comes from exactly and maybe how to fix it.

I'm trying to have a POC project that has the following features:

• fading action bar, using this library: https://github.com/flavienlaurent/NotBoringActionBar
• imageView that change their sizes in parallel (top and bottom) , as you scroll.
• the imageViews are actually KenBurnsView, and they switch between multiple images that might be from the Internet.
• all in fragments and action-bar-navigation is supported.

here's the project: https://drive.google.com/file/d/0B_nrUhQ0MIgwUGZ3cjJwZVpVbkU/

the problem is that even though everything works , the RandomTransitionGenerator sometimes go outside of the content of the image being shown, so empty area is shown too. Also, sometimes, the zoom factor gets really large. of course, I had to change some stuff on both libraries in order for this to work, but most of the code remained intact.

Sometimes the transitioning starts outside of the image boundries, not in the center, this results in white borders being showed. Is there is any way to fix this or is this a known bug and is there a bugfix for it in the works?

I am using your lib from yesterday, and I'm loving it! ;)

There's just one thing I can't get rid of: When I start with one image, and it's already animating, then I call my image loading library to load another one from web, and the result of network call is a drawable with different size. Then KenBurnsView zooms out or in from the previous drawable rectangle to the new rectangle, to get max rectangle size to fill the viewport. The problem is that I don't want that zoom - I want to have my new drawable in imageView instantly panning left and right (beacuse that's how I set my transition generator), in its own drawable size, and foget about old rectangle. I just can't get rid of that initial zoom in my transistion generator.

I have the KenBurnsView and a button over it in a FrameLayout. Now, I am using a Ripple Effect on the button when clicked.

Previously before using KenBurnsView (I just had a simple ImageView) the ripple used to draw over the ImageView.

But now as I replaced the ImageView with this, the ripple draws below it. How can this be solved?

I stumbled upon some errors while I'm performing ObjectAnimator animations on kenburnsview, mainly, I was expanding/collapsing the view. Each time the height field changed, the image view was stuttering, reloading the image or transition on it. I always got IncompatibleRatioException: can't perform effect on rects with distinct aspect ratios. I tried to resolve it by setting the image to null, then by setting the transition generator to null (but that didn't work so instead I set it to a new generator with method to return; immediately without calculations, but that also crashed for another reason, because the library needs values from that method).

Eventually I thought about suggesting a method which freezes the layout so that no calculations or redraws are done. This is helpful in advanced situations such as collapsing/expanding/animating the bounds of kenburnsview, even with height/width of zero. Of course, an unfreeze method after animations are completed.

I just realise adding KenBurnsView at my activity will cause the phone physical back button stop working.

Override onBackPressed() no response as well.

Hi,

We are getting OutOfMemoryError very frequently while loading bitmap from KenBurnsView library. Here is the complete error logcat:

java.lang.OutOfMemoryError at android.graphics.BitmapFactory.nativeDecodeAsset(BitmapFactory.java) at android.graphics.BitmapFactory.decodeStream(BitmapFactory.java:677) at android.graphics.BitmapFactory.decodeResourceStream(BitmapFactory.java:507) at android.graphics.drawable.Drawable.createFromResourceStream(Drawable.java:872) at android.content.res.Resources.loadDrawable(Resources.java:3054) at android.content.res.Resources.getDrawable(Resources.java:1613) at android.widget.ImageView.resolveUri(ImageView.java:648) at android.widget.ImageView.setImageResource(ImageView.java:377) at com.flaviofaria.kenburnsview.KenBurnsView.setImageResource(KenBurnsView.java:125)

Can you tell me the root cause? It seems that bitmap is not getting recycled as soon as the Activity killed by OS. Somehow bitmap remains in memory.

Thanks, Sanjay

When the animation plays, its perfectly fine. But when I use view.pause() then the animations stops but the image becomes very small in size.

How can this problem be solved? I need to give the users a way to stop the animation of this View if they want to.

Here is a temporary dirty fix but it takes a second to adjust:

RandomTransitionGenerator.java
try {
    mLastGenTrans = new Transition(srcRect, dstRect, mTransitionDuration,
        mTransitionInterpolator);
} catch (IncompatibleRatioException e) {
// Most likely the window was resized.
srcRect = generateRandomRect(drawableBounds, viewport);
mLastGenTrans = new Transition(srcRect, dstRect, mTransitionDuration,
        mTransitionInterpolator);
}

I had a weird crash when I rotated my tablet several times with the view enabled. I have pinpointed it to the MathUtils.haveSameAspectRatio() function, and the truncation...

If my previous destRect had a ratio of 0.637 and my new viewPort has a rect ratio of 0.625 The function will say that the viewPortRatio has not changed. (even if we can tell right now that the difference between the two is more than 0.01)

If the random rect generator, provided with a viewport with a 0.625 ratio then returns a rect with a ratio of 0.624999, this will raise the IncompatibleRatioException in the Transition constructor.

I believe the truncating is not that good of an idea when you are comparing the aspect ratios. Imho, it should at least be one decimal further than the comparison itself.

Hi,

Encountered an issue when trying to upload a new build of an app to Google Play Console:

New permissions added Warning:

Users that have the APK with version code XX may need to accept the android.permission.READ_PHONE_STATE permission, which may result in them not upgrading to this version of the app.

Tip:

Ensure that the new permissions are necessary, and consider mentioning these permissions in the What's new in this release text.

Since this is a permission I did not explicitly add I investigated the AndroidManifest.xml of my app and Google was right.

The manifest merger report stated:

uses-permission#android.permission.READ_PHONE_STATE IMPLIED from /Users/jesper/Developer/_android/iap-core-android/app/src/main/AndroidManifest.xml:2:1-18:12 reason: com.flaviofaria.kenburnsview has a targetSdkVersion < 4

I'd imagine this is unintended and would love to have a fix for where the targetSdkVersion is 4 or higher.

Note for anyone else having this issue, there is a quickfix: <uses-permission android:name="android.permission.READ_PHONE_STATE" tools:node="remove"/>

My scenario is actually i'm using this kenBurnsView in collapsing toolbar and bellow collapsing toolbar i have viewpager and tablayout. I'm changing the image as

mViewPager.setOnPageChangeListener(new ViewPager.OnPageChangeListener() {
            @Override
            public void onPageScrolled(int position, float positionOffset, int positionOffsetPixels) {
                changeHeaderImage(position);
            }

the problem is when i touch the screen for swiping viewpager image moves arbitrarily until i stop touching it.

Unable to start activity as it giving RuntimeException plus Error in inflating class com.flaviofaria.kenburnsview.KenBurnsView. Error caused by android.view.InflateException.

Please resolve.

I was playing with this but found when the KenBurnsView size is being animated (I'm actually animating the weight of other views which is causing the KenBurnsView to resize) it goes kind of crazy. It seems the drawing does not take into account the fact that the KenBurnsView size has changed between frames :-(