Hi, I'm starting to use your lib and I got this issue. By default, the DelayClick is true, but when I tap on the view the ripple works great, but the ClickListener of my view isn't triggered. When I set the Delay to false works fine.

I take a look in your lib code and I found an IF that test if delay is false to run the click on child view, but if the test is true I didn't found the code to run the click on child when the animation finish.

If it is a real bug and you don't have time to fix, I can try to fork and fix to you.

Thanks

line 687 cause endless loop in MaterialRippleLayout.java

code: public RippleBuilder rippleInAdapter(boolean inAdapter) { this.rippleInAdapter(inAdapter); //687 return this; }

this.rippleInAdapter(inAdapter); maybe this.rippleSearchAdapter=inAdapter;

I'm trying your library on my view holder but when I run the project the application crash, these happend when I scroll the listView.

The code is:

public class CategoryViewCell extends AbstractAdapter {

public CategoryViewCell(List<HashMap<String, Object>> dataModel){
    super(dataModel);
}

@Override
public View getView(int position, View convertView, ViewGroup viewGroup){

    ViewHolder viewHolder;
    if(convertView == null)
    {
        viewHolder = new ViewHolder();
        convertView = ApplicationLoader.mainLayoutInflater.inflate(R.layout.lsta_pral_item, null);
        viewHolder.imageView = (ImageView)convertView.findViewById(R.id.lstaPralItem);
        convertView.setTag(viewHolder);
    }
    else
    {
        viewHolder = (ViewHolder) convertView.getTag();
    }

    HashMap<String, Object> information = dataModel.get(position);
    String imagen = information.get("imagen").toString();

    Bitmap bitmapFromFile = ImageLoaderService.getInstance().getBitmapFromFile(imagen);
    if (bitmapFromFile != null)
    {
        viewHolder.imageView.setImageBitmap(bitmapFromFile);
    }
    else
    {
        viewHolder.imageView.setImageResource(R.drawable.no_found_image);
    }

    MaterialRippleLayout.on(viewHolder.imageView).rippleColor(Color.RED).create();


    return convertView;
}

private static class ViewHolder
{
    ImageView imageView;
}

}

And the crash is:

java.lang.IllegalStateException: MaterialRippleLayout could not be created: parent of the view already is a MaterialRippleLayout
        at org.pademobile.widgets.MaterialRippleLayout$RippleBuilder.create(MaterialRippleLayout.java:701)
        at org.pademobile.bills.artifacts.CategoryViewCell.getView(CategoryViewCell.java:60)
        at android.widget.AbsListView.obtainView(AbsListView.java:2255)
        at android.widget.ListView.makeAndAddView(ListView.java:1790)
        at android.widget.ListView.fillDown(ListView.java:691)
        at android.widget.ListView.fillGap(ListView.java:655)
        at android.widget.AbsListView.trackMotionScroll(AbsListView.java:5143)
        at android.widget.AbsListView.scrollIfNeeded(AbsListView.java:3243)
        at android.widget.AbsListView.onTouchMove(AbsListView.java:3587)
        at android.widget.AbsListView.onTouchEvent(AbsListView.java:3431)
        at android.view.View.dispatchTouchEvent(View.java:7736)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2212)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1945)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2218)
        at android.view.ViewGroup.dispatchTouchEvent(ViewGroup.java:1959)
        at com.android.internal.policy.impl.PhoneWindow$DecorView.superDispatchTouchEvent(PhoneWindow.java:2068)
        at com.android.internal.policy.impl.PhoneWindow.superDispatchTouchEvent(PhoneWindow.java:1515)
        at android.app.Activity.dispatchTouchEvent(Activity.java:2466)
        at com.android.internal.policy.impl.PhoneWindow$DecorView.dispatchTouchEvent(PhoneWindow.java:2016)
        at android.view.View.dispatchPointerEvent(View.java:7916)
        at android.view.ViewRootImpl$ViewPostImeInputStage.processPointerEvent(ViewRootImpl.java:4023)
        at android.view.ViewRootImpl$ViewPostImeInputStage.onProcess(ViewRootImpl.java:3902)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3452)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3502)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3471)
        at android.view.ViewRootImpl$AsyncInputStage.forward(ViewRootImpl.java:3578)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3479)
        at android.view.ViewRootImpl$AsyncInputStage.apply(ViewRootImpl.java:3635)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3452)
        at android.view.ViewRootImpl$InputStage.onDeliverToNext(ViewRootImpl.java:3502)
        at android.view.ViewRootImpl$InputStage.forward(ViewRootImpl.java:3471)
        at android.view.ViewRootImpl$InputStage.apply(ViewRootImpl.java:3479)
        at android.view.ViewRootImpl$InputStage.deliver(ViewRootImpl.java:3452)
        at android.view.ViewRootImpl.deliverInputEvent(ViewRootImpl.java:5657)
        at android.view.ViewRootImpl.doProcessInputEvents(ViewRootImpl.java:5588)
        at android.view.ViewRootImpl.enqueueInputEvent(ViewRootImpl.java:5559)
        at androi

I noticed minSdk is set to 14, so some users like me which are forced to support older versions can't use your library.

As an enhancement, if you do not want to support older android versions, you can add a section in the readme.md explaining that you can use this library using the Jake Wharton's animation backport (http://nineoldandroids.com/) changing the imports from import android.animation.*; to: import com.nineoldandroids.animation.*; , import android.util.Property; to import com.nineoldandroids.util.Property; and calling function shouldDelayChildPressedState() only if you're using api greater than 14.

Thank and congrats for the great job! David.

Hi, I have custom list adapter of list view where each row is instantiated within "getView(int position, View convertView, ViewGroup parent)" method. The root view of each row is "MaterialRippleLayout" and it has some child views. There I set some click listener of child views. But "onClick(View v)" method is not being called when child view is clicked.

Is it possible to get the End of the Rippleanimation. I want to make the RippleAnimation to fill the screen and when it is filled( animation ended) the activity should be closed or anotherone should start.

so an ripplelayout.onAnimationEnd with returntype of boolean or something similar would be great

Hi,

At first, thank you for the awesome library! I tried it in a ListView with setting app:rippleInAdapter="true", When I long click on an item in the list, the listener correctly called but immediately after releasing touch (MotionEvent.ACTION_UP) the onItemClick method of OnItemClickListener get called! even if returning true in onItemLongClick method!

I've tested it with a normal FrameLayout and it hasn't any problem...

I suggest you forget about LongClick in your click handling mechanism for the layout...

Feature backlog:

• [x] Implement a callback or post onClick() when Ripple animation ends so one can start heavy UI operations after. For example ListView item click and a transition to another screen.
• [x] Persistent Ripple effect flag (does not fade out and remains coloured)
• [x] Fix AdapterView onItemClickListener when MaterialRippleLayout is a item container
• [x] rippleFade attributes to control duration and strength of fade out effect

When the LongClick listener is set to the view on which the MaterialRippleLayout is statically applied the event fires only when you don't move your finger while holding. It is the only place from which it is possible to consume the event. It behaves like this even in the demo application.

Hi balysv, it's me again.

This is a suggestion. Check if view parent already is a MaterialRiplleLayout before create a new one, to prevent stackoverflow. I got this error in an adapter that I create the ripple on my code. But, as an adapter reuse the view, my code insert an MaterialRippleLayout inside another and this cause stackoverflow. I fix the issue in my code, but I suggest this fix on the create method.

Thanks

The following classes could not be instantiated:
- com.balysv.materialripple.MaterialRippleLayout (Open Class, Show Exception)
 Tip: Use View.isInEditMode() in your custom views to skip code or show sample data when shown in the IDE

Inside AndroidStudio. Maybe add view.isInEditMode() support?

I also keep getting:

Exception Details 
java.lang.ClassNotFoundException: com.nineoldandroids.util.Property

It's just in layout preview from AndroidStudio. App is running fine, though. It's just quite annoying since you can't see your layout anymore from the editor.

Or maybe anyone have any trick to "fix" this?

This is the Layout I am using which works perfectly when I use it inside the .xml of my Fragment:

         <com.balysv.materialripple.MaterialRippleLayout
                android:id="@+id/orderByFilterBtn"
                android:layout_width="match_parent"
                android:layout_height="match_parent"
                app:mrl_rippleColor="@color/gray_light"
                android:layout_margin="2dp">

                <LinearLayout
                    android:layout_width="match_parent"
                    android:layout_height="match_parent"
                    android:orientation="horizontal">

                    <TextView
                        android:id="@+id/orderByFilterTxt"
                        android:layout_width="wrap_content"
                        android:layout_height="wrap_content"
                        android:layout_gravity="center_vertical"
                        android:text="@string/popular"
                        android:layout_marginStart="10dp"
                        />

                    <ImageView
                        android:id="@+id/orderByFilterDown"
                        android:layout_width="15dp"
                        android:layout_height="15dp"
                        android:layout_marginEnd="10dp"
                        android:layout_marginStart="4dp"
                        android:layout_gravity="center_vertical"
                        android:src="@drawable/baseline_arrow_drop_down_gray_24dp"
                        />

                </LinearLayout> 

            </com.balysv.materialripple.MaterialRippleLayout>

But when I try to use it from a Custom View with exactly the same code, the click event never gets called.

view.findViewById(R.id.orderByFilterBtn).setOnClickListener(s->{ //Click Event });

Any ideas why?

I applied the example in the demo. It works smoothly. although the width of the list items is match_parent, the Ripple width value is wrap_content. How do I fix this?

I have a button and when I clicked it goes to another activity. I entered the time value in this button for example app: I used mrl_rippleDuration. But it doesn't take action for about 1 second after the animation ends.

my xml :

<com.balysv.materialripple.MaterialRippleLayout
            android:layout_width="wrap_content"
            android:layout_height="wrap_content"
            app:mrl_rippleBackground="@color/colorRed"
            app:mrl_rippleDuration="200">
   <Button
                android:id="@+id/other_activity"
                android:layout_width="350dp"
                android:layout_height="wrap_content"
                android:background="@color/transparent"/>
</com.balysv.materialripple.MaterialRippleLayout>

activity Class

     btn_other_activity = findViewById(R.id.other_activity);
     btn_other_activity.setOnClickListener(new View.OnClickListener() {
            @Override
            public void onClick(View v) {
                Intent intent = new Intent(context, OtherActivity.class);
                startActivity(intent);
            }
        });

Hi, I have custom list adapter of list view the root view of each row is "MaterialRippleLayout" and it has some child views. There I set some click listener of child views. But "onClick(View v)" method is not being called when child view is clicked.

Can you please provide example of ListView with root view is MaterialRippleLayout with child onclicklistener.