Hey,

is there a way to show a notification, which is handling the total progress for multiple file upload (using multiple requests) out of the box?

Best regards

What's pattern this library? Chunk files or resumable file?

The Google show differences Resumable Chunks

When down connection the upload can be continue?

hi, am trying to upload mp4 file from device storage but am keep geting error the code am using is

                UploadService.NAMESPACE = BuildConfig.APPLICATION_ID;

                final String uploadID = UUID.randomUUID().toString();
                final String serverUrlString = "http://xxyyzz.com/mmff/upload.php";

                try {

                    new MultipartUploadRequest(context, uploadID, serverUrlString)
                            .addFileToUpload(Environment.getExternalStorageDirectory().getAbsolutePath() + "/file2.mp4", "your-param-name")
                            .addHeader("your-custom-header-name", "your-custom-value")
                            .addParameter("your-param-name", "your-param-value")
                            .setNotificationConfig(new UploadNotificationConfig())
                            .setMaxRetries(2)
                            .startUpload();

                } catch (Exception exc) {
                    Log.e("AndroidUploadService", exc.getMessage(), exc);
                }

I needed a chunk upload feature for binary upload and it works fine so far, the main idea is to set a CHUNK_SIZE (default is 5MB) at initialisation and .setChunkUpload(true) in the BinaryUploadRequest request.

Hi, I sometimes get the following error when the upload finishes and it crashes my app. Any idea or help? The last part after --- is the error. I brought the previous logs to get you an idea of when it does happen. (It is related to uploadservice/UploadService).

Thanks

I/UploadService: UploadService - (uploadId: N/A) - Service is about to be stopped because idle timeout of 10s has been reached I/UploadService: NotificationActionsObserver - (uploadId: N/A) - unregistered I/UploadService: UploadService - (uploadId: N/A) - Stopping foreground execution I/UploadService: UploadService - (uploadId: N/A) - UploadService destroyed

D/AndroidRuntime: Shutting down VM E/AndroidRuntime: FATAL EXCEPTION: main Process: myApp, PID: 5855 android.app.RemoteServiceException: Context.startForegroundService() did not then call Service.startForeground(): ServiceRecord{5986d70 u0 myApp/net.gotev.uploadservice.UploadService} at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2182) at android.os.Handler.dispatchMessage(Handler.java:107) at android.os.Looper.loop(Looper.java:237) at android.app.ActivityThread.main(ActivityThread.java:8107) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

Describe the bug When I upgrade the lib to 4.5.0, I always get a 413 reply from servers (I tried different servers). These servers are Peertube servers (I tried in different versions of these Peertube servers).

I downgraded the lib to 4.4.2

To Reproduce It's not so easy as it needs to use the app at https://github.com/stom79/TubeLab/tree/update_upload Code:

Upload activity :https://github.com/stom79/TubeLab/blob/update_upload/app/src/main/java/app/fedilab/fedilabtube/PeertubeUploadActivity.java GlobalUploadObserver: https://github.com/stom79/TubeLab/blob/update_upload/app/src/main/java/app/fedilab/fedilabtube/services/GlobalUploadObserver.java Application: https://github.com/stom79/TubeLab/blob/update_upload/app/src/main/java/app/fedilab/fedilabtube/FedilabTube.java

Steps to reproduce the behavior:

1. Create or use an account on Peertube
2. Click on upload a video
3. Select a video and click upload

Expected behavior Get a 200 reply from servers like I get when using 4.4.2

OS and Lib versions (please complete the following information):

• Android Upload Service version: 4.5.0
• Android version and API version: Android 10
• HTTP stack: OkHttpStack

Request code:

new MultipartUploadRequest(PeertubeUploadActivity.this, "https://" + Helper.getLiveInstance(PeertubeUploadActivity.this) + "/api/v1/videos/upload")
                            .setMethod("POST")
                            .setBearerAuth(token)
                            .addHeader("User-Agent", getString(R.string.app_name) + "/" + BuildConfig.VERSION_NAME)
                            .addParameter("privacy", String.valueOf(idPrivacy))
                            .addParameter("nsfw", "false")
                            .addParameter("name", filename)
                            .addParameter("commentsEnabled", "true")
                            .addParameter("downloadEnabled", "true")
                            .addParameter("waitTranscoding", "true")
                            .addParameter("channelId", idChannel)
                            .addFileToUpload(uri.toString(), "videofile")
                            .setNotificationConfig((context, uploadId) -> getNotificationConfig(uploadId))
                            .setMaxRetries(2)
                            .startUpload();

Where have you added the request code?

• [x] Activity
• [ ] Service
• [ ] Other class (add additional info about it)

Debug Log:

MultipartUploadTask - (uploadId: 982d1af5-8b54-419a-a59d-1098ac9f44c6) - Server response: code 413, body 
2020-11-21 09:36:49.520 27553-31691/app.fedilab.tubelab I/UploadService: UploadTask - (uploadId: 982d1af5-8b54-419a-a59d-1098ac9f44c6) - upload error
2020-11-21 09:36:49.555 27553-27553/app.fedilab.tubelab W/System.err: net.gotev.uploadservice.exceptions.UploadError: Upload error
2020-11-21 09:36:49.556 27553-27553/app.fedilab.tubelab W/System.err:     at net.gotev.uploadservice.UploadTask.onResponseReceived(UploadTask.kt:237)
2020-11-21 09:36:49.556 27553-27553/app.fedilab.tubelab W/System.err:     at net.gotev.uploadservice.HttpUploadTask.upload(HttpUploadTask.kt:65)
2020-11-21 09:36:49.557 27553-27553/app.fedilab.tubelab W/System.err:     at net.gotev.uploadservice.UploadTask.run(UploadTask.kt:144)
2020-11-21 09:36:49.557 27553-27553/app.fedilab.tubelab W/System.err:     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
2020-11-21 09:36:49.557 27553-27553/app.fedilab.tubelab W/System.err:     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
2020-11-21 09:36:49.557 27553-27553/app.fedilab.tubelab W/System.err:     at java.lang.Thread.run(Thread.java:919)

From server:

{"message":"xx.xx.xx.xx - - [20/Nov/2020:17:37:07 +0000] \"POST /api/v1/videos/upload HTTP/1.1\" 413 - \"-\" \"Tubelab/fdroid_full\"\n","level":"info","label":"example.com:443","timestamp":"2020-11-20T17:37:07.396Z"}

Describe the bug I run sample and upload big file, but not work

javax.net.ssl.SSLException: Write error: ssl=0x7a5418f8c8: I/O error during system call, Broken pipe
       at com.android.org.conscrypt.NativeCrypto.SSL_write(Native Method)
       at com.android.org.conscrypt.NativeSsl.write(NativeSsl.java:426)
       at com.android.org.conscrypt.ConscryptFileDescriptorSocket$SSLOutputStream.write(ConscryptFileDescriptorSocket.java:660)
       at okio.OutputStreamSink.write(JvmOkio.kt:53)
       at okio.AsyncTimeout$sink$1.write(AsyncTimeout.kt:103)
       at okio.RealBufferedSink.flush(RealBufferedSink.kt:247)
       at okhttp3.internal.http1.Http1ExchangeCodec$KnownLengthSink.flush(Http1ExchangeCodec.kt:276)
       at okio.ForwardingSink.flush(ForwardingSink.kt:32)
       at okhttp3.internal.connection.Exchange$RequestBodySink.flush(Exchange.kt:228)
       at okio.RealBufferedSink.flush(RealBufferedSink.kt:250)
       at net.gotev.uploadservice.okhttp.OkHttpBodyWriter.flush(OkHttpBodyWriter.kt:25)
       at net.gotev.uploadservice.network.BodyWriter.write(BodyWriter.kt:67)
       at net.gotev.uploadservice.network.BodyWriter.writeStream(BodyWriter.kt:42)
       at net.gotev.uploadservice.protocols.multipart.MultipartUploadTask.writeFiles(MultipartUploadTask.kt:52)
       at net.gotev.uploadservice.protocols.multipart.MultipartUploadTask.onWriteRequestBody(MultipartUploadTask.kt:81)
       at net.gotev.uploadservice.okhttp.OkHttpStackRequest$createBody$1.writeTo(OkHttpStackRequest.kt:76)
       at okhttp3.internal.http.CallServerInterceptor.intercept(CallServerInterceptor.kt:59)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at net.gotev.uploadservicedemo.App.lambda$getOkHttpClient$1(App.java:87)
       at net.gotev.uploadservicedemo.-$$Lambda$App$i1SOtWVwIE4ECfByutde1MWQaGw.intercept(Unknown Source:0)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at okhttp3.internal.connection.ConnectInterceptor.intercept(ConnectInterceptor.kt:34)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at okhttp3.internal.cache.CacheInterceptor.intercept(CacheInterceptor.kt:95)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at okhttp3.internal.http.BridgeInterceptor.intercept(BridgeInterceptor.kt:83)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at okhttp3.internal.http.RetryAndFollowUpInterceptor.intercept(RetryAndFollowUpInterceptor.kt:76)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at okhttp3.logging.HttpLoggingInterceptor.intercept(HttpLoggingInterceptor.java:212)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at net.gotev.uploadservicedemo.App.lambda$getOkHttpClient$0(App.java:76)
       at net.gotev.uploadservicedemo.-$$Lambda$App$2XvpshJlC8JG_AkWVft4Xf_QR38.intercept(Unknown Source:0)
       at okhttp3.internal.http.RealInterceptorChain.proceed(RealInterceptorChain.kt:109)
       at okhttp3.internal.connection.RealCall.getResponseWithInterceptorChain$okhttp(RealCall.kt:201)
       at okhttp3.internal.connection.RealCall.execute(RealCall.kt:154)
       at net.gotev.uploadservice.okhttp.OkHttpStackRequest.getResponse(OkHttpStackRequest.kt:95)
       at net.gotev.uploadservice.HttpUploadTask.upload(HttpUploadTask.kt:49)
       at net.gotev.uploadservice.UploadTask.run(UploadTask.kt:140)
       at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1167)
       at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:641)
       at java.lang.Thread.run(Thread.java:919)
   	Suppressed: java.net.ProtocolException: unexpected end of stream
       at okhttp3.internal.connection.Exchange$RequestBodySink.close(Exchange.kt:239)
       at okio.RealBufferedSink.close(RealBufferedSink.kt:268)
       at net.gotev.uploadservice.okhttp.OkHttpBodyWriter.close(OkHttpBodyWriter.kt:30)
       at kotlin.io.CloseableKt.closeFinally(Closeable.kt:60)
2020-08-25 13:57:43.367 6397-21586/net.gotev.uploadservicedemo E/UploadService:     at net.gotev.uploadservice.okhttp.OkHttpStackRequest$createBody$1.writeTo(OkHttpStackRequest.kt:75)

To Reproduce Steps to reproduce the behavior:

1. Open App
2. New Multipart Upload
3. Input link, header, add file
4. Click check icon on right top
5. Progress to 14% and broken

Device: Android 10 Samsung A30

When I just include your dependency into my gradle project I'm catching this

Error:(2) Error retrieving parent for item: No resource found that matches the given name 'android:TextAppearance.Material.Widget.Button.Inverse'.

Any other requirements to be met?

Uploads to Akami servers fail.

From what I was told, this was because not Content-Length was being passed in the headers. After a lot of debugging, turns out conn.setChunkedStreamingMode(0) is the issue. Setting the chucked mode sends by default data is 1024 bytes and it sends headers with each bit of data. I would recommend removing this option.

Please can you give me information about how can I upload large files?

Caused by java.lang.RuntimeException: android.os.TransactionTooLargeException: data parcel size 10516560 bytes at android.app.ContextImpl.startServiceCommon(ContextImpl.java:1692) at android.app.ContextImpl.startForegroundService(ContextImpl.java:1638) at android.content.ContextWrapper.startForegroundService(ContextWrapper.java:688) at net.gotev.uploadservice.extensions.ContextExtensionsKt.startNewUpload(ContextExtensions.kt:31) at net.gotev.uploadservice.UploadRequest.startUpload(UploadRequest.kt:54) at net.gotev.uploadservice.observer.request.RequestObserver.subscribe(RequestObserver.kt:52) at net.gotev.uploadservice.UploadRequest.subscribe(UploadRequest.kt:82)

I was trying to upload an image to a protected service that requires an autorization header but it's failing. The headers are set on a OkHttp interceptor, also I tried to add an OkHttp logging interceptor and is not logging anything. Is the library overwritting the OkHttp interceptors?

Bumps express from 4.17.1 to 4.17.3.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps qs to 6.11.0 and updates ancestor dependency express. These dependencies need to be updated together.

Updates qs from 6.7.0 to 6.11.0

Updates express from 4.17.1 to 4.18.2

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Bumps commons-net from 3.8.0 to 3.9.0.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

├─ android.os.PowerManager$WakeLock instance │ Leaking: UNKNOWN │ Retaining 3.5 kB in 51 objects │ ↓ PowerManager$WakeLock.this$0 │ ~~~~~~ ├─ android.os.PowerManager instance │ Leaking: UNKNOWN │ Retaining 3.3 kB in 48 objects │ mContext instance of net.gotev.uploadservice.UploadService │ ↓ PowerManager.mContext │ ~~~~~~~~ ╰→ net.gotev.uploadservice.UploadService instance ​ Leaking: YES (ObjectWatcher was watching this because net.gotev.uploadservice.UploadService received Service#onDestroy() callback and Service not held by ActivityThread) ​ Retaining 1.8 kB in 31 objects