Kotlin: 1.0.6

Builds fail on two different linux ci servers, spitting out error: @PaperParcel can only be applied to classes that implement android.os.Parcelable. for every class.

Our app builds without error on os x machines.

Here is an example class:

@PaperParcel
data class Pagination(
        val total: Int = 0,
        val count: Int = 0,
        val perPage: Int = 0,
        val currentPage: Int = 1,
        val totalPages: Int = 1
) : PaperParcelable {
    companion object {
        @JvmField val CREATOR = PaperParcelPagination.CREATOR
    }
}

Hello dear lib developer,

thanks for this awesome PaperParcel library. I read your Blogpost with the history of this lib in kotlin and why it's interesting to also have it for java based android apps. However, i have the following problem:

I use AutoValue and did simply include your library and added implements Parcelable. But now i'm forced to implement a "describeContents" field of type int in my builder / in my constructors of my AutoValue abstract class.

What is this field supposed to do? And, is it really so important, that I have to add a setter for it? This feels a little bit too intrusive.

Hello, I've been reviewing the library, and I must say, I really love the approach it has taken. I'm working with the Kotlin version mostly.

I see that the v2.x branch has improved a lot over the current v1, most importantly:

1. No new object creation is needed anymore vis PaperParcels.wrap
2. Reflection is now totally gone.

However, 1 seems to come with the penalty of more boilerplate. Is there a way, anyway really, we can possibly avoid the explicit CREATOR and writeToParcel hooks.

Is it possible to use @Transient in place of the new @Exclude annotation?

Also, the documentation doesn't mention anything about class and field level type adapters anymore. Are those still supported? Just curious though, as I do not personally use them

Thank you.

@PaperParcel
data class UIModel constructor(
        val id: String,
        val isGetting: Boolean = false,
        val pk: String? = null,
        @Transient val listData: List<Data>? = null,
        val taxonym: String? = null
) : PaperParcelable {
    constructor(
            id: String,
            isGetting: Boolean,
            pk: String?,
            taxonym: String?
    ) : this(
            id,
            isGetting,
            pk,
            null,
            taxonym
    )

    companion object {
        @JvmField
        val CREATOR = PaperParcelUIModel.CREATOR
    }
}

So first off I had to add in this secondary constructor in order to get this to build. The Data class is annotated @PaperParcel and implements PaperParcelable with the CREATOR companion object. Everything is in Kotlin. This was the only way I could get a successful build. There is a generated file, PaperParcelUIModel which has a writeToParcel method which correctly excludes the Transient field and a createFromParcel method which calls the secondary constructor. However when I, run, observe, and debug, my code I see that the Transient field with the List is still being included in the Bundle used to save and restore state. Any idea on why this is? Thanks, James.

Hi,

first of all, great work with registering adapters accross multiple modules! Thx

My setup: paperparcel -> beta2 kotlin 1.0.6

app-module: TestImpl (implements ITest) @ParcelPaper class TestImpl : ITest

interface-module: ITest is an interface which implements Parcelable interface ITest : Parcelable

-> problem: annotation processor throws the following exception: "error: @PaperParcel can only be applied to classes that implement android.os.Parcelable."

if i put the interface in the same module or add "Parcelable" to "TestImpl" @ParcelPaper class TestImpl : ITest, Parcelable class it is working.

IMPORTANT: it is working with this setup and kotlin 1.0.5-3. seems something changed in kapt3

Your library is really great, but i get an error message writing a custom typeadapter

@RegisterAdapter object PairAdapter : TypeAdapter<Pair<String, String>> {
  override fun readFromParcel(source: Parcel): Pair<String, String> {
    return Pair(source.readString(), source.readString())
  }

  override fun writeToParcel(value: Pair<String, String>, dest: Parcel, flags: Int) {
    dest.writeString(value.first)
    dest.writeString(value.second)
  }
}

data class with pair object:

@PaperParcel data class ObjectWithPair(val pair: Pair<String, String>) : Parcelable {
  companion object {
    @JvmField val CREATOR = PaperParcelObjectWithPair.CREATOR
  }

  override fun describeContents() = 0

  override fun writeToParcel(dest: Parcel, flags: Int) {
    PaperParcelObjectWithPair.writeToParcel(this, dest, flags)
  }
}

error message: Unknown type kotlin.Pair<java.lang.String,java.lang.String>. Define a TypeAdapter to handle custom types. For more info, see https://github.com/grandstaish/paperparcel.

i have also tested to explicitly define the typedapter with the full qualified package name like the error mentioned, but this didn´t work either

@RegisterAdapter object PairAdapter : TypeAdapter<kotlin.Pair<java.lang.String, java.lang.String>> {
...
}

The example DateTypeAdapter is working as expected but not the Pair Adapter. Maybe you could have a look at it.

I am using the newest version: 2.0.0-beta1

Thx

I'd like to have a generic way to use the generated wrap/getContents methods for a given type. In particular, I'd like a single class that has these two methods (that delegates out to the various generated FooParcel/BarParcel classes):

public static <ORIG, PARCELABLE extends Parcelable> PARCELABLE wrap(ORIG object)
public static <ORIG, PARCELABLE extends Parcelable> ORIG unwrap(PARCELABLE object)

I started implementing this but realized I should check with you first to make sure this is an enhancement you'd be amenable to. Thoughts?

Having annotation is quite small code change. But would it be possible to have extension which accepts an object and saves/load it from parcel.

At least current API could be improved with extension to avoid using util classes

The proguard rules are currently keeping all PaperParcel classes and classes annotated with PaperParcel.

Is there reason the rules couldn't just keep class members instead?

I have separated my code in 2 Android modules. I have some @PaperParcel data classes (Kotlin) in one package and some in the other. I put the compile in both modules but I get error when building the project.

Say we have a simple Kotlin data class:

@PaperParcel
data class File(val filePath: String) {
}

We want to determine the file name using the path. One approach is to add a function:

fun name(): String {
  val name: String
  // Calculate file name from path
  return name
}

This makes us calculate the name often. Instead, we choose to use a delegated property:

val name: String by lazy {
    // Calculate file name from path. Done only once
}

This breaks the compiler as the name is a delegated property, not a member property. Using @GetterMethodName also doesn't work for this reason.

Hi! I think I suddenly break gradle configuration with my recent PR with incap support.

For version 2.0.7 to work properly I have to add both paperparcel and paperparcel-api artifacts even despite the fact that paperparcel-api declared using api configuration inside paperparcel module.

I have an app with 3 modules:mobile(mobile app), wear(watch app)and core(contains some common entities).

I tried to use paperparcel in mobile and core modules. In mobile module(plugin: 'com.android.application') it works fine, but in core module(plugin: 'com.android.library') this exception was caught: org.jetbrains.kotlin.util.ReenteringLazyValueComputationException

:core:kaptGenerateStubsReleaseKotlin FAILED

FAILURE: Build failed with an exception.

• What went wrong: Execution failed for task ':core:kaptGenerateStubsReleaseKotlin'.

Internal compiler error. See log for more details

My file in core module:

core->build.gradle:

apply plugin: 'com.android.library' apply plugin: "kotlin-android" apply plugin: 'kotlin-android-extensions' apply plugin: 'kotlin-kapt'

android { compileSdkVersion 24 buildToolsVersion "23.0.2"

defaultConfig {
    minSdkVersion 19
}

}

dependencies { compile 'com.google.android.gms:play-services-wearable:8.1.0'

compile "org.jetbrains.kotlin:kotlin-stdlib-jdk7:$kotlin_version"

compile 'nz.bradcampbell:paperparcel:2.0.0'
compile 'nz.bradcampbell:paperparcel-kotlin:2.0.0'
kapt 'nz.bradcampbell:paperparcel-compiler:2.0.0'

}

Also I enabled org.gradle.parallel and tried to add generateStubs = true but it didn't resolve this issue.

I can't build an apk and get this error msg: Error:(12, 33) Unresolved reference: PaperParcelState

PaperParcelState:

@PaperParcel data class State(
            val count: Int,
            val modificationDate: Date
    ) : PaperParcelable {
        @Transient
        val somethingToExclude = 10000L

        companion object {
            @JvmField
            val CREATOR = PaperParcelState.CREATOR
        }
    }

project build.gradle:

// Top-level build file where you can add configuration options common to all sub-projects/modules.

buildscript {
    ext.kotlin_version = '1.1.61'
    repositories {
        google()
        jcenter()
    }
    dependencies {
        classpath 'com.android.tools.build:gradle:3.0.1'
        classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"

        // NOTE: Do not place your application dependencies here; they belong
        // in the individual module build.gradle files
    }
}

allprojects {
    repositories {
        google()
        jcenter()
    }
}

task clean(type: Delete) {
    delete rootProject.buildDir
}

module build.gradle:

apply plugin: 'kotlin-kapt'

apply plugin: 'com.android.application'

apply plugin: 'kotlin-android'

apply plugin: 'kotlin-android-extensions'

android {
    compileSdkVersion 26
    defaultConfig {
        applicationId "com.example.ruslan.myapplication"
        minSdkVersion 15
        targetSdkVersion 26
        versionCode 1
        versionName "1.0"
        testInstrumentationRunner "android.support.test.runner.AndroidJUnitRunner"
    }
    buildTypes {
        release {
            minifyEnabled false
            proguardFiles getDefaultProguardFile('proguard-android.txt'), 'proguard-rules.pro'
        }
    }
}

dependencies {
    implementation fileTree(dir: 'libs', include: ['*.jar'])
    implementation"org.jetbrains.kotlin:kotlin-stdlib-jre7:$kotlin_version"
    implementation 'com.android.support:appcompat-v7:26.1.0'
    implementation 'com.android.support.constraint:constraint-layout:1.0.2'
    implementation 'nz.bradcampbell:paperparcel:2.0.4'
    implementation 'nz.bradcampbell:paperparcel-kotlin:2.0.4'
    kapt 'nz.bradcampbell:paperparcel-compiler:2.0.4'
    testImplementation 'junit:junit:4.12'
    androidTestImplementation 'com.android.support.test:runner:1.0.1'
    androidTestImplementation 'com.android.support.test.espresso:espresso-core:3.0.1'
}

Could you please help me resolve this issue?

Looks like the fields that are being generated have different names from the ones that are defined in the data class.

Data Class

@PaperParcel
data class User(
    val id: Long,
    val firstName: String,
    val lastName: String
) : PaperParcelable {
  companion object {
    @JvmField val CREATOR = PaperParcelUser.CREATOR
  }
}

Build Error

Information:Gradle tasks [:app:generateDebugSources, :app:generateDebugAndroidTestSources, :app:mockableAndroidJar, :app:compileDebugAndroidTestSources, :app:compileDebugUnitTestSources, :app:compileDebugSources]
Error:No field match found for the constructor parameter "arg0" in com.example.login.User. Constructor arguments are matched with fields via their name and type.
Error:No field match found for the constructor parameter "arg1" in com.example.login.User. Constructor arguments are matched with fields via their name and type.
Error:No field match found for the constructor parameter "arg2" in com.example.login.User. Constructor arguments are matched with fields via their name and type.
Error:Execution failed for task ':app:compileDebugJavaWithJavac'.
> Compilation failed; see the compiler error output for details.

PS: I am using Android Studio 3.-0 Beta 7

Hi, I've just found my own bug in this code causing an IllegalArgumentException:

@PaperParcel
data class MultiSearchState(
        val searchQuery: String? = null,
        val activeSearchType: SearchType = SearchType.MOVIES
) : ViewState, PaperParcelable {

    companion object {
        @JvmField val CREATOR = PaperParcelSearchState_SearchStarted.CREATOR
    }
}

The problem was the CREATOR val referring to another's class (SearchState.SearchStarted not MultiSearchState) creator. That's totally my mistake but it might be a good idea to show some error or warning. It's probably an often mistake after copy/paste. Anyway, thanks for the great library! It's the best.

Hi, I am trying to use PaperParcel in my data class models, it does compile and run, but Android Studio is not indexing/recognizing the generated files. Android Studio version 2.3.3 Kotlin version 1.1.3-2

My project is a multi-module project and I am using PaperParcel in one library module. My project has multiple flavors and build types. I see the generated code under $library/build/generated/source/kapt/release/$packages_path