Hi,

Thanks for the great work on this HN RN apps :)

I look at your code to know how you deal with one problem i faced with RN, and i finally see that you didn't face it right now : If you look at the "Dot matrix printer playing "eye of the tiger" [video]" news, you will see html <pre><code> in the middle of the content.

Did you have any idea, to transform those html code, in <Text style='pre'> or in other react componants like a <CodeHighlight> for example ? This is not just string replacement but something more difficult by replacing some part of the text by React Components.

It's difficult to explain why the problem seems difficult to resolve, but i hope you will understand me.

Thanks for sharing :)

@ivanph I'm currently trying to upgrade the app with react native 0.16 under the react-native-0_16 branch, could you confirm if everything is fine with android

You can try it here: https://getexponent.com/@notbrent/hacker-news

When you want to rebuild binaries you can do this: https://docs.getexponent.com/versions/v9.0.0/guides/building-standalone-apps.html

:smile: or don't merge if you don't want to, that's fine

Hi,

I ran the following commands-

npm install react-native run-anroid

The application gets deployed on my device, but, it says the server has to be running so that the app gets the JS Bundle.

I ran-

react-native start

But, it throws up the following error-

root@purvotara:~/ReactJS/native/HackerNews-React-Native# react-native start
 ┌────────────────────────────────────────────────────────────────────────────┐ 
 │  Running packager on port 8081.                                            │ 
 │                                                                            │ 
 │  Keep this packager running while developing on any JS projects. Feel      │ 
 │  free to close this tab and run your own packager instance if you          │ 
 │  prefer.                                                                   │ 
 │                                                                            │ 
 │  https://github.com/facebook/react-native                                  │ 
 │                                                                            │ 
 └────────────────────────────────────────────────────────────────────────────┘ 
Looking for JS files in
   /home/bozzmob/ReactJS/native/HackerNews-React-Native 


React packager ready.

 ERROR  watch /home/bozzmob/ReactJS/native/HackerNews-React-Native ENOSPC
{"code":"ENOSPC","errno":"ENOSPC","syscall":"watch /home/bozzmob/ReactJS/native/HackerNews-React-Native","filename":"/home/bozzmob/ReactJS/native/HackerNews-React-Native"}
Error: watch /home/bozzmob/ReactJS/native/HackerNews-React-Native ENOSPC
    at exports._errnoException (util.js:874:11)
    at FSWatcher.start (fs.js:1239:19)
    at Object.fs.watch (fs.js:1267:11)
    at NodeWatcher.watchdir (/home/bozzmob/ReactJS/native/HackerNews-React-Native/node_modules/react-native/node_modules/sane/src/node_watcher.js:144:20)
    at new NodeWatcher (/home/bozzmob/ReactJS/native/HackerNews-React-Native/node_modules/react-native/node_modules/sane/src/node_watcher.js:45:8)
    at /home/bozzmob/ReactJS/native/HackerNews-React-Native/node_modules/react-native/packager/react-packager/src/FileWatcher/index.js:95:21
    at tryCallOne (/home/bozzmob/ReactJS/native/HackerNews-React-Native/node_modules/react-native/node_modules/promise/lib/core.js:37:12)
    at /home/bozzmob/ReactJS/native/HackerNews-React-Native/node_modules/react-native/node_modules/promise/lib/core.js:103:15
    at flush (/home/bozzmob/ReactJS/native/HackerNews-React-Native/node_modules/react-native/node_modules/promise/node_modules/asap/raw.js:50:29)
    at doNTCallback0 (node.js:417:9)

What am I doing wrong?

It'd be great if this was in the appstore so we could try it out. It's hard to find what react native apps are in the appstore and this one looks like a good one. :)

• What went wrong: A problem occurred evaluating project ':app'.

  Could not find property 'MYAPP_RELEASE_STORE_PASSWORD' on SigningConfig_Decorated{name=release, storeFile=/home/carlos/react-native/HackerNews-React-Native/android/app/hn-reader_android.keystore, storePassword=null, keyAlias=null, keyPassword=null, storeType=/home/carlos/react-native/HackerNews-React-Native/android/app/hn-reader_android.keystore}.

that's the log:

09-24 14:49:33.156    1662-1662/com.hackernews E/ViewRootImpl﹕ sendUserActionEvent() mView == null
09-24 14:49:33.196    1662-1798/com.hackernews W/ReactNativeJS﹕ 'Error: undefined is not an object (evaluating \'RCTAsyncStorage.multiMerge\')\n stack: \n  <unknown>                       index.android.bun…:45700\n  require                         index.android.bun…:254\n  <unknown>                       index.android.bun…:45067\n  require                         index.android.bun…:254\n  <unknown>                       index.android.bun…:44019\n  require                         index.android.bun…:254\n  <unknown>                       index.android.bun…:43922\n  require                         index.android.bun…:254\n  require                         index.android.bun…:200\n  __callFunction                  index.android.bun…:5612\n  <unknown>                       index.android.bun…:5559\n  guard                           index.android.bun…:5502\n  callFunctionReturnFlushedQueue  index.android.bun…:5559\n URL: http://192.168.31.8:8081/index.android.bundle?platform=android\n line: 45700\n message: undefined is not an object (evaluating \'RCTAsyncStorage.multiMerge\')'
09-24 14:49:33.196    1662-1798/com.hackernews W/ReactNativeJS﹕ 'Error: undefined is not an object (evaluating \'module[method]\')\n stack: \n  __callFunction                  index.android.bun…:5613\n  <unknown>                       index.android.bun…:5559\n  guard                           index.android.bun…:5502\n  callFunctionReturnFlushedQueue  index.android.bun…:5559\n URL: http://192.168.31.8:8081/index.android.bundle?platform=android\n line: 5613\n message: undefined is not an object (evaluating \'module[method]\')'
09-24 14:49:33.196    1662-1806/com.hackernews E/unknown:React﹕ Exception in native call from JS
    com.facebook.react.bridge.NativeArgumentsParseException: RCTNetworking.sendRequest got 2 arguments, expected 6
            at com.facebook.react.bridge.BaseJavaModule$JavaMethod.invoke(BaseJavaModule.java:62)
            at com.facebook.react.bridge.NativeModuleRegistry$ModuleDefinition.call(NativeModuleRegistry.java:126)
            at com.facebook.react.bridge.NativeModuleRegistry.call(NativeModuleRegistry.java:64)
            at com.facebook.react.bridge.CatalystInstance$NativeModulesReactCallback.call(CatalystInstance.java:326)
            at com.facebook.react.bridge.queue.NativeRunnable.run(Native Method)
            at android.os.Handler.handleCallback(Handler.java:739)
            at android.os.Handler.dispatchMessage(Handler.java:95)
            at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:31)
            at android.os.Looper.loop(Looper.java:145)
            at com.facebook.react.bridge.queue.MessageQueueThread$1.run(MessageQueueThread.java:137)
            at java.lang.Thread.run(Thread.java:818)

Hi, I added an android version to your app and thought I'll ask before sending a PR. You can take a look here https://github.com/ivanph/HackerNews-React-Native/tree/android_port. I was able to make it work for both platforms from the same code-base. Let me know if you are interested and I'll send the PR.

Thanks.

First,Thanks for the awesome project,I learn a lot form this.

After go review the code,I decide to migrate it to ES6, and update it to the latest RN-0.27.2.

Hi-

I was playing around with this app, and I wanted to promote it on this gallery that @ide and I are working on (http://exp.host/). I got everything working, but the content doesn't update -- all the stories are from a few weeks ago.

I think the issue is with the Kimono Labs endpoint you're using. When I load the URL https://www.kimonolabs.com/api/d3rpj7om , part of the response is ..."frequency":"Manual Crawl","... which made me think it might be configured in a way that you have to manually run the updates?

Is there any way we could fix this up so that the content updates every 15 minutes or something like that?

There is a problem in App.Views.Post.Elements.Comment.index.js.You define textAlign twice ,In the last style "showRepliesButtonText". And Thanks your awesome project to learn react-native.

Hi,

First of all, thanks for making this project open source for our learnings. I'm new bee in React-Native.

I'm trying to create 'build native build' for ios app of this in Deco IDE. And, I'm facing this error -

** BUILD FAILED **

The following build commands failed: CompileC /Users/DAMAGE/Documents/React\ Native\ Projects/HackerNews-React-Native-master/ios/build/Build/Intermediates/RCTWebSocket.build/Debug-iphonesimulator/RCTWebSocket.build/Objects-normal/x86_64/RCTSRWebSocket.o RCTSRWebSocket.m normal x86_64 objective-c com.apple.compilers.llvm.clang.1_0.compiler (1 failure)

Error: Command failed: /usr/libexec/PlistBuddy -c Print:CFBundleIdentifier build/Build/Products/Debug-iphonesimulator/HN Reader.app/Info.plist Print: Entry, ":CFBundleIdentifier", Does Not Exist

so far, awesome code to learn and use however, if I can live without exponent , I really do not understand it how it works so removed from index.android.js import { Constants, } from 'exponent';

and related bar height styles from the file.