Fatal Exception: java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.Window android.app.Activity.getWindow()' on a null object reference at com.reactnativesystemnavigationbar.SystemNavigationBarModule.lambda$setSystemUIFlags$3$com-reactnativesystemnavigationbar-SystemNavigationBarModule(SystemNavigationBarModule.java:245) at com.reactnativesystemnavigationbar.SystemNavigationBarModule$$ExternalSyntheticLambda3.run(:6) at android.os.Handler.handleCallback(Handler.java:873) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:214) at android.app.ActivityThread.main(ActivityThread.java:6981) at java.lang.reflect.Method.invoke(Method.java) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:493) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1445)

My React Native (not Expo) app is reporting several crashes (via Firebase Crashlytics) which appear related to this module (1.0.2):

Fatal Exception: java.lang.NullPointerException
Attempt to invoke virtual method 'android.view.Window android.app.Activity.getWindow()' on a null object reference

com.reactnativesystemnavigationbar.SystemNavigationBarModule.setNavigationColor (SystemNavigationBarModule.java:105)

This error never occurred before using this module. It's happening across Android versions 10, 11, 12.

From reading that error log it kind of sounds like setNavigationColor is being called too soon? I'm calling it like SystemNavigationBar.setNavigationColor("#FDF7F5", false) from inside a useEffect where I'd assume it should be fine to do so.

Hi guys! FIrst of all thank you for this project! After integration with notifee and firebase cloud messaging background handler, i have found this bug:

2022-10-28 14:09:01.178 13660-13660/app.vidit E/AndroidRuntime: FATAL EXCEPTION: main
    Process: app.vidit, PID: 13660
    java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.Window android.app.Activity.getWindow()' on a null object reference
        at com.reactnativesystemnavigationbar.SystemNavigationBarModule.lambda$setSystemUIFlags$3$com-reactnativesystemnavigationbar-SystemNavigationBarModule(SystemNavigationBarModule.java:245)
        at com.reactnativesystemnavigationbar.SystemNavigationBarModule$$ExternalSyntheticLambda3.run(Unknown Source:6)
        at android.os.Handler.handleCallback(Handler.java:938)
        at android.os.Handler.dispatchMessage(Handler.java:99)
        at android.os.Looper.loopOnce(Looper.java:226)
        at android.os.Looper.loop(Looper.java:313)
        at android.app.ActivityThread.main(ActivityThread.java:8751)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:571)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1135)

i was easily fixed that with adding the following code to the native module(for every function that check for the view):

            if(getCurrentActivity() == null) {
              return;
            }

I am using this property and it changes depending on if I have dark mode enabled

SystemNavigationBar.setNavigationColor(0xff00ff00, false);

when I have a <StatusBar /> with backgroundColor and barStyle defined, my <StatusBar /> ignore my custom barStyle and change status icons colors with that function

I have a screen that in its light mode uses a dark color at the top, when the function sets the dark icons become unreadable

I don't know if there is currently any way to handle this problem

Thank you very much for sharing this library.

Thank you for the library, it works great, exactly what we need!

Just a quick question. Are the functions that are only supported by higher level of Android APIs causing an app to crash? To rephrase, do I need to check the API Level before the call, or are you checking it manually inside the code?

Example of the feature is here: setNavigationBarDividerColor() Only API Level 28 (Android 9) and higher is supported.

Thanks!

Bumps decode-uri-component from 0.2.0 to 0.2.2.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Hello there. We are experiencing rare native crashes in setNavigationColor function:

java.lang.RuntimeException: Illegal callback invocation from native module. This callback type only permits a single invocation from native code.
    at com.facebook.react.bridge.CallbackImpl.invoke(CallbackImpl.java:4)
    at com.facebook.react.bridge.PromiseImpl.resolve(PromiseImpl.java:2)
    at com.reactnativesystemnavigationbar.SystemNavigationBarModule.lambda$setModeStyle$4(SystemNavigationBarModule.java:10)
    at com.reactnativesystemnavigationbar.SystemNavigationBarModule.c
    at aa.e.run
    at android.os.Handler.handleCallback(Handler.java:873)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at android.os.Looper.loop(Looper.java:226)
    at android.app.ActivityThread.main(ActivityThread.java:7224)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:500)
    at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:913)

This is probably caused by the setModeStyle internal call, because it accepts promise, so that when parent function has finished it calls promise.resolve second time. This is fixed by overloading setModeStyle without promise, so that we can call it from UI thread directly.

We were experiencing some crashes caused by the NullPointerException raised in the library in production.

java.lang.NullPointerException: Attempt to invoke virtual method 'android.view.Window android.app.Activity.getWindow()' on a null object reference
    at com.reactnativesystemnavigationbar.SystemNavigationBarModule.setNavigationColor(SystemNavigationBarModule.java:1)
    at java.lang.reflect.Method.invoke(Method.java)
    at com.facebook.react.bridge.JavaMethodWrapper.invoke(JavaMethodWrapper.java:18)
    at com.facebook.react.bridge.JavaModuleWrapper.invoke(JavaModuleWrapper.java:13)
    at com.facebook.react.bridge.queue.NativeRunnable.run(NativeRunnable.java)
    at android.os.Handler.handleCallback(Handler.java:938)
    at android.os.Handler.dispatchMessage(Handler.java:99)
    at com.facebook.react.bridge.queue.MessageQueueThreadHandler.dispatchMessage(MessageQueueThreadHandler.java:1)
    at android.os.Looper.loopOnce(Looper.java:210)
    at android.os.Looper.loop(Looper.java:299)
    at com.facebook.react.bridge.queue.MessageQueueThreadImpl$4.run(MessageQueueThreadImpl.java:8)
    at java.lang.Thread.run(Thread.java:920)

It appears that Activity was stopped before setNavigationColor call.

- ui.lifecycle {
  screen: MainActivity, 
  state: stopped
}
- ui.lifecycle {
  screen: MainActivity, 
  state: saveInstanceState
}
- NullPointerException: Attempt to invoke virtual method 'android.view.Window android.app.Activity.getWindow()' on a null object reference

There is an issue in the code below:

if (getCurrentActivity() == null) {
         promise.reject("Error: ", "false");
         return;
}
final Window view = getCurrentActivity().getWindow();

Because getCurrentActivity() result is not saved, current activity may be replaced by null after if condition worked, which is exactly what happens before the crash. For example, Happy path: App working -> setNavigationColor() -> app stops -> if getCurrentActivity() == null is true -> return. Edge case: App working -> setNavigationColor() -> if getCurrentActivity() == null is FALSE -> app stops -> getCurrentActivity().getWindow() -> NPE.

In the edge case NPE happens because app is already stopped, so that getCurrentActivity() returns null and then getWindow() is called on the null instance.

This PR saves getCurrentActivity() result into the variable, so that Activity.getWindow() never raises a NPE.

…roid.view.Window android.app.Activity.getWindow()' on a null object reference

Since getCurrentActivity() is null, it cannot fetch view and gives an error. This was fixed by checking the issue. and the minimum pack was kept as 21.

React Native template already provides buildToolsVersion, minSdkVersion, compileSdkVersion and targetSdkVersion ext options, so I think that build.gradle should not use SystemNavigationBar_ prefixed options. This may cause some inconsistencies in build process.

Attempt to invoke virtual method 'android.view.Window android.app.Activity.getWindow()' on a null object reference at com.reactnativesystemnavigationbar.SystemNavigationBarModule.setNavigationColor

When trying to call setNavigationColor I get [Unhandled promise rejection: TypeError: null is not an object (evaluating 'NavigationBar.NO_MODE')].

  import SystemNavigationBar from "react-native-system-navigation-bar";

  useEffect(() => {
    const changeNavigationBar = async () => {
      try {
        const result = await SystemNavigationBar.setNavigationColor("red");
        console.log("Result:", result);
      } catch (error) {
        console.error("Error:", error);
      }
    };
    changeNavigationBar();
  }, []);

Deps:

    "expo": "~47.0.9",
    "react": "18.1.0",
    "react-dom": "18.1.0",
    "react-native": "0.70.5",
    "react-native-system-navigation-bar": "^2.1.0",

Error:

Clues:

Seems something there:

import { NativeModules, Platform, processColor } from 'react-native';

// NaviagationBar is null
const { NavigationBar } = NativeModules;

// ...

const setNavigationColor = async (
  color: string | number,
  style?: 'light' | 'dark',
  bar?: 'navigation' | 'status' | 'both'
) => {
  if (Platform.OS === 'android') {
    const { modeStyle, mode } = getBarModeTypes(style, bar);
    return await NavigationBar.setNavigationColor(
      color === 'translucent' ? 0 : processColor(color),
      color === 'translucent',
      modeStyle,
      mode
    );
  }
};

Does it work this expo at all? Or I need to use this: https://docs.expo.dev/versions/latest/sdk/navigation-bar/

When running an application using the latest version of this dependency with the latest version of React Native, the following error appears:

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup.
Error: Command failed: ./gradlew app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

* What went wrong:
Could not determine the dependencies of task ':react-native-system-navigation-bar:compileDebugAidl'.
> Could not resolve all task dependencies for configuration ':react-native-system-navigation-bar:debugCompileClasspath'.
   > Could not find com.facebook.react:react-native:0.68.2.
     Required by:
         project :react-native-system-navigation-bar

* Try:
> Run with --stacktrace option to get the stack trace.
> Run with --info or --debug option to get more log output.
> Run with --scan to get full insights.

* Get more help at https://help.gradle.org

BUILD FAILED in 4s

info Run CLI with --verbose flag for more details.
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

Seems to be releated to the following commit https://github.com/kadiraydinli/react-native-system-navigation-bar/commit/97653186f28c0276106eca6e0716a45c416b3340 Is there a reason to hardcode the react native version to 0.68.2 in this dependency? Trying to understand this change, as I'm using react native version 0.70.6 and it does not seem to work, but it is working in the previous version of this library. For now I'll just pin it to 2.0.1

Error is triggered by this function

await SystemNavigationBar.setNavigationColor(theme.colors.barColor);

Error Message in Sentry

Error: false
  at promiseMethodWrapper(node_modules/react-native/Libraries/BatchedBridge/NativeModules.js:105:60)
  at setNavigationColor(node_modules/react-native-system-navigation-bar/src/index.tsx:84:7)
  at next(native)
  at asyncGeneratorStep(node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
  at _next(node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:57)
  at anonymous(node_modules/@babel/runtime/helpers/asyncToGenerator.js:20:14)
  at tryCallTwo(node_modules/promise/setimmediate/core.js:44:3)
  at tryCallTwo$argument_1(node_modules/promise/setimmediate/core.js:204:6)
  at Promise(node_modules/promise/setimmediate/core.js:66:3)
  at anonymous(node_modules/@babel/runtime/helpers/asyncToGenerator.js:19:24)
  at apply(native)
  at <global>(node_modules/react-native-system-navigation-bar/src/index.tsx:75:25)
  at show(src/infrastructure/navigation/Navigation.js:88:62)
  at next(native)
  at asyncGeneratorStep(node_modules/@babel/runtime/helpers/asyncToGenerator.js:3:24)
  at _next(node_modules/@babel/runtime/helpers/asyncToGenerator.js:22:57)
  at anonymous(node_modules/@babel/runtime/helpers/asyncToGenerator.js:20:14)
  at tryCallTwo(node_modules/promise/setimmediate/core.js:44:3)
  at tryCallTwo$argument_1(node_modules/promise/setimmediate/core.js:204:6)
  at Promise(node_modules/promise/setimmediate/core.js:66:3)
  at anonymous(node_modules/@babel/runtime/helpers/asyncToGenerator.js:19:24)
  at apply(native)
  at Nav(src/infrastructure/navigation/Navigation.js:87:13)
  at Nav(src/infrastructure/navigation/Navigation.js:121:5)
  at commitHookEffectListMount(node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:5827:31)
  at flushPassiveEffects(node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:7532:23)
  at commitRootImpl(node_modules/react-native/Libraries/Renderer/implementations/ReactNativeRenderer-prod.js:7371:7)
  at G(node_modules/scheduler/cjs/scheduler.production.min.js:13:205)
  at J(node_modules/scheduler/cjs/scheduler.production.min.js:14:128)
  at apply(native)
  at queueReactNativeMicrotask(node_modules/react-native/Libraries/Core/Timers/JSTimers.js:248:35)
  at _callTimer(node_modules/react-native/Libraries/Core/Timers/JSTimers.js:114:15)
  at _callReactNativeMicrotasksPass(node_modules/react-native/Libraries/Core/Timers/JSTimers.js:162:41)
  at callReactNativeMicrotasks(node_modules/react-native/Libraries/Core/Timers/JSTimers.js:413:12)
  at __callReactNativeMicrotasks(node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:390:42)
  at __guard$argument_0(node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:132:39)
  at __guard(node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:366:7)
  at flushedQueue(node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:131:18)
  at callFunctionReturnFlushedQueue(node_modules/react-native/Libraries/BatchedBridge/MessageQueue.js:116:29)

Error Detail link: https://sentry.io/share/issue/766768c8245e48a797726dcad8bca33f/

My Dependencies

 "react-native-system-navigation-bar": "^2.0.0",
 "react": "18.1.0",
 "react-native": "0.70.0",

Some Affected devices Xiaomi Redmi S2 (Android 9) Nokia 3.4 (Android 12) vivo 1806 (Android 10) Xiaomi Redmi 9 (Android 10)

I look forward to your help, thanks.

Hi, i recently installed your library and when i want to "setNavigationColor" with "light bar" on true, buttons doesn't color in "black". I'm on react native v0.69. Can you help me please ?

When user changes the orientation to landscape, the navigation bar does not disappear.

It works only in portrait mode.

  const mode = useOrientation();

 const setImmer = async() => {
    const result = await SystemNavigationBar.immersive(); // does not work in landscape
  }

useEffect(() => {
   if(mode === 'LANDSCAPE'){
      setTimeout(setImmer, 2000 )
    }
  }, [mode]);