Description

In this pr I am hoping to create a suspending implementation of the httpClient so that, should a user so wish they could avoid using threads.

Huge thank you/love/creative respect/kudos must go to both @iNoles, @lucasvalenteds and @SleeplessByte who all helped me get this running at points I was completely stuck

Fixes #431

Check all that apply

• [x] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactoring (change which changes the current internal or external interface)
• [x] This change requires a documentation update

How Has This Been Tested?

This pr changes the implementation but the test remain the same as the object was not change the behaviour

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation, if necessary
• [x] My changes generate no new compiler warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes

Thank you for submitting your Pull Request. Please make sure you have familiarised yourself with the Contributing Guidelines before continuing.

Description

I added async block for some functions and left blocking one alone. I was a bit curious why somebody else didn't added this one.

Fixes #429

Type of change

Check all that apply

• [ ] Bug fix (non-breaking change which fixes an issue)
• [x] New feature (non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactoring (change which changes the current internal or external interface)
• [ ] This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the changes, with instructions so we can reproduce. If you have added comprehensive tests for your changes, you may ommit this section.

Checklist:

• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation, if necessary
• [x] My changes generate no new compiler warnings
• [x] I have added tests that prove my fix is effective or that my feature works
• [x] New and existing unit tests pass locally with my changes

When i download a big file I am getting an out of memory error in Android. If the file is small there is no problem.

Maybe it can be related to this.

Out of memory error or this Out of memory error 2

I'd like to be able to make requests like this:

 val (request, response, result) = Fuel.post(url)
            .body(MyCustomRequestBodyObject(...)) // here
            .responseObject<MyCustomResponseBodyObject>()

Currently I have an extension method in my project which allows this:

fun Request.body(any: Any) = body(mapper...)

Would be nice if this was a part of the fuel-jackson module.

Currently Fuel handles HTTP Status Code 303 as an error. It should be handled as a redirect though: https://en.wikipedia.org/wiki/HTTP_303 https://httpstatuses.com/303

Description

This PR aims to release Fuel new version 1.16.0. This will target Kotlin 1.3 with new coroutine.

Type of change

Check all that apply

• [x] Release new version

How Has This Been Tested?

Checklist:

• [x] I have performed a self-review of my own code

This pull requests adds some suspend functions to the Request class. They were added in a new module called fuel-coroutines and are intended to allows the developers to avoid callbacks while using asynchronous calls.

Description

This PR allows PATCH requests to be made without a http-method-override header

Type of change

Check all that apply

• [ ] Bug fix (a non-breaking change which fixes an issue)
• [x] New feature (a non-breaking change which adds functionality)
• [ ] Breaking change (fix or feature that would cause existing functionality to not work as expected)
• [ ] Refactoring (a change which changes the current internal or external interface)
• [ ] This change requires a documentation update

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the changes, with instructions so we can reproduce. If you have added comprehensive tests for your changes, you may omit this section.

I have not created tests to verify that this PR is working, however I have modified the sample android app and I can confirm that a patch request is working with httpbin.org. If a test case is required then I'm willing to add one (might need some help with this)

Checklist:

• [x] I have performed a self-review of my own code
• [x] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation, if necessary
• [ ] My changes generate no new compiler warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Inspect the bytecode viewer, including reasoning why

Description

This PR adds review dog to travis CI. It is a continuation over #476. So, it can report our violations at the line they occurs.

Type of change

Check all that apply

• [x] Linter support

How Has This Been Tested?

In case you did not include tests describe why you and how you have verified the changes, with instructions so we can reproduce. If you have added comprehensive tests for your changes, you may omit this section.

Checklist:

• [x] I have performed a self-review of my own code
• [ ] I have commented my code, particularly in hard-to-understand areas
• [ ] I have made corresponding changes to the documentation, if necessary
• [ ] My changes generate no new compiler warnings
• [ ] I have added tests that prove my fix is effective or that my feature works
• [ ] New and existing unit tests pass locally with my changes
• [ ] Inspect the bytecode viewer, including reasoning why

This pull requests rewrites all Gradle build files from Groovy DSL to Kotlin DSL.

The motivation to change them is to reduce duplication and maintenance effort by declaring versions in a single file and defining common logic in one place, which make them reusable. Better syntax highlight and autocomplete is expected too.

At the moment, all tests are passing and Android Studio doesn't have any warnings.

Improvements to make

• Logic to build Android-based modules are not as reusable as JVM-based modules
• Make sure publish plugin is working as expected. At the moment Gradle is loggin the warning below.

  Publication release not found in project :fuel-android.
  Publication release not found in project :fuel-livedata
  

• Gradle found different versions of kotlin-stdlib, but tests are passing. The command below may help to identify them.

  ./gradlew dependencyInsight --configure compile --dependency kotlin-stdlib
  

I'd love hear some feedback from you about using Kotlin instead of Groovy and also suggestions to improve the build scripts!

Attempting to execute:

"http://api.forismatic.com/api/1.0/?method=getQuote&format=json&lang=en".httpGet().response { request, response, result -> 
     println(request)
     println(response)
}

produces:

java.lang.IllegalStateException: Cannot access request header fields after connection is set
     at com.github.kittinunf.fuel.toolbox.HttpClient.executeRequest(HttpClient.kt:69)
     at com.github.kittinunf.fuel.core.requests.TaskRequest.call(TaskRequest.kt:16)
     at com.github.kittinunf.fuel.core.requests.AsyncTaskRequest.call(AsyncTaskRequest.kt:13)
     at com.github.kittinunf.fuel.core.requests.AsyncTaskRequest.call(AsyncTaskRequest.kt:6)
     at java.util.concurrent.FutureTask.run(FutureTask.java:237)
     at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1133)
     at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:607)
     at com.github.kittinunf.fuel.core.FuelManager$executor$2$1$1.run(FuelManager.kt:49)
     at java.lang.Thread.run(Thread.java:761)

Using the cUrlLoggingRequestInterceptor I got the following curl that when executed on a terminal it works:

curl -i -H "Accept-Encoding:compress;q=0.5, gzip;q=1.0" "http://api.forismatic.com/api/1.0/?method=getQuote&format=json&lang=en"

Bug Report

Description

Can't make kotlinx-serialization to decode a list of objects from a JSON string. If I use responseString and 'manually' decode from the resulting string, it works.

To Reproduce

Steps to reproduce the behavior:

Below are two blocks of code, first doesn't work, second does.

@Serializable
data class Store(val storeID: String)

   // does not work
    val (request, response, data) = Fuel.get(address)
        .awaitObjectResponse<List<Store>>(
            kotlinxDeserializerOf()
        )
  // does work
  val httpAsync = Fuel.get(address)
        .responseString { request, response, result ->
            result.fold({ d ->
                    val obj = json.decodeFromString<List<Store>>(d)
                    println(obj[0].name)
            }, { e ->
                println(e.message)
            })
        }

Expected behavior

Should deserialize string.

Actual behavior

Throws the exception below. Exception stack:

Exception in thread "main" Expected class kotlinx.serialization.json.JsonObject (Kotlin reflection is not available) as the serialized body of kotlinx.serialization.Polymorphic<List>, but had class kotlinx.serialization.json.JsonArray (Kotlin reflection is not available)
	com.github.kittinunf.fuel.core.FuelError$Companion.wrap(FuelError.kt:86)
	com.github.kittinunf.fuel.core.DeserializableKt.awaitResponse(Deserializable.kt:258)
Caused by: kotlinx.serialization.json.internal.JsonDecodingException: Expected class kotlinx.serialization.json.JsonObject (Kotlin reflection is not available) as the serialized body of kotlinx.serialization.Polymorphic<List>, but had class kotlinx.serialization.json.JsonArray (Kotlin reflection is not available)
	kotlinx.serialization.json.internal.JsonExceptionsKt.JsonDecodingException(JsonExceptions.kt:24)
	kotlinx.serialization.json.internal.PolymorphicKt.decodeSerializableValuePolymorphic(Polymorphic.kt:94)
	kotlinx.serialization.json.internal.StreamingJsonDecoder.decodeSerializableValue(StreamingJsonDecoder.kt:81)
	kotlinx.serialization.json.Json.decodeFromString(Json.kt:95)
	MainKt$test$$inlined$kotlinxDeserializerOf$1.deserialize(FuelSerialization.kt:55)

Environment

IntelliJ IDEA Community

Bug Report

Description

Docs issue probably. fuel-kotlinx-serialization mentions awaitResponseObject in docs which AFAIK does not exist (anymore?). It's probably awaitObjectResponse.

To Reproduce

Steps to reproduce the behavior:

1. Go to last sample

Expected behavior

Docs should suggest awaitObjectResponse instead.

I am trying to post data using ".jsonBody" but every time it tries to POST it returns a Body: null. Am I formatting the json incorrectly? Any suggestions?

 var intHR = heartRateBpm.value.toInt()
        data class tobesent(
            var devID: String,
            var currentDB: Float,
            var currentHr: Int,
            var userLatitude: Float,
            var userLongitude: Float,
        )
        val send = tobesent("Andy",0f,intHR,0f,0f)
        Fuel.post("https://smart-sense-dashboard.herokuapp.com/api/sensors/")
            .header(Headers.AUTHORIZATION, "4a16b669-43bc-412a-8dad-18dc7fb199d9")
            .jsonBody(Gson().toJson(send).toString())
            .responseString()
            .also { println(it) }

Is there a place to be notified of Fuel security issues? If submitting to issue is not a problem, I will try to describe the Issue directly.

P.S. A feature called "Privately reporting a security vulnerability" has recently been released by Github, so if enable it and I will contact you from there.

https://docs.github.com/ja/code-security/security-advisories/guidance-on-reporting-and-writing/privately-reporting-a-security-vulnerability

Bug Report

Description

When an exception is thrown in a request interceptor, that runtime exception bubbles up until the point that it is assumed (inside of of fuel code) to be a FuelError, is unsafe cast as one, and causes a runtime error at the failed cast.

To Reproduce

Simple code to recreate:

val manager = FuelManager().apply {
    basePath = "https://example.com"
    addRequestInterceptor { { throw RuntimeException("oops") } }
}

runBlocking {
    manager.get("/").awaitStringResult()
}

Will throw error:

class java.lang.RuntimeException cannot be cast to class com.github.kittinunf.fuel.core.FuelError (java.lang.RuntimeException is in module java.base of loader 'bootstrap'; com.github.kittinunf.fuel.core.FuelError is in unnamed module of loader 'app')

Instead of throwing the expected RuntimeException wrapped in a FuelError.

Expected behavior

All non-FuelErrors should be wrapped in a FuelError and be handleable as FuelErrors in the request would be, and not have the failed cast.

Screenshots

N/A

Environment

Development Machine

• OS: macos and linux
• IDE: IntelliJ (and running live outside of IDE)
• Fuel version: 2.3.1
• Kotlin version: 1.7.10

Smartphone or Emulator

N/A

Additional context

The error is right here: https://github.com/kittinunf/fuel/blob/105d3111d71623cb831af3f411ea253db766f369/fuel/src/main/kotlin/com/github/kittinunf/fuel/core/requests/SuspendableRequest.kt#L58

It seems as simple as changing this to:

.recover {
    if (it is FuelError) Result.Failure(it as FuelError)
    else Result.Failure(FuelError.wrap(it))
}

However I can't seem to get Fuel building locally because of "SDK location not found" at "build.gradle.kts:130" despite having the same JDK 11 set up that I use for everything else. So either feel free to crib that if it makes sense or any direction on how to set up a local build would be great and I'd put up a PR with a test immediately.

Thanks!