Describe the bug when i try to install package

Installing 1 other package using npm.
> npm install --save @maniac-tech/react-native-expo-read-sms
npm ERR! code ERESOLVE
npm ERR! ERESOLVE unable to resolve dependency tree
npm ERR!
npm ERR! While resolving: [email protected]
npm ERR! Found: [email protected]
npm ERR! node_modules/react-native
npm ERR!   react-native@"0.70.5" from the root project
npm ERR!
npm ERR! Could not resolve dependency:
npm ERR! peer react-native@"^0.41.2" from @maniac-tech/[email protected]
npm ERR! node_modules/@maniac-tech/react-native-expo-read-sms
npm ERR!   @maniac-tech/react-native-expo-read-sms@"*" from the root project
npm ERR!
npm ERR! Fix the upstream dependency conflict, or retry
npm ERR! this command with --force, or --legacy-peer-deps
npm ERR! to accept an incorrect (and potentially broken) dependency resolution.
npm ERR!
npm ERR! See C:\Users\kotsh\AppData\Local\npm-cache\eresolve-report.txt for a full report.

npm ERR! A complete log of this run can be found in:
npm ERR!     C:\Users\kotsh\AppData\Local\npm-cache\_logs\2022-11-20T12_45_23_492Z-debug.log

expo version "expo": "~47.0.6", "react": "18.1.0", "react-native": "0.70.5"

Describe the bug i'm using expo 45 built dev apk by eas build -p android --profile development installed on real device

App.js

import { StatusBar } from "expo-status-bar";
import { StyleSheet, Text, View } from "react-native";
import {
  startReadSMS,
  checkIfHasSMSPermission,
  requestReadSMSPermission,
} from "@maniac-tech/react-native-expo-read-sms";
import { useEffect } from "react";

export default function App() {
  useEffect(() => {
    if (checkIfHasSMSPermission) read();
    // requestReadSMSPermission();
    return () => {};
  }, []);

  async function read() {
    await startReadSMS(successCallbackFn);
  }
  async function successCallbackFn(status, sms, error) {
    console.log("successCallbackFn", status, sms, error);
  }

  return (
    <View style={styles.container}>
      <Text>Open up App.js to start working on your app!</Text>
      <StatusBar style="auto" />
    </View>
  );
}

const styles = StyleSheet.create({
  container: {
    flex: 1,
    backgroundColor: "#fff",
    alignItems: "center",
    justifyContent: "center",
  },
});

error i get

`new NativeEventEmitter()` was called with a non-null argument without the required `removeListeners` method.
at node_modules\expo\build\environment\react-native-logs.fx.js:18:22 in warn
at node_modules\react-native\Libraries\EventEmitter\NativeEventEmitter.js:67:20 in constructor
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:463:12 in __invokeCallback
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:125:27 in __guard$argument_0
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:368:10 in __guard   
at node_modules\react-native\Libraries\BatchedBridge\MessageQueue.js:124:16 in invokeCallbackAndReturnFlushedQueue

Description:

Can see the following errors when the startReadSMS function is called:

WARN  `new NativeEventEmitter()` was called with a non-null argument without the required `addListener` method.
WARN  `new NativeEventEmitter()` was called with a non-null argument without the required `removeListeners` method.

Description:

At the moment, we need to manually set READ_SMS and RECEIVE_SMS permissions in the app after installing the package.

This update handles this in two ways:

• Added these permissions to the AndroidManifest.xml
• Updated requestReadSMSPermission to ask the user for granting the permission via Android Native API

Description:

At the moment, we need to manually set READ_SMS and RECEIVE_SMS permissions in the app after installing the package, can we instead get them added to the library itself ?

Description:

We have hasPermissions which checks if we have the required SMS permissions in place.

Currently it is being used internally, but we wan it to be available outside the lib too.

Is your feature request related to a problem? Please describe. Not really a problem. Considering developer experience, the library API can be improved.

Describe the solution you'd like

With the fluent interface, the usage will look like this:

import smsReader from "react-native-expo-read-sms";

smsReader
  .withPermission()
  .onRead(sms => { 
    /* do something with SMS string */ 
    smsReader.stop()
  })
  .onFail(error => { 
    /* do something with error; maybe stop reading */ 
  })

Describe alternatives you've considered

Support for Config

See notes in context about supporting config that goes with auto stop mechanism. In that case, the signature of the interface changes:

smsReader() // without config
  .withPermission()
  .onRead(...)
  .onFail(...)

smsReader( { maxOnReads: 5, stopOnFail: false } )
  .withPermission()
  .onRead(...)
  .onFail(...)

Stop on failure

We can have implicit stop in case of failure so that the library user doesn't have to call stop inside onFail.

Additional context

• In the fluent interface, the function withPermission() will ask for permission if not given already. If the user denies the permission, onRead will not be called.
• As onRead and onFailure may be called multiple times, it's the user's responsibility to call stop whenever done. We can have an implicit limit on how many times onRead can be called. So that way even if the user forgets to call stop; we can stop listening whenever the counter completes. This counter mechanism can also allow (optional) configuration. Ideally that we can take as a param in the reader function: smsReader({ maxOnReads: 10 }). If the optional config is not provided, then the user will be smsReader()

Describe the bug The documentation states that requestReadSMSPermission returns a boolean which is not the case

To Reproduce Steps to reproduce the behavior:

1. call requestReadSMSPermission without passing explicit SMS permission in any app

Expected behavior It should return boolean

Screenshots N/A

Desktop (please complete the following information):

• Platform agnostic

Smartphone (please complete the following information):

• Platform agnostic

Additional context N/A

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like Add a simple Description in the read me

Describe alternatives you've considered N/A

Additional context N/A