Alright, so I took the liberty of doing most of this over the past couple of days, but finals are coming up, and if I don't submit this now I'll probably fail because I'll do no studying. I've outlined all the changes below. Let me know if you want to change any history because there are a lot of commits here.

What's here: An integration of ActionBarCompat with all activities using Gradle/Android Studio. I used ABC because it's finally mature enough to handle all this and it is likely what other apps will start using going forward. Plus, all the documentation is pretty much identical for both of them. Requisite cleanup of all layout files Recreation of most of the features that were present on the old Action Bar

What's missing/broken: Testing on pre-3.0 builds and real devices Styling of the dropdown menus from the overflow menu (this is done by setting DropDownListViewStyle in the themes) Styling the overflow icons appropriately. They show up blue when tapped. I'm not sure how to change this Integration with Eclipse builds For some reason the comment bubbles got huge with this. I think it is an issue with scaling, but I really couldn't lock it down.

Stuff that was lost: You can no longer tap the action bar to scroll you up to the top of a comments list. I think this is just theoretically incompatible with the way custom views are added. I think that implementing one of the suggestions here: http://cyrilmottier.com/2013/01/09/back-to-top-android-vs-ios/ will be a good way to make up for this.

Further thoughts: I'm not sure if having just the up arrow is the best way to go about things going forward, as it introduces some buginess with touch targets it seems. Maybe creating an icon and having a normal up arrow would be the way to go. As it stands now the app icon does a pretty bad job as a home icon though.

Anyway, I'll be around to support this however possible.

(Assuming this is not intended behavior.) Activities are restarted when changing device orientation on newer Android versions. #27 does not prevent this. It is probably caused by the screenSize configChange, which is also called on rotation.

You could probably fix this by easily adding "screenSize" to all the android:configChanges entries in AndroidManifest.xml:

android:configChanges="keyboardHidden|orientation|screenSize"

See http://stackoverflow.com/a/11631017 for further info.

I could not test this myself with your source because of various unrelated build errors I currently can´t fix, but with other projects, this worked well.

This PR has the intention of adding downvoting to the list of options for a user if that user can downvote. I was not able to fully test this because I don't have downvoting privileges. However, when using the html provided by @wting in Issue #43 and forcing his username the option did appear. Before merging this in it would probably be wise for someone who has downvoting privileges to pull my branch and run it to make sure everything is kosher.

That being said, given that the display shows up properly and the fact that the voting logic is pretty trivial I'm confident that this works.

Hi Manuel,

I've finished the work you started for handling external news.ycombinator.com urls for posts.

The solution isn't super clean, but it would have required a lot of refactoring otherwise which I'm not comfortable with in a codebase that's not mine.

Let me know what you think.

Cheers, Pascal

This is the pull request for the "pull down to refresh" feature discussed in #163.

Currently it is not ready for merging. This is just to help keep track of it!

This PR adds 'Search' functionality (#36) to the app and addresses the Load More issue, where the posts cannot be loaded more than once (#64). The second was fixed implicitly, as it was needed by the search implementation.

I'd love some feedback and review and hope you like it. I know, that some of the code styles are not in sync with the current style, but I guess this will be fixed, if the other PR gets merged, or if we settle on a style. If it is not ok, please let me know, what I can and should fix.

The Search uses the new API used by HN (https://hn.algolia.io/api).

I added a little button so that the user can open an article in their default browser. nothing major but I think it can be frustrating not being able to easily access the article in my own browser if I need to for some reason. It's just a little browser icon.

This is a fix for https://github.com/manmal/hn-android/issues/189.

This PR updates the project to use Android 32 and more recent Gradle version. I'm not an Android developer so it could probably use some more experienced eyes on it.

First and 3rd commit are upgrading Android SDK, Gradle and other dependencies. The code in app/build.gradle around building variants wasn't working so I removed it -- someone can probably comment whether it's necessary.

Second commit is to fix issues when parsing the HN feed. I'm not sure what changed in the markup but using class selectors instead of tag position selectors fixes the problem.

While the button to show comments now shows again, a new issue has turned up. Now I don't get any of the comments displayed. The comment page loads for a while but remains empty (same as when looking at comments for an article with zero comments). This broke around yesterday without the App receiving am update, so I assume the problem is due to a change in the data returned by news.ycombinator.com.

P.S: Sorry for the typos and bad formatting, I am currently on mobile.

Android Studio is awesome, and people should be able to develop using it. I just followed the migration guide from Android's website. I'm not positive which config files we want floating around, so I just followed what the Github Android app did.

Hi,

I was looking at issue #158 and decided to try and fix it. I found out that having an intent-filter exposes an activity externally even with exported=false. Removing them fixes the issue and everything still works as normal.

The second thing in this PR is removing HN from the 'share' menu. I noticed that it didn't work so I was going to try and fix it. However, I realised that it's probably not needed as the user can't actually post using this app (and any links they click on should be picked up by the VIEW intent and sent to the app anyway rather than using the SEND intent).

Update: Also added http links to the intent. Links on the actual website will be https but other links could be http (probably fixes #166).

Update: reverted a commit that introduced a small bug ("not valid" message shown when loading HN homepage from external link).

Let me know what you think :).

• As they are no more supported, removes outdated article readers such as

1. google gwt
2. view text

• makes https endpoint for instapaper provider as http are no longer supported.
• adds textize provider

This is a bug fix for the issue below: https://github.com/manmal/hn-android/issues/183

Please let me know if you need any changes to this pull request.

This bug occurs when opening particular links and it will continue to occur when opening the same link.

For example the link currently on the homepage with the following details:

Title: SoundCloud's Collapse

Link: https://www.buzzfeed.com/ryanmac/inside-the-storm-at-soundcloud

Screenshot: https://imgur.com/gallery/Q9lAU

This app sometimes drains the battery pretty hard, the culprit is probably an article that was not released once the activity has been put in background

Some screenshots for reference: