Bundel is a digital wellbeing Android app, helping you to focus by grouping up notifications and only releasing them in batches

I annotated the provideDatabase method with @Singleton annotation to avoid creating a new database instance for every injection. I also marked the DataRepository with @Singleton for similar reasons. Although DatabaseModule is installed in a singleton component, you still have to scope its bindings. See the following for more info: https://dagger.dev/hilt/components

I replaced the provide method with constructor injection to bind the DiskImagesStorage. However, one thing to note is that the ImagesStorage from DI is never used.

Describe the bug App crashing after giving access to notifications

To Reproduce Steps to reproduce the behavior:

1. Give permissions
2. Go back to the app

Expected behavior I would expect to reach the main screen.

Screenshots N.A.

Smartphone (please complete the following information):

• Device: S9
• OS: Android 10

Additional context

java.lang.NoSuchFieldError: No static field WEBP_LOSSLESS of type Landroid/graphics/Bitmap$CompressFormat; in class Landroid/graphics/Bitmap$CompressFormat; or its superclasses (declaration of 'android.graphics.Bitmap$CompressFormat' appears in /system/framework/framework.jar)
        at dev.sebastiano.bundel.storage.DiskImagesStorage$ImageFormat.<clinit>(DiskImagesStorage.kt:109)
        at dev.sebastiano.bundel.storage.DiskImagesStorage.getCachedImageFormat(DiskImagesStorage.kt:99)
        at dev.sebastiano.bundel.storage.DiskImagesStorage.getIconFile(DiskImagesStorage.kt:59)
        at dev.sebastiano.bundel.storage.DiskImagesStorage.saveIcon(DiskImagesStorage.kt:37)
        at dev.sebastiano.bundel.storage.DiskImagesStorage.saveIconsFrom(DiskImagesStorage.kt:24)
        at dev.sebastiano.bundel.storage.RobertoRepository.saveNotification(RobertoRepository.kt:15)
        at dev.sebastiano.bundel.storage.RobertoRepository$saveNotification$1.invokeSuspend(Unknown Source:15)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlinx.coroutines.DispatchedTask.run(DispatchedTask.kt:106)
        at kotlinx.coroutines.EventLoopImplBase.processNextEvent(EventLoop.common.kt:274)
        at kotlinx.coroutines.BlockingCoroutine.joinBlocking(Builders.kt:84)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking(Builders.kt:59)
        at kotlinx.coroutines.BuildersKt.runBlocking(Unknown Source:1)
        at kotlinx.coroutines.BuildersKt__BuildersKt.runBlocking$default(Builders.kt:38)
        at kotlinx.coroutines.BuildersKt.runBlocking$default(Unknown Source:1)
        at dev.sebastiano.bundel.notifications.BundelNotificationListenerService.onListenerConnected(BundelNotificationListenerService.kt:30)
        at android.service.notification.NotificationListenerService$MyHandler.handleMessage(NotificationListenerService.java:2076)
        at android.os.Handler.dispatchMessage(Handler.java:107)
        at android.os.Looper.loop(Looper.java:237)
        at android.app.ActivityThread.main(ActivityThread.java:8167)
        at java.lang.reflect.Method.invoke(Native Method)
        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:496)
        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1100)

Describe the bug App crashes on giving notification access

To Reproduce Steps to reproduce the behavior:

1. Open project in Android Studio.
2. Run it on Emulator API 29 or API 30
3. Give notification access to the app on device
4. App Crashes

Error via logcat:

2021-05-14 14:38:24.583 11014-11014/dev.sebastiano.bundel E/AndroidRuntime: FATAL EXCEPTION: main
    Process: dev.sebastiano.bundel, PID: 11014
    java.lang.RuntimeException: Tried to marshall a Parcel that contained Binder objects.
        at android.os.Parcel.nativeMarshall(Native Method)
        at android.os.Parcel.marshall(Parcel.java:552)
        at dev.sebastiano.bundel.storage.NotificationsCache.toByteArray(NotificationsCache.kt:53)
        at dev.sebastiano.bundel.storage.NotificationsCache.writeToFile(NotificationsCache.kt:44)
        at dev.sebastiano.bundel.storage.NotificationsCache.storeStatusBarNotification(NotificationsCache.kt:36)
        at dev.sebastiano.bundel.storage.RobertoRepository$saveNotification$2.invokeSuspend(RobertoRepository.kt:24)

Expected behavior To not crash

Add component selection rules rejecting any Kotlin version that does not match the version in the libs.version.toml file. The effect of this is that the Kotlin version will always require a manual version bump and will not be updated with ./gradlew versionCatalogUpdate, which is probably the safest since Compose is also tied to a specific Kotlin version.

For KSP any version that does not match the specified Kotlin version is rejected so that the KSP and Kotlin versions should always match.

Describe the bug The app crashes on startup with the following exception:

java.lang.NullPointerException: getString(context.contentResolver, "enabled_notification_listeners") must not be null
at dev.sebastiano.bundel.notifications.NotificationServiceHelpersKt.needsNotificationsPermission(NotificationServiceHelpers.kt:9)

To Reproduce I was able to get the app to start by making the following changes:

internal fun needsNotificationsPermission(context: Context): Boolean {
    val pkgName = context.packageName
    val enabledListeners = Settings.Secure.getString(context.contentResolver, "enabled_notification_listeners")
        ?.split(":")
    if (enabledListeners != null && enabledListeners.isEmpty()) return false

    return enabledListeners == null || enabledListeners
        .map { listenerPackageName -> ComponentName.unflattenFromString(listenerPackageName) }
        .none { pkgName == it?.packageName }
}

However, after the fix, I couldn't reproduce the error by simply uninstalling the app. I had to wipe the device data for the error to recur.

Desktop (please complete the following information):

• OS: Windows 10

Smartphone (please complete the following information):

• Device: Emulator
• OS: Android API 30

This adds a workflow to run ./gradlew versionCatalogUpdate and, if the catalog is updated, create a PR with the diffs. The workflow is scheduled to run once a week, and can be triggered manually too.

The heavy lifting is in the peter-evans/create-pull-request action that will manage creating and updating the PR when changes are detected. Because during the build gradlew is also changed, that change is reverted before creating the PR.

The PR does not give a comprehensive description of the changed dependencies, it merely produces a new branch and a diff. The created branch can be used to verify the dependency updates or do adjustments before merging, mainly serving as a reminder that updates are available.

The initial run will update the formatting of the catalog so that will be a bit noisy :)

The app requires a google-services.json to run; we need to document it and explain how users can generate it, and also how they can make do with the dummy one in build-config/ if they only need to run tests or static analysis.

• [x] Add basic dependency
• [x] Disable it by default
• [x] Provide the user with a way to enable it during the onboarding
• [ ] Provide the user with a way to disable/enable it in the Settings screen

Let's create a Settings screen to setup the navigation infrastructure in the app.

• [ ] Create a Settings screen
• [ ] Setup Navigation Components for Compose
• [ ] Add a button on Main screen to navigate to Settings