Hi @mrousavy ,

This is truly amazing work!!

I was trying the instructions to run it for my android device, on a windows machine, got the below error:

Was hoping if you too had any similar issue:

FAILURE: Build failed with an exception.

• Where: Build file 'C:\Usersxxxxxvision_camera\Colorwaver\android\app\build.gradle' line: 162

• What went wrong: A problem occurred evaluating project ':app'.

Could not get unknown property 'release' for SigningConfig container of type org.gradle.api.internal.FactoryNamedDomainObjectContainer.

• Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

• Get more help at https://help.gradle.org

BUILD FAILED in 2s

error Failed to install the app. Make sure you have the Android development environment set up: https://reactnative.dev/docs/environment-setup. Error: Command failed: gradlew.bat app:installDebug -PreactNativeDevServerPort=8081

FAILURE: Build failed with an exception.

• Where: Build file 'C:\Users\xxxxx\Colorwaver\android\app\build.gradle' line: 162

• What went wrong: A problem occurred evaluating project ':app'.

Could not get unknown property 'release' for SigningConfig container of type org.gradle.api.internal.FactoryNamedDomainObjectContainer.

• Try: Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output. Run with --scan to get full insights.

• Get more help at https://help.gradle.org

When I run react-native run-android this error pops up. My phone is connected through adb.

This is an amazing app and I would love to try it. Plz help me.

Hermes is way faster than JSC and more up to date.

• Faster JSI calls because Hermes does not do as many C++ thread-lock-operations as JSC
  • Means: Faster Frame Processor <-> FP Plugin calls, so faster color palette detection
  • Means: Faster UI Worklet <-> C++ calls, so faster and more efficient animations
• Even faster app startup time because Hermes uses bytecode and is optimized for fast app startup
• Overall faster JS execution
• More up to date as Hermes will become the default JS Engine for React Native soon.

Blockers

• [x] iOS doesn't build for me after enabling Hermes (<folly/folly-config.h> file not found or boost/operators.hpp file not found C++ errors, rising from either RNReanimated or VisionCamera.) (FIXED)
• [ ] ShareableValue::adapt causes a SIGABRT crash on Hermes (Tried to access a value backed by a different Runtime)
• [x] Hermes' garbage collector (Hades GC) runs on a separate Thread, so the jsi::HostObject destructor is called on a Thread that might not have a JNI Environment attached. This crashes on Android after a few seconds of running the Frame Processor. (FIXED)

This PR focuses mainly on the code split and cleanup, further PRs will include UI changes and new features.

Summary

• refactor and simplification of the code
• ColorTile component added
• Reanimated.TextInput "hax" removed in favor of react-native-animateable-text
• temporarily disabled Hermes on iOS to fix build issues (Folly header)

Preview/PoC that app is running

Beep boop. Your images are optimized!

Your image file size has been reduced by 22% 🎉

Black Lives Matter | 💰 donate | 🎓 learn | ✍🏾 sign

📝 docs | :octocat: repo | 🙋🏾 issues | 🏅 swag | 🏪 marketplace

Hi, i just read your comment from this topic: https://github.com/react-native-camera/react-native-camera/issues/2942#issuecomment-1004122038.

I think it's really good, I want to make some function like add effects into face while webrtc calling, can u provide some example? Thanks so much

I get this error when trying to compile using the command: npx react-native run-android --variant=release

In file included from ../../../../src/main/cpp/JSIJNIConversion.cpp:25: ../../../../src/main/cpp/java-bindings/JHashMap.h:16:8: error: redefinition of 'JHashMap' struct JHashMap : JavaClass<JHashMap<K, V>, JMap<K, V>> { ^ ../../../../build/fbjni-0.3.0-headers.jar\fbjni/detail/Iterator.h:170:8: note: previous definition is here struct JHashMap : JavaClass<JHashMap<K, V>, JMap<K, V>> { ^ 1 error generated.

When enabling Hermes on iOS, ShareableValue::adapt crashes with the error

Tried to clone a value backed by a different Runtime

This is a SIGABRT and unfortunately really hard to debug. So I have no idea what's causing this.

My animated color hook:

export function useAnimatedColor(
  color: Reanimated.SharedValue<string>,
): Readonly<Reanimated.SharedValue<string | number>> {
  const animation = useSharedValue(0);
  const colorFrom = useSharedValue(DEFAULT_COLOR);
  const colorTo = useSharedValue(color.value);

  useAnimatedReaction(
    () => color.value,
    (newColor, prevColor) => {
      animation.value = 0;
      colorFrom.value = prevColor ?? DEFAULT_COLOR;
      colorTo.value = newColor;
      animation.value = withTiming(1, {
        duration: 150,
        easing: Easing.linear,
      });
      console.log(`Animating from ${prevColor} -> ${newColor}`);
    },
  );

  // TODO: Using colorFrom and colorTo in here raises "Attempting to assign to readonly property" error...
  return useDerivedValue(() =>
    interpolateColor(animation.value, [0, 1], [colorFrom.value, colorTo.value]),
  );
}

is causing this error:

See https://github.com/software-mansion/react-native-reanimated/issues/2329 for more details.

Right now, I've hotfixed this by using a custom patch for react-native-reanimated that completely removes the RGB cache. This now runs correctly, but ideally I want to fix this and make use of the cache for performance reasons.

Creates a custom implementation of getColors to get the colors directly on the CVPixelBuffer we already stream, instead of converting CMSampleBuffer -> CVPixelBuffer -> CGImage -> UIImage every time.

This should make the Frame Processor Plugin a lot faster.

• Use optical/digital Video Stabilization Mode to minimize color flickering/rapid changes - depending on what's available.
• Use format that more closely matches the screen size instead of just choosing the highest one (optimizes performance)