First of all thanks for sharing this awesome project. It's been a great learning resource for me esp Rx and Dagger2 parts. I have learnt a lot form this project and also from Ribots mediums post.

I am trying to figure out how do I handle 401, 403 errors gracefuly

my Retrofit service is as below

@POST("user/login")
    Observable<Response<UserSignIn>> signIn(@Body Register signIn);

and my DataManager is as below

public Observable<Response<UserSignIn>> signIn(String emailId, String password) {
        return mService.signIn(new SatService.Register(emailId, password))
                .doOnNext(new Action1<Response<UserSignIn>>() {
                    @Override
                    public void call(Response<UserSignIn> response) {

                        //TODO: remove sensitive debug logs
                        Timber.d("status code: %s", response.code());
                        Timber.d("body: %s", response.body());
                        Timber.d("error body: %s", response.errorBody());
                        Timber.d("message: %s", response.message());

                        if(response.code() == 200) {
                            UserSignIn userSignIn = response.body();

                            mPreferencesHelper.putUserId(userSignIn.getUserId());
                            mPreferencesHelper.putAccessToken(userSignIn.getToken());
                            mPreferencesHelper.putExpires(userSignIn.getExpires());
                        } else if (responce.code == 403) {
                            // Handle this error gracefully and return some meaningful text which I can show it to the user on screen

                        } ...
                    }
                });
    }

As you can see I am returning Observable<Response<UserSignIn>> from DataManager to my Presenter and in my Presenter I am again doing if(response.code() == 200) { } which is redundant and feels wrong to me.

I think I should not pass Response to Presenter but should pass Observable

I thought of using map and flatMap, but again I am stuck up with what should go in else part?

mService.signIn(new SatService.Register(emailId, password))
            .map(new Func1<Response<UserSignIn>, UserSignIn>() {
            @Override
            public UserSignIn call(Response<UserSignIn> response) {

                if(response.code() == 200) {
                    return response.body();
                } else {
                   ** return ;** // what should I return here?
                }
            }
        });

Is there a better way to Handle this? Is this the case for EventBus?

Hi, I have been checking the code for "android-boilerplate" as template for new project, and this project "ribot-app-android" as sample implementation utilizing same project.

I really admire all the work done in "android-boilerplate" & I consider one of the best (If not the best) samples of complete typical Android application.

I have a question regarding these two projects trying to understand:

• In "ribot-app-android" there is dependency between ActivityComponent & ApplicationComponent but in "android-boilerplate" I don't find such relation but I find Subcomponent definition. May I know why?

Thanks in advance.

I am trying to implement the Findbugs in my project but It's not passing findbugs check. Here is the error log

The following errors occurred during analysis:
  File not found: filesystem:app/build/intermediates/classes
:app:findbugs FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':app:findbugs'.
> java.io.IOException: No files to analyze could be opened
* Try:
Run with --info or --debug option to get more log output.
* Exception is:
org.gradle.api.tasks.TaskExecutionException: Execution failed for task ':app:findbugs'.
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:84)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.execute(ExecuteActionsTaskExecuter.java:55)
	at org.gradle.api.internal.tasks.execution.SkipUpToDateTaskExecuter.execute(SkipUpToDateTaskExecuter.java:62)
	at org.gradle.api.internal.tasks.execution.ValidatingTaskExecuter.execute(ValidatingTaskExecuter.java:58)
	at org.gradle.api.internal.tasks.execution.SkipEmptySourceFilesTaskExecuter.execute(SkipEmptySourceFilesTaskExecuter.java:88)
	at org.gradle.api.internal.tasks.execution.ResolveTaskArtifactStateTaskExecuter.execute(ResolveTaskArtifactStateTaskExecuter.java:46)
	at org.gradle.api.internal.tasks.execution.SkipTaskWithNoActionsExecuter.execute(SkipTaskWithNoActionsExecuter.java:51)
	at org.gradle.api.internal.tasks.execution.SkipOnlyIfTaskExecuter.execute(SkipOnlyIfTaskExecuter.java:54)
	at org.gradle.api.internal.tasks.execution.ExecuteAtMostOnceTaskExecuter.execute(ExecuteAtMostOnceTaskExecuter.java:43)
	at org.gradle.api.internal.tasks.execution.CatchExceptionTaskExecuter.execute(CatchExceptionTaskExecuter.java:34)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:236)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker$1.execute(DefaultTaskGraphExecuter.java:228)
	at org.gradle.internal.Transformers$4.transform(Transformers.java:169)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:61)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:228)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter$EventFiringTaskWorker.execute(DefaultTaskGraphExecuter.java:215)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.processTask(AbstractTaskPlanExecutor.java:77)
	at org.gradle.execution.taskgraph.AbstractTaskPlanExecutor$TaskExecutorWorker.run(AbstractTaskPlanExecutor.java:58)
	at org.gradle.execution.taskgraph.ParallelTaskPlanExecutor.process(ParallelTaskPlanExecutor.java:50)
	at org.gradle.execution.taskgraph.DefaultTaskGraphExecuter.execute(DefaultTaskGraphExecuter.java:113)
	at org.gradle.execution.SelectedTaskExecutionAction.execute(SelectedTaskExecutionAction.java:37)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
	at org.gradle.execution.DefaultBuildExecuter.access$000(DefaultBuildExecuter.java:23)
	at org.gradle.execution.DefaultBuildExecuter$1.proceed(DefaultBuildExecuter.java:43)
	at org.gradle.execution.DryRunBuildExecutionAction.execute(DryRunBuildExecutionAction.java:32)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:37)
	at org.gradle.execution.DefaultBuildExecuter.execute(DefaultBuildExecuter.java:30)
	at org.gradle.initialization.DefaultGradleLauncher$3.execute(DefaultGradleLauncher.java:196)
	at org.gradle.initialization.DefaultGradleLauncher$3.execute(DefaultGradleLauncher.java:193)
	at org.gradle.internal.Transformers$4.transform(Transformers.java:169)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:106)
	at org.gradle.internal.progress.DefaultBuildOperationExecutor.run(DefaultBuildOperationExecutor.java:56)
	at org.gradle.initialization.DefaultGradleLauncher.doBuildStages(DefaultGradleLauncher.java:193)
	at org.gradle.initialization.DefaultGradleLauncher.doBuild(DefaultGradleLauncher.java:119)
	at org.gradle.initialization.DefaultGradleLauncher.run(DefaultGradleLauncher.java:102)
	at org.gradle.launcher.exec.GradleBuildController.run(GradleBuildController.java:71)
	at org.gradle.tooling.internal.provider.ExecuteBuildActionRunner.run(ExecuteBuildActionRunner.java:28)
	at org.gradle.launcher.exec.ChainingBuildActionRunner.run(ChainingBuildActionRunner.java:35)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:41)
	at org.gradle.launcher.exec.InProcessBuildActionExecuter.execute(InProcessBuildActionExecuter.java:26)
	at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:75)
	at org.gradle.tooling.internal.provider.ContinuousBuildActionExecuter.execute(ContinuousBuildActionExecuter.java:49)
	at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:44)
	at org.gradle.tooling.internal.provider.ServicesSetupBuildActionExecuter.execute(ServicesSetupBuildActionExecuter.java:29)
	at org.gradle.launcher.daemon.server.exec.ExecuteBuild.doBuild(ExecuteBuild.java:67)
	at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.WatchForDisconnection.execute(WatchForDisconnection.java:47)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.ResetDeprecationLogger.execute(ResetDeprecationLogger.java:26)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.RequestStopIfSingleUsedDaemon.execute(RequestStopIfSingleUsedDaemon.java:34)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:74)
	at org.gradle.launcher.daemon.server.exec.ForwardClientInput$2.call(ForwardClientInput.java:72)
	at org.gradle.util.Swapper.swap(Swapper.java:38)
	at org.gradle.launcher.daemon.server.exec.ForwardClientInput.execute(ForwardClientInput.java:72)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.LogAndCheckHealth.execute(LogAndCheckHealth.java:55)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.LogToClient.doBuild(LogToClient.java:60)
	at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.EstablishBuildEnvironment.doBuild(EstablishBuildEnvironment.java:72)
	at org.gradle.launcher.daemon.server.exec.BuildCommandOnly.execute(BuildCommandOnly.java:36)
	at org.gradle.launcher.daemon.server.api.DaemonCommandExecution.proceed(DaemonCommandExecution.java:120)
	at org.gradle.launcher.daemon.server.exec.StartBuildOrRespondWithBusy$1.run(StartBuildOrRespondWithBusy.java:50)
	at org.gradle.launcher.daemon.server.DaemonStateCoordinator$1.run(DaemonStateCoordinator.java:297)
	at org.gradle.internal.concurrent.ExecutorPolicy$CatchAndRecordFailures.onExecute(ExecutorPolicy.java:54)
	at org.gradle.internal.concurrent.StoppableExecutorImpl$1.run(StoppableExecutorImpl.java:40)
Caused by: org.gradle.api.UncheckedIOException: java.io.IOException: No files to analyze could be opened
	at org.gradle.internal.UncheckedException.throwAsUncheckedException(UncheckedException.java:43)
	at org.gradle.internal.reflect.JavaMethod.invoke(JavaMethod.java:76)
	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.doExecute(DefaultTaskClassInfoStore.java:141)
	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:134)
	at org.gradle.api.internal.project.taskfactory.DefaultTaskClassInfoStore$StandardTaskAction.execute(DefaultTaskClassInfoStore.java:123)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:632)
	at org.gradle.api.internal.AbstractTask$TaskActionWrapper.execute(AbstractTask.java:615)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeAction(ExecuteActionsTaskExecuter.java:95)
	at org.gradle.api.internal.tasks.execution.ExecuteActionsTaskExecuter.executeActions(ExecuteActionsTaskExecuter.java:76)
	... 70 more
Caused by: java.io.IOException: No files to analyze could be opened
	at edu.umd.cs.findbugs.FindBugs2.execute(FindBugs2.java:276)
	at org.gradle.api.plugins.quality.internal.findbugs.FindBugsExecuter.runFindbugs(FindBugsExecuter.java:39)
	at org.gradle.process.internal.worker.request.WorkerAction.run(WorkerAction.java:87)
	at org.gradle.process.internal.worker.request.WorkerAction.runThenStop(WorkerAction.java:71)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:35)
	at org.gradle.internal.dispatch.ReflectionDispatch.dispatch(ReflectionDispatch.java:24)
	at org.gradle.internal.remote.internal.hub.MessageHub$Handler.run(MessageHub.java:377)
	... 2 more
BUILD FAILED

What is the use of this line if (subscriber.isUnsubscribed()) return;

in below code.

  public Observable<Ribot> setRibots(final Collection<Ribot> newRibots) {
        return Observable.create(new Observable.OnSubscribe<Ribot>() {
            @Override
            public void call(Subscriber<? super Ribot> subscriber) {
                if (subscriber.isUnsubscribed()) return;
                BriteDatabase.Transaction transaction = mDb.newTransaction();
                try {
                    mDb.delete(Db.RibotProfileTable.TABLE_NAME, null);
                    for (Ribot ribot : newRibots) {
                        long result = mDb.insert(Db.RibotProfileTable.TABLE_NAME,
                                Db.RibotProfileTable.toContentValues(ribot.profile()),
                                SQLiteDatabase.CONFLICT_REPLACE);
                        if (result >= 0) subscriber.onNext(ribot);
                    }
                    transaction.markSuccessful();
                    subscriber.onCompleted();
                } finally {
                    transaction.end();
                }
            }
        });
    }

Is it necessary to use it ??

Hi, I am little confused about the subscription.

  if (mSubscription != null) mSubscription.unsubscribe();

In my case, I am making two retrofit calls one by one.

 @Override
    public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    rootView = inflater.inflate(R.layout.fragmen, null);

    loadClientTemplate();
    loadOffices();
    retrun rootView;
}

My Presenter Methods are

public void loadClientTemplate() {
checkViewAttached();
        getMvpView().showProgressbar(true);
        mSubscription = mDataManager.getClientTemplate()
                .observeOn(AndroidSchedulers.mainThread())
                .subscribeOn(Schedulers.io())
                .subscribe(new Subscriber<ClientsTemplate>() {
                    @Override
                    public void onCompleted() {
                        getMvpView().showProgressbar(false);
                    }

                    @Override
                    public void onError(Throwable e) {
                        getMvpView().showProgressbar(false);
                        getMvpView().showFetchingError("Failed to fetch clientTemplate");
                    }

                    @Override
                    public void onNext(ClientsTemplate clientsTemplate) {
                        getMvpView().showProgressbar(false);
                        getMvpView().showClientTemplate(clientsTemplate);
                    }
                });
    }

public void loadOffices() {
        checkViewAttached();
        getMvpView().showProgressbar(true);
        mSubscription = mDataManager.getOffices()
                .observeOn(AndroidSchedulers.mainThread())
                .subscribeOn(Schedulers.io())
                .subscribe(new Subscriber<List<Office>>() {
                    @Override
                    public void onCompleted() {
                        getMvpView().showProgressbar(false);
                    }

                    @Override
                    public void onError(Throwable e) {
                        getMvpView().showProgressbar(false);
                        getMvpView().showFetchingError("Failed to load offices list");
                    }

                    @Override
                    public void onNext(List<Office> offices) {
                        getMvpView().showProgressbar(false);
                        getMvpView().showOffices(offices);
                    }
                });
    }

Yes, I understand the logic for unsubscribing the Subscription. As first call is completed and when next call will come unsubscribe the subscription and subscribe to subscription again.

but here I am making both calls simultaneously, So I can not use.

  if (mSubscription != null) mSubscription.unsubscribe();

At last here, subscription will have two Observables.

can I have to unsubscribe all, at last of the calls completions ?

Hi, I am doing my GSoC project https://github.com/therajanmaurya/android-client-2.0 in which I am using RxJava 2 and handling rest API calls. Initially, a user logged in and get an access token, I don’t know when this access token will expire so I want to implement a logic that will call, whenever I will get 401 error, that should fire a request to the server to refresh the access token and try the current request again. I don’t want check 401 in every request-response. I want to implement this in such a way that I don’t need to check 401 response code in every rest API call, if any request code is 401 then it will automatically make another request to refresh the access token and try the current request again.

Hey Thanks for a great app and architecture.

Do you plan to make updates to the boilerplate project ? (like RxJava, BuildTools, Google Services , etc) ?

Thanks.

Hi ! Just curious: Is it right that the app somehow forget that it sent a sign-in request if the user turn the screen of the device after pushing the button ? The http request get cancelled and loading sign get removed.

How is your way to handle this when the current state (loading) can barely get stored in DB ?

ah, now i see that looks messy because I didn't have my environment with the keys and didn't want to configure it. But you can do it manually if you want.

1. Modify your gradle file to

   compile 'com.squareup.retrofit2:retrofit:2.0.0-beta3' compile "com.squareup.retrofit2:converter-gson:2.0.0-beta3" compile "com.squareup.retrofit2:adapter-rxjava:2.0.0-beta3" compile 'com.squareup.okhttp3:logging-interceptor:3.0.1'

create a builder

  OkHttpClient.Builder builder = new OkHttpClient().newBuilder();
  builder.readTimeout(10, TimeUnit.SECONDS);
  builder.connectTimeout(5, TimeUnit.SECONDS);

and add interceptors to it.

this is all :)

In My project, I have managed all strings in strings.xml and thinking to add also Presenter String message into strings.xml but I think Presenter does deal with Context.

Is it good to use Context in Presenter.

I have noticed that throughout the whole project and as an example in the PreferencesHelper.class you are using the Observable.create method without checking for isSubscribed. It is maybe not a problem in your exact usage pattern but as suggested from reowned Android Devs the usage of Observable.create should be avoided for various reasons. I think you can replace the Observable.create in most places with either Observable.just or Observable.fromCallable. There you get most of the thinks required from the Observable contract for free.

As this question Implementing MVP in Android app described, DataManager is a big concern if I am gonna take the architecture applied in ribot.

It's a simple fact that DataManager will grow as the business grows. The ribot android app is just a small demo project and we already have a medium size DataManager here. How would you deal with the problem if the DataManager grows too big?