Yesterday I became root on my phone so I torified all my apps, including RedReader Beta, often I get an error telling me that I'm not allowed to do whatever I'm doing. When I see the details, looks like it's 403.

This is very weird because I've entered into Reddit tons of times on the desktop TOR browser and I never got this error.

Enums are generally not recommended by Google so I changed (some of) the enums to IntDefs instead. I also have no idea as to why the previous pull requests are showing up as well.

With 1.14 it now always prompts where to save pictures and videos, can we set a default folder to save in? And a checkbox to have the prompt to save a different folder? Thank you for your hard work!

Just trying to work on the project in Eclipse, and if it were possible to move the code out of main.java.* so it is simply org.quantambadger.* would negate thousands (7000+) of errors in Eclipse. I can make a pull request if you would like.

Edit: I have done this locally, but there are still an insane amount of errors. What do you use to code it, and for error checking, as it is simply not working in Eclipse with all the missing dependencies from holoeverywhere, etc

Hello! Hope you don't mind rather large pull requests. I grouped them according to changes.

1st commit

• Update gradle wrapper to 6.5 using git bash
• (Also clean up duplicates in .gitignore.)

2nd commit

• Update Roboto font to 2.138 (from https://github.com/googlefonts/roboto/releases)

3rd commit

• Move version name and code from manifest to gradle
• Group support libraries from third-party ones

4th commit

• Reformat build.gradle, travis, and pmd rules to the .editorconfig

5th commit

• Update Android Studio 3.5.3 -> 4.0.0 (changelog)
• Update Jackson 2.10.0 -> 2.11.0 (changelog)
• Update Commons Lang 3.9 -> 3.10 (changelog)
• Update Joda Time 2.10.5 -> 2.10.6 (changelog)
• Update OkHttp 3.12.8 -> 3.12.12 (changelog)
• Update buildTools 29.0.2 -> 29.0.3
• Update PMD 5.6.0 -> 5.8.1 (changelog)

6th commit

• Migrate to AndroidX (adds on almost 0.5 MB to the APK for whatever reason, mostly bloat)
• On top of initial AndroidX versions:
  • Update AndroidX AppCompat 1.0.0 -> 1.1.0 (changelog)
  • Update AndroidX RecyclerView 1.0.0 -> 1.1.0 (changelog)
  • Update Google Material 1.0.0 -> 1.1.0 (changelog)

7th commit

• Leave out all of META-INF, it's all useless

8th commit

• Fix some deprecations (drops total number identified by lint from 51 to 6, yay!)

I keep getting an 'Unexpected Storage Error' - even after uninstalling. I have still enough free memory, though.

Phone is Xiaomi Mi4. OS is 6.0.1 (CM13-20160909).

An unknown internal error has occurred, related to the cache storage. You are probably running out of space. Exception: java.io.FileNotFoundException/storage/emulated/0/Android/data/org.quantumbadger.redreader/cache/5db91f67-2bdc-43b7-9437-935d014f1e21.rr_cache_data_tmp: open failed: EACCES (Permission denied) libcore.io.IoBridge.open(IoBridge.java:452) java.io.FileOutputStream.<init>(FileOutputStream.java:87) java.io.FileOutputStream.<init>(FileOutputStream.java:72) org.quantumbadger.redreader.cache.CacheManager$WritableCacheFile.<init>(CacheManager.java:203) org.quantumbadger.redreader.cache.CacheManager$WritableCacheFile.<init>(CacheManager.java:191) org.quantumbadger.redreader.cache.CacheManager.openNewCacheFile(CacheManager.java:276) org.quantumbadger.redreader.cache.CacheDownload$2.onSuccess(CacheDownload.java:160) org.quantumbadger.redreader.http.okhttp.OKHTTPBackend$1.executeInThisThread(OKHTTPBackend.java:134) org.quantumbadger.redreader.cache.CacheDownload.performDownload(CacheDownload.java:143) org.quantumbadger.redreader.cache.CacheDownload.doDownload(CacheDownload.java:90) org.quantumbadger.redreader.cache.CacheDownloadThread.run(CacheDownloadThread.java:36)Caused by: Exception: android.system.ErrnoExceptionopen failed: EACCES (Permission denied) libcore.io.Posix.open(Native Method) libcore.io.BlockGuardOs.open(BlockGuardOs.java:186) libcore.io.IoBridge.open(IoBridge.java:438) java.io.FileOutputStream.<init>(FileOutputStream.java:87) java.io.FileOutputStream.<init>(FileOutputStream.java:72) org.quantumbadger.redreader.cache.CacheManager$WritableCacheFile.<init>(CacheManager.java:203) org.quantumbadger.redreader.cache.CacheManager$WritableCacheFile.<init>(CacheManager.java:191) org.quantumbadger.redreader.cache.CacheManager.openNewCacheFile(CacheManager.java:276) org.quantumbadger.redreader.cache.CacheDownload$2.onSuccess(CacheDownload.java:160) org.quantumbadger.redreader.http.okhttp.OKHTTPBackend$1.executeInThisThread(OKHTTPBackend.java:134) org.quantumbadger.redreader.cache.CacheDownload.performDownload(CacheDownload.java:143) org.quantumbadger.redreader.cache.CacheDownload.doDownload(CacheDownload.java:90) org.quantumbadger.redreader.cache.CacheDownloadThread.run(CacheDownloadThread.java:36)

This addresses issue #162.

In the onCreate function of MainActivity, I added a call to create an Android alarm that triggers every hour.

I created a BroadcastReceiver that receives the alarm and checks for new messages on Reddit. Once it receives them, it parses the received messages and compares the newest message to the newest message from the previous check (which is saved in system preferences storage). If the new one is different, then the user has received a new message and a notification is broadcast to the user.

When the user taps this notification, it starts the app and there is a check in MainActivity of the Intent created by the activity to find out whether it is from a new message notification. If so, the inbox is opened for the user to view the new message they received.

Finally, I added a setting to enable/disable notifications, and I used Google Translate to provide translations of the setting's name.

Perhaps migrating to gradle would benefit this project, proguard and signing as well as dependencies are some benefits I'd name offhand. I could look into this if there's any interest?

Notifications haven't worked for me for a while now, but I didn't find a bug report about it yet. There is a thread on Reddit about it from a while back: https://www.reddit.com/r/RedReader/comments/ai1b8v/i_dont_get_notifications_i_used_to_but_not_now/

I'm using a Nokia 8 Plus with Android 9, in case that helps.

I noticed that searches would not include nsfw results, even if show nsfw content was enabled. This seems to be due to an undocumented API change requiring a cookie for searches to return nsfw results. I've implemented this with the okhttp backend. I have also updated the SDK version to 27.

I am guessing this has something to do with this: https://github.com/QuantumBadger/RedReader/commit/adc377d8e76ab655e5561afaf3e3e0b4bbefe73f

After cleaning the app settings the views work now, but obviously I don't want to to that since I have a lot of tweaked settings, after restoring the settings backup from Titanium Backup the crush still happens.

Hi I know there are lots of unofficial reddit client that use reddit push from official reddit app for faster real-time notification. What do you think?

For some reason when searching, every janky disgusting subreddit with a small amount of subscribers appears before larger, more mainstream subs.

Example: r/Publicfreakout, an extremely popular, mostly SFW sub.

Type P and U you get "pussybforeandafter" with 73k subscribers and "publicsexporn" with 700k subscribers. Next "Publicfucking" with 300k viewers.

You have to pretty much spell out the entire "PublicFreakout" to get the more SFW subreddit with 4 MILLION subscribers.

An adjustment to the subreddit algorithm would be much appreciated.

If a post is given in Markdown with a pre-formatted block (e.g. one bounded by lines of ```), then line break characters in the block should be rendered literally, as line breaks, not collapsed into inter-word space.

In the case of comments, RedReader displays such blocks correctly.

However, in the case of posts, line breaks are incorrect collapsed.

Tests are given for version 1.2, running on LineageOS for microG, version 19 build timestamp 2012 Nov 02.

Subreddit emotes are those :xxxx: (Where x is a single digit number) things you see in the comment sections of some subreddits. They're pretty niche and not supported by any reddit app except the official one as far as I know. They're used frequently in r/xqcow so you can take a look there if you want to test this out.

This is the first android project I've worked on so I might've made some dumb design decisions in my code. If you want me to change something, I'd be happy to give it a try.

Right now there is no way to do so. at least not if you aren't logged in with an account. If user wishes to save a thread for later/archive purposes it is not possible and finding the thread again, if possible, is a nightmare. Can we have an option like a star symbol to save specific threads?

If i follow links to i.imgur.com when the 'video> use external player'option is enabled, and 'photos>internal viewer' enabled, vlc isn't opening for videos hosted there, i get the openGL rendered still thumbnail image.

When accessing the link to imgur's horrific site in a chromium based browser, the video [mp4 if the longclick-download option is anything to go on] plays just fine.

I'll accept 'imgur made 3rd party access impossible' as an answer. They've historically been enemies of an open Internet.