It would be great if the new reactions in the web version of GitHub would be also visible in the app for comments, issues and pull requests. Also it would be awesome to be able to set reactions, too.

Newly introduced :

• rxJava2
• rxAndroid
• retrolambda

removed classes :

• FillReadmeTask
• ReadmeLoader

FillReadmeTask has been replaced by asynchronous operation concatenation from flatMap operator (rxJava2) while ReadmeLoader has been removed in favour of RepositoryService.

The newly created service package is meant to gather Service classes, each one wrapping data loading logic that is currently contained into Loaders. This would have the advantage of reducing the number of Loader and AsyncTask classes used, plus it would group asynchronous data fetch processes by Fragment, instead of by Data.

This would make the program logic easier to follow in my opinion, since background services populating the view would be all declared in one Service class, instead of multiple Loader and AsyncTask classes.

This fixes the downloads of downloads and zipballs as well as this NPE:

java.lang.NullPointerException at com.gh4a.activities.RepositoryActivity.onOptionsItemSelected(RepositoryActivity.java:405) at android.support.v4.app.Watson.onMenuItemSelected(Watson.java:119) at com.actionbarsherlock.ActionBarSherlock.callbackOptionsItemSelected(ActionBarSherlock.java:603) at com.actionbarsherlock.internal.ActionBarSherlockNative.dispatchOptionsItemSelected(ActionBarSherlockNative.java:78) at com.actionbarsherlock.app.SherlockFragmentActivity.onMenuItemSelected(SherlockFragmentActivity.java:205) at com.android.internal.policy.impl.PhoneWindow.onMenuItemSelected(PhoneWindow.java:1012) at com.android.internal.view.menu.MenuBuilder.dispatchMenuItemSelected(MenuBuilder.java:735) at com.android.internal.view.menu.MenuItemImpl.invoke(MenuItemImpl.java:152) [...]

Heavy work in progress. Created to make it easy for myself to list tasks and share updates.

Tasks

:white_check_mark: Step 1 - Behavior

:white_check_mark: Review Comments screen

• [x] ~~Redirect to correct commit or pull request changes when clicking on diff hunk file~~
  • Apparently, to display diffs for outdated comments we need to load multiple commits and combine the output. This means that support for this is not something for this pull request. The current solution is just to disable clicking on outdated files.
• [x] ~~Figure out how many diff lines to display~~
  • I don't really see a way how to determine this. 4 lines work nicely for now
• [x] ~~Figure out when to display hunk header in diffs (@@ line)~~
  • These are displayed when they are located directly above the first visible line. For now, I'm just going to not display them at all.
• [x] Add option to enter file with selected comment highlighted
• [x] Fix sorting issues
  • Most probably the sort order is first by filename, then by line number.
• [x] Toolbar actions
  • [x] Share
  • [x] Open in browser
• [x] Make line numbers clickable for sharing
• [x] Replying
  • [x] Figure out when to disable reply buttons (They are not always available)
    • If review comment is a reply to someone else's comment and was submitted together with other comments then it's displayed without reply button. Right now the app doesn't display it at all so I'll have to fix that. It's a bit confusing but better let's stay consistent :)
  • [x] Add replying dialog
  • [x] Refresh review after replying
• [x] Comment actions
  • [x] Edit
  • [x] Delete

:white_check_mark: Reviews

• [x] Add indicator showing that all comments in review are outdated
• [x] Correctly load pending reviews and their comments
• [x] Add options menu
  • [x] ~~Edit (if has body text)~~
    • Couldn't find a way to edit reviews with API
  • [x] Share
• [x] ~~Add view changes button (figure out how exactly it works)~~
  • Similar to viewing files for outdated comments this would require loading and combining diff from multiple commits.
• [x] Add quoting for reviews with body

:white_check_mark: Link handling

• [x] Handle #pullrequestreview-<id> links
• [x] Handle #discussion_r<id> links
• [x] Handle #discussion-diff-<id><line id> links

Step 2 - User Interface

General

• [x] Test with dark theme

Review Comments screen

• [x] Make text in diff hunks selectable
• [x] Improve appearance of file headers
• [x] Make outdated hunks indicator easier to distinguish
• [x] Add spacing/dividers between hunks?

Reviews

• [x] Improve show details button, should it be so big?
• [x] Improve review details text (right now hard to see when if it's a body or summary)
• [x] Improve indicator for all outdated comments
• [x] Add correct review type icons (approved, requested changes, etc)

Step 3 - Cleanup

• [x] Extract all strings

This is 1st pull request implementing reviews support. It's focused on displaying them and replying to comment. Next pull requests will deal with creating new reviews, requesting reviewers etc.

#391

When entering the body text for a new issue, or a comment on an existing issue, we only have space (depending on device) for about four lines of text. Even though we can scroll within that, it's very cramped.

When clicking the edit button next to an existing comment, we get a much larger text editor to work in. It would good to be able to somehow use such an editor when first creating issues or comments.

If Octodroid/GH4A could have Material design implemented, that would be awesome, especially as the overall design style makes the usage of apps cleaner and easier.

Work in progress.

Still thinking about this but I tink I have a basic implementation idea. I want it to look similar to the event cards in "News Feed" but since each notification is a different item I'll have to do it a bit differently.

1. When the notification in a holder is null then we'll render a header with repository name and a button to mark all notifications from that repo as read. It should also have standing out background and a top shadow to replicate the card look.

2. When the notification is not null then we'll render a notification. This will have a card background and some more notification specific stuff on it. Not sure exactly how I'll make this one look like.

3. When the notification is set to be the last one it'll also render the bottom shadow which will, in turn, look like all the notifications and header were located on a single card.

You can get a basic idea of how the grouping will work if you open the app and check the log.

We'll see how it'll turn out once I get some more time to finish this. Let me know if you have any suggestions or questions.

Closes #175.

Implemented using https://github.com/evernote/android-job for backward compatibility without the need to have Google Play Services.

• Each GitHub notifications gets its own notification and all of them are bundled together (Not sure how it works on older API, need to test that)
• There is a setting to toggle them, which I have set to be disabled by default
• There is a setting to change synchronization interval ranging from 15min (lowest possible value) to 6 hours (can add higher values)
• Clicking on notification opens its corresponding screen and automatically dismisses it from notification drawer
• All notifications belong to a single channel on Android O so users can customize here a priority, sound, vibration, etc.

Potential improvements:

• Auto-mark as read when clicking on notifications (could be controlled by setting)
• Button to manually mark as read (unsubscribe?)
• Include launcher badges (I plan to create a separate pull request for that once this one is merged)
• Better icon. I've used the launcher icon but it would be nice if someone could create a vector drawable with a similar shape. @slapperwan perhaps you still have contact with the guy that made the launcher icon (Would be also nice to create adaptive icon)
• Display icon of repository owner on each notification. (@maniac103 I'm not sure myself how to make it work well. We need something to load a Bitmap and the loading must finish before Job finishes.)
• Support notifications for multiple accounts
• Handle logged-out case (do not check for notifications when logged out, stop job when logging out)

Closes #42

OctoDroid's old pure black theme, simple and clean, now gone, should be kept as a third alternative.

I believe I'm not the only one who can't stand the new Material Design dark theme, and although I appreciate the effort to modernize app's appearance but for some things like git the oldschool black terminal look is natural. Currently I've reverted to 3.7.2, which is perfect for me, and disabled updates.

• black

  • OPEN status is immediately visible
  • header is small and unobtrusive
  • subject (title) is emphasized
  • overall: content is dominating

  

• Material Dark

  • OPEN status is practically lost
  • header is huge, bright and dominating
  • header labels are wrapped in a broken way
  • subject (title) isn't the most readable thing in the header, so it looks unstructured
  • avatar is tinted
  • overall: appearance is prioritized, content is subdued, which isn't what Material Design is about, actually.

  

It should be really useful to add a panel with GitHub notifications, near the news feed. The API seems simple to use: https://developer.github.com/v3/activity/notifications/

In a second round, it can help to solve #42.

Octodriod v4.4.0 OS version : Android 8.1.0

There seems to be a problem with the counters of stars, followers, gist... that we can find in "about" tabs (counters on repositories list are ok)

When counters equals 0 on github, Octodroid set them at 1 For a fresh new project : issue, PR, fork, stars & watcher are at 1

I tried to star one of my projects : counter is correctly updated in repositories list but it stays at 1 in "about" tab (and this time, it is correct).

I saw this issue on directory "about" & user "about" tabs.

This small PR puts together a few fixes for some minor bugs I found in the Notifications screen:

• tapping on the repository name accidentally marks all notifications as read (#1255)
• unsubscribing from a notification thread marks the notification as read in the UI, however this isn't done on the server side: after refreshing the screen the notification is still displayed as unread (#1258). To address this, I've decided to display a toast to let the user know that the unsubscription was successful, without marking the notification as read.
• if a notification has already been read, avoid calling the API to mark it as read again when the user taps on it. This prevents useless API calls and works around a weird side-effect (maybe a bug?) of the GH API endpoint, which marks a notification as read but also unexpectedly moves it to Inbox if it was marked as done.

Fixes #1255 Fixes #1258

Hello,

It would be nice to be able to copy usernames, either by making those selectable, or by adding the option anywhere possible, especially in issue/PR comments and user profile.

Thanks

This PR adds support for review_dismissed events in the pull request timeline.

The implementation lacks two things compared to the GitHub UI:

• the user who made the dismissed review (GH UI says "X dismissed Y's stale review"), because objects returned by the API don't contain that piece of information
• the dismissal message, which can be optionally set when the review is dismissed manually. I honestly didn't feel like changing the layout to add that detail, which isn't used most of the time in my experience.

I've also tweaked the message that gets displayed when a review is dismissed: now it says "previously reviewed" instead of just "reviewed", so that at least users can see at a glance which reviews are dismissed. (It would be nice to show "previously approved/requested changes" like the GitHub UI, but again the API doesn't provide that piece of information :/)

While doing some tests on Lollipop, I've noticed that for some strange reason when the night theme is enabled in settings, the navigation icon in the app bar is red instead of white.

It doesn't seem to be a recent regression, since the bug was present even at commit 4a620a9b (yes, I've randomly checked out a random old commit and gave it a try).

It is also worth noting the missing margin for the dropdown arrow in the top right corner (it's too close to the profile picture, compared to recent Android versions).