This is a solution to the limitation that otto only processes methods of the immediate type, disregarding any annotated super methods. This topic has been discussed here.

This pull request adds an annotation to the public API of otto which allows the user to explicitly declare classes for which otto should check super classes for annotations (producers/subscribers).

Credits for the original implementation of this pull request go to @deadfalkon.

Otto is a very good library. But when I passed Proguard packaged into APK, data thread transmission failure, I have to follow the instructions to -keepclassmembers class * * { @com.squareup.otto.Subscribe public *; @com.squareup.otto.Produce public *; } Otto demo, the project is, click the button no reaction. Look forward to solve as soon as possible.

DO NOT MERGE

This pretty fundamentally changes how the event bus behaves with regard to registration and unregistration.

There is now a concept of a Finder<T> whose job is to locate the @Subscribe and @Produce-annotated methods on instances of T. The annotation processor generates finders for each type which perform the installation and uninstallation of subscribers and producers onto the bus.

A Subscriber<T> is an interface which represents something that can accept an event of type T. A Producer<T> is an interface which represents something that can produce a new event of type T. The annotation processor's code for the Finder<T> calls generated Subscriber and Producer classes which call real methods on the finder's T type.

Since we cannot guarantee the precense of annotation-generated classes at runtime, a reflection implementation is provided as a fallback which behaves exactly as the v1.x Otto Bus does.

TODO

• [ ] Evaluate better invalidation for the unregistration inside of a handler case.
• [ ] Fix unregistration in a handler/producer tests.
• [ ] Write integration tests using the Dagger framework.

Probably a lot more...

I tried using dagger with AndroidAnnotations within activities. The problem is that AndroidAnnotations creates a subclass of my activity. When you look for annotated subscribers in com.squareup.otto.AnnotatedHandlerFinder#loadAnnotatedMethods you use listenerClass.getDeclaredMethods() This does not return the methods from the super-class. So I can not receive messages if I create a subclass of the class that contains subscribe methods. I got around this by registering an anonymous class with an annotated method. Not sure if you want to support this, just mentioned it. Thanks, Gabi

Hi, I am using Otto on my application. It works well.

I would be interested in refreshing the screen from an event in an intentservice (which has its own thread).

For that, I am trying to use Otto with ThreadEnforcer.ANY

But I got the same exception that I would obtain if I would call the view directly from the intentService (means other that the main thread). Is there a way in Otto to "redirect" easily the event from the IntentService to the Main thread ??? I just want to know when to do it.

Thank you

Michael

Already registered my activity at onResume() but still running into this exception when I un-register it at onPause(). However, I'd like to suggest better error handling. If the object is really not registered, why don't Bus just ignore it when there is a call to un-register, instead of throwing an exception and crash the app?

Caused by: java.lang.IllegalArgumentException: Missing event handler for an annotated method. Is class com.company.activity.MyActivity registered? at com.squareup.otto.Bus.unregister(Bus.java:288) at com.company.activity.MyActivity.onPause(SingleTripResultActivity.java:231) at android.app.Activity.performPause(Activity.java:5493) at android.app.Instrumentation.callActivityOnPause(Instrumentation.java:1251) at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3171) at android.app.ActivityThread.performPauseActivity(ActivityThread.java:3140) at android.app.ActivityThread.handlePauseActivity(ActivityThread.java:3118) at android.app.ActivityThread.access$1000(ActivityThread.java:157) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1258) at android.os.Handler.dispatchMessage(Handler.java:102) at android.os.Looper.loop(Looper.java:157) at android.app.ActivityThread.main(ActivityThread.java:5293) at java.lang.reflect.Method.invokeNative(Method.java) at java.lang.reflect.Method.invoke(Method.java:515) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:1265) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1081) at dalvik.system.NativeStart.main(NativeStart.java)

This should allow for some more interesting event hierarchies.

Code should compile and run with mvn clean verify, although I was unable to test the otto-sample stuff, because I didn't want to install Maven 3.1.1 (which the android-maven-plugin requires).

There is a problem using https://github.com/excilys/androidannotations with Otto. When we pass this to Otto, it can see generated by AA class, which doesn't have any @Subscribe and @Produce annotations. The first solution is to wrap all annotated methods on ClassA_ in the AndroidAnnotations project, something like this:

@EActivity
class ClassActivity{
  @Subscribe public void onMyEvent(Event event){
    //...
  }
}

Generated class could be:

class ClassActivity_{
  @Subscribe public void onMyEvent_(Event event){
    onMyEvent(event);  
  }
}

We use wrappers for methods to call this.onMyEvent which could be overriden in ClassActivity_

But it is rather complicated to generate lots of code. The easiest way is to modify Otto a bit. We assume, that ClassA_ is generated by AA from ClassA.

See issue https://github.com/square/otto/issues/148 .

This change makes the static producer/subscriber hashmaps thread safe.

Note, there may be other parts that aren't thread safe but this covers what we've seen to be the most common issue.

I have a parent activity that contains a @Subscribe method. When I try to register the parent using bus.register(this), the AnnotatedHandlerFinder finds all @Subscribe methods in the child class, not in the parent.

That's because: AnnotatedHandlerFinder.findAllSubscribers() take the class of the instance and not the parent.

A solution would be to add a new method bus.register(this, listenerClass), where listenerClassis the type of the parent object?

In the samples I register and unregister on Bus in the onResume() and onPause() callbacks. But how do I use Otto in plain Java Objects? (no Activity, Fragment and so on). In plain Java Objects I can register in the constructor but where I have to unregister?

at com.squareup.otto.Bus.throwRuntimeException(Bus.java:460) at com.squareup.otto.Bus.dispatch(Bus.java:387) at com.squareup.otto.Bus.dispatchQueuedEvents(Bus.java:368) at com.squareup.otto.Bus.post(Bus.java:337) at com.squareup.otto.Bus.throwRuntimeException(Bus.java:460) at com.squareup.otto.Bus.dispatch(Bus.java:387) at com.squareup.otto.Bus.dispatchQueuedEvents(Bus.java:368) at com.squareup.otto.Bus.post(Bus.java:337)

It would be nice if EventHandler was package public, so that subclasses of Bus could override dispatch. I have that change in a local fork, but I'd rather depend on the official library.

So I said: bus.post(228); //int

and then tried to get it inside my Fragment and it haven't worked.

Then I changed it to String and everything became fine.

Is it ok?

Good morning, it is the first time I will use Otto and I wonder if you could give an example of that class should be created and where it should place the functions, which will be @Subscribes. I understand the operation, but I can not understand where they are to be the functions that are activated by the certain event, which want to capture to make a sincrinización between threads. Thank you and I hope your help.

PS: if I do not explained well, ask and I write otherwise

When registering/unregistering within parent classes consumers now have the ability to point to the parent and use producer/subscriber annotated methods within. This uses the child class instance to reflectively trigger the parent class method.