Thanks a lot for making your nice, light-weight and tracker-free app available as open source! Would you also consider making the APK available outside of Play Store – for those who cannot use it or rather avoid it for e.g. privacy reasons? Possibilities would e.g. be tagging your releases and attaching it there – or tagging and having your app built and included with F-Droid.

Rationale

Over 25% of the world's Android devices still run Android 6.0 or older [1]. This version of Android still has native support for moving applications to SD cards — this is crucial when dealing with low-storage devices. Many more recent OEM OSes also support moving applications to SD cards. This means making applications movable to the SD card is IMHO a rational choice.

Solution

Add android:installLocation="auto" flag to AndroidMainfest.xml. The default for Android is, curiously, not "auto" but "internalOnly"

https://developer.android.com/guide/topics/data/install-location

Signed-off-by: Atrate [email protected]

The 3-dot context menu to the right of each track in the track tab is very difficult to tap without changing the position in the tracklist. I have tried multiple resolutions and still have the same issue. Trying to tap the dots quickly to add a track to a playlist usually results in scrolling down or up the tracklist rather than opening the menu.

I love this app! I am willing to contribute to development, I also have a feature I'd like to request/help implement.

On my phone Odeon crashes on every startup. Android 8.0.0. Storage permission given.

[09-01 07:11:26.560 3363:4192 I/ActivityManager]
START u0 {act=android.intent.action.MAIN cat=[android.intent.category.LAUNCHER] flg=0x10200000 cmp=fr.nihilus.music/.HomeActivity bnds=[796,245][1053,593] (has extras)} from uid 10175

[09-01 07:11:26.602 3363:4704 I/ActivityManager]
Start proc 25383:fr.nihilus.music/u0a408 for activity fr.nihilus.music/.HomeActivity

[09-01 07:11:28.887 3363:3385 I/LaunchCheckinHandler]
Displayed fr.nihilus.music/.HomeActivity,cp,ca,2304

[09-01 07:11:30.330 25383:25383 E/AndroidRuntime]
FATAL EXCEPTION: main
Process: fr.nihilus.music, PID: 25383
m.b.a.o.u.c: Unexpected exception thrown by non-Glide code
	at m.b.a.o.u.m$a.run(:9)
	at android.os.Handler.handleCallback(Handler.java:789)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6592)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:769)
	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:108)
Caused by: android.content.res.Resources$NotFoundException: Drawable fr.nihilus.music:drawable/placeholder_track_icon with resource ID #0x7f0800b6
Caused by: android.content.res.Resources$NotFoundException: File res/drawable/placeholder_track_icon.xml from drawable resource ID #0x7f0800b6
	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:792)
	at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:614)
	at android.content.res.Resources.getDrawableForDensity(Resources.java:876)
	at android.content.res.XResources.getDrawableForDensity(XResources.java:868)
	at android.content.res.Resources.getDrawable(Resources.java:818)
	at android.content.res.XResources.getDrawable(XResources.java:790)
	at m.b.a.o.w.e.a.a(:6)
	at m.b.a.s.h.m(:3)
	at m.b.a.s.h.r(:7)
	at m.b.a.s.h.o(:4)
	at m.b.a.o.u.m$a.run(:8)
	at android.os.Handler.handleCallback(Handler.java:789)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6592)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.Zygote$MethodAndArgsCaller.run(Zygote.java:240)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:769)
	at de.robv.android.xposed.XposedBridge.main(XposedBridge.java:108)
Caused by: android.content.res.Resources$NotFoundException: Drawable fr.nihilus.music:color/color_on_surface_12_alpha with resource ID #0x7f060030
Caused by: android.content.res.Resources$NotFoundException: File res/color/color_on_surface_12_alpha.xml from drawable resource ID #0x7f060030
	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:792)
	at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:614)
	at android.content.res.Resources.loadDrawable(Resources.java:885)
	at android.content.res.TypedArray.getDrawableForDensity(TypedArray.java:953)
	at android.content.res.TypedArray.getDrawable(TypedArray.java:928)
	at android.content.res.XResources$XTypedArray.getDrawable(XResources.java:1363)
	at android.graphics.drawable.LayerDrawable.updateLayerFromTypedArray(LayerDrawable.java:382)
	at android.graphics.drawable.LayerDrawable.inflateLayers(LayerDrawable.java:261)
	at android.graphics.drawable.LayerDrawable.inflate(LayerDrawable.java:194)
	at android.graphics.drawable.DrawableInflater.inflateFromXmlForDensity(DrawableInflater.java:142)
	at android.graphics.drawable.Drawable.createFromXmlInnerForDensity(Drawable.java:1295)
	at android.graphics.drawable.Drawable.createFromXmlForDensity(Drawable.java:1254)
	at android.content.res.ResourcesImpl.loadDrawableForCookie(ResourcesImpl.java:779)
	at android.content.res.ResourcesImpl.loadDrawable(ResourcesImpl.java:614)
	at android.content.res.Resources.getDrawableForDensity(Resources.java:876)
	at android.content.res.XResources.getDrawableForDensity(XResources.java:868)
	at android.content.res.Resources.getDrawable(Resources.java:818)
	at android.content.res.XResources.getDrawable(XResources.java:790)
	at m.b.a.o.w.e.a.a(:6)
	at m.b.a.s.h.m(:3)
	at m.b.a.s.h.r(:7)
	at m.b.a.s.h.o(:4)
	at m.b.a.o.u.m$a.run(:8)
	at android.os.Handler.handleCallback(Handler.java:789)
	at android.os.Handler.dispatchMessage(Handler.java:98)
	at android.os.Looper.loop(Looper.java:164)
	at android.app.ActivityThread.main(ActivityThread.java:6592)

[09-01 07:11:30.335 3363:10030 W/ActivityManager]
  Force finishing activity fr.nihilus.music/.HomeActivity

[09-01 07:11:30.353 3363:3379 I/ActivityManager]
Showing crash dialog for package fr.nihilus.music u0

[09-01 07:11:30.440 643:643 D/SFPerfTracer]
       layers: (4:14) (StatusBar#0 (0xaf483000): 0:1704696) (PieTriggerBOTTOM#0 (0xaf7c5000): 0:6053) (com.joko.wp.service.MyService#0 (0xaf64a000): 0:2098429)* (DimLayerController/Stack=0#0 (0xaf55a000): 0:2728)* (Sprite#0 (0xaf7a6000): 0:151)* (animation background stackId=1#0 (0xaf683000): 0:600)* (PieControlPanel#0 (0xaf7b0000): 0:1144)* (VoiceInteractionSession#0 (0xaf48d000): 0:568)* (InputMethod#0 (0xaf783000): 0:3733)* (NavigationBar#0 (0xaf644000): 0:713) (#0 (0xaf694000): 0:23)* (ch.deletescape.lawnchair.plah/ch.deletescape.lawnchair.Launcher#0 (0xaf797000): 0:131)- (Splash Screen fr.nihilus.music#0 (0xaf79e000): 0:36)- (fr.nihilus.music/fr.nihilus.music.HomeActivity#0 (0xaf499000): 1:68) 

[09-01 07:11:30.840 3363:3378 W/ActivityManager]
Activity pause timeout for ActivityRecord{30e4dbb u0 fr.nihilus.music/.HomeActivity t37640 f}

[09-01 07:11:32.226 3363:10030 W/ActivityManager]
  Force finishing activity fr.nihilus.music/.HomeActivity

[09-01 07:11:32.241 643:643 D/SFPerfTracer]
       layers: (7:14) (StatusBar#0 (0xaf483000): 0:1704696) (PieTriggerBOTTOM#0 (0xaf7c5000): 0:6053) (com.joko.wp.service.MyService#0 (0xaf64a000): 54:2098499) (DimLayerController/Stack=0#0 (0xaf55a000): 0:2738) (Sprite#0 (0xaf7a6000): 0:151)* (animation background stackId=1#0 (0xaf683000): 0:600)* (PieControlPanel#0 (0xaf7b0000): 0:1144)* (VoiceInteractionSession#0 (0xaf48d000): 0:568)* (InputMethod#0 (0xaf783000): 0:3733)* (NavigationBar#0 (0xaf644000): 0:713) (#0 (0xaf694000): 0:23)* (fr.nihilus.music/fr.nihilus.music.HomeActivity#0 (0xaf499000): 13:93)* (Application Error: fr.nihilus.music#0 (0xaf797000): 2:17) (ch.deletescape.lawnchair.plah/ch.deletescape.lawnchair.Launcher#0 (0xaf79e000): 7:12) 

[09-01 07:11:32.268 3363:10030 I/ActivityManager]
Killing 25383:fr.nihilus.music/u0a408 (adj 900): crash

I just tried your music player out for the first time today, and I was really impressed! The interface is very functional, but also clean and simple (no fluff).

I'm currently running Android 10 and noticed that artwork wasn't being displayed. I also noticed that version 2.0.2 appears to have a fix for this issue. Is there a reason you haven't published a build for version 2.0.2 yet?

Thanks, Dan

For a smoother transition to Jetpack Compose, the following changes were implemented:

• replace usages of LiveData with StateFlow, that always provides an initial value
• expose live state in ViewModels
• replace MediaItem with dedicated UI models

Media sources have been reorganized to better follow Android Architecture best practices:

• Split responsibilities of BrowserTree between BrowserTree and MediaSearchEngine
• Move BrowserTree to media module
• Drop MediaDao in favor of repositories for tracks, albums, artists and playlists

This should slightly reduce build times, avoiding invalidation of the whole project and running Room processor when anything shared in "core" module is changed.

Sharing ViewModels between multiple fragments makes it harder to reason about how components interact together. By dedicating a single ViewModel to each Fragment, each screen computes and retains its own state. State shared between multiple screens should be shared from the data layer.

ProcessLifecycleOwner is more suitable than ViewModel to manage the MediaBrowser connection lifecycle. ViewModel keeps MediaBrowser connected until Activity is destroyed, ProcessLifecycleOwner disconnects whenever the app moves to the background, which is more efficient.

Sharing configuration between Gradle modules is better done using a Gradle convention plugin. This was previously done using cross-project configuration.

This happened when I installed it on my Galaxy J7 Star - Android 9.

It was so annoying that I uninstall multiple times and installing it multiple times over and over again.

• When executing this sequence of actions, there is a loss of data in the activity HomeActivity:

1. KeyEvent(name=BACK)
2. IntentEvent(intent='am start fr.nihilus.music/fr.nihilus.music.HomeActivity')
3. TouchEvent [[540,152],[720,236]]
4. TouchEvent [[360,152],[540,236]]
5. TouchEvent [[565,61],[649,145]]
6. TouchEvent [[628,71],[712,155]]
7. SetTextEvent [[134,64],[628,162]]
8. ScrollEvent(direction=FULL_LEFT)
9. ScrollEvent(direction=UP) [[0,236],[720,1558]]
10. Cap01: capture screen properties before rotation
11. DoubleRotationEvent
12. Cap02: capture screen properties after rotation
13. Cap01 != Cap02 (focus variable changes state)

• HomeActivity: the pop-up menu disappears

Before and after double screen rotation

A data loss problem occurs when data is accidentally deleted or state variables are accidentally assigned with default or initial values. This issue is related to the activity's lifecycle (1). When a screen rotation occurs, the activity is destroyed and resumed. Data loss will happen if the developer does not save the variables before the destruction and restore them after creation. To avoid this, the developers have to implement both the logic necessary to save the activity state in the onSaveInstanceState() callback method and the logic to resume its state in the onRestoreInstanceState() callback method. Another way to avoid data loss problems is to use the view model, designed to store and manage UI-related data in a lifecycle-conscious way (2).

Note:

• Double screen rotation: It is executed twice to reach a state that should be exactly the same as the screen before if no data loss occurred.
• A data loss problem occurs when data is accidentally deleted or state variables are accidentally assigned with default or initial values.

1. https://developer.android.com/guide/components/activities/activity-lifecycle
2. https://developer.android.com/topic/libraries/architecture/viewmodel

Hi,

first of all thank you very much for your awesome app! Excellent work! Now to my problem... I find it very confusing that when you open an album and hit the play button in the bottom right corner of the album cover it starts playing a random song from the album instead of the first song in the list. (Shuffle is deactivated) Also is there a way to see the current titles of the playlist? When I started playing an album and then leave the album page I still can iterate through the album's song using the next and previous buttons, but can't see the list of songs in the playlist?

Thanks!

User Journey

This feature request is for a new user journey, described thus:

as a user of Odeon, I want to be able to connect Odeon with my Wallet, and show my ERC-721 tokens (NFTs) (audio tracks, playlists).

Odeon

Below is a screenshot of the existing Odeon music player app:

Music for the player is currently served from the device's own filesystem.

Proposed Architecture

Components

An architecture to enable this can include the following components:

• WalletConnect is a protocol for connecting to Wallet Apps on a device. This allows a user to transact on an Ethereum Virtual Machine (EVM)-compatible blockchain.

• Optimism is an EVM-compatible blockchain-based network, used for minting and transferring ERC-721 tokens (NFTs).

• IPFS is a distributed file system, used for storing files, such as mp3 audio files, and JSON metadata files.

Approach

Odeon could:

1. Connect with the wallet app on the user's device using WalletConnect
2. Read / write ERC-721 token (NFT) data from / to Optimism
3. Retrieve audio files and metadata content from IPFS
4. Play audio
5. (Advanced feature) to cache audio tracks on your device for offline playback.

Additional Thoughts

Implementation

This kind of functionality can very easily extend the existing excellent UX that Odeon already has.

For example, a "Connect Wallet" (step 1) option can live in the main Hamburger underneath "Settings", or even in "Settings". It need only require a few steps in the app to "Connect Wallet", and WalletConnect makes this veery easy!

Everything else can happen in the background... pulling in metadata and audio files (steps 2 and 3 above). It may perhaps need some extension in order to stream content from an IPFS gateway though.

As for playback (step 4), Odeon's existing audio player UI is more than capable of this.

For the advanced feature, a "Keep for Offline" checkbox for each track can live beneath "Add to playlist" and "Delete" in the options for each track:

"Delete" might need to be disabled for NFT audio tracks because it's not really possible to "delete" from IPFS.

Future Features

Future features could include:

• Publish new playlists as NFTs to store in your wallet, or to send to your friends' wallets
• Publish new original music as NFTs to send to music collectors.

Notes

I accept that this may appear a somewhat esoteric concept to propose. But I believe it to be based in a very sane context.

The world is very slowly coming to terms with jpeg NFTs, indicating clearly that gif, then mp3 then mp4 will follow.

NFTs for Music are emerging, as evidenced by Jonathan Mann's recent release "Right Click Save As".

Further, zero-knowledge rollup networks such as Optimism, Arbitrum and zksync are substantially increasing the capacity of blockchain networks, meanwhile reducing their cost of use.

And finally, IPFS is emerging as the default go-to storage for decentralised content and metadata, and while still maturing in some aspects, it represents a sustainable part of the architecture. This is especially true in light of the progress made by Filecoin project.

Credits

All the credit goes to you for reading all this. Bravo to you!

All views work on the phone itself and the Artist view loads ok but the Album view just has a spinner and never loads. I have the same issue in a car and also via the AA emulator. Any way of fixing this or suggestions? My library is about 30k files