The VerticalDividerItemDecoration was being drawn over the entire recyclerview, rather than just the cell bounds for each position.

This meant that shouldHideDivider() had no effect.

The bounds calcutation for the VerticalDividerItemDecoration is now correct.

ShowLastDivider behaviour is also now supported for VerticalDividerItemDecoration in a GridLayout

From the Material Design Spec

Dividers are placed along the bottom edge of the content tiles, independent of the grid.

The current implementation draws the dividers below the item:

        if (mDividerType == DividerType.DRAWABLE) {
-            bounds.top = child.getBottom() + params.topMargin + transitionY;
+            // I haven't tested the drawable implementation
+            bounds.top = child.getBottom() + params.topMargin + transitionY - dividerSize;
            bounds.bottom = bounds.top + dividerSize;
        } else {
-            bounds.top = child.getBottom() + params.topMargin + dividerSize / 2 + transitionY;
+            // this one works great
+            bounds.top = child.getBottom() + params.topMargin - dividerSize / 2 + transitionY;
            bounds.bottom = bounds.top;
        }

and this can be removed because the size does not change

    @Override
    protected void setItemOffsets(Rect outRect, int position, RecyclerView parent) {
-        outRect.set(0, 0, 0, getDividerSize(position, parent));
+        outRect.set(0, 0, 0, 0);
    }

This feature should be optional

Hi,

I'm using an ItemAnimator with an Horizontal LinearLayoutManager. When I call notifyItemRemoved or notifyItemInserted the drawers are not drawn until I scroll to new items. It seems related to this issue https://code.google.com/p/android/issues/detail?id=100653

Could it be possible to fix it?

Thanks !

Hi there,

Is there a way of changing the divider size depending not only on the position but also on the content? In my case, my adapter extends from a CursorRecyclerAdapter and depending on the position content I set a different view type.

    @Override
    public int getItemViewType(int position) {
        if (mDataValid && mCursor != null && mCursor.moveToPosition(position)) {
            String cursorUid = mCursor.getString(mCursor.getColumnIndex(ChatProvider.COL_FROM_UID));
            String previousUid = "";
            if (!mCursor.isFirst()) {
                mCursor.moveToPrevious();
                previousUid = mCursor.getString(mCursor.getColumnIndex(ChatProvider.COL_FROM_UID));
                mCursor.moveToNext();
            }

            if (cursorUid.equals(uid))
                return VIEW_TYPE_ME;
            else if (previousUid.equals(cursorUid))
                return VIEW_TYPE_OTHERS_BIS;
            else
                return VIEW_TYPE_OTHERS;

        }
        return 0;
    }

My problem is that I set the adapter to the recyclerview when the cursor is loaded inside the onLoadFinished method of the CursorLoader and the "dividerSize" method seems to get called before the cursor is loaded setting the default divider to all items.

@Override
    public int dividerSize(int position, RecyclerView parent) {
        switch (getItemViewType(position)) {
            case VIEW_TYPE_ME:
                Utils.convertDpToPixel(context.getResources().getDimension(R.dimen.divider_chat_normal), context);
                break;

            case VIEW_TYPE_OTHERS:
                Utils.convertDpToPixel(context.getResources().getDimension(R.dimen.divider_chat_normal), context);
                break;

            case VIEW_TYPE_OTHERS_BIS:
                Utils.convertDpToPixel(context.getResources().getDimension(R.dimen.divider_chat_bis), context);
                break;
        }
        return Utils.convertDpToPixel(context.getResources().getDimension(R.dimen.divider_chat_normal), context);
    }

I've tried to call addItemDecoration after the data is loaded into the cursor with no luck.

   @Override
    public void onLoadFinished(Loader<Cursor> loader, Cursor data) {
        messagesChatAdapter.swapCursor(data);
        recyclerView.scrollToPosition(messagesChatAdapter.getItemCount() - 1);
        recyclerView.addItemDecoration(new HorizontalDividerItemDecoration.Builder(getActivity())
                .sizeProvider(messagesChatAdapter)
                .color(android.R.color.transparent)
                .build());
    }

Hi, I use the API as the doc says:

recyclerView.addItemDecoration( new HorizontalDividerItemDecoration.Builder(this) .color(Color.RED) .sizeResId(R.dimen.divider) .marginResId(R.dimen.leftmargin, R.dimen.rightmargin) .build());

However, I find that the color that shows is not the same as that it should be. Could you please help me out?

…coration

Extend HorizontalDividerItemDecoration as it basically is the same except for calculating how many children to draw and not to redraw for children that already haven been drawn.

I'm using radio buttons in my cells in a horizontal linear layout.

I noticed that when calling notifyItemChanged on two cells at the same time, one to uncheck the radio button and one to check the radio button. That the dividers flash and glitch weirdly.

The above can be worked around by calling notifyDataSetChanged(). But the same problem occurs when calling notifyItemRemoved and notifyItemChanged at the same time which I haven't been able to work around whilst still getting the removed animation.

Thanks, Tom

Example project https://github.com/Sylapse/DividerSample.git

when set to true, divider is still showing

I can confirm that my adapter is implementing FlexibleDividerDecoration.VisibilityProvider and overriding shouldHideDivider. I can also confirm that shouldHideDivider is not being called

Changelog:

• ItemDecorator can handle reversed recycleviews
• More complex sample where you can change between many recycleview configuration without another activities

1 skip draw divider only for the real last view when mShowLastDivider set to false 2 getItemOffsets return zero size Rect for last view when mShowLastDivider set to false

just install sample project. Run on an emulator. Open Memory Monitor. Scroll up and down with several times. Memory is growing. Sometimes GC start, but cannot release more memory. Always call GC.

Any idea on this issue?

Thanks

recyclerview-flexibledivider package was hosted on jcenter() but it is closed now.

Can you put it in another repository and can the change the read.me file

hi, thanks in advance for your library. recently google released the new androix libraries (AKA support libraries) i will be great if you update the lib dependencies to this news libraries

HorizontalDividerItemDecoration mItemDecoration = new HorizontalDividerItemDecoration.Builder(this)
                .color(ContextCompat.getColor(mContext, R.color.color_333333))
                .sizeResId(R.dimen.px_1)
                .marginResId(R.dimen.dp_16, R.dimen.dp_16)
                .build();
mRecyclerView.addItemDecoration(mItemDecoration);