Hi!

First, I love this player, it's very fast. The only problem I have is that the hardware buttons aren't being recognised by the app. If I hold the volume up button from my headset, nothing happens. It works with other music player. I use CM 12.1 on a Samsung S3 if it helps. I can give you some logs if you need.

Though pausing music is flawless, I am unable to resume music using a hardware button on my headphones

Conditions: Headphones: JBL Tune 500BT OS: Android 11 App: Simple Music Player 5.11.3

Steps to reproduce:

• Play music on your headphones
• Pause music using hardware button: as in result, music is paused
• Try to resume music using the same button: as of result, the music remains stopped

Expected behaviour (this is how it works in AntennaPod, Spotify, VLC…): Pressing the button again resumes music

Possibly related with: https://github.com/SimpleMobileTools/Simple-Music-Player/issues/395

Nokia 6 with Android 7.1.2.

My music collection is about 2000 songs, 14GB data. It is a mix of mp3, ogg, flac and art data. Data is organized in folders starting from one rootfolder on the SDcard. Simple Music Player freezes upon many actions. e.g. adding the rootfolder to the playlist, opening the All Song playlist, going back from settings to normal view. Then I get "the app is not responding" notification every few minutes. It can take 10min to 15min before the app responds again.

Also likely related is that many songs are processed then displayed with < unknown > artist while the information is available in the file meta data. When I re-install the app (to start with an empty playlist) and only add one folder it is fine.

Reference: VLC player on this phone displays a progress bar when scanning for all media in the same folders, it takes a few minutes but does not hang. Also VLC can recognize all meta data like Artist properly.

Addresses #332.

I will describe all the changes I've done and their rationale. Let me know if you disagree with something – I made the changes granular, so it's easy to revert a specific change by reverting the commit.

Small changes

• Introduced PlaybackSetting enum to deal with different playback setting states.
• Added tooltips for shuffle and playback setting buttons.
• Removed playback setting strings that are not used anymore.
• Deleted autoplay strings since we don't have that feature anymore? The strings are not used anywhere.

Changes that need approval

Replace "enabled"-style messages with "do-this"-style messages.

Since we don't have 2 enabled/disabled states for playback settings anymore, I think it feels more clear and concise to use a simple setting description, so that the user sees a message with how playback will work now.

So UX will look like this - user switches between playback settings and sees messages "Repeat current song" -> "Stop playback after current song" -> "Repeat playlist" instead of "Current song repetition enabled" -> "Stop playback after current song enabled" -> "Playlist repetition enabled".

Replace Toasts with Snackbars

When clicking on the action button a couple of times, Toasts are being displayed sequentially, and it's hard to understand what your last action actually was. Snackbars are replaced instantly when a new one comes in, so it's clear what your action caused.

PR merge checklist

• [x] Should we replace "enabled"-style messages with "do-this"-style messages?
• [ ] ~~Should we replace Toasts with Snackbars?~~
• [ ] ~~If we go ahead with using Snackbars, should I add helper functions in Simple-Commons similar to those for Toasts?~~

Is your feature request related to a problem? Please describe. Sometimes people don't want to binge through their music, but instead only listen to one track and then have the playing stop until they want to listen to the next track. It can be annoying to immediately be bombarded with a different song.

I haven't found any option that could result in the desired pausing-behaviour.

Describe the solution you'd like In the spot where the user can select whether the song should loop or not, add a fourth option: pause. This option should pause and the current song when it's done playing.

Additional context Unfortunately, most open-source music players lack this feature.

It appears that I have to dig down into the music library to find a track before the Simple Music Player will start playing music. That's way too complicated as a user interface. A big "Play All" button on the launch screen would make the interface much more simple and easy to use. It should be close to the bottom/center of the screen because that's where a person's thumb is going to be when holding the phone. It's foolish to put buttons at the top because that requires users to poke at them with a second hand. It's much more efficient to design the UI for single-hand thumb usage. Anyway, here's a mockup of what the home screen could look like. One touch "play all" button would make getting to the actual music player much more simple.

This interface could make playing other music within the library much easier too. For example, when selecting an artist or album, the button could show as "Play Selected".

- First of all, .OPUS file support.

• Lyrics over Album Art in main application (tap to toggle maybe?, like in Samsung Music app)
• Showing previous button in notifications without expanding (or a option switch to enlarge notification)
• Change Lockscreen wallpaper with Album Art
• Dynamically change notification color based on Album Art (like in VLC)

This PR addresses issues https://github.com/SimpleMobileTools/Simple-Music-Player/issues/470, https://github.com/SimpleMobileTools/Simple-Music-Player/issues/391, https://github.com/SimpleMobileTools/Simple-Music-Player/issues/376, and some notification, widget related improvements and bug fixes.

Major changes:

• Remove the fake notification as it led to seemingly unpredictable side effects.
• Update foreground logic and move notification creation code to a separate helper class
• Save and restore the current queue item and its position, previously everything was reset and service was stopped.
• Update widgets properly on track state change, track info wasn't being updated.
• Add a close (❌) button in the player notification on all android versions.
• Save the state, pause the player and hide the notification when the sleep timer ends, no need to kill the service.
• Move the media session callback object to a separate file, it'll grow in size later.

someone reported the same issue a long time ago (#160), but this bug is still present as of today.

(and yes, I'm using 5.13.1, the latest release of this app)

Notes

• implement editing audio tags for specific media files.
• add function to rename audio files (for pre-Android 11 devices) alongside changing audio metadata like song title, song artist, song album names.
• editing the metadata is done with the JAudioTagger library for its simplicity but newer versions only support Android 8 (API 26 and above). The maximum version we can use to support at least API 21 is 2.2.5.
• the changes written are persisted even after rescanning by the MediaScannerConnection. Other apps can see these changes in the file metadata from MediaStore.
• The official JAudioTagger does not support editing metadata for AAC, OPUS files. However, does for WAV and WMA files but the changes written, are not detected by the android MediaStore. In the app, we disable the rename functionality for these files. MP3, M4A, OGG and FLAC files work well
• should close #298
• ~~this PR should be merged before the project can be built due to an update to the commons library~~
• ~~add new string grant_change_metadata_permission= "Please grant the permission to modify audio properties" that displays on a toast when the user denies permission to modify a file.~~

Steps:

1. Play the song.
2. Set the sleep timer for e.g. 5 minutes.
3. Attempt to deactivate the sleep timer.

The sleep timer cannot be deactivated.

If I set the sleep timer for e.g. 5 minutes. Then if I want to opt out of automatically disabling the app, there is no way of deactivating the sleep timer.

Apps: Android 10 Simple Music Player 5.7.1

Translations update from Hosted Weblate for Simple Mobile Tools/Simple Music Player.

It also includes following components:

• Simple Mobile Tools/Simple Music Player metadata

Current translation status:

Hi,

Many people like me tend to sort their music Hirachically into folders, unfortunately this is not supported by most music players and they all offer a list of folders containing audio files, which makes it a pita to browse big collections...

It would be cool if we could navigate through subfolders, play a folder and if that is finished go one level up and play the next subfolder...

Hi there. I really enjoy using many of the "Simple" apps on Android; thank you for your work!

While I know the intention with this app is to "keep it simple", would it be very much effort to modify the equalizer so that the left and right channels could be controlled separately? As one of millions of people with moderate hearing loss, the ability to boost certain bands in one of my ears would allow me to fully and evenly hear the music in both of my ears when listening. I am able to do this on the Linux desktop but after extensive research, it seems that there are no free and open source Android apps (and perhaps only one proprietary app) able to provide this feature. In terms of accessibility, it would be really valuable for a lot of people if the Simple Music Player could eventually support this.

Thanks for your consideration!

It takes a long time to export all playlists if you have many. From the playlist screen it takes 6 taps if you dont set a name and choose to overwrite an existing .m3u file. I suggest adding a button below "import playlist" to export all the playlists with their current names. Maybe also a pop-up warning that this will overwrite existing .m3u files with the same name. Adding an option yo export playlists when selecting a couple could be cool to. Thanks.

I would be nice to be able to add the current song your listening to from the player screen. Currently, it takes may extra steps to do this. One has to press back to get out of the player view, and often the song is not visible in tracks or albums or wherever it was originally clicked on. So you have to search for it to be able to add it to a playlist. The attatchrd photos indicate with red some ideas I have on placement to open a menu. If I think it would also be cool to have a "More from artist/album" feature. That could be integrated and tapped on from the same menu in those places I marked.