I used to have one thing in my addiction list (Fresh new install from fdroid today) and a half hour later when i looked again the list has doubled to two duplicate addictions..

This happened a few times

I recently added another item to my list and only a few minutes later the list has doubled again to 4 items both items both duplicated.

I am 100% sure they worked before but now on every release on multiple devices the cached times don't reset correctly

Expected: Reset time, close and open app, time is relatively small because of the recent reset Actual: Reset time, close and open app, time is back where it was

I am genuinely baffled.

I have made some qol improvements on various parts of the ui:

• Use Material components instead of regular Android components. If you want to implement Material You theme later, you pretty much have to use them. Also, as I explained earlier, you don't have to avoid it and they simply look nicer.
• Fix toolbar not showing on light mode.
• Fix a bug where you can pick a future time in today.
• The date formatting now expands to years, months and weeks. Also, if any time unit is 0, it's hidden. Fixes #24
• The Create activity is more optimized for one handed usage. (all elements are positioned lower).

Many people stop for a length of time rather then a one time relapse. Then they restart abstaining from whatever. It would be nice if that was an option over just a relapse button that restarts automatically. Maybe keep time since abstaining was stopped. I personally would feel better if i could restart a fresh new abstaining attempt from an existing button if i have stopped for a few days, where i would likely trash the last attempt over use the relapse button when i wanted to try abstaining again

Unfortunately this bug seems to keep reappearing😄 The clean install of 5.1.4 works perfectly fine (also thanks for crediting me in the release notes) but when updating from 4.0.1 with an existing save file it crashes again.

However this time its reproducible in the Emulator, so maybe that helps in getting rid of the bug.

Steps to reproduce:

1. Check out the revision of the repository where version was updated to 4.0.1
2. Build and clean install this version on the emulator
3. Open the app and create an entry
4. Check out the current master branch (5.1.4) and update the app on the emulator by building and running again

I appended the full crash log at the end, but the only relevant lines are

Caused by: java.io.InvalidClassException: com.katiearose.sobriety.Addiction; at com.katiearose.sobriety.CacheHandler.readCache(CacheHandler.kt:17) at com.katiearose.sobriety.Main.onCreate(Main.kt:61)

I don't really get why it crashes, because there is try catch blocks everywhere that should have caught that exception. Mabye its worth considering to use a different way of storage, since these FileOutPutStreams etc. are a bit tricky to debug. Since the data is very simple, you could use Android's Shared Preferences, and save the list as a serialized string in a single key value pair there. Or if you want to debug the current system, here is the full crash log:

E/AndroidRuntime: FATAL EXCEPTION: main Process: com.katiearose.sobriety, PID: 21703 java.lang.RuntimeException: Unable to start activity ComponentInfo{com.katiearose.sobriety/com.katiearose.sobriety.Main}: java.io.InvalidClassException: com.katiearose.sobriety.Addiction; local class incompatible: stream classdesc serialVersionUID = -8477717136644775154, local class serialVersionUID = 7971970991809636397 at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3635) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792) at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103) at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135) at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210) at android.os.Handler.dispatchMessage(Handler.java:106) at android.os.Looper.loopOnce(Looper.java:201) at android.os.Looper.loop(Looper.java:288) at android.app.ActivityThread.main(ActivityThread.java:7839) at java.lang.reflect.Method.invoke(Native Method) at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) Caused by: java.io.InvalidClassException: com.katiearose.sobriety.Addiction; local class incompatible: stream classdesc serialVersionUID = -8477717136644775154, local class serialVersionUID = 7971970991809636397 at java.io.ObjectStreamClass.initNonProxy(ObjectStreamClass.java:624) at java.io.ObjectInputStream.readNonProxyDesc(ObjectInputStream.java:1713) at java.io.ObjectInputStream.readClassDesc(ObjectInputStream.java:1594) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1872) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1412) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:427) at java.util.ArrayList.readObject(ArrayList.java:791) at java.lang.reflect.Method.invoke(Native Method) at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1066) at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2013) at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1899) at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1412) at java.io.ObjectInputStream.readObject(ObjectInputStream.java:427) at com.katiearose.sobriety.CacheHandler.readCache(CacheHandler.kt:17) at com.katiearose.sobriety.Main.onCreate(Main.kt:61) at android.app.Activity.performCreate(Activity.java:8051) at android.app.Activity.performCreate(Activity.java:8031) at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1329) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3608) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3792)  at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:103)  at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)  at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)  at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2210)  at android.os.Handler.dispatchMessage(Handler.java:106)  at android.os.Looper.loopOnce(Looper.java:201)  at android.os.Looper.loop(Looper.java:288)  at android.app.ActivityThread.main(ActivityThread.java:7839)  at java.lang.reflect.Method.invoke(Native Method)  at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)  at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:1003) 

Just updated via F-Droid and got this error when attempting to launch the app.

type: crash
osVersion: google/oriole/oriole:13/TP1A.220905.004.A1/2022091400:user/release-keys
package: com.katiearose.sobriety:12
process: com.katiearose.sobriety

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.katiearose.sobriety/com.katiearose.sobriety.Main}: java.io.InvalidClassException: m1.a; class invalid for deserialization
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3677)
	at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3814)
	at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:101)
	at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
	at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
	at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2309)
	at android.os.Handler.dispatchMessage(Handler.java:106)
	at android.os.Looper.loopOnce(Looper.java:201)
	at android.os.Looper.loop(Looper.java:288)
	at android.app.ActivityThread.main(ActivityThread.java:7904)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:548)
	at com.android.internal.os.ExecInit.main(ExecInit.java:49)
	at com.android.internal.os.RuntimeInit.nativeFinishInit(Native Method)
	at com.android.internal.os.RuntimeInit.main(RuntimeInit.java:355)
Caused by: java.io.InvalidClassException: m1.a; class invalid for deserialization
	at java.io.ObjectStreamClass$ExceptionInfo.newInvalidClassException(ObjectStreamClass.java:154)
	at java.io.ObjectStreamClass.checkDeserialize(ObjectStreamClass.java:798)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1901)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1440)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:428)
	at java.util.ArrayList.readObject(ArrayList.java:791)
	at java.lang.reflect.Method.invoke(Native Method)
	at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1066)
	at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2041)
	at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1927)
	at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1440)
	at java.io.ObjectInputStream.readObject(ObjectInputStream.java:428)
	at n1.e.a(Unknown Source:105)
	at com.katiearose.sobriety.Main.onCreate(Unknown Source:88)
	at android.app.Activity.performCreate(Activity.java:8301)
	at android.app.Activity.performCreate(Activity.java:8280)
	at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1389)
	at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3658)
	... 14 more

There seems to be an issue when updating the app, and then reading a save file created in the old version.

Steps to reproduce: 1 Checkout version 3.0.0 2 Add a couple of entries 3 Checkout the newest version => update the app => start the app => app crashes with this error:

java.lang.OutOfMemoryError: OutOfMemoryError thrown while trying to throw OutOfMemoryError; no stack trace available

Re-installing the app fixes this bug but also gets rid of previous entries.

Afaik the "recent average" function calculates the average of the last 3 abstaining periods. With that in mind, I'd like to report some, uh, weird behavior with it:

• If the addiction has never been relapsed at all, the average displays the time of the current abstaining period. That's kinda odd (and wrong as well), since there's no abstaining history to begin with.
• If it has been relapsed, when you first log the relapse, the average is calculated and displayed correctly. However, when you close the app and open it again, the average displays the time of the new abstaining period.

Example: If I create an addiction with the time of 1 hour ago and I log the relapse, the average is displayed as 20 minutes (which is correct). However, if I close and open the app again, if the time of the new period is 10 seconds, when I open the app, the "average" is displayed as 10 seconds instead of the actual average value.

Am i gonna fix it?

• [x] Yes, but only after #38 since i'm not exactly familiar with resolving merge conflicts and stuff. If you know how, plz teach me.

When adding a new entry, I think the recent average should be null instead of the current implementation. If I add an entry with a future time, it shows the recent average as the difference between now and the set time (in negative). Same applies to adding an entry with a past time (difference in positive).

Are there any limitations that make this app incompatible with older Android devices? Can't install it from provided APK files.

I think it can be easily lowered to 21.

https://github.com/KiARC/Sobriety/blob/master/app/build.gradle#L11

I admit, this might look like a big change, but i promise it only has advantages😄 I refactored Main to use a RecyclerView to display the cards, replacing the createNewCard method.

Advantages of using a recycler view:

• More efficient (Views are "recycled" when scrolling)
• Allows updating of all cards in sync
• Animations for deleting / inserting
• Design of cards is now easier to modify

To put it simply, the logic part of createNewCard is now in the onBindViewHolder method of the Recyclerview Adapter, the design part of createNewCard is now fixed into the card_addiction.xml

I also made some minor design changes, trying out if icons would work as reset / delete buttons, this is just a suggestion.

⚠️These changes still don't contain a fix for the current crash when trying to read old files.

Does this app follow the calendar year or does it just accumulate seconds and minutes to form weeks and months? The app says im 11 months 3 weeks, but by the calendar im 1 year 4 days?

The milestones and savings disappear when closing the milestones and savings view.

Here is a Youtube Short of the bug https://youtu.be/0iBE2V1FUvA

Don't ask me why a short; Youtube decided it was a short.

I am running the latest version available on F-Droid (just updated and tested before posting the issue).

• OnePlus 6 (A6003)
• OxygenOS 11.1.2.2 (Android version 11)
• Sobriety v7.0.0
• F-Droid 1.15.4

Upgraded from the F-Droid 6.2.1 release and the App crashed on launch. The App cache was already empty and I don't want to clear the actual data and set it up again :unamused: .

Here is the startup exception:

11-23 16:33:54.950 15702 15702 E AndroidRuntime: java.lang.RuntimeException: Unable to start activity ComponentInfo{com.katiearose.sobriety/com.katiearose.sobriety.activities.Main}: java.io.InvalidClassException: j$.time.t; class invalid for deserialization
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3280)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:3419)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.servertransaction.LaunchActivityItem.execute(LaunchActivityItem.java:83)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.servertransaction.TransactionExecutor.executeCallbacks(TransactionExecutor.java:135)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.servertransaction.TransactionExecutor.execute(TransactionExecutor.java:95)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2026)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.os.Handler.dispatchMessage(Handler.java:107)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.os.Looper.loop(Looper.java:214)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.ActivityThread.main(ActivityThread.java:7400)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:491)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:935)
11-23 16:33:54.950 15702 15702 E AndroidRuntime: Caused by: java.io.InvalidClassException: j$.time.t; class invalid for deserialization
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectStreamClass$ExceptionInfo.newInvalidClassException(ObjectStreamClass.java:154)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectStreamClass.checkDeserialize(ObjectStreamClass.java:798)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1873)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1412)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readObject(ObjectInputStream.java:427)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.util.HashMap.readObject(HashMap.java:1408)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1066)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2013)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1899)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1412)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readObject(ObjectInputStream.java:427)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.util.ArrayList.readObject(ArrayList.java:791)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.lang.reflect.Method.invoke(Native Method)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectStreamClass.invokeReadObject(ObjectStreamClass.java:1066)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readSerialData(ObjectInputStream.java:2013)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readOrdinaryObject(ObjectInputStream.java:1899)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readObject0(ObjectInputStream.java:1412)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at java.io.ObjectInputStream.readObject(ObjectInputStream.java:427)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at j1.a.a(Unknown Source:105)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at com.katiearose.sobriety.activities.Main.onCreate(Unknown Source:148)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.Activity.performCreate(Activity.java:7824)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.Activity.performCreate(Activity.java:7813)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.Instrumentation.callActivityOnCreate(Instrumentation.java:1307)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:3255)
11-23 16:33:54.950 15702 15702 E AndroidRuntime:        ... 11 more

Maybe this issue is related to #48 , but I'm wondering why it's not mentioned in the release notes (or fixed before the F-Droid release), as the Issue seems to be known for about a month.

It would be great to be able to release Sobriety on iOS but a lot of work would need to be done on making the code work on both platforms. Luckily Kotlin can be used for both, but Android APIs wouldn't work and neither would many Google libraries I would assume. This is a very long term goal.