We're don't really care about "No exposure detected", right? How about only notifies users when "Exposure detected", instead of pop-up "No exposure detected" every day at a random time?

https://github.com/ailabstw/social-distancing-android/blob/aee80856ae1b19cc3f961d1f929944ff2300030e/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/Secrets.kt#L1:L43

Could you provide documentation of these "secret" functions? Thanks.

For releasing the source code to everyone, it would be better to have continues integration to ensure every pull request can be build successfully. implement it in github action should be a good solution.

the patch file is in below which can be applied by git am command:

$ git am github-action-build.patch

it would be easier if I can submit pull request :D

github-action-build.patch

From bd768a10257763847b7825444cd37032577a0243 Mon Sep 17 00:00:00 2001
From: "Yuren Ju (yurenju)" <[email protected]>
Date: Sun, 27 Jun 2021 21:50:39 +0800
Subject: [PATCH 1/2] feat: support github action build

---
 .github/workflows/build.yaml | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)
 create mode 100644 .github/workflows/build.yaml

diff --git a/.github/workflows/build.yaml b/.github/workflows/build.yaml
new file mode 100644
index 0000000..2693c37
--- /dev/null
+++ b/.github/workflows/build.yaml
@@ -0,0 +1,19 @@
+name: Build
+
+on: [pull_request]
+
+jobs:
+  build:
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Set up JDK 11
+        uses: actions/setup-java@v2
+        with:
+          java-version: '11'
+          distribution: 'adopt'
+      - name: Validate Gradle wrapper
+        uses: gradle/wrapper-validation-action@v1
+      - name: Build with Gradle
+        run: ./gradlew build -x test

From 8c10dea6c409e28250a44721ce2953e6bc9cb9cd Mon Sep 17 00:00:00 2001
From: "Yuren Ju (yurenju)" <[email protected]>
Date: Sun, 27 Jun 2021 22:00:44 +0800
Subject: [PATCH 2/2] fix: disable lint for build process

---
 SocialDistance/build.gradle | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/SocialDistance/build.gradle b/SocialDistance/build.gradle
index 790f26c..4128cac 100644
--- a/SocialDistance/build.gradle
+++ b/SocialDistance/build.gradle
@@ -57,6 +57,10 @@ android {
             path "src/main/cpp/CMakeLists.txt"
         }
     }
+
+    lintOptions {
+        abortOnError false
+    }
 }
 
 repositories {

Several users report the message field in an SMS app is empty after scanning a QR Code. Some users indicate that the message field is NOT EMPTY at the very beginning then disappeared immediately.

We received 11 reports during 6/15~10/11. We have been receiving more than 20 reports since 11/28. We did not change relative behavior since 6/15.

e82ccb373dedda130f3de8201a261b7fe42f5f55

https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/DailySummaryAdapter.kt#L1

https://github.com/ailabstw/social-distancing-android/blob/8e4e761dc681a0a71a48c609f58c8b199c41c84f/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/DailySummaryViewModel.kt#L1

The package name didn't match the folder structure also.

https://developer.android.com/about/versions/12/features/splash-screen

Android 12 adds the SplashScreen API, which enables a new app launch animation for all apps.

However, Social Distancing app already implemented a custom Splash Screen. Which caused double Splash Screen on Android 12.

The current implementation is a wait of 600ms https://github.com/ailabstw/social-distancing-android/blob/4aaa3e3e10d49ecc2b9abe0379c332b86f9b6b72/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/SplashActivity.kt#L14-L17

It will be better if migrate to SplashScreen Compat Library

BarcodeScanningActivity is very userful. Hope it can support other automation applications. in shortcuts.xml add exported to true. Help the elders reduce more steps.

thanks

https://github.com/ailabstw/social-distancing-android/blob/c7179d943bc242a8eca2fd1cc4eda0f62523e7b3/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/BaseActivity.kt#L25

Any reason of forcing portrait mode? It is possible that if a foldable device unfold, the screen will be in landscape mode.

Ref: https://developer.android.com/guide/topics/ui/foldables

https://github.com/ailabstw/social-distancing-android/blob/develop/SocialDistance/src/main/java/tw/gov/cdc/exposurenotifications/activity/UploadActivity.kt

• Private property name 'SUPPORTED_TEST_TYPES' should not contain underscores in the middle or the end
• Private property name 'COMMAS' doesn't match regex '_?[a-z][A-Za-z\d]*'
• Private property name 'BASE64' doesn't match regex '_?[a-z][A-Za-z\d]*'
• Private property name 'HASH_ALGO' should not contain underscores in the middle or the end

the following network security config has no use and should be removed

    <domain-config cleartextTrafficPermitted="false">
        <domain includeSubdomains="true">secure.example.com</domain>
    </domain-config>