Thank you for developing this library! I was looking for the library like this. I tried it on the below condition, but dividers were not drawn.

Device: Nexus 5(5.1.1) Library: com.android.support:recyclerview-v7:23.1.0, com.github.magiepooh:recycler-itemdecoration:1.1.0@aar, ... Code:

@Override
public View onCreateView(LayoutInflater inflater, ViewGroup container, Bundle savedInstanceState) {
    View view = inflater.inflate(R.layout.fragment_main, container, false);

    mRecyclerView = (RecyclerView) view.findViewById(R.id.recycler_view);

    mLinearLayoutManager = new LinearLayoutManager(getActivity(), LinearLayoutManager.VERTICAL, false);
    mRecyclerView.setLayoutManager(mLinearLayoutManager);

    RecyclerView.ItemDecoration decoration = ItemDecorations.vertical(getActivity())
            .type(TweetListAdapter.TWEET_TYPE, R.color.divider_color)
            .create();
    mRecyclerView.addItemDecoration(decoration);

    mSwipeRefreshLayout = (SwipeRefreshLayout) view.findViewById(R.id.swipe_refresh);

    return view;
}

XML:

<?xml version="1.0" encoding="utf-8"?>
<RelativeLayout xmlns:android="http://schemas.android.com/apk/res/android"
            android:layout_width="match_parent"
            android:layout_height="match_parent">

    <android.support.v4.widget.SwipeRefreshLayout
        android:id="@+id/swipe_refresh"
        android:layout_width="match_parent"
        android:layout_height="wrap_content"
        android:enabled="false">

        <android.support.v7.widget.RecyclerView
            android:id="@+id/recycler_view"
            android:layout_width="match_parent"
            android:layout_height="match_parent"
            android:scrollbarSize="@dimen/scrollbar"
            android:scrollbars="vertical"/>
    </android.support.v4.widget.SwipeRefreshLayout>
</RelativeLayout>

This pull request is focused on resolving occurrences of Sonar rules squid:S1066 - Collapsible "if" statements should be merged squid:S1319 - Declarations should use Java collection interfaces such as "List" rather than specific implementation classes such as "LinkedList" squid:SwitchLastCaseIsDefaultCheck - "switch" statements should end with a "default" clause pmd:ImmutableField - Immutable Field

You can find more information about the issues here: https://dev.eclipse.org/sonar/coding_rules#q=squid:S1066 https://dev.eclipse.org/sonar/coding_rules#q=squid:S1319 https://dev.eclipse.org/sonar/coding_rules#q=squid:SwitchLastCaseIsDefaultCheck https://dev.eclipse.org/sonar/coding_rules#q=pmd:ImmutableField

Please let me know if you have any questions.

M-Ezzat

Horizontal RecyclerView in RecyclerView

// This All right
RecyclerView.ItemDecoration decoration = ItemDecorations.horizontal(getContext())
                .first(R.drawable.divider_trans_vertical_4dp)
                .type(PhotoViewHolder.LAYOUT_ID, R.drawable.divider_trans_vertical_4dp)
                .last(R.drawable.divider_trans_vertical_4dp)
                .create();

// Some time some divider are missing, I don't known why.
RecyclerView.ItemDecoration decoration = ItemDecorations.horizontal(getContext())
                .type(PhotoViewHolder.LAYOUT_ID, R.drawable.divider_trans_vertical_4dp)
                .create();

Error:Execution failed for task ':presentation:processDebugManifest'.

Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:29:9-36 is also present at [com.github.magiepooh:recycler-itemdecoration:1.1.1] AndroidManifest.xml:12:9-35 value=(true). Suggestion: add 'tools:replace="android:allowBackup"' to element at AndroidManifest.xml:27:5-98:19 to override.

Libraries should not define application node; allowBackup attribute may cause caller get a build error like following:

Error:Execution failed for task ':app:processDebugManifest'. Manifest merger failed : Attribute application@allowBackup value=(false) from AndroidManifest.xml:77:9-36 is also present at [com.github.magiepooh:recycler-itemdecoration:1.1.1] AndroidManifest.xml:12:9-35 value=(true). Suggestion: add 'tools:replace="android:allowBackup"' to element at AndroidManifest.xml:75:5-520:19 to override.

Although we can add tools:replace as suggestion, but I think libraries should not define this attribute at all.

Hi, Im getting this error:

Error:(25, 13) Failed to resolve: com.github.magiepooh:recycler-itemdecoration:1.1.2 Show in File
Show in Project Structure dialog

when trying to put this in the gradle: compile 'com.github.magiepooh:recycler-itemdecoration:1.1.2' I have also tried: compile 'com.github.magiepooh:recycler-itemdecoration:1.1.1' And I have tried to put @aar at the end and I have tried to put maven{...jtpack.io} and still didn't work

repositories {
        maven {
            url "https://jitpack.io"
        }
    }

Any idea what am I doing wrong? Thanks !