Hi,

Sometimes getting this error, not sure what causes.

java.lang.NullPointerException at android.os.Parcel.readIntArray(Parcel.java:678) com.test.example..StaggeredGridView$SavedState.(StaggeredGridView.java:2105) com.test.example.viewpager.StaggeredGridView$SavedState.(StaggeredGridView.java:2101) at com.test.example.viewpager.StaggeredGridView$SavedState$1.createFromParcel(StaggeredGridView.java:2129) at com.test.example.viewpager.StaggeredGridView$SavedState$1.createFromParcel(StaggeredGridView.java:1) at android.os.Parcel.readParcelable(Parcel.java:1919) at android.os.Parcel.readValue(Parcel.java:1784) at android.os.Parcel.readSparseArrayInternal(Parcel.java:2050) at android.os.Parcel.readSparseArray(Parcel.java:1506) at android.os.Parcel.readValue(Parcel.java:1841) at android.os.Parcel.readMapInternal(Parcel.java:2021) at android.os.Bundle.unparcel(Bundle.java:208) at android.os.Bundle.getSparseParcelableArray(Bundle.java:1167) at com.android.internal.policy.impl.PhoneWindow.restoreHierarchyState(PhoneWindow.java:1463) at android.app.Activity.onRestoreInstanceState(Activity.java:843) at android.app.Activity.performRestoreInstanceState(Activity.java:815) at android.app.Instrumentation.callActivityOnRestoreInstanceState(Instrumentation.java:1096) at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2641) at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2679) at android.app.ActivityThread.access$2300(ActivityThread.java:125) at android.app.ActivityThread$H.handleMessage(ActivityThread.java:2033) at android.os.Handler.dispatchMessage(Handler.java:99) at android.os.Looper.loop(Looper.java:123) at android.app.ActivityThread.main(ActivityThread.java:4627) at java.lang.reflect.Method.invokeNative(Native Method) at java.lang.reflect.Method.invoke(Method.java:521) at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:868) at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:626) at dalvik.system.NativeStart.main(Native Method)

Btw, here is line 2105:

    private SavedState(Parcel in) {
        super(in);
        firstId = in.readLong();
        position = in.readInt();
        in.readIntArray(topOffsets);
        in.readTypedList(mapping, ColMap.CREATOR);  
    }

The class was using an ArrayList of ArrayList of Integers to simply map the column where an item was placed. This solution is overly complicated and poor in performances, especially when the adapter holds hundreds (or more) items: some of the operations (contains() and remove() in particular) called on the ArrayList(s) containing the positions for a single column in fillUp() and fillDown() have a O(n) complexity. That required traversing the array multiple times for each position, which is a very expensive operation in a cpu-bound context (= user scrolling or flinging the list).

Since we don't need ordering in the columns mapping, I just replaced the internal ArrayList with an HashSet, whose complexity is O(1) for the same operations. We could have done even better with a HashMap<Integer, Integer> or a SparseIntArray but the performance optimizations are not enough to justify drastically modifying the save/restore state code for the purpose of my pull request (SparseIntArray is not even parcelable or serializable).

I've also made a small optimization to avoid using multiple autoboxing for the same int value when iterating through the columns values.

hi guys,

sorry in advance to @briangriffey for still being a noob who can't do pull requests.

so basically, StaggeredGridView.layoutChildren() can trigger an NPE when it removes child Views because it iterates on the original number of child Views. the fix is super super simple and i don't have time to learn git so i'm posting it here with fingers crossed that one of the wonderful contributors will add it into the main branch.

both changes are in StaggeredGridView.layoutChildren()

first, we adjust the looping condition.

final int childCount = getChildCount();
int amountRemoved = 0;

for (int i = 0; i < childCount; i++) {
    View child = getChildAt(i);

becomes

final int childCount = getChildCount();
int amountRemoved = 0;

for (int i = 0; i < childCount-amountRemoved; i++) {
    View child = getChildAt(i);

second, we adjust the increment so we don't skip over new ith element.

// child has been removed
removeViewAt(i);
if(i-1>=0) invalidateLayoutRecordsAfterPosition(i-1);
amountRemoved++;
continue;

becomes

// child has been removed
removeViewAt(i);
if(i-1>=0) invalidateLayoutRecordsAfterPosition(i-1);
amountRemoved++;
i--;
continue;

and that's it. hope this helps :)

hi,

thanks for this awesome view btw. i noticed there was no way of customizing the selection color so i added in this feature. unfortunately, i'm a total git and github noob and since the changes are super simple, i figured i'd post them here and cross my fingers they end up in the main source rather than learn to make pull requests.

i added 2 lines: a. in res/values/attrs.xml, add this line with the other attribute declarations

<attr name="selector" format="color|reference" />

b. in src/.../StaggeredGridView.java, add this line inside the StaggeredGridView(Context context, AttributeSet attrs, int defStyle) constructor, alongside the other attribute parsings

mSelector = a.getDrawable(R.styleable.StaggeredGridView_selector);

that's it! sorry for being useless with git. hope you enjoy the new feature!

I am able to scroll down but when I try to scroll up I am unable to.It just seems that the list ends there. I am facing this problem in android 4.2.2 both on emulator and actual device.

It worked great until I started to make it look better with setitemMargin()

The view won't scroll up once I set it. and it crashed as well.

I tested on gallaxy s2 with 2.3.3

09-27 15:47:40.352: W/dalvikvm(21531): threadid=1: thread exiting with uncaught exception (group=0x41581700) 09-27 15:47:40.352: E/AndroidRuntime(21531): FATAL EXCEPTION: main 09-27 15:47:40.352: E/AndroidRuntime(21531): java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.staggeredgridviewdemo/com.example.staggeredgridviewdemo.activities.MainActivity}: java.lang.NullPointerException 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2211) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.ActivityThread.handleLaunchActivity(ActivityThread.java:2261) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.ActivityThread.access$600(ActivityThread.java:141) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.ActivityThread$H.handleMessage(ActivityThread.java:1256) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Handler.dispatchMessage(Handler.java:99) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Looper.loop(Looper.java:137) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.ActivityThread.main(ActivityThread.java:5103) 09-27 15:47:40.352: E/AndroidRuntime(21531): at java.lang.reflect.Method.invokeNative(Native Method) 09-27 15:47:40.352: E/AndroidRuntime(21531): at java.lang.reflect.Method.invoke(Method.java:525) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.android.internal.os.ZygoteInit$MethodAndArgsCaller.run(ZygoteInit.java:737) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:553) 09-27 15:47:40.352: E/AndroidRuntime(21531): at dalvik.system.NativeStart.main(Native Method) 09-27 15:47:40.352: E/AndroidRuntime(21531): Caused by: java.lang.NullPointerException 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readIntArray(Parcel.java:784) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.origamilabs.library.views.StaggeredGridView$SavedState.(StaggeredGridView.java:2108) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.origamilabs.library.views.StaggeredGridView$SavedState.(StaggeredGridView.java:2104) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.origamilabs.library.views.StaggeredGridView$SavedState$1.createFromParcel(StaggeredGridView.java:2132) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.origamilabs.library.views.StaggeredGridView$SavedState$1.createFromParcel(StaggeredGridView.java:1) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readParcelable(Parcel.java:2062) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readValue(Parcel.java:1971) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readSparseArrayInternal(Parcel.java:2284) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readSparseArray(Parcel.java:1693) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readValue(Parcel.java:2028) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Parcel.readMapInternal(Parcel.java:2255) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Bundle.unparcel(Bundle.java:223) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.os.Bundle.getSparseParcelableArray(Bundle.java:1237) 09-27 15:47:40.352: E/AndroidRuntime(21531): at com.android.internal.policy.impl.PhoneWindow.restoreHierarchyState(PhoneWindow.java:1644) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.Activity.onRestoreInstanceState(Activity.java:938) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.Activity.performRestoreInstanceState(Activity.java:910) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.Instrumentation.callActivityOnRestoreInstanceState(Instrumentation.java:1138) 09-27 15:47:40.352: E/AndroidRuntime(21531): at android.app.ActivityThread.performLaunchActivity(ActivityThread.java:2189) 09-27 15:47:40.352: E/AndroidRuntime(21531): ... 11 more

Thx!!!!

No idea how to repeat it. It occasionally happen.

java.lang.NullPointerException
    at com.origamilabs.library.views.StaggeredGridView.onTouchEvent(SourceFile:545)
    at android.view.View.dispatchTouchEvent(View.java:7143)
    at android.view.ViewGroup.dispatchTransformedTouchEvent(ViewGroup.java:2238)

The line number may be slightly different at my local version. It refers to the "if" line and the NPE is caused by a null mAdapter in "mAdapter.isEnabled(motionPosition)". A patch is as follows:

    public boolean onTouchEvent(MotionEvent ev) {
                /**
                 * PATCHED: mAdapter may cause NPE
                 */
                if (!mDataChanged && mAdapter!=null && mAdapter.isEnabled(motionPosition)) { /** line 545 */
                    // TODO : handle
                    mTouchMode = TOUCH_MODE_TAP;
                } else {
                    mTouchMode = TOUCH_MODE_REST;
                }

When using multiple List Item Type, the recycling view given back to your adapter is wrong type for the asked Type. So it crashes when your code tries to get the viewHolder

It is similar to this issue http://stackoverflow.com/questions/16526291/listview-with-different-items-and-viewholders-leading-to-classcastexception

When i debugged the code, i found that when offscreen views are added to scrapview List, it was giving wrong ViewType for that view

private void recycleOffscreenViews() {

        final LayoutParams lp = (LayoutParams) child.getLayoutParams();
        System.out.println("######### recycleOffscreenViews child ######### "+child.getTag().getClass().getCanonicalName()+" : "+lp.viewType);
        mRecycler.addScrap(child);

}

I checked the viewType obtained from the child LayoutParams. It doesn't have the proper value for that view. It was always 0.

So the problem is, in obtainView() function,

    final LayoutParams sglp = (LayoutParams) lp;
    sglp.position = position;
    sglp.viewType = positionViewType;

   // FIX. 
   view.setLayoutParams(sglp);

The layoutParams is not set to the view. Which is why it is always 0 and while adding to ScrapView list.

So after the setting the LayoutParams to the view before returning the view from obtainView() function, everthing works fine. I had tested with 6 different list items in StaggeredGridView. It handles the recycling of views properly.

Every time i clicked on an item with the first item spanned, it would re-layout the children and after a few clicks it was 1 column. I saw no need for laying out the children during CheckForTap and everything now behaves correctly since applying this and the other PR's.

I try it many times but it give me errors...

java.lang.RuntimeException: Unable to start activity ComponentInfo{com.example.staggeredgridviewdemo/com.example.staggeredgridviewdemo.MainActivity}: android.view.InflateException: Binary XML file line #9: Error inflating class com.origamilabs.library.views.StaggeredGridView

Can you Please send me 1 full source code example with library ? If possible then Please mail me:[email protected]

Hey guys :)

Someone know why this event not works?

I don't see the Log and the Dialog

final StaggeredGridView listViewCards = (StaggeredGridView) rootView.findViewById(R.id.listViewCards);
listViewCards.setLongClickable(true);
listViewCards.setOnItemLongClickListener(new StaggeredGridView.OnItemLongClickListener() {
            @Override
            public boolean onItemLongClick(AdapterView<?> adapterView, View view, int i, long l) {
                Logger.e("onItemLongClick");
                new MaterialDialog.Builder(getActivity())
                        .title("Options")
                        .items(R.array.card_options)
                        .itemsCallback(new MaterialDialog.ListCallback() {
                            @Override
                            public void onSelection(MaterialDialog dialog, View view, int which, CharSequence text) {
                            }
                        })
                        .show();
                return true;
            }
        });

http://stackoverflow.com/questions/28875962/error-inflating-class-com-origamilabs-library-views-staggeredgridview

Can u check this link ? I got some error and not fix yet.

Hi, i've been using this code for a while, but i can't find the way to create a header view which matchs the whole width of the StaggeredGridView. I would like to know if someone was able to implement it, and how to do it please.

I know that other StaggeredGridView libs or forks are able to do it, but since i've implemented my app with this one, i would like to stick to it if possible.

thanks in advance